source: trunk/Source/WebCore/bindings/v8/custom/V8DOMStringMapCustom.cpp @ 110137

Revision 110137, 4.1 KB checked in by haraken@chromium.org, 3 years ago (diff)

[V8][Performance] Optimize V8 bindings for HTMLElement.classList,
Element.dataset and Node.attributes
https://bugs.webkit.org/show_bug.cgi?id=80376

Reviewed by Adam Barth.

This patch improves the performance of HTMLElement.classList, Element.dataset
and Node.attributes by 6.4 times, 7.1 times and 10.9 times, respectively.

Previously, a 'hiddenReferenceName' string was allocated on v8::Handle and
created every time the DOM attribute is accessed, in spite of the fact that
the 'hiddenReferenceName' string is static.

This patch moves the 'hiddenReferenceName' string to v8::Persistent and makes it static.
Also, this patch removes 'if (!elementValue.IsEmpty() && elementValue->IsObject())',
since if 'element' exists, it is guaranteed that 'elementValue' is not empty
and is an Object.

Performance tests: https://bugs.webkit.org/attachment.cgi?id=130283

AppleWebKit/JavaScriptCore:
div.classList : 382ms
div.classList.foo = 123 : 335ms
div.dataset : 403ms
div.dataset.foo = 123 : 5250ms
div.attributes : 183ms

Chromium/V8 (without this patch):
div.classList : 9140ms
div.classList.foo = 123 : 9086ms
div.dataset : 9930ms
div.dataset.foo = 123 : 49698ms
div.attributes : 13489ms

Chromium/V8 (with this patch):
div.classList : 1435ms
div.classList.foo = 123 : 1470ms
div.dataset : 1400ms
div.dataset.foo = 123 : 30396ms
div.attributes : 1242ms

No tests. No change in behavior.

  • bindings/v8/custom/V8DOMStringMapCustom.cpp: Modified as described above.

(WebCore::toV8):

  • bindings/v8/custom/V8DOMTokenListCustom.cpp: Ditto.

(WebCore::toV8):

  • bindings/v8/custom/V8NamedNodeMapCustom.cpp: Ditto.

(WebCore::toV8):

  • bindings/v8/V8HiddenPropertyName.cpp: Defined a hidden property name string statically

to optimize the macro.
(WebCore):
(WebCore::V8HiddenPropertyName::hiddenReferenceName):

  • bindings/v8/V8HiddenPropertyName.h: Modified to switch two prefixes "WebCore::HiddenProperty::"

and "WebCore::HiddenReference::", depending on whether a given name represents a hidden property
or a hidden reference.
(WebCore):
(V8HiddenPropertyName):

  • Property svn:eol-style set to native
Line 
1/*
2 * Copyright (C) 2010 Google Inc. All rights reserved.
3 *
4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are
6 * met:
7 *
8 *     * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer.
10 *     * Redistributions in binary form must reproduce the above
11 * copyright notice, this list of conditions and the following disclaimer
12 * in the documentation and/or other materials provided with the
13 * distribution.
14 *     * Neither the name of Google Inc. nor the names of its
15 * contributors may be used to endorse or promote products derived from
16 * this software without specific prior written permission.
17 *
18 * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
19 * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
20 * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
21 * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
22 * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
23 * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
24 * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
25 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
29 */
30
31#include "config.h"
32#include "V8DOMStringMap.h"
33
34#include "DOMStringMap.h"
35#include "V8Binding.h"
36#include "V8DOMWrapper.h"
37#include "V8Element.h"
38
39namespace WebCore {
40
41v8::Handle<v8::Integer> V8DOMStringMap::namedPropertyQuery(v8::Local<v8::String> name, const v8::AccessorInfo& info)
42{
43    INC_STATS("DOM.DOMStringMap.NamedPropertyQuery");
44    if (V8DOMStringMap::toNative(info.Holder())->contains(toWebCoreString(name)))
45        return v8::Integer::New(v8::None);
46    return v8::Handle<v8::Integer>();
47}
48
49v8::Handle<v8::Value> V8DOMStringMap::namedPropertyGetter(v8::Local<v8::String> name, const v8::AccessorInfo& info)
50{
51    INC_STATS("DOM.DOMStringMap.NamedPropertyGetter");
52    String value = V8DOMStringMap::toNative(info.Holder())->item(toWebCoreString(name));
53    if (value.isNull())
54        return notHandledByInterceptor();
55    return v8StringOrUndefined(value);
56}
57
58v8::Handle<v8::Array> V8DOMStringMap::namedPropertyEnumerator(const v8::AccessorInfo& info)
59{
60    INC_STATS("DOM.DOMStringMap.NamedPropertyEnumerator");
61    Vector<String> names;
62    V8DOMStringMap::toNative(info.Holder())->getNames(names);
63    v8::Handle<v8::Array> properties = v8::Array::New(names.size());
64    for (size_t i = 0; i < names.size(); ++i)
65        properties->Set(v8::Integer::New(i), v8String(names[i]));
66    return properties;
67}
68
69v8::Handle<v8::Boolean> V8DOMStringMap::namedPropertyDeleter(v8::Local<v8::String> name, const v8::AccessorInfo& info)
70{
71    INC_STATS("DOM.DOMStringMap.NamedPropertyDeleter");
72    ExceptionCode ec = 0;
73    V8DOMStringMap::toNative(info.Holder())->deleteItem(toWebCoreString(name), ec);
74    return ec ? v8::False() : v8::True();
75}
76
77v8::Handle<v8::Value> V8DOMStringMap::namedPropertySetter(v8::Local<v8::String> name, v8::Local<v8::Value> value, const v8::AccessorInfo& info)
78{
79    INC_STATS("DOM.DOMStringMap.NamedPropertySetter");
80    ExceptionCode ec = 0;
81    V8DOMStringMap::toNative(info.Holder())->setItem(toWebCoreString(name), toWebCoreString(value), ec);
82    if (ec)
83        return throwError(ec);
84    return value;
85}
86
87v8::Handle<v8::Value> toV8(DOMStringMap* impl)
88{
89    if (!impl)
90        return v8::Null();
91    v8::Handle<v8::Object> wrapper = V8DOMStringMap::wrap(impl);
92    // Add a hidden reference from the element to the DOMStringMap.
93    Element* element = impl->element();
94    if (!wrapper.IsEmpty() && element) {
95        v8::Handle<v8::Value> elementValue = toV8(element);
96        if (!elementValue.IsEmpty() && elementValue->IsObject())
97            elementValue.As<v8::Object>()->SetHiddenValue(V8HiddenPropertyName::domStringMap(), wrapper);
98    }
99    return wrapper;
100}
101
102} // namespace WebCore
Note: See TracBrowser for help on using the repository browser.