Ignore:
Timestamp:
11/28/11 14:52:56 (3 years ago)
Author:
tony@chromium.org
Message:

ews bots should pass --force to update-webkit-chromium
https://bugs.webkit.org/show_bug.cgi?id=73230

Reviewed by Adam Barth.

This makes it less likely for gclient changes to break the bots (e.g.,
if a DEPS repository moves or is switched to a branch).

Also pass --force when using |build-webkit --update-chromium| since this
appears to only be used by the bots.

Take 2: Add Options.non_interactive to update.py's options() method.

  • Scripts/update-webkit:
  • Scripts/webkitdirs.pm:

(determineIsChromium): Add --force-update to update-webkit --chromium.
(forceChromiumUpdate):
(buildChromium): Pass --force to update-webkit-chromium.

  • Scripts/webkitpy/tool/steps/update.py:

(Update.run): Add --force-update if non-interactive (i.e., bots).

  • Scripts/webkitpy/tool/steps/update_unittest.py:
File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/Tools/Scripts/update-webkit

    r101281 r101285  
    109109    my @chromiumUpdateArgs = ("perl", "Tools/Scripts/update-webkit-chromium"); 
    110110    push @chromiumUpdateArgs, "--chromium-android" if isChromiumAndroid(); 
     111    push @chromiumUpdateArgs, "--force" if forceChromiumUpdate(); 
    111112    system(@chromiumUpdateArgs) == 0 or die $!; 
    112113} elsif (isAppleWinWebKit()) { 
Note: See TracChangeset for help on using the changeset viewer.