Ignore:
Timestamp:
04/24/12 16:43:13 (2 years ago)
Author:
ojan@chromium.org
Message:

Improve code for embedding flakiness dashboard as an iframe
https://bugs.webkit.org/show_bug.cgi?id=84782

Reviewed by Dirk Pranke.

-Include the horizontal scrollbar height in the measured height of the page.
-Post a message everytime the height changes instead of in response to a queryContentHeight message.
This way, the embedder doesn't need to poll.

No new tests. This is hard to test because it involves postMessage and iframes.
Once we switch the dashboard tests over to qunit, we should be able to write an
asyncTest for this.

  • TestResultServer/static-dashboards/flakiness_dashboard.js:

(generatePage):
(appendHTML):
(appendExpectations):
(postHeightChangedMessage):
(generatePageForIndividualTests.if):
(generatePageForIndividualTests):

  • TestResultServer/static-dashboards/flakiness_dashboard_embedded.html: Added.
File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/Tools/ChangeLog

    r115131 r115133  
     12012-04-24  Ojan Vafai  <ojan@chromium.org> 
     2 
     3        Improve code for embedding flakiness dashboard as an iframe 
     4        https://bugs.webkit.org/show_bug.cgi?id=84782 
     5 
     6        Reviewed by Dirk Pranke. 
     7 
     8        -Include the horizontal scrollbar height in the measured height of the page. 
     9        -Post a message everytime the height changes instead of in response to a queryContentHeight message. 
     10        This way, the embedder doesn't need to poll. 
     11 
     12        No new tests. This is hard to test because it involves postMessage and iframes. 
     13        Once we switch the dashboard tests over to qunit, we should be able to write an 
     14        asyncTest for this. 
     15 
     16        * TestResultServer/static-dashboards/flakiness_dashboard.js: 
     17        (generatePage): 
     18        (appendHTML): 
     19        (appendExpectations): 
     20        (postHeightChangedMessage): 
     21        (generatePageForIndividualTests.if): 
     22        (generatePageForIndividualTests): 
     23        * TestResultServer/static-dashboards/flakiness_dashboard_embedded.html: Added. 
     24 
    1252012-04-16  Ojan Vafai  <ojan@chromium.org> 
    226 
Note: See TracChangeset for help on using the changeset viewer.