Ignore:
Timestamp:
04/28/12 01:22:07 (2 years ago)
Author:
zimmermann@webkit.org
Message:

SVGAnimateMotion does not handle accumulation
https://bugs.webkit.org/show_bug.cgi?id=18564

Reviewed by Antti Koivisto.

Source/WebCore:

Implement accumulation for <animateMotion>. Add lots of new
reftests, verifying additive/accumulate behavior is correct.

Tests: svg/animations/animateMotion-additive-1-expected.svg

svg/animations/animateMotion-additive-1.svg
svg/animations/animateMotion-additive-2a-expected.svg
svg/animations/animateMotion-additive-2a.svg
svg/animations/animateMotion-additive-2b-expected.svg
svg/animations/animateMotion-additive-2b.svg
svg/animations/animateMotion-additive-2c-expected.svg
svg/animations/animateMotion-additive-2c.svg
svg/animations/animateMotion-additive-2d-expected.svg
svg/animations/animateMotion-additive-2d.svg
svg/animations/mozilla/animateMotion-by-1-expected.svg
svg/animations/mozilla/animateMotion-by-1.svg
svg/animations/mozilla/animateMotion-from-to-1-expected.svg
svg/animations/mozilla/animateMotion-from-to-1.svg
svg/animations/mozilla/animateMotion-indefinite-to-1-expected.svg
svg/animations/mozilla/animateMotion-indefinite-to-1.svg
svg/animations/mozilla/animateMotion-indefinite-to-2-expected.svg
svg/animations/mozilla/animateMotion-indefinite-to-2.svg
svg/animations/mozilla/animateMotion-mpath-pathLength-1-expected.svg
svg/animations/mozilla/animateMotion-mpath-pathLength-1.svg
svg/animations/mozilla/animateMotion-mpath-targetChange-1-expected.svg
svg/animations/mozilla/animateMotion-mpath-targetChange-1.svg
svg/animations/mozilla/animateMotion-to-overridden-1-expected.svg
svg/animations/mozilla/animateMotion-to-overridden-1.svg

  • svg/SVGAnimateMotionElement.cpp:

(WebCore::SVGAnimateMotionElement::SVGAnimateMotionElement):
(WebCore::SVGAnimateMotionElement::buildTransformForProgress):
(WebCore::SVGAnimateMotionElement::calculateAnimatedValue):

  • svg/SVGAnimateMotionElement.h:

LayoutTests:

Import mozilla <animateMotion> reftests, and two testscases from
Dr. Olaf Hoffmanns SVG test suite, covering all additive/accumulate modes
for <animateMotion>.

  • svg/animations/animateMotion-additive-1-expected.svg: Added.
  • svg/animations/animateMotion-additive-1.svg: Added.
  • svg/animations/animateMotion-additive-2a-expected.svg: Added.
  • svg/animations/animateMotion-additive-2a.svg: Added.
  • svg/animations/animateMotion-additive-2b-expected.svg: Added.
  • svg/animations/animateMotion-additive-2b.svg: Added.
  • svg/animations/animateMotion-additive-2c-expected.svg: Added.
  • svg/animations/animateMotion-additive-2c.svg: Added.
  • svg/animations/animateMotion-additive-2d-expected.svg: Added.
  • svg/animations/animateMotion-additive-2d.svg: Added.
  • svg/animations/mozilla/animateMotion-by-1-expected.svg: Added.
  • svg/animations/mozilla/animateMotion-by-1.svg: Added.
  • svg/animations/mozilla/animateMotion-from-to-1-expected.svg: Added.
  • svg/animations/mozilla/animateMotion-from-to-1.svg: Added.
  • svg/animations/mozilla/animateMotion-indefinite-to-1-expected.svg: Added.
  • svg/animations/mozilla/animateMotion-indefinite-to-1.svg: Added.
  • svg/animations/mozilla/animateMotion-indefinite-to-2-expected.svg: Added.
  • svg/animations/mozilla/animateMotion-indefinite-to-2.svg: Added.
  • svg/animations/mozilla/animateMotion-mpath-pathLength-1-expected.svg: Added.
  • svg/animations/mozilla/animateMotion-mpath-pathLength-1.svg: Added.
  • svg/animations/mozilla/animateMotion-mpath-targetChange-1-expected.svg: Added.
  • svg/animations/mozilla/animateMotion-mpath-targetChange-1.svg: Added.
  • svg/animations/mozilla/animateMotion-to-overridden-1-expected.svg: Added.
  • svg/animations/mozilla/animateMotion-to-overridden-1.svg: Added.
File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r115553 r115554  
     12012-04-28  Nikolas Zimmermann  <nzimmermann@rim.com> 
     2 
     3        SVGAnimateMotion does not handle accumulation 
     4        https://bugs.webkit.org/show_bug.cgi?id=18564 
     5 
     6        Reviewed by Antti Koivisto. 
     7 
     8        Import mozilla <animateMotion> reftests, and two testscases from 
     9        Dr. Olaf Hoffmanns SVG test suite, covering all additive/accumulate modes 
     10        for <animateMotion>. 
     11 
     12        * svg/animations/animateMotion-additive-1-expected.svg: Added. 
     13        * svg/animations/animateMotion-additive-1.svg: Added. 
     14        * svg/animations/animateMotion-additive-2a-expected.svg: Added. 
     15        * svg/animations/animateMotion-additive-2a.svg: Added. 
     16        * svg/animations/animateMotion-additive-2b-expected.svg: Added. 
     17        * svg/animations/animateMotion-additive-2b.svg: Added. 
     18        * svg/animations/animateMotion-additive-2c-expected.svg: Added. 
     19        * svg/animations/animateMotion-additive-2c.svg: Added. 
     20        * svg/animations/animateMotion-additive-2d-expected.svg: Added. 
     21        * svg/animations/animateMotion-additive-2d.svg: Added. 
     22        * svg/animations/mozilla/animateMotion-by-1-expected.svg: Added. 
     23        * svg/animations/mozilla/animateMotion-by-1.svg: Added. 
     24        * svg/animations/mozilla/animateMotion-from-to-1-expected.svg: Added. 
     25        * svg/animations/mozilla/animateMotion-from-to-1.svg: Added. 
     26        * svg/animations/mozilla/animateMotion-indefinite-to-1-expected.svg: Added. 
     27        * svg/animations/mozilla/animateMotion-indefinite-to-1.svg: Added. 
     28        * svg/animations/mozilla/animateMotion-indefinite-to-2-expected.svg: Added. 
     29        * svg/animations/mozilla/animateMotion-indefinite-to-2.svg: Added. 
     30        * svg/animations/mozilla/animateMotion-mpath-pathLength-1-expected.svg: Added. 
     31        * svg/animations/mozilla/animateMotion-mpath-pathLength-1.svg: Added. 
     32        * svg/animations/mozilla/animateMotion-mpath-targetChange-1-expected.svg: Added. 
     33        * svg/animations/mozilla/animateMotion-mpath-targetChange-1.svg: Added. 
     34        * svg/animations/mozilla/animateMotion-to-overridden-1-expected.svg: Added. 
     35        * svg/animations/mozilla/animateMotion-to-overridden-1.svg: Added. 
     36 
    1372012-04-27  Yury Semikhatsky  <yurys@chromium.org> 
    238 
Note: See TracChangeset for help on using the changeset viewer.