Ignore:
Timestamp:
03/31/06 13:36:38 (9 years ago)
Author:
sullivan
Message:

Reviewed by Tim Omernick.


Some cleanup in the WebIconDatabase code in a fruitless search for the cause
of the mysterious -[WebFileDatabase performSetObject:forKey] crash

  • Misc/WebIconDatabase.m: (-[WebIconDatabase _createFileDatabase]): removed obsolete comment (-[WebIconDatabase _loadIconDictionaries]): Added ERRORs for unexpected early returns. Made dictionaries be autoreleased until the end of the method where they are retained, so that the early returns don't leak; added ASSERTs that the _private->dictionary values aren't being leaked. (-[WebIconDatabase _updateFileDatabase]): Added an ERROR for an unexpected early return, and made a trivial style fix.
File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/WebKit/ChangeLog

    r13615 r13618  
     12006-03-31  John Sullivan  <sullivan@apple.com> 
     2 
     3        Reviewed by Tim Omernick. 
     4         
     5        Some cleanup in the WebIconDatabase code in a fruitless search for the cause 
     6        of the mysterious -[WebFileDatabase performSetObject:forKey] crash 
     7 
     8        * Misc/WebIconDatabase.m: 
     9        (-[WebIconDatabase _createFileDatabase]): 
     10        removed obsolete comment 
     11        (-[WebIconDatabase _loadIconDictionaries]): 
     12        Added ERRORs for unexpected early returns. Made dictionaries be autoreleased until 
     13        the end of the method where they are retained, so that the early returns don't leak; 
     14        added ASSERTs that the _private->dictionary values aren't being leaked. 
     15        (-[WebIconDatabase _updateFileDatabase]): 
     16        Added an ERROR for an unexpected early return, and made a trivial style fix. 
     17 
    1182006-03-31  Trey Matteson  <trey@usa.net> 
    219 
Note: See TracChangeset for help on using the changeset viewer.