Changeset 13726 for trunk/WebCore/dom/Element.h

Timestamp:

04/07/06 01:31:17 (3 years ago)

Author:

mjs

Message:

LayoutTests:

Reviewed by Anders.

Added test case for incidental fix from this change:

• Convert Element JS bindings to be almost completely autogenerated http://bugzilla.opendarwin.org/show_bug.cgi?id=8227

• fast/dom/Element/dimension-properties-unrendered-expected.txt: Added.
• fast/dom/Element/dimension-properties-unrendered.html: Added.
• fast/dom/Element/resources/dimension-properties-unrendered.js: Added.

WebCore:

Reviewed by Anders.

• Convert Element JS bindings to be almost completely autogenerated http://bugzilla.opendarwin.org/show_bug.cgi?id=8227

• dom/Element.idl: Declare full interface in IDL.
• dom/Element.h: (WebCore::Element::tagQName): Renamed from tagName, so the real DOM method can be called tagName. (WebCore::Element::tagName): inline alias for nodeName.
• dom/Element.cpp: (WebCore::Element::scrollByUnits): Moved logic from JS bindings to core DOM. (WebCore::Element::scrollByLines): ditto (WebCore::Element::scrollByPages): ditto (WebCore::Element::offsetLeft): ditto, plus make unrendered elements return 0 not undefined (WebCore::Element::offsetTop): ditto, plus make unrendered elements return 0 not undefined (WebCore::Element::offsetWidth): ditto, plus make unrendered elements return 0 not undefined (WebCore::Element::offsetHeight): ditto, plus make unrendered elements return 0 not undefined (WebCore::Element::offsetParent): ditto (WebCore::Element::clientWidth): ditto, plus make unrendered elements return 0 not undefined (WebCore::Element::clientHeight): ditto, plus make unrendered elements return 0 not undefined (WebCore::Element::scrollLeft): ditto (WebCore::Element::scrollTop): ditto (WebCore::Element::setScrollLeft): ditto (WebCore::Element::setScrollTop): ditto (WebCore::Element::scrollWidth): ditto, plus make unrendered elements return 0 not undefined (WebCore::Element::scrollHeight): ditto, plus make unrendered elements return 0 not undefined

• bindings/scripts/CodeGeneratorJS.pm: Added support for ConvertUndefinedToTrue, for benefit of scroll methods where omitted arguments should be treated as true. However, maybe explicit overloading in the IDL would be a better long-term approach for optional arguments.

• khtml/ecma/kjs_binding.cpp: (KJS::valueToStringWithNullCheck): fixed formatting (KJS::valueToBooleanTreatUndefinedAsTrue): added for binding of scrollIntoView (isn't this lame?)
• khtml/ecma/kjs_binding.h: (KJS::toJS): fixed formatting, added new stuff
• khtml/ecma/kjs_dom.cpp: (KJS::DOMElement::getValueProperty): removed most of contents (KJS::DOMElement::putValueProperty): ditto (KJS::DOMElementProtoFunc::callAsFunction): ditto

• css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::canShareStyleWithElement): updated for rename of tagName to tagQName (WebCore::CSSStyleSelector::checkOneSelector): ditto
• dom/Document.cpp: (WebCore::Document::importNode): ditto
• editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::removeInlineStyle): ditto (WebCore::areIdenticalElements): ditto
• html/HTMLElement.cpp: (WebCore::HTMLElement::inEitherTagList): ditto (WebCore::HTMLElement::inInlineTagList): ditto (WebCore::HTMLElement::inBlockTagList): ditto

Files:

• trunk/WebCore/dom/Element.h (modified) (3 diffs)

trunk/WebCore/dom/Element.h

@@ -31 +31 @@
 #include "Attr.h"
 #include "QualifiedName.h"
+#include "KWQScrollBar.h"
 
 namespace WebCore {
@@ -69 +70 @@
     void scrollIntoViewIfNeeded(bool centerIfNeeded);
 
+    void scrollByUnits(int units, KWQScrollGranularity granularity);
+    void scrollByLines(int lines);
+    void scrollByPages(int pages);
+
+    int offsetLeft();
+    int offsetTop();
+    int offsetWidth();
+    int offsetHeight();
+    Element* offsetParent();
+    int clientWidth();
+    int clientHeight();
+    int scrollLeft();
+    int scrollTop();
+    void setScrollLeft(int);
+    void setScrollTop(int);
+    int scrollWidth();
+    int scrollHeight();
+
     void removeAttribute(const String &name, ExceptionCode& ec);
     void removeAttributeNS(const String &namespaceURI, const String& localName, ExceptionCode&);
@@ -80 +99 @@
     virtual CSSStyleDeclaration *style();
 
-    virtual const QualifiedName& tagName() const { return m_tagName; }
+    const QualifiedName& tagQName() const { return m_tagName; }
+    String tagName() const { return nodeName(); }
     virtual bool hasTagName(const QualifiedName& tagName) const { return m_tagName.matches(tagName); }