Changeset 13988 for trunk/WebCore/rendering/RenderBlock.h

Timestamp:

04/20/06 15:22:14 (3 years ago)

Author:

adele

Message:

LayoutTests:

Test for http://bugzilla.opendarwin.org/show_bug.cgi?id=8273
REGRESSION: Read only input text field renders at the wrong height when value attribute is not present

• fast/forms/input-readonly-empty-expected.checksum: Added.
• fast/forms/input-readonly-empty-expected.png: Added.
• fast/forms/input-readonly-empty-expected.txt: Added.
• fast/forms/input-readonly-empty.html: Added.

WebCore:

Reviewed by Hyatt.

Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=8273
REGRESSION: Read only input text field renders at the wrong height when value attribute is not present

Test: fast/forms/input-readonly-empty.html

• rendering/RenderBlock.h: Added hasLineIfEmpty.
• rendering/RenderBlock.cpp: (WebCore::RenderBlock::hasLineIfEmpty): Added. Checks for rootEditableElement as well as a shadowNode who has an input element as a parent. (WebCore::RenderBlock::getBaselineOfLastLineBox): Calls hasLineIfEmpty instead of just checking for the rootEditableElement.
• rendering/bidi.cpp: (WebCore::RenderBlock::layoutInlineChildren): ditto.

Files:

• trunk/WebCore/rendering/RenderBlock.h (modified) (1 diff)

trunk/WebCore/rendering/RenderBlock.h

@@ -277 +277 @@
     Position positionForRenderer(RenderObject *renderer, bool start=true) const;
     
+    bool hasLineIfEmpty() const;
+    
 protected:
     struct FloatingObject {