Changeset 15121 for trunk/WebCore/rendering/RenderBlock.h

Timestamp:

06/30/06 19:51:32 (3 years ago)

Author:

ddkilzer

Message:

WebCore:

Reviewed by Hyatt.

• fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7204 float inserted in fixed height block via DOM not repainted

Test: fast/repaint/float-move-during-layout.html

• rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlockChildren): (WebCore::RenderBlock::repaintOverhangingFloats): Renamed repaintFloatingDescendants() to this and limited it to repainting overhanging floats. Added a boolean parameter that forces all descendant overhanging floats (that don't have their own layer) to paint.
• rendering/RenderBlock.h:
• rendering/RenderBox.cpp: (WebCore::RenderBox::repaintDuringLayoutIfMoved): Changed to paint all descendant floats.
• rendering/RenderObject.cpp: (WebCore::RenderObject::repaintOverhangingFloats):
• rendering/RenderObject.h:

LayoutTests:

Reviewed by Hyatt.

• test for http://bugzilla.opendarwin.org/show_bug.cgi?id=7204 float inserted in fixed height block via DOM not repainted

• fast/repaint/float-move-during-layout-expected.checksum: Added.
• fast/repaint/float-move-during-layout-expected.png: Added.
• fast/repaint/float-move-during-layout-expected.txt: Added.
• fast/repaint/float-move-during-layout.html: Added.

Files:

• trunk/WebCore/rendering/RenderBlock.h (modified) (1 diff)

trunk/WebCore/rendering/RenderBlock.h

@@ -108 +108 @@
 
     virtual void repaintObjectsBeforeLayout();
-    virtual void repaintFloatingDescendants();
+    virtual void repaintOverhangingFloats(bool paintAllDescendants);
     virtual void getAbsoluteRepaintRectIncludingFloats(IntRect& bounds, IntRect& fullBounds);