Changeset 15437 for trunk/JavaScriptCore/API/APICast.h

Timestamp:

07/14/06 15:39:58 (2 years ago)

Author:

ggaren

Message:

JavaScriptCore:

Reviewed by Maciej.

• Implemented ref-counting of JSContexts by splitting into two datatypes: JSGlobalContext, which you can create/retain/release, and JSContext, which you can't.

Internally, you retain a JSGlobalContext/ExecState by retaining its
interpreter, which, in the case of a global ExecState, owns it.

• Also made ~Interpreter() protected to catch places where Interpreter is manually deleted. (Can't make it private because some crazy fool decided it would be a good idea to subclass Interpreter in other frameworks. I pity da fool.)

• API/APICast.h: (toJS): Added cast for new JSGlobalContext
• API/JSStringRef.h: Changed vague "you must" language to more specific (but, ultimately, equally vague) "behavior is undefined if you don't" language. (KJS::Interpreter::Interpreter): Factored more common initialization into init()
• kjs/interpreter.h: (KJS::Interpreter::ref): new (KJS::Interpreter::deref): new (KJS::Interpreter::refCount): new
• kjs/testkjs.cpp: (doIt): Ref-count the interpreter.

JavaScriptGlue:

Reviewed by Maciej.

• Updated JSInterpreter to work with Interpreter ref-counting in JavaScriptCore.

(JSInterpreter::JSInterpreter::~JSInterpreter): Now protected to catch
manual delete.

WebCore:

Reviewed by Maciej.

• Updated ScriptInterpreter to work with Interpreter ref-counting in JavaScriptCore.

(KJS::ScriptInterpreter::~ScriptInterpreter): Now protected to catch
manual delete.

Files:

• trunk/JavaScriptCore/API/APICast.h (modified) (1 diff)

trunk/JavaScriptCore/API/APICast.h

@@ -41 +41 @@
 
 inline KJS::ExecState* toJS(JSContextRef c)
+{
+    return reinterpret_cast<KJS::ExecState*>(const_cast<__JSContext*>(c));
+}
+
+inline KJS::ExecState* toJS(JSGlobalContextRef c)
 {
     return reinterpret_cast<KJS::ExecState*>(c);