Changeset 15469 for trunk/JavaScriptCore/API/JSCallbackFunction.cpp

Timestamp:

07/16/06 15:17:04 (2 years ago)

Author:

ggaren

Message:

Reviewed by Maciej.

• Added names to functions.

• Removed GetPrivate/SetPrivate from callbackFunctions and callbackConstructors. The private data idiom is that a JS object stores its native implementation as private data. For functions and constructors, the native implementation is nothing more than the callback they already store, so supporting private data, too, confuses the idiom. If you *really* want, you can still create a custom function with private data.

• API/JSCallbackConstructor.cpp:
• API/JSCallbackConstructor.h:
• API/JSCallbackFunction.cpp: (KJS::JSCallbackFunction::JSCallbackFunction):
• API/JSCallbackFunction.h:
• API/JSCallbackObject.cpp: (KJS::JSCallbackObject::staticFunctionGetter):
• API/JSObjectRef.cpp: (JSObjectMakeFunction): (JSObjectMakeFunctionWithBody): (JSObjectGetPrivate): (JSObjectSetPrivate):
• API/JSObjectRef.h:
• API/minidom.c: (main):
• API/testapi.c: (main):

Files:

• trunk/JavaScriptCore/API/JSCallbackFunction.cpp (modified) (2 diffs)

trunk/JavaScriptCore/API/JSCallbackFunction.cpp

@@ -34 +34 @@
 const ClassInfo JSCallbackFunction::info = { "CallbackFunction", &InternalFunctionImp::info, 0, 0 };
 
-JSCallbackFunction::JSCallbackFunction(ExecState* exec, JSObjectCallAsFunctionCallback callback)
-    : InternalFunctionImp(static_cast<FunctionPrototype*>(exec->lexicalInterpreter()->builtinFunctionPrototype()))
+JSCallbackFunction::JSCallbackFunction(ExecState* exec, JSObjectCallAsFunctionCallback callback, const Identifier& name)
+    : InternalFunctionImp(static_cast<FunctionPrototype*>(exec->lexicalInterpreter()->builtinFunctionPrototype()), name)
     , m_callback(callback)
 {
-}
-
-bool JSCallbackFunction::implementsCall() const
-{
-    return true;
 }
 
@@ -58 +53 @@
 }
 
-void JSCallbackFunction::setPrivate(void* data)
-{
-    m_privateData = data;
-}
-
-void* JSCallbackFunction::getPrivate()
-{
-    return m_privateData;
-}
-
 } // namespace KJS