Show
Ignore:
Timestamp:
07/16/06 15:17:04 (2 years ago)
Author:
ggaren
Message:

Reviewed by Maciej.


  • Added names to functions.


  • Removed GetPrivate/SetPrivate from callbackFunctions and callbackConstructors. The private data idiom is that a JS object stores its native implementation as private data. For functions and constructors, the native implementation is nothing more than the callback they already store, so supporting private data, too, confuses the idiom. If you *really* want, you can still create a custom function with private data.
  • API/JSCallbackConstructor.cpp:
  • API/JSCallbackConstructor.h:
  • API/JSCallbackFunction.cpp: (KJS::JSCallbackFunction::JSCallbackFunction):
  • API/JSCallbackFunction.h:
  • API/JSCallbackObject.cpp: (KJS::JSCallbackObject::staticFunctionGetter):
  • API/JSObjectRef.cpp: (JSObjectMakeFunction): (JSObjectMakeFunctionWithBody): (JSObjectGetPrivate): (JSObjectSetPrivate):
  • API/JSObjectRef.h:
  • API/minidom.c: (main):
  • API/testapi.c: (main):
Files:
1 modified

Legend:

Unmodified
Added
Removed

  • trunk/JavaScriptCore/ChangeLog

    r15468 r15469  
     12006-07-16  Geoffrey Garen  <ggaren@apple.com> 
     2 
     3        Reviewed by Maciej. 
     4         
     5        - Added names to functions. 
     6         
     7        - Removed GetPrivate/SetPrivate from callbackFunctions and callbackConstructors. 
     8        The private data idiom is that a JS object stores its native implementation 
     9        as private data. For functions and constructors, the native implementation is nothing 
     10        more than the callback they already store, so supporting private data, too, 
     11        confuses the idiom. If you *really* want, you can still create a custom  
     12        function with private data. 
     13 
     14        * API/JSCallbackConstructor.cpp: 
     15        * API/JSCallbackConstructor.h: 
     16        * API/JSCallbackFunction.cpp: 
     17        (KJS::JSCallbackFunction::JSCallbackFunction): 
     18        * API/JSCallbackFunction.h: 
     19        * API/JSCallbackObject.cpp: 
     20        (KJS::JSCallbackObject::staticFunctionGetter): 
     21        * API/JSObjectRef.cpp: 
     22        (JSObjectMakeFunction): 
     23        (JSObjectMakeFunctionWithBody): 
     24        (JSObjectGetPrivate): 
     25        (JSObjectSetPrivate): 
     26        * API/JSObjectRef.h: 
     27        * API/minidom.c: 
     28        (main): 
     29        * API/testapi.c: 
     30        (main): 
     31 
    1322006-07-15  Maciej Stachowiak  <mjs@apple.com> 
    233