Changeset 166026 in webkit for trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp

Timestamp:

Mar 20, 2014 5:04:44 PM (4 years ago)

Author:

ap@apple.com

Message:

Generalize WebInspector check in maybeInitializeSandboxExtensionHandle().
​https://bugs.webkit.org/show_bug.cgi?id=130079
<rdar://problem/16286683>

Reviewed by Anders Carlsson.

• UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::maybeInitializeSandboxExtensionHandle):

Perform an early return for all paths that don't need a sandbox extension due to
access being assumed, not only for WebInspector pages.

• UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::hasAssumedReadAccessToURL):
(WebKit::WebProcessProxy::checkURLReceivedFromWebProcess):

• UIProcess/WebProcessProxy.h:

Factored out m_localPathsWithAssumedReadAccess iteration to a public function.

File:

• trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp (modified) (1 diff)

trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp

@@ -628 +628 @@
         return false;
 
+    if (m_process->hasAssumedReadAccessToURL(url))
+        return false;
+
 #if ENABLE(INSPECTOR)
-    // Don't give the inspector full access to the file system.
-    if (WebInspectorProxy::isInspectorPage(*this))
-        return false;
+    // Inspector resources are in a directory with assumed access.
+    ASSERT_WITH_SECURITY_IMPLICATION(!WebInspectorProxy::isInspectorPage(*this));
 #endif