Changeset 19011

Timestamp:

01/21/07 09:19:03 (2 years ago)

Author:

weinig

Message:

LayoutTests:

Reviewed by Darin.

• test for http://bugs.webkit.org/show_bug.cgi?id=10472 REGRESSION: "add" method of <select> object does not put the <option> object in the correct position

• fast/dom/HTMLSelectElement/options-collection-detached-expected.txt: Added.
• fast/dom/HTMLSelectElement/options-collection-detached.html: Added.

WebCore:

Reviewed by Darin.

• fix http://bugs.webkit.org/show_bug.cgi?id=10472 REGRESSION: "add" method of <select> object does not put the <option> object in the correct position

Test: fast/dom/HTMLSelectElement/options-collection-detached.html

• html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::setRecalcListItems): Reset the options collection info if the <select> is not in the document. For in-document <select>s this happens anyway as a result of the DOM tree version increasing.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/dom/HTMLSelectElement/options-collection-detached-expected.txt (added)
• LayoutTests/fast/dom/HTMLSelectElement/options-collection-detached.html (added)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/html/HTMLSelectElement.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2007-01-21  Mitz Pettel  <mitz@webkit.org>
+
+        Reviewed by Darin.
+
+        - test for http://bugs.webkit.org/show_bug.cgi?id=10472
+          REGRESSION: "add" method of <select> object does not put the <option> object in the correct position
+
+        * fast/dom/HTMLSelectElement/options-collection-detached-expected.txt: Added.
+        * fast/dom/HTMLSelectElement/options-collection-detached.html: Added.
+
 2007-01-21  Mitz Pettel  <mitz@webkit.org>
 

trunk/WebCore/ChangeLog

@@ +1 @@
+2007-01-21  Mitz Pettel  <mitz@webkit.org>
+
+        Reviewed by Darin.
+
+        - fix http://bugs.webkit.org/show_bug.cgi?id=10472
+          REGRESSION: "add" method of <select> object does not put the <option> object in the correct position
+
+        Test: fast/dom/HTMLSelectElement/options-collection-detached.html
+
+        * html/HTMLSelectElement.cpp:
+        (WebCore::HTMLSelectElement::setRecalcListItems): Reset the options collection
+        info if the <select> is not in the document. For in-document <select>s this
+        happens anyway as a result of the DOM tree version increasing.
+
 2007-01-21  Mitz Pettel  <mitz@webkit.org>
 

trunk/WebCore/html/HTMLSelectElement.cpp

@@ -515 +515 @@
             static_cast<RenderListBox*>(renderer())->setOptionsChanged(true);
     }
+    if (!inDocument())
+        m_collectionInfo.reset();
     setChanged();
 }