Show
Ignore:
Timestamp:
01/26/07 16:03:56 (2 years ago)
Author:
bdakin
Message:

Reviewed by Darin.

Fix for <rdar://problem/4956565> REGRESSION: After scrolling frame,
hovering over link in this frame doesn't change cursor to pointing
hand

The mouseMove event was not being propagated correctly after using
the mouse to scroll the frame because m_mousePressed was never
getting set to false.

  • page/EventHandler.cpp: (WebCore::EventHandler::handleMousePressEvent): This code does not belong here.
  • page/EventHandler.h: lastEventIsMouseUp() is only ever relevant in EventHandlerMac, so it can just be a static function there.
  • page/mac/EventHandlerMac.mm: (WebCore::lastEventIsMouseUp): Make this static. (WebCore::EventHandler::passMouseDownEventToWidget): Here is where we need to set m_mousePressed to false if lastEventIsMouseUp() is true.
Files:
1 modified

Legend:

Unmodified
Added
Removed

  • trunk/WebCore/ChangeLog

    r19164 r19166  
     12007-01-26  Beth Dakin  <bdakin@apple.com> 
     2 
     3        Reviewed by Darin. 
     4 
     5        Fix for <rdar://problem/4956565> REGRESSION: After scrolling frame,  
     6        hovering over link in this frame doesn't change cursor to pointing  
     7        hand 
     8 
     9        The mouseMove event was not being propagated correctly after using  
     10        the mouse to scroll the frame because m_mousePressed was never  
     11        getting set to false. 
     12 
     13        * page/EventHandler.cpp: 
     14        (WebCore::EventHandler::handleMousePressEvent): This code does not  
     15        belong here. 
     16        * page/EventHandler.h: lastEventIsMouseUp() is only ever relevant  
     17        in EventHandlerMac, so it can just be a static function there. 
     18        * page/mac/EventHandlerMac.mm: 
     19        (WebCore::lastEventIsMouseUp): Make this static. 
     20        (WebCore::EventHandler::passMouseDownEventToWidget): Here is where  
     21        we need to set m_mousePressed to false if lastEventIsMouseUp() is  
     22        true. 
     23 
    1242007-01-26  David Hyatt  <hyatt@apple.com> 
    225