Context Navigation

RenderBlock.h

Timestamp:

02/05/07 15:25:44 (2 years ago)

Author:

adele

Message:

LayoutTests:

Reviewed by Mitz and Anders.

Tests for http://bugs.webkit.org/show_bug.cgi?id=11811
<rdar://problem/4947184> REGRESSION (r11783): Hebrew text in list boxes is reversed

WebCore:

Reviewed by Mitz and Anders.

Fix for http://bugs.webkit.org/show_bug.cgi?id=11811
<rdar://problem/4947184> REGRESSION (r11783): Hebrew text in list boxes is reversed

http://bugs.webkit.org/show_bug.cgi?id=11812
<rdar://problem/4960269> REGRESSION (Native file upload): Hebrew filenames are reversed

Tests:
fast/text/international/bidi-listbox.html
fast/text/international/bidi-listbox-atsui.html

rendering/RenderBlock.h: Added static bidiReorderCharacters that will run the bidi algorithm on a character buffer.
rendering/bidi.cpp: (WebCore::RenderBlock::bidiReorderCharacters): Added. Creates an anonymous RenderBlock and RenderText to feed into bidiReorderLines. (WebCore::RenderBlock::constructLine): Uses the new convenience methods on BidiRun.
rendering/bidi.h: (WebCore::BidiRun::reversed): Added convenience method. (WebCore::BidiRun::dirOverride): ditto.

rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::paintObject): Creates a buffer and calls bidiReorderCharacters to get a correctly ordered character buffer for drawText.
rendering/RenderListBox.cpp: (WebCore::RenderListBox::paintItemForeground): ditto.

Files:

r18826	r19414
38	38	class RenderBlock : public RenderFlow {
39	39	public:
	40	typedef Vector<UChar, 1024> CharacterBuffer;
	41	static void bidiReorderCharacters(Document, RenderStyle, CharacterBuffer&);
	42
40	43	RenderBlock(Node*);
41	44	virtual ~RenderBlock();