Changeset 19979 for trunk/LayoutTests/fast/dom/HTMLDocument/document-special-properties.html

Timestamp:

03/06/07 01:05:42 (23 months ago)

Author:

andersca

Message:

LayoutTests:

Reviewed by Maciej.

<rdar://problem/5035045>
REGRESSION: WebKit browser doesn't display image at http://www.metoffice.gov.uk/weather/satellite/index.html

Add some tests where image elements have id _and_ name elements.

• fast/dom/HTMLDocument/document-special-properties-expected.txt:
• fast/dom/HTMLDocument/document-special-properties.html:

WebCore:

Reviewed by Maciej.

<rdar://problem/5035045>
REGRESSION: WebKit browser doesn't display image at http://www.metoffice.gov.uk/weather/satellite/index.html

It turns out WinIE does allow you to access images by their id as special document properties. However, this is only
allowed when the element also has a name attribute. The value of the name attribute is ignored and can even be empty!

• bindings/js/kjs_html.cpp: (KJS::JSHTMLDocument::namedItemGetter): Return jsUndefined() if the collection is empty.

• html/HTMLImageElement.cpp: (WebCore::HTMLImageElement::parseMappedAttribute): (WebCore::HTMLImageElement::insertedIntoDocument): (WebCore::HTMLImageElement::removedFromDocument):
• html/HTMLImageElement.h: Add the id attribute value to the extra named item map.

• html/HTMLNameCollection.cpp: (WebCore::HTMLNameCollection::traverseNextItem): Check for images with name attributes that match, as well as elements with id attributes that match where the element also has a name attribute.

Files:

• trunk/LayoutTests/fast/dom/HTMLDocument/document-special-properties.html (modified) (4 diffs)

trunk/LayoutTests/fast/dom/HTMLDocument/document-special-properties.html

@@ -33 +33 @@
 <img name="image5" width="0" height="0">
 <img id="image5" width="0" height="0">
+<img id="image6" name="image6name" width="0" height="0">
+<img id="image7" name="" width="0" height="0">
+<img id="image8" name="image8name" width="0" height="0">
+<img id="image8" width="0" height="0">
+<img id="image8" name="image7name" width="0" height="0">
+<img id="image9" name="image9name" width="0" height="0">
 
 <form name="form1" width="0" height="0"></form>
@@ -151 +157 @@
         print(" " + e.tagName);
 
-        if (e.name && e.id) {
-            print("(id,name)");
-        } else if (e.name) {
-            print("(name)");
+    if (e.name && e.id) {
+        print("(id,name)");
+    } else if (e.name) {
+        print("(name)");
         } else if (e.id) {
-            print("(id)");
-        }
+        print("(id)");
+    }
     } else if (e.navigator) {
         print(" WINDOW");
@@ -174 +180 @@
     } else if (propVal.length) {
         print(" collection(" + propVal.length + ")");
-        for (var i = 0; i < propVal.length; i++) {
-            printElement(propVal[i]);
-        }
+    for (var i = 0; i < propVal.length; i++) {
+        printElement(propVal[i]);
+    }
     } else {
         print(" single");
-        printElement(propVal);
+    printElement(propVal);
     }
     
@@ -191 +197 @@
 testProperty("Image by id (multiple)", "image4");
 testProperty("Image by id/name mixed", "image5");
+testProperty("Image by id, name present (unique)", "image6");
+testProperty("Image by id, empty name present (unique)", "image7");
+testProperty("Image by id, name present (multiple)", "image8");
+testProperty("Image by name, id present (unique)", "image9name");
+
 print("<br>");