Changeset 20072 for trunk/WebCore/dom/Element.h

Timestamp:

03/08/07 18:12:43 (22 months ago)

Author:

mjs

Message:

LayoutTests:

Reviewed by Adele.

<rdar://problem/4646563> REGRESSION: Unable to send text message from Verizon text message website: vtext.com (12588)
http://bugs.webkit.org/show_bug.cgi?id=12588

Carefully revised which focus operations restore previous selection, which clear it, and which
select the whole control contents, these test cases cover every focus call I could find.

• fast/forms/focus-selection-input-expected.txt: Added.
• fast/forms/focus-selection-input.html: Added.
• fast/forms/focus-selection-textarea-expected.txt: Added.
• fast/forms/focus-selection-textarea.html: Added.
• fast/forms/onselect-textfield-expected.txt:

WebCore:

Reviewed by Adele.

<rdar://problem/4646563> REGRESSION: Unable to send text message from Verizon text message website: vtext.com (12588)
http://bugs.webkit.org/show_bug.cgi?id=12588

Carefully revised which focus operations restore previous selection, which clear it, and which
select the whole control contents.

Tests:
fast/forms/focus-selection-input.html
fast/forms/focus-selection-textarea.html

• dom/Element.cpp: (WebCore::Element::focus):
• dom/Element.h:
• html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::focus): (WebCore::HTMLInputElement::accessKeyAction):
• html/HTMLInputElement.h:
• html/HTMLLabelElement.cpp: (WebCore::HTMLLabelElement::focus): (WebCore::HTMLLabelElement::accessKeyAction):
• html/HTMLLabelElement.h:
• html/HTMLLegendElement.cpp: (WebCore::HTMLLegendElement::focus):
• html/HTMLLegendElement.h:
• html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::focus):
• html/HTMLTextAreaElement.h:
• page/FocusController.cpp: (WebCore::FocusController::advanceFocus):

Files:

• trunk/WebCore/dom/Element.h (modified) (1 diff)

trunk/WebCore/dom/Element.h

@@ -159 +159 @@
     virtual String target() const { return String(); }
         
-    virtual void focus();
+    virtual void focus(bool restorePreviousSelection = true);
     virtual void updateFocusAppearance(bool restorePreviousSelection = false);
     void blur();