Changeset 21003 for trunk/WebCore/dom/Node.h

Timestamp:

04/22/07 01:23:55 (21 months ago)

Author:

ap

Message:

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=13115
REGRESSION: 1000% performance regression in DOM access by index, which was already slow

• dom/NodeList.h: Move cached data into a separate class, so it can be shared.

• dom/Node.h: Replace the set of registered NodeLists with a struct that also contains a shared NodeList::Caches (so the size of Node doesn't change).

• dom/NodeList.cpp: (WebCore::NodeList::NodeList): (WebCore::NodeList::~NodeList): (WebCore::NodeList::recursiveLength): (WebCore::NodeList::itemForwardsFromCurrent): (WebCore::NodeList::itemBackwardsFromCurrent): (WebCore::NodeList::recursiveItem): (WebCore::NodeList::itemWithName): (WebCore::NodeList::rootNodeChildrenChanged): (WebCore::NodeList::NodeListInfo::NodeListInfo): (WebCore::NodeList::NodeListInfo::reset):
• dom/ChildNodeList.cpp: (WebCore::ChildNodeList::ChildNodeList): (WebCore::ChildNodeList::length): (WebCore::ChildNodeList::item): (WebCore::ChildNodeList::nodeMatches):
• dom/ChildNodeList.h:
• dom/Node.cpp: (WebCore::Node::childNodes): (WebCore::Node::registerNodeList): (WebCore::Node::unregisterNodeList): (WebCore::Node::notifyLocalNodeListsAttributeChanged): (WebCore::Node::notifyLocalNodeListsChildrenChanged): Adjust for the above changes.

Files:

• trunk/WebCore/dom/Node.h (modified) (2 diffs)

trunk/WebCore/dom/Node.h

@@ -46 +46 @@
 class NamedAttrMap;
 class NodeList;
+struct NodeListsNodeData;
 class PlatformKeyboardEvent;
 class PlatformMouseEvent;
@@ -457 +458 @@
 
 protected:
-    typedef HashSet<NodeList*> NodeListSet;
-    NodeListSet* m_nodeLists;
+    NodeListsNodeData* m_nodeLists;
 
     short m_tabIndex;