Changeset 21120 for trunk/WebCore/rendering/RenderObject.h

Timestamp:

04/26/07 12:51:11 (21 months ago)

Author:

hyatt

Message:

Reviewed by hyatt

• http://bugs.webkit.org/show_bug.cgi?id=13496 Eliminate repaintObjectsBeforeLayout

No tests added since there is no change to functionality. Several
tests in fast/repaint test repainting of objects that move during layout.

• page/FrameView.cpp: (WebCore::FrameView::layout):
• rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlockChildren): Removed an early setNeedsLayout(false). Resetting the bit here prevents the full repaint that we rely on when we decide not to repaint children that move.
• rendering/RenderBlock.h:
• rendering/RenderObject.cpp:
• rendering/RenderObject.h:
• rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::setCellWidths): Replaced the call to repaintObjectsBeforeLayout() if the cell didn't need layout with an unconditional repaint(). We don't bother with repainting only the delta between the old and new widths, since by marking the cell for layout results in a full repaint with the new width anyway.

Files:

• trunk/WebCore/rendering/RenderObject.h (modified) (1 diff)

trunk/WebCore/rendering/RenderObject.h

@@ -700 +700 @@
     virtual void repaintOverhangingFloats(bool paintAllDescendants = false);
 
-    // Called before layout to repaint all dirty children (with selfNeedsLayout() set).
-    virtual void repaintObjectsBeforeLayout();
-
     bool checkForRepaintDuringLayout() const;