Changeset 21184 for trunk/WebCore/dom/Element.h

Timestamp:

04/29/07 13:32:51 (21 months ago)

Author:

darin

Message:

Reviewed by Adele.

• fix the Gmail part of http://bugs.webkit.org/show_bug.cgi?id=12798 and <rdar://problem/4118559>

This patch changes things so that resizing can make things larger than their
initial size, but not smaller. I believe this resolves the problem for Gmail,
but you can still get strange behavior if you have a small right-aligned <textarea>.

• rendering/RenderLayer.cpp: (WebCore::RenderLayer::resize): Rewrote to use more IntPoint and IntSize and add in a new minimum-size algorithm. This function now has the side effect of storing a new minimumSizeForResizing in the element being resized, and respects any existing minimum as well. (WebCore::RenderLayer::offsetFromResizeCorner): Reversed this so it converts the point into coordinates relative to the resize corner, hence negative numbers mean the point is above and to the left. This is used only in the algorithm above.

• dom/Element.h: Removed unneeded include of Attr.h, and added forward declarations as needed. Removed all friend declarations; there was no need for any of them. Tweaked formatting of various declarations and removed unneeded parameter names. Made as much as possible private, and a couple things public to avoid the need for friend classes. Added minimumSizeForResizing, setMinimumSizeForResizing, rareData, and createRareData functions.

• dom/Element.cpp: (WebCore::rareDataMap): Added. Function to return the single global map. (WebCore::rareDataFromMap): Added. For use by inlined functions to get the data from the map in the case where it's present. (WebCore::ElementRareData::ElementRareData): Added. (WebCore::Element::~Element): Added code to delete the element from the rare data map when appropriate. (WebCore::Element::rareData): Added. (WebCore::Element::createRareData): Added. (WebCore::Element::setAttributeNodeNS): Got rid of the old inline version of this, since it was the sole reason we had to include Attr.h in Element.h. (WebCore::Element::minimumSizeForResizing): Added. Accesses rare data. (WebCore::Element::setMinimumSizeForResizing): Ditto.

• dom/Node.h: Renamed the m_specified bit since it's now used for two purposes. Its new long name is m_attrWasSpecifiedOrElementHasRareData.

• dom/Attr.cpp: (WebCore::Attr::Attr): Updated for bit name change.
• dom/Attr.h: (WebCore::Attr::specified): Ditto. (WebCore::Attr::setSpecified): Added, since setting the bit directly is pretty ugly now.
• dom/Document.cpp: (WebCore::Document::adoptNode): Updated for bit name change.
• dom/Node.cpp: (WebCore::Node::Node): Ditto. (WebCore::Node::dump): Ditto.

• dom/NamedAttrMap.cpp: (WebCore::NamedAttrMap::isReadOnlyNode): Moved out of line, since this was the sole reason we had to include Element.h in NamedAttrMap.h.

• html/HTMLElement.cpp: (WebCore::HTMLElement::nodeName): Changed to use tagQName() since that's a public way to do something that's now private. (WebCore::HTMLElement::cloneNode): Ditto.

• dom/Attribute.cpp:
• dom/NamedAttrMap.h:
• dom/NamedMappedAttrMap.cpp:
• dom/StyledElement.h:
• html/HTMLTokenizer.h:
• xml/XPathFunctions.cpp:
• xml/XPathStep.cpp: Updated includes, and other administrivia.

Files:

• trunk/WebCore/dom/Element.h (modified) (11 diffs)

trunk/WebCore/dom/Element.h

@@ -1 +1 @@
 /*
- * This file is part of the DOM implementation for KDE.
- *
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Peter Kelly (pmk@post.com)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
- * Copyright (C) 2003, 2004, 2005, 2006 Apple Computer, Inc.
+ * Copyright (C) 2003, 2004, 2005, 2006, 2007 Apple Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
@@ -28 +26 @@
 #define Element_h
 
-#include "Attr.h"
+#include "ContainerNode.h"
+#include "QualifiedName.h"
 #include "ScrollTypes.h"
 #include "Timer.h"
@@ -35 +34 @@
 
 class AtomicStringList;
+class Attr;
 class Attribute;
+class CSSStyleDeclaration;
+class ElementRareData;
+class IntSize;
 
 class Element : public ContainerNode {
-    friend class Document;
-    friend class NamedAttrMap;
-    friend class Attr;
-    friend class Node;
-    friend class CSSStyleSelector;
 public:
     Element(const QualifiedName&, Document*);
@@ -50 +48 @@
     virtual const AtomicStringList* getClassList() const;
     const AtomicString& getIDAttribute() const;
-    bool hasAttribute(const QualifiedName& name) const;
-    const AtomicString& getAttribute(const QualifiedName& name) const;
-    void setAttribute(const QualifiedName& name, StringImpl* value, ExceptionCode&);
-    void removeAttribute(const QualifiedName& name, ExceptionCode&);
+    bool hasAttribute(const QualifiedName&) const;
+    const AtomicString& getAttribute(const QualifiedName&) const;
+    void setAttribute(const QualifiedName&, StringImpl* value, ExceptionCode&);
+    void removeAttribute(const QualifiedName&, ExceptionCode&);
 
     bool hasAttributes() const;
@@ -89 +87 @@
     int scrollHeight();
 
-    void removeAttribute(const String &name, ExceptionCode& ec);
-    void removeAttributeNS(const String &namespaceURI, const String& localName, ExceptionCode&);
+    void removeAttribute(const String& name, ExceptionCode&);
+    void removeAttributeNS(const String& namespaceURI, const String& localName, ExceptionCode&);
 
     PassRefPtr<Attr> getAttributeNode(const String& name);
     PassRefPtr<Attr> getAttributeNodeNS(const String& namespaceURI, const String& localName);
     PassRefPtr<Attr> setAttributeNode(Attr*, ExceptionCode&);
-    PassRefPtr<Attr> setAttributeNodeNS(Attr* newAttr, ExceptionCode& ec) { return setAttributeNode(newAttr, ec); }
+    PassRefPtr<Attr> setAttributeNodeNS(Attr*, ExceptionCode&);
     PassRefPtr<Attr> removeAttributeNode(Attr*, ExceptionCode&);
     
-    virtual CSSStyleDeclaration *style();
+    virtual CSSStyleDeclaration* style();
 
     const QualifiedName& tagQName() const { return m_tagName; }
@@ -126 +124 @@
 
     // convenience methods which ignore exceptions
-    void setAttribute(const QualifiedName& name, const String& value);
-
-    virtual NamedAttrMap *attributes() const;
+    void setAttribute(const QualifiedName&, const String& value);
+
+    virtual NamedAttrMap* attributes() const;
     NamedAttrMap* attributes(bool readonly) const;
 
     // This method is called whenever an attribute is added, changed or removed.
-    virtual void attributeChanged(Attribute* attr, bool preserveDecls = false) {}
+    virtual void attributeChanged(Attribute*, bool preserveDecls = false) {}
 
     // not part of the DOM
     void setAttributeMap(NamedAttrMap*);
 
-    virtual void copyNonAttributeProperties(const Element *source) {}
+    virtual void copyNonAttributeProperties(const Element* source) {}
 
     virtual void attach();
     virtual void detach();
-    virtual RenderStyle *styleForRenderer(RenderObject *parent);
-    virtual RenderObject *createRenderer(RenderArena *, RenderStyle *);
-    virtual void recalcStyle( StyleChange = NoChange );
+    virtual RenderStyle* styleForRenderer(RenderObject* parent);
+    virtual RenderObject* createRenderer(RenderArena*, RenderStyle*);
+    virtual void recalcStyle(StyleChange = NoChange);
 
     virtual bool childTypeAllowed(NodeType);
@@ -149 +147 @@
     virtual Attribute* createAttribute(const QualifiedName& name, StringImpl* value);
     
-    void dispatchAttrRemovalEvent(Attribute *attr);
-    void dispatchAttrAdditionEvent(Attribute *attr);
+    void dispatchAttrRemovalEvent(Attribute*);
+    void dispatchAttrAdditionEvent(Attribute*);
 
     virtual void accessKeyAction(bool sendToAnyEvent) { }
@@ -156 +154 @@
     virtual String toString() const;
 
-    virtual bool isURLAttribute(Attribute *attr) const;
+    virtual bool isURLAttribute(Attribute*) const;
     virtual String target() const { return String(); }
         
@@ -164 +162 @@
     bool needsFocusAppearanceUpdate() const { return m_needsFocusAppearanceUpdate; }
     void setNeedsFocusAppearanceUpdate(bool b) { m_needsFocusAppearanceUpdate = b; }
-    
+
 #ifndef NDEBUG
-    virtual void dump(TextStream *stream, DeprecatedString ind = "") const;
-    virtual void formatForDebugger(char *buffer, unsigned length) const;
+    virtual void dump(TextStream* , DeprecatedString ind = "") const;
+    virtual void formatForDebugger(char* buffer, unsigned length) const;
 #endif
 
-    Node* insertAdjacentElement(const String& where, Node* newChild, int& exception);
+    Node* insertAdjacentElement(const String& where, Node* newChild, ExceptionCode&);
     bool contains(const Node*) const;
 
@@ -178 +176 @@
     virtual String title() const;
 
-protected:
+    String openTagStartToString() const;
+
+    void updateId(const AtomicString& oldId, const AtomicString& newId);
+
+    IntSize minimumSizeForResizing() const;
+    void setMinimumSizeForResizing(const IntSize&);
+
+private:
+    ElementRareData* rareData();
+    const ElementRareData* rareData() const;
+    ElementRareData* createRareData();
+
     virtual void createAttributeMap() const;
-    String openTagStartToString() const;
-
-private:
-    void updateId(const AtomicString& oldId, const AtomicString& newId);
 
     virtual void updateStyleAttributeIfNeeded() const {}
@@ -192 +197 @@
     bool m_needsFocusAppearanceUpdate;
 
-protected: // member variables
+protected:
     mutable RefPtr<NamedAttrMap> namedAttrMap;
+
+private:
     QualifiedName m_tagName;
 };