Changeset 25161

Show
Ignore:
Timestamp:
08/20/07 15:05:25 (23 months ago)
Author:
kmccullo
Message:

JavaScriptCore:

Reviewed by Geoff and Adam.

  • Changing stack depth to 500 (from 100 on mac and win) to help out some apps specifically gmail. < rdar://problem/3590522> JavaScript call stack limit of 99 is too small for some applications; needs to be closer to 500 (4045)
  • kjs/object.cpp:

LayoutTests:

Reviewed by Geoff and Adam.

  • Changing stack depth toi 500 (from 100 in mac and win) to help out some apps specifically gmail. < rdar://problem/3590522> JavaScript call stack limit of 99 is too small for some applications; needs to be closer to 500 (4045).
  • fast/js/deep-recursion-test-expected.txt: Added.
  • fast/js/deep-recursion-test.html: Added.
Location:
trunk
Files:
2 added
3 modified

Legend:

Unmodified
Added
Removed

  • trunk/JavaScriptCore/ChangeLog

    r25085 r25161  
     12007-08-16  Kevin McCullough  <kmccullough@apple.com> 
     2 
     3        Reviewed by Geoff and Adam. 
     4 
     5        - Changing stack depth to 500 (from 100 on mac and win) to help out some apps specifically gmail.  <rdar://problem/3590522> JavaScript call stack limit of 99 is too small for some applications; needs to be closer to 500 (4045) 
     6 
     7        * kjs/object.cpp: 
     8 
    192007-08-15  Peter Kasting  <zerodpx@gmail.org> 
    210 

  • trunk/JavaScriptCore/kjs/object.cpp

    r21332 r25161  
    3636// maximum global call stack size. Protects against accidental or 
    3737// malicious infinite recursions. Define to -1 if you want no limit. 
    38 #if PLATFORM(DARWIN) || PLATFORM(WIN_OS) 
    39 // Given OS X stack sizes we run out of stack at about 350 levels. 
    40 // If we improve our stack usage, we can bump this number. 
    41 #define KJS_MAX_STACK 100 
    42 #else 
    43 #define KJS_MAX_STACK 1000 
    44 #endif 
     38// In real-world testing it appears ok to bump the stack depth count to 500. 
     39// This of course is dependent on stack frame size. 
     40#define KJS_MAX_STACK 500 
    4541 
    4642#define JAVASCRIPT_CALL_TRACING 0 

  • trunk/LayoutTests/ChangeLog

    r25154 r25161  
     12007-08-16  Kevin McCullough  <kmccullough@apple.com> 
     2 
     3        Reviewed by Geoff and Adam. 
     4 
     5        - Changing stack depth toi 500 (from 100 in mac and win) to help out some apps specifically gmail.  <rdar://problem/3590522> JavaScript call stack limit of 99 is too small for some applications; needs to be closer to 500 (4045). 
     6 
     7        * fast/js/deep-recursion-test-expected.txt: Added. 
     8        * fast/js/deep-recursion-test.html: Added. 
     9 
    1102007-08-19  Maciej Stachowiak  <mjs@apple.com> 
    211