Changeset 29665


Ignore:
Timestamp:
01/18/08 23:49:53 (7 years ago)
Author:
alp@webkit.org
Message:

2008-01-18 Luca Bruno <lethalman88@gmail.com>

Reviewed by Alp Toker.

http://bugs.webkit.org/show_bug.cgi?id=16910
[GTK] REGRESSION: keyboard cursor doesn't blink

http://bugs.webkit.org/show_bug.cgi?id=16863
[GTK] REGRESSION: tab focusing doesn't work

  • WebView/webkitwebview.cpp: (webkit_web_view_focus_in_event): Added. Set the active frame. (webkit_web_view_class_init):
Location:
trunk/WebKit/gtk
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/WebKit/gtk/ChangeLog

    r29663 r29665  
     12008-01-18  Luca Bruno  <lethalman88@gmail.com> 
     2 
     3        Reviewed by Alp Toker. 
     4 
     5        http://bugs.webkit.org/show_bug.cgi?id=16910 
     6        [GTK] REGRESSION: keyboard cursor doesn't blink 
     7 
     8        http://bugs.webkit.org/show_bug.cgi?id=16863 
     9        [GTK] REGRESSION: tab focusing doesn't work 
     10 
     11        * WebView/webkitwebview.cpp: 
     12        (webkit_web_view_focus_in_event): Added. Set the active frame. 
     13        (webkit_web_view_class_init): 
     14 
    1152008-01-16  Alp Toker  <alp@atoker.com> 
    216 
  • trunk/WebKit/gtk/WebView/webkitwebview.cpp

    r29663 r29665  
    340340} 
    341341 
     342static gboolean webkit_web_view_focus_in_event(GtkWidget* widget, GdkEventFocus* event) 
     343{ 
     344    // TODO: Improve focus handling as suggested in 
     345    // http://bugs.webkit.org/show_bug.cgi?id=16910 
     346    GtkWidget* toplevel = gtk_widget_get_toplevel(widget); 
     347    if (GTK_WIDGET_TOPLEVEL(toplevel) && gtk_window_has_toplevel_focus(GTK_WINDOW(toplevel))) { 
     348        WebKitWebView* webView = WEBKIT_WEB_VIEW(widget); 
     349        Frame* frame = core(webkit_web_view_get_main_frame(webView)); 
     350        core(webView)->focusController()->setActive(frame); 
     351    } 
     352    return GTK_WIDGET_CLASS(webkit_web_view_parent_class)->focus_in_event(widget, event); 
     353} 
     354 
    342355static void webkit_web_view_realize(GtkWidget* widget) 
    343356{ 
     
    930943    widgetClass->size_allocate = webkit_web_view_size_allocate; 
    931944    widgetClass->popup_menu = webkit_web_view_popup_menu_handler; 
     945    widgetClass->focus_in_event = webkit_web_view_focus_in_event; 
    932946 
    933947    GtkContainerClass* containerClass = GTK_CONTAINER_CLASS(webViewClass); 
Note: See TracChangeset for help on using the changeset viewer.