Changeset 30737

Timestamp:

03/04/08 00:25:26 (2 years ago)

Author:

mrowe@apple.com

Message:

2008-03-04 Mark Rowe < mrowe@apple.com>

Reviewed by Sam Weinig.

Add a note about preferring if over else if when the previous if is terminated by a return statement.

• coding/coding-style.html:

Location:

trunk/WebKitSite

Files:

• ChangeLog (modified) (1 diff)
• coding/coding-style.html (modified) (2 diffs)

trunk/WebKitSite/ChangeLog

@@ +1 @@
+2008-03-04  Mark Rowe  <mrowe@apple.com>
+
+        Reviewed by Sam Weinig.
+
+        Add a note about preferring if over else if when the previous if is terminated by a return statement.
+
+        * coding/coding-style.html:
+
 2008-02-08  Adam Roben  <aroben@apple.com>
 

trunk/WebKitSite/coding/coding-style.html

@@ -202 +202 @@
 </li>
 
-<li>An else statement should go on the same line as a preceding close brace.
+<li>An <code>else</code> statement should go on the same line as a preceding close brace.
 <h4 class="right">Right:</h4>
 <pre class="code">
@@ -218 +218 @@
 }
 else {
+    ...
+}
+</pre>
+</li>
+
+<li>An <code>else if</code> statement should be written as an <code>if</code> statement when the prior <code>if</code> concludes with a <code>return</code> statement.
+<h4 class="right">Right:</h4>
+<pre class="code">
+if (condition) {
+    ...
+    return someValue;
+}
+if (condition) {
+    ...
+}
+</pre>
+
+<h4 class="wrong">Wrong:</h4>
+<pre class="code">
+if (condition) {
+    ...
+    return someValue;
+} else if (condition) {
     ...
 }