Changeset 31226 for trunk/JavaScriptCore/kjs/JSVariableObject.h

Timestamp:

03/21/08 21:59:20 (8 months ago)

Author:

oliver@apple.com

Message:

Optimise lookup of Math, undefined, NaN and Infinity

Reviewed by Maciej

Added a method to JSVariableObject to allow us to inject DontDelete properties
into the symbol table and localStorage. This results in a 0.4% progression in
SunSpider, with a 8% gain in math-partial-sums.

Files:

• trunk/JavaScriptCore/kjs/JSVariableObject.h (modified) (2 diffs)

trunk/JavaScriptCore/kjs/JSVariableObject.h

@@ -87 +87 @@
         bool symbolTablePut(const Identifier&, JSValue*);
         bool symbolTableInitializeVariable(const Identifier&, JSValue*, unsigned attributes);
+        bool symbolTableInsert(const Identifier&, JSValue*, unsigned attributes);
 
         JSVariableObjectData* d;
@@ -135 +136 @@
         return true;
     }
+    
+    inline bool JSVariableObject::symbolTableInsert(const Identifier& propertyName, JSValue* value, unsigned attributes)
+    {
+        if (symbolTable().get(propertyName.ustring().rep()) != missingSymbolMarker())
+            return false;
 
+        ASSERT((attributes & DontDelete) != 0);
+        size_t localStorageIndex = d->localStorage.size();
+        d->localStorage.append(LocalStorageEntry(value, attributes));
+        symbolTable().add(propertyName.ustring().rep(), localStorageIndex);
+        return true;
+    }
 } // namespace KJS