Changeset 31336

Show
Ignore:
Timestamp:
03/26/08 18:10:15 (16 months ago)
Author:
justin.garcia@apple.com
Message:

2008-03-26 Justin Garcia < justin.garcia@apple.com>

Reviewed by Harrison.

< rdar://problem/5820749> REGRESSION (Safari 3.1): Mail's plain text reply omits blank line following the attribution

  • editing/markup.cpp: (WebCore::createFragmentFromText): When asked to create a fragment from "Attribution:\n" with a context from [html, 0] to [html, 0], we'd return "<html>Attribution</html><br>". Don't enclose paragraphs in clones of the context's enclosing block if that block is the html or body element. Currently no way to test [DOMHTMLElement createFragmentFromText:].
Location:
trunk/WebCore
Files:
2 modified

Legend:

Unmodified
Added
Removed

  • trunk/WebCore/ChangeLog

    r31334 r31336  
     12008-03-26  Justin Garcia  <justin.garcia@apple.com> 
     2 
     3        Reviewed by Harrison. 
     4 
     5        <rdar://problem/5820749> REGRESSION (Safari 3.1): Mail's plain text reply omits blank line following the attribution 
     6 
     7        * editing/markup.cpp: 
     8        (WebCore::createFragmentFromText): When asked to create a fragment from "Attribution:\n" 
     9        with a context from [html, 0] to [html, 0], we'd return "<html>Attribution</html><br>". 
     10        Don't enclose paragraphs in clones of the context's enclosing block if that block is the 
     11        html or body element.  Currently no way to test [DOMHTMLElement createFragmentFromText:]. 
     12 
    1132008-03-26  Antti Koivisto  <antti@apple.com> 
    214 

  • trunk/WebCore/editing/markup.cpp

    r31169 r31336  
    10571057    // Break string into paragraphs. Extra line breaks turn into empty paragraphs. 
    10581058    Node* block = enclosingBlock(context->firstNode()); 
    1059     bool useClonesOfEnclosingBlock = !block->hasTagName(bodyTag); 
     1059    bool useClonesOfEnclosingBlock = block && !block->hasTagName(bodyTag) && !block->hasTagName(htmlTag); 
    10601060     
    10611061    Vector<String> list;