Changeset 31358

Timestamp:

03/26/08 21:13:47 (2 years ago)

Author:

mitz@apple.com

Message:

Reviewed by Dave Hyatt.

• fix < rdar://problem/5816522> REGRESSION (r30111-30112): Tahoe web cam website has some text in Chinese or japanese

• html/HTMLParser.cpp: (WebCore::HTMLParser::insertNode): Added call to beginParsingChildren() on the new node. (WebCore::HTMLParser::handleError): Ditto. (WebCore::HTMLParser::reopenResidualStyleTags): Ditto. (WebCore::HTMLParser::pushBlock): Removed incorrect call to beginParsingChildren() on the current node.
• manual-tests/applet-finish-parsing-children.html: Added.
• manual-tests/resources/DrawMessage.class: Added.

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• html/HTMLParser.cpp (modified) (5 diffs)
• manual-tests/applet-finish-parsing-children.html (added)
• manual-tests/resources/DrawMessage.class (added)

trunk/WebCore/ChangeLog

@@ +1 @@
+2008-03-26  Dan Bernstein  <mitz@apple.com>
+
+        Reviewed by Dave Hyatt.
+
+        - fix <rdar://problem/5816522> REGRESSION (r30111-30112): Tahoe web cam website has some text in Chinese or japanese
+
+        * html/HTMLParser.cpp:
+        (WebCore::HTMLParser::insertNode): Added call to beginParsingChildren()
+        on the new node.
+        (WebCore::HTMLParser::handleError): Ditto.
+        (WebCore::HTMLParser::reopenResidualStyleTags): Ditto.
+        (WebCore::HTMLParser::pushBlock): Removed incorrect call to
+        beginParsingChildren() on the current node.
+        * manual-tests/applet-finish-parsing-children.html: Added.
+        * manual-tests/resources/DrawMessage.class: Added.
+
 2008-03-26  Brady Eidson  <beidson@apple.com>
 

trunk/WebCore/html/HTMLParser.cpp

@@ -330 +330 @@
             // assumes that newNode is neither 0 nor a pointer to the document.
             pushBlock(localName, tagPriority);
+            newNode->beginParsingChildren();
             ASSERT(!didRefCurrent);
             newNode->ref(); 
@@ -418 +419 @@
                 
                 pushBlock(localName, tagPriority);
+                newNode->beginParsingChildren();
                 setCurrent(newNode);
                 if (!n->attached() && !m_isParsingFragment)
@@ -561 +563 @@
                         {
                             pushBlock(localName, tagPriority);
+                            n->beginParsingChildren();
                             setCurrent(n);
                             inStrayTableContent++;
@@ -1204 +1207 @@
         // Now push a new stack element for this node we just created.
         pushBlock(elem->tagName, elem->level);
+        newNode->beginParsingChildren();
 
         // Set our strayTableContent boolean if needed, so that the reopened tag also knows
@@ -1227 +1231 @@
 void HTMLParser::pushBlock(const AtomicString& tagName, int level)
 {
-    current->beginParsingChildren();
     blockStack = new HTMLStackElem(tagName, level, current, didRefCurrent, blockStack);
     didRefCurrent = false;