Changeset 34414

Show
Ignore:
Timestamp:
06/07/08 01:20:58 (6 months ago)
Author:
mitz@apple.com
Message:

2008-06-07 Pierre-Luc Beaudoin <pierre-luc.beaudoin@collabora.co.uk>

With the help of Jonathon Jongsma.

Reviewed by Dan Bernstein.

Fix for https://bugs.webkit.org/show_bug.cgi?id=19279
REGRESSION (r32660): Text not redrawn correctly when selection changes

  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paint): Add a condition for when ePos <= sPos
Location:
trunk/WebCore
Files:
2 modified

Legend:

Unmodified
Added
Removed

  • trunk/WebCore/ChangeLog

    r34410 r34414  
     12008-06-07  Pierre-Luc Beaudoin  <pierre-luc.beaudoin@collabora.co.uk> 
     2 
     3        With the help of Jonathon Jongsma. 
     4 
     5        Reviewed by Dan Bernstein. 
     6 
     7        Fix for https://bugs.webkit.org/show_bug.cgi?id=19279 
     8        REGRESSION (r32660): Text not redrawn correctly when selection changes 
     9 
     10        * rendering/InlineTextBox.cpp: 
     11        (WebCore::InlineTextBox::paint): 
     12        Add a condition for when ePos <= sPos  
     13 
    1142008-06-06  Julien Chaffraix  <jchaffraix@webkit.org> 
    215 

  • trunk/WebCore/rendering/InlineTextBox.cpp

    r33071 r34414  
    418418 
    419419        updateGraphicsContext(context, textFillColor, textStrokeColor, textStrokeWidth); 
    420         if (!paintSelectedTextSeparately) { 
     420        if (!paintSelectedTextSeparately || ePos <= sPos) { 
    421421            // FIXME: Truncate right-to-left text correctly. 
    422422            paintTextWithShadows(context, textRun, 0, m_truncation == cNoTruncation ? m_len : m_truncation, textOrigin, m_x + tx, m_y + ty, width(), height(), textShadow, textStrokeWidth > 0);