Show
Ignore:
Timestamp:
08/03/08 01:34:42 (4 months ago)
Author:
britto@apple.com
Message:

2008-08-02 Maxime Britto <britto@apple.com>

Reviewed by Eric Seidel.

<rdar://problem/6118969>
https://bugs.webkit.org/show_bug.cgi?id=19971
Modifiy the cursor interactively when on panning mode (middle click auto scroll)
When the panning is in progress the cursor is an arrow representing the direction of the current scroll

  • page/EventHandler.cpp: (WebCore::EventHandler::autoscrollTimerFired): Before each scroll we actualize the cursor to match the current direction (WebCore::EventHandler::setPanScrollCursor): determines the direction of the upcoming scroll. (WebCore::EventHandler::handleMouseMoveEvent):
  • page/EventHandler.h:
  • platform/Cursor.h: Add propotypes for the new cursor functions
  • platform/gtk/CursorGtk.cpp: to avoid build break (WebCore::middlePanningCursor): (WebCore::eastPanningCursor): (WebCore::northPanningCursor): (WebCore::northEastPanningCursor): (WebCore::northWestPanningCursor): (WebCore::southPanningCursor): (WebCore::southEastPanningCursor): (WebCore::southWestPanningCursor): (WebCore::westPanningCursor):
  • platform/mac/CursorMac.mm: to avoid build break (WebCore::middlePanningCursor): (WebCore::eastPanningCursor): (WebCore::northPanningCursor): (WebCore::northEastPanningCursor): (WebCore::northWestPanningCursor): (WebCore::southPanningCursor): (WebCore::southEastPanningCursor): (WebCore::southWestPanningCursor): (WebCore::westPanningCursor):
  • platform/qt/CursorQt.cpp: to avoid build break (WebCore::middlePanningCursor): (WebCore::eastPanningCursor): (WebCore::northPanningCursor): (WebCore::northEastPanningCursor): (WebCore::northWestPanningCursor): (WebCore::southPanningCursor): (WebCore::southEastPanningCursor): (WebCore::southWestPanningCursor): (WebCore::westPanningCursor):
  • platform/win/CursorWin.cpp: Add specific icons for the panning as windows resizing icons are both sides arrows (WebCore::middlePanningCursor): (WebCore::eastPanningCursor): (WebCore::northPanningCursor): (WebCore::northEastPanningCursor): (WebCore::northWestPanningCursor): (WebCore::southPanningCursor): (WebCore::southEastPanningCursor): (WebCore::southWestPanningCursor): (WebCore::westPanningCursor):
  • platform/wx/CursorWx.cpp: to avoid build break (WebCore::middlePanningCursor): (WebCore::eastPanningCursor): (WebCore::northPanningCursor): (WebCore::northEastPanningCursor): (WebCore::northWestPanningCursor): (WebCore::southPanningCursor): (WebCore::southEastPanningCursor): (WebCore::southWestPanningCursor): (WebCore::westPanningCursor):

2008-08-02 Maxime Britto <britto@apple.com>

Reviewed by Eric Seidel.


These icons are copies from the resizers in WebCore/Ressources

  • ChangeLog:
  • WebKit.vcproj/WebKit.rc:
  • WebKit.vcproj/panEastCursor.png: Added.
  • WebKit.vcproj/panNorthCursor.png: Added.
  • WebKit.vcproj/panNorthEastCursor.png: Added.
  • WebKit.vcproj/panNorthWestCursor.png: Added.
  • WebKit.vcproj/panSouthCursor.png: Added.
  • WebKit.vcproj/panSouthEastCursor.png: Added.
  • WebKit.vcproj/panSouthWestCursor.png: Added.
  • WebKit.vcproj/panWestCursor.png: Added.
  • WebKit.vcproj/resource.h:
  • WebKitDLL.cpp: (loadResourceIntoBuffer):
Files:
1 modified

Legend:

Unmodified
Added
Removed
  • trunk/WebCore/platform/gtk/CursorGtk.cpp

    r30501 r35532  
    214214    return c; 
    215215} 
     216     
     217const Cursor& middlePanningCursor() 
     218{ 
     219    return moveCursor(); 
     220} 
     221 
     222const Cursor& eastPanningCursor() 
     223{ 
     224    return eastResizeCursor(); 
     225} 
     226 
     227const Cursor& northPanningCursor() 
     228{ 
     229    return northResizeCursor(); 
     230} 
     231 
     232const Cursor& northEastPanningCursor() 
     233{ 
     234    return northEastResizeCursor(); 
     235} 
     236 
     237const Cursor& northWestPanningCursor() 
     238{ 
     239    return northWestResizeCursor(); 
     240} 
     241 
     242const Cursor& southPanningCursor() 
     243{ 
     244    return southResizeCursor(); 
     245} 
     246 
     247const Cursor& southEastPanningCursor() 
     248{ 
     249    return southEastResizeCursor(); 
     250} 
     251 
     252const Cursor& southWestPanningCursor() 
     253{ 
     254    return southWestResizeCursor(); 
     255} 
     256 
     257const Cursor& westPanningCursor() 
     258{ 
     259    return westResizeCursor(); 
     260} 
     261     
    216262 
    217263const Cursor& verticalTextCursor()