Changeset 35605

Timestamp:

08/06/08 09:33:19 (4 months ago)

Author:

cfleizach@apple.com

Message:

Fix an accessibility layout test that was failing on different platforms

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/accessibility/bounds-for-range-expected.txt (modified) (1 diff)
• WebKitTools/ChangeLog (modified) (1 diff)
• WebKitTools/DumpRenderTree/mac/AccessibilityUIElementMac.mm (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2008-08-06  chris fleizach  <cfleizach@apple.com>
+
+        Reviewed by Beth Dakin
+
+        Fix AX layout test for multi-platform
+
+        * accessibility/bounds-for-range-expected.txt:
+
 2008-08-06  Cameron Zwarich  <cwzwarich@uwaterloo.ca>
 

trunk/LayoutTests/accessibility/bounds-for-range-expected.txt

@@ -52 +52 @@
 
 ----------------------
-{{-9945.000000, 10850.000000}, {59.000000, 18.000000}}
-{{-9982.000000, 10832.000000}, {215.000000, 18.000000}}
-{{-9992.000000, 10814.000000}, {11.000000, 18.000000}}
-{{-9992.000000, 10778.000000}, {766.000000, 36.000000}}
-{{-9949.000000, 10778.000000}, {1.000000, 18.000000}}
+{{-1.000000, -1.000000}, {59.000000, 18.000000}}
+{{-1.000000, -1.000000}, {215.000000, 18.000000}}
+{{-1.000000, -1.000000}, {11.000000, 18.000000}}
+{{-1.000000, -1.000000}, {766.000000, 36.000000}}
+{{-1.000000, -1.000000}, {1.000000, 18.000000}}
 
 

trunk/WebKitTools/ChangeLog

@@ +1 @@
+2008-08-06  chris fleizach  <cfleizach@apple.com>
+
+        Reviewed by Beth Dakin
+
+        AX functions shouldn't return position information because it changes
+        based on the platform
+
+        * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
+        (AccessibilityUIElement::boundsForRange):
+
 2008-08-06  Eric Seidel  <eric@webkit.org>
 

trunk/WebKitTools/DumpRenderTree/mac/AccessibilityUIElementMac.mm

@@ -290 +290 @@
         rect = [value rectValue]; 
     
-    NSMutableString* boundsDescription = [NSMutableString stringWithFormat:@"{{%f, %f}, {%f, %f}}",rect.origin.x,rect.origin.y,rect.size.width,rect.size.height];
+    // don't return position information because it is platform dependent
+    NSMutableString* boundsDescription = [NSMutableString stringWithFormat:@"{{%f, %f}, {%f, %f}}",-1.0f,-1.0f,rect.size.width,rect.size.height];
     return [boundsDescription createJSStringRef];
 }