Changeset 54191

Timestamp:

02/01/10 18:43:01 (5 years ago)

Author:

jorlow@chromium.org

Message:

2010-01-27 Matt Perry <​mpcomplete@chromium.org>

Reviewed by Eric Seidel.

Add support for addUserScript to chromium port.

• public/WebView.h:
• src/WebViewImpl.cpp: (WebKit::WebViewImpl::addUserScript): (WebKit::WebViewImpl::removeAllUserContent):
• src/WebViewImpl.h:

Location:

trunk/WebKit/chromium

Files:

• ChangeLog (modified) (1 diff)
• public/WebStorageArea.h (modified) (1 diff)

trunk/WebKit/chromium/ChangeLog

@@ -37 +37 @@
         (WebKit::isASingleWord): Use wordBreakIterator(), and correctly check
         the return value of textBreakNext().
+
+2010-01-29  Jeremy Orlow  <jorlow@chromium.org>
+
+        Reviewed by Eric Seidel.
+
+        [Chromium] Clean up WebStorageArea
+        https://bugs.webkit.org/show_bug.cgi?id=34353
+
+        Get rid of legacy glue code and fix a typo.
+
+        * public/WebStorageArea.h:
 
 2010-01-29  Jeremy Orlow  <jorlow@chromium.org>

trunk/WebKit/chromium/public/WebStorageArea.h

@@ -58 +58 @@
     virtual WebString getItem(const WebString& key) = 0;
 
-    // Set the value that corresponds to a specific key. QuotaException is set if we've
+    // Set the value that corresponds to a specific key. QuotaException is set if
     // the StorageArea would have exceeded its quota. The value is NOT set when there's
     // an exception.  url is the url that should be used if a storage event fires.
-    // FIXME: The following is a hack to keep Chromium compiling until the other half is landed.  Remove soon.
-    virtual void setItem(const WebString& key, const WebString& newValue, const WebURL& url, bool& quotaException) // Deprecated.
-    {
-        WebString oldValue;
-        setItem(key, newValue, url, quotaException, oldValue);
-    }
-    virtual void setItem(const WebString& key, const WebString& newValue, const WebURL& url, bool& quotaException, WebString& oldValue)
-    {
-        setItem(key, newValue, url, quotaException);
-    }
+    virtual void setItem(const WebString& key, const WebString& newValue, const WebURL& url, bool& quotaException, WebString& oldValue) = 0;
 
     // Remove the value associated with a particular key.  url is the url that should be used
     // if a storage event fires.
-    // FIXME: The following is a hack to keep Chromium compiling until the other half is landed.  Remove soon.
-    virtual void removeItem(const WebString& key, const WebURL& url) // Deprecated.
-    {
-        WebString oldValue;
-        removeItem(key, url, oldValue);
-    }
-    virtual void removeItem(const WebString& key, const WebURL& url, WebString& oldValue)
-    {
-        removeItem(key, url);
-    }
+    virtual void removeItem(const WebString& key, const WebURL& url, WebString& oldValue) = 0;
 
     // Clear all key/value pairs.  url is the url that should be used if a storage event fires.
-    // FIXME: The following is a hack to keep Chromium compiling until the other half is landed.  Remove soon.
-    virtual void clear(const WebURL& url) // Deprecated.
-    {
-        bool somethingCleared;
-        clear(url, somethingCleared);
-    }
-    virtual void clear(const WebURL& url, bool& somethingCleared)
-    {
-        clear(url);
-    }
+    virtual void clear(const WebURL& url, bool& somethingCleared) = 0;
 };