Changeset 54818 in webkit

Timestamp:

Feb 16, 2010 4:54:05 AM (8 years ago)

Author:

xan@webkit.org

Message:

2010-02-16 Xan Lopez <​xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Bump version to 1.1.22 so we can depend on it in applications.

• configure.ac:

WebKit/gtk:

2010-02-16 Xan Lopez <​xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Add a new WebKitWebSettings setting, 'auto-resize-window', set to
FALSE by default, that when enabled will apply any resizes or
moves done by a page through various DOM methods (moveTo,
resizeTo, moveBy, resizeBy).

• WebCoreSupport/ChromeClientGtk.cpp:
• webkit/webkitwebsettings.cpp: (webkit_web_settings_class_init): (webkit_web_settings_set_property): (webkit_web_settings_get_property): (webkit_web_settings_copy):

WebKitTools:

2010-02-16 Xan Lopez <​xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Enable 'auto-resize-window' in our DRT.

• DumpRenderTree/gtk/DumpRenderTree.cpp: (resetDefaultsToConsistentValues):

Location:

trunk

Files:

• ChangeLog (modified) (1 diff)
• WebKit/gtk/ChangeLog (modified) (1 diff)
• WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp (modified) (1 diff)
• WebKit/gtk/webkit/webkitwebsettings.cpp (modified) (6 diffs)
• WebKitTools/ChangeLog (modified) (1 diff)
• WebKitTools/DumpRenderTree/gtk/DumpRenderTree.cpp (modified) (1 diff)
• configure.ac (modified) (1 diff)

trunk/ChangeLog

@@ +1 @@
+2010-02-16  Xan Lopez  <xlopez@igalia.com>
+
+        Reviewed by Gustavo Noronha.
+
+        Bump version to 1.1.22 so we can depend on it in applications.
+
+        * configure.ac:
+
 2010-02-12  Simon Hausmann  <simon.hausmann@nokia.com>
 

trunk/WebKit/gtk/ChangeLog

@@ +1 @@
+2010-02-16  Xan Lopez  <xlopez@igalia.com>
+
+        Reviewed by Gustavo Noronha.
+
+        Add a new WebKitWebSettings setting, 'auto-resize-window', set to
+        FALSE by default, that when enabled will apply any resizes or
+        moves done by a page through various DOM methods (moveTo,
+        resizeTo, moveBy, resizeBy).
+
+        * WebCoreSupport/ChromeClientGtk.cpp:
+        * webkit/webkitwebsettings.cpp:
+        (webkit_web_settings_class_init):
+        (webkit_web_settings_set_property):
+        (webkit_web_settings_get_property):
+        (webkit_web_settings_copy):
+
 2010-02-15  Emilio Pozuelo Monfort  <pochu27@gmail.com>
 

trunk/WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp

@@ -89 +89 @@
                  "height", intrect.height(),
                  NULL);
+
+    gboolean autoResizeWindow;
+    WebKitWebSettings* settings = webkit_web_view_get_settings(m_webView);
+    g_object_get(settings, "auto-resize-window", &autoResizeWindow, NULL);
+
+    if (!autoResizeWindow)
+        return;
+
+    GtkWidget* window = gtk_widget_get_toplevel(GTK_WIDGET(m_webView));
+#if GTK_CHECK_VERSION(2, 18, 0)
+    if (gtk_widget_is_toplevel(window)) {
+#else
+    if (GTK_WIDGET_TOPLEVEL(window)) {
+#endif
+        gtk_window_move(GTK_WINDOW(window), intrect.x(), intrect.y());
+        gtk_window_resize(GTK_WINDOW(window), intrect.width(), intrect.height());
+    }
 }
 

trunk/WebKit/gtk/webkit/webkitwebsettings.cpp

@@ -104 +104 @@
     gboolean enable_site_specific_quirks;
     gboolean enable_page_cache;
+    gboolean auto_resize_window;
 };
 
@@ -148 +149 @@
     PROP_ENABLE_DEFAULT_CONTEXT_MENU,
     PROP_ENABLE_SITE_SPECIFIC_QUIRKS,
-    PROP_ENABLE_PAGE_CACHE
+    PROP_ENABLE_PAGE_CACHE,
+    PROP_AUTO_RESIZE_WINDOW
 };
 
@@ -760 +762 @@
                                                          flags));
 
+    /**
+    * WebKitWebSettings:auto-resize-window:
+    *
+    * Web pages can request to modify the size and position of the
+    * window containing the #WebKitWebView through various DOM methods
+    * (resizeTo, moveTo, resizeBy, moveBy). By default WebKit will not
+    * honor this requests, but you can set this property to %TRUE if
+    * you'd like it to do so. If you wish to handle this manually, you
+    * can connect to the notify signal for the
+    * #WebKitWebWindowFeatures of your #WebKitWebView.
+    * 
+    * Since: 1.1.22
+    */
+    g_object_class_install_property(gobject_class,
+                                    PROP_AUTO_RESIZE_WINDOW,
+                                    g_param_spec_boolean("auto-resize-window",
+                                                         _("Auto Resize Window"),
+                                                         _("Automatically resize the toplevel window when a page requests it"),
+                                                         FALSE,
+                                                         flags));
+
     g_type_class_add_private(klass, sizeof(WebKitWebSettingsPrivate));
 }
@@ -968 +991 @@
         priv->enable_page_cache = g_value_get_boolean(value);
         break;
+    case PROP_AUTO_RESIZE_WINDOW:
+        priv->auto_resize_window = g_value_get_boolean(value);
+        break;
     default:
         G_OBJECT_WARN_INVALID_PROPERTY_ID(object, prop_id, pspec);
@@ -1093 +1119 @@
     case PROP_ENABLE_PAGE_CACHE:
         g_value_set_boolean(value, priv->enable_page_cache);
+        break;
+    case PROP_AUTO_RESIZE_WINDOW:
+        g_value_set_boolean(value, priv->auto_resize_window);
         break;
     default:
@@ -1163 +1192 @@
                  "enable-site-specific-quirks", priv->enable_site_specific_quirks,
                  "enable-page-cache", priv->enable_page_cache,
+                 "auto-resize-window", priv->auto_resize_window,
                  NULL));
 

trunk/WebKitTools/ChangeLog

@@ +1 @@
+2010-02-16  Xan Lopez  <xlopez@igalia.com>
+
+        Reviewed by Gustavo Noronha.
+
+        Enable 'auto-resize-window' in our DRT.
+
+        * DumpRenderTree/gtk/DumpRenderTree.cpp:
+        (resetDefaultsToConsistentValues):
+
 2010-02-15  Martin Robinson  <mrobinson@webkit.org>
 

trunk/WebKitTools/DumpRenderTree/gtk/DumpRenderTree.cpp

@@ -336 +336 @@
                  "enable-caret-browsing", FALSE,
                  "enable-page-cache", FALSE,
+                 "auto-resize-window", TRUE,
                  NULL);
 

trunk/configure.ac

@@ -3 +3 @@
 m4_define([webkit_major_version], [1])
 m4_define([webkit_minor_version], [1])
-m4_define([webkit_micro_version], [21])
+m4_define([webkit_micro_version], [22])
 
 # This is the version we'll be using as part of our User-Agent string