Changeset 7531

Timestamp:

09/13/04 13:17:29 (4 years ago)

Author:

kocienda

Message:

Reviewed by John

Fix for this bug:

<rdar://problem/3784840> REGRESSION (Mail): Text is inserted in the wrong place after changing typing style

• khtml/editing/htmlediting_impl.cpp: (khtml::InputTextCommandImpl::prepareForTextInsertion): Code to handle typing style did not check to see if the reference node used for the DOM node insertion operation was a block. If it is, then the new node containing the new editing style now is inserted at the start of the block, instead of after it.

Location:

trunk/WebCore

Files:

• ChangeLog-2005-08-23 (modified) (1 diff)
• khtml/editing/htmlediting_impl.cpp (modified) (1 diff)

trunk/WebCore/ChangeLog-2005-08-23

@@ +1 @@
+2004-09-13  Ken Kocienda  <kocienda@apple.com>
+
+        Reviewed by John
+
+        Fix for this bug:
+        
+        <rdar://problem/3784840> REGRESSION (Mail): Text is inserted in the wrong place after changing typing style
+
+        * khtml/editing/htmlediting_impl.cpp:
+        (khtml::InputTextCommandImpl::prepareForTextInsertion): Code to handle typing style did not
+        check to see if the reference node used for the DOM node insertion operation was a block.
+        If it is, then the new node containing the new editing style now is inserted at the start of the block,
+        instead of after it.
+
 2004-09-13  Ken Kocienda  <kocienda@apple.com>
 

trunk/WebCore/khtml/editing/htmlediting_impl.cpp

@@ -1545 +1545 @@
             TextImpl *editingTextNode = document()->createEditingTextNode("");
             NodeImpl *node = endingSelection().start().upstream(StayInBlock).node();
-            insertNodeAfter(applyTypingStyle(editingTextNode), node);
+            if (node->isBlockFlow())
+                insertNodeAt(applyTypingStyle(editingTextNode), node, 0);
+            else
+                insertNodeAfter(applyTypingStyle(editingTextNode), node);
             pos = Position(editingTextNode, 0);
         }