2011-11-23 Sheriff Bot Unreviewed, rolling out r101057. http://trac.webkit.org/changeset/101057 https://bugs.webkit.org/show_bug.cgi?id=73027 Broke Chromium Windows build (Requested by aklein on #webkit). * html/HTMLTrackElement.cpp: (WebCore::HTMLTrackElement::HTMLTrackElement): (WebCore::HTMLTrackElement::didCompleteLoad): (WebCore::HTMLTrackElement::textTrackReadyStateChanged): * html/HTMLTrackElement.h: * html/HTMLTrackElement.idl: * html/LoadableTextTrack.cpp: (WebCore::LoadableTextTrack::loadTimerFired): (WebCore::LoadableTextTrack::cueLoadingStarted): (WebCore::LoadableTextTrack::cueLoadingCompleted): * html/TextTrack.cpp: (WebCore::TextTrack::TextTrack): (WebCore::TextTrack::setReadyState): * html/TextTrack.h: (WebCore::TextTrack::readyState): * html/TextTrack.idl: 2011-11-23 Yury Semikhatsky Unreviewed. Build fix. Added missing ENABLE(WORKERS) guards. * inspector/WorkerConsoleAgent.cpp: * inspector/WorkerConsoleAgent.h: * inspector/WorkerRuntimeAgent.cpp: * inspector/WorkerRuntimeAgent.h: 2011-11-23 Philippe Normand [GStreamer] improper usage of gst_object_ref_sink https://bugs.webkit.org/show_bug.cgi?id=73014 Reviewed by Martin Robinson. No new tests. Existing tests cover this already. * platform/graphics/gstreamer/GRefPtrGStreamer.cpp: (WTF::adoptGRef): Ensure this is called with non-floating GstObjects. (WTF::GstElement): Replace gst_object_ref_sink with gst_object_ref+gst_object_sink like advised in the GstObject documentation. (WTF::GstPad): Ditto. * platform/graphics/gstreamer/GRefPtrGStreamer.h: 2011-11-23 Yury Semikhatsky Web Inspector: split console agent into worker and page console agents https://bugs.webkit.org/show_bug.cgi?id=73019 InspectorConsoleAgent now has two descendants: WorkerConsoleAgent and PageConsoleAgent which encapsulate functionality specific for the type of inspected instance. Reviewed by Pavel Feldman. * CMakeLists.txt: * GNUmakefile.list.am: * Target.pri: * WebCore.gypi: * WebCore.vcproj/WebCore.vcproj: * WebCore.xcodeproj/project.pbxproj: * inspector/InspectorConsoleAgent.cpp: (WebCore::InspectorConsoleAgent::InspectorConsoleAgent): (WebCore::InspectorConsoleAgent::~InspectorConsoleAgent): (WebCore::InspectorConsoleAgent::clearMessages): (WebCore::InspectorConsoleAgent::addMessageToConsole): (WebCore::InspectorConsoleAgent::resourceRetrievedByXMLHttpRequest): (WebCore::InspectorConsoleAgent::didReceiveResponse): (WebCore::InspectorConsoleAgent::didFailLoading): (WebCore::InspectorConsoleAgent::addConsoleMessage): * inspector/InspectorConsoleAgent.h: * inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): * inspector/InspectorStyleTextEditor.cpp: * inspector/InspectorStyleTextEditor.h: * inspector/PageConsoleAgent.cpp: Copied from Source/WebCore/inspector/PageDebuggerAgent.cpp. (WebCore::PageConsoleAgent::PageConsoleAgent): (WebCore::PageConsoleAgent::~PageConsoleAgent): (WebCore::PageConsoleAgent::clearMessages): (WebCore::PageConsoleAgent::addInspectedNode): (WebCore::PageConsoleAgent::developerExtrasEnabled): * inspector/PageConsoleAgent.h: Copied from Source/WebCore/inspector/PageDebuggerAgent.h. * inspector/PageDebuggerAgent.cpp: * inspector/PageDebuggerAgent.h: * inspector/PageRuntimeAgent.cpp: Copied from Source/WebCore/inspector/PageDebuggerAgent.h. (WebCore::PageRuntimeAgent::PageRuntimeAgent): PageRuntimeAgent was moved into its own file. (WebCore::PageRuntimeAgent::~PageRuntimeAgent): (WebCore::PageRuntimeAgent::scriptStateForFrameId): (WebCore::PageRuntimeAgent::getDefaultInspectedState): * inspector/PageRuntimeAgent.h: Copied from Source/WebCore/inspector/PageDebuggerAgent.h. * inspector/WorkerConsoleAgent.cpp: Copied from Source/WebCore/inspector/PageDebuggerAgent.h. (WebCore::WorkerConsoleAgent::WorkerConsoleAgent): (WebCore::WorkerConsoleAgent::~WorkerConsoleAgent): (WebCore::WorkerConsoleAgent::addInspectedNode): (WebCore::WorkerConsoleAgent::developerExtrasEnabled): * inspector/WorkerConsoleAgent.h: Copied from Source/WebCore/inspector/PageDebuggerAgent.h. * inspector/WorkerDebuggerAgent.cpp: * inspector/WorkerDebuggerAgent.h: * inspector/WorkerInspectorController.cpp: (WebCore::WorkerInspectorController::WorkerInspectorController): * inspector/WorkerInspectorController.h: * inspector/WorkerRuntimeAgent.cpp: Copied from Source/WebCore/inspector/PageDebuggerAgent.h. (WebCore::WorkerRuntimeAgent::WorkerRuntimeAgent): WorkerRuntimeAgent was moved into its own file. (WebCore::WorkerRuntimeAgent::~WorkerRuntimeAgent): (WebCore::WorkerRuntimeAgent::scriptStateForFrameId): (WebCore::WorkerRuntimeAgent::getDefaultInspectedState): * inspector/WorkerRuntimeAgent.h: Copied from Source/WebCore/inspector/PageDebuggerAgent.h. 2011-11-23 Alexander Pavlov Web Inspector: warning icon for unrecognized style rule should have tooltip https://bugs.webkit.org/show_bug.cgi?id=50638 Reviewed by Yury Semikhatsky. * English.lproj/localizedStrings.js: Add new tooltip strings. * inspector/front-end/CSSCompletions.js: (WebInspector.CSSCompletions.prototype.keySet): Added. * inspector/front-end/StylesSidebarPane.js: Create a separate IMG element for an exclamation mark. * inspector/front-end/elementsPanel.css: (.styles-section .properties li.not-parsed-ok img.exclamation-mark): 2011-11-23 Halton Huo [EFL] Add zlib depend when freetype is used. https://bugs.webkit.org/show_bug.cgi?id=66365 Unreviewed build fix. When freetype is enabled, uncompress() function is used by WOFFFileFormat.cpp. Since zlib is not required by freetype, we need to add libz as dependency for fix linking issue. No new test because this change is only to fix linking issue. * PlatformEfl.cmake: add ZLIB as dependency when using freetype 2011-11-23 Mihnea Ovidenie CSS Exclusions: parse the shorthand "wrap" property https://bugs.webkit.org/show_bug.cgi?id=71905 Reviewed by Dean Jackson. Test: fast/exclusions/wrap-parsing.html * css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): * css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::getPropertyValue): * css/CSSParser.cpp: (WebCore::CSSParser::parseValue): * css/CSSProperty.cpp: (WebCore::CSSProperty::isInheritedProperty): * css/CSSPropertyLonghand.cpp: (WebCore::initShorthandMap): * css/CSSPropertyNames.in: * css/CSSStyleApplyProperty.cpp: (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty): * css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): 2011-11-23 Alexandru Chiculita [CSS Filters] WebKit crashes when changing the filter https://bugs.webkit.org/show_bug.cgi?id=72723 Reviewed by Simon Fraser. There are three things fixed with this patch: 1. The list of effects wasn't cleared when the FilterOperations were changed. 2. The sourceImage was going to be 0, because the m_sourceGraphicBuffer.release() was also clearing the reference to m_sourceGraphicBuffer. Next time the build() method was called m_graphicsBufferAttached was set to false, but the m_sourceGraphicBuffer was not regenerated, because the size was not invalidated. 3. maxEffectRects were not updated when a new list of effects was built. Test: css3/filters/crash-filter-change.html * rendering/FilterEffectRenderer.cpp: (WebCore::FilterEffectRenderer::build): (WebCore::FilterEffectRenderer::prepare): * rendering/FilterEffectRenderer.h: (WebCore::FilterEffectRenderer::setSourceImageRect): 2011-11-23 Elliot Poger [Skia] fix duplicate symbol __ZN7WebCore11BitmapImage16initPlatformDataEv error https://bugs.webkit.org/show_bug.cgi?id=72954 Reviewed by Adam Barth. * WebCore.gyp/WebCore.gyp: 2011-11-18 Pavel Podivilov Web Inspector: add integration test for compiler source maps. https://bugs.webkit.org/show_bug.cgi?id=72730 Reviewed by Pavel Feldman. Test: http/tests/inspector/compiler-source-mapping-debug.html * inspector/front-end/DebuggerPresentationModel.js: (WebInspector.DebuggerPresentationModel.prototype._bindScriptToRawSourceCode): (WebInspector.DebuggerPresentationModel.prototype.setCompilerSourceMapping): (WebInspector.DebuggerPresentationModel.prototype.evaluateInSelectedCallFrame): (WebInspector.DebuggerPresentationModel.prototype.get executionLineLocation): (WebInspector.DebuggerPresentationModel.DefaultLinkifierFormatter.prototype.formatRawSourceCodeAnchor): (WebInspector.DebuggerPresentationModel.Linkifier.prototype.linkifyLocation): (WebInspector.DebuggerPresentationModel.Linkifier.prototype._updateAnchor): 2011-11-23 Martin Robinson Build fix for GTK+. * platform/graphics/gtk/DrawingBufferGtk.cpp: (WebCore::DrawingBuffer::DrawingBuffer): Update signature and ASSERT for the GTK+ port. 2011-11-23 Rafael Weinstein Remove notifyChange from the public interface of CSSMutableStyleDeclaration https://bugs.webkit.org/show_bug.cgi?id=72660 Reviewed by Ojan Vafai. No tests needed. This is only a refactor. * css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::CSSMutableStyleDeclaration): (WebCore::CSSMutableStyleDeclaration::addParsedProperty): * css/CSSMutableStyleDeclaration.h: (WebCore::CSSMutableStyleDeclaration::setProperty): (WebCore::CSSMutableStyleDeclaration::removeProperty): (WebCore::CSSMutableStyleDeclaration::removePropertiesInSet): * css/CSSStyleSelector.cpp: (WebCore::leftToRightDeclaration): (WebCore::rightToLeftDeclaration): * editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange): * html/HTMLElement.cpp: (WebCore::HTMLElement::setContentEditable): 2011-11-23 Scott Graham Adding gamepad support https://bugs.webkit.org/show_bug.cgi?id=69451 Reviewed by Darin Fisher. Plumb gamepad data access through platform. Test: gamepad/gamepad-polling-access.html * WebCore.gypi: * page/Navigator.cpp: (WebCore::Navigator::webkitGamepads): * page/Navigator.h: * platform/Gamepads.h: Added. * platform/chromium/GamepadsChromium.cpp: Added. (WebCore::sampleGamepads): * platform/chromium/PlatformSupport.h: 2011-11-23 Dmitry Lomov Get rid of WebCore dependencies from TypedArray implementation types https://bugs.webkit.org/show_bug.cgi?id=72783 Reviewed by David Levin. Remove WebCore specific logic for neutering Typed Array implementations. * bindings/scripts/CodeGeneratorJS.pm: (GenerateImplementation): * bindings/scripts/CodeGeneratorV8.pm: * html/canvas/ArrayBuffer.cpp: (WTF::ArrayBuffer::transfer): * html/canvas/ArrayBuffer.h: * html/canvas/ArrayBufferView.cpp: (WTF::ArrayBufferView::neuter): * html/canvas/ArrayBufferView.h: * html/canvas/DataView.cpp: (WebCore::DataView::neuter): * html/canvas/DataView.h: * html/canvas/Float32Array.h: * html/canvas/Float64Array.h: * html/canvas/Int16Array.h: * html/canvas/Int32Array.h: * html/canvas/Int8Array.h: * html/canvas/Uint16Array.h: * html/canvas/Uint32Array.h: * html/canvas/Uint8Array.h: 2011-11-23 Raul Hudea First step towards http://webkit.org/b/70025 Allow -webkit-transform to be have effect to SVG elements. Currently, the CSS transform takes precedence over the SVG transform attribute Allow SVG elements to be transformed using webkit-transform https://bugs.webkit.org/show_bug.cgi?id=71309 Reviewed by Nikolas Zimmermann. Tests: svg/clip-path/clip-path-css-transform-1.svg svg/clip-path/clip-path-css-transform-2.svg svg/custom/clip-path-with-css-transform-1.svg svg/custom/clip-path-with-css-transform-2.svg svg/custom/pointer-events-image-css-transform.svg svg/custom/pointer-events-text-css-transform.svg svg/dom/css-transforms.xhtml svg/dynamic-updates/SVG-dynamic-css-transform.html svg/dynamic-updates/SVGClipPathElement-css-transform-influences-hitTesting.html svg/transforms/svg-css-transforms-clip-path.xhtml svg/transforms/svg-css-transforms.xhtml * manual-tests/svg-animation-css-transform.html: Added. * manual-tests/svg-css-animate-compound.html: Added. * manual-tests/svg-css-transition-compound.html: Added. * rendering/svg/RenderSVGModelObject.cpp: (WebCore::RenderSVGModelObject::styleWillChange): Set the updateTransform flag on SVG elements whenever a CSS transform is present on the style * svg/SVGStyledTransformableElement.cpp: (WebCore::SVGStyledTransformableElement::animatedLocalTransform): Use the RenderStyle's transform (if it exists) over the SVG's transform * svg/SVGTextElement.cpp: (WebCore::SVGTextElement::animatedLocalTransform): Use the RenderStyle's transform (if it exists) over the SVG's transform 2011-11-23 Rafael Weinstein [MutationObservers] Cleanup duplicated code in Element & CharacterData https://bugs.webkit.org/show_bug.cgi?id=72986 Reviewed by Ojan Vafai. This patch creates a MutationObserverInterestGroup which represents the set of MutationObservers which should receive all mutations of a given type generated from a specific node. No tests needed. This patch is only a refactor. * dom/CharacterData.cpp: (WebCore::CharacterData::dispatchModifiedEvent): * dom/ChildListMutationScope.cpp: (WebCore::MutationAccumulationRouter::ChildListMutationAccumulator::ChildListMutationAccumulator): (WebCore::MutationAccumulationRouter::ChildListMutationAccumulator::enqueueMutationRecord): (WebCore::MutationAccumulationRouter::MutationAccumulationRouter::incrementScopingLevel): * dom/Element.cpp: (WebCore::enqueueAttributesMutationRecord): * dom/WebKitMutationObserver.cpp: (WebCore::MutationObserverInterestGroup::createForChildListMutation): (WebCore::MutationObserverInterestGroup::createForCharacterDataMutation): (WebCore::MutationObserverInterestGroup::createForAttributesMutation): (WebCore::MutationObserverInterestGroup::MutationObserverInterestGroup): (WebCore::MutationObserverInterestGroup::isOldValueRequested): (WebCore::MutationObserverInterestGroup::enqueueMutationRecord): * dom/WebKitMutationObserver.h: (WebCore::MutationObserverInterestGroup::isEmpty): (WebCore::MutationObserverInterestGroup::hasOldValue): 2011-11-23 Marc-Andre Decoste [chromium] HDC leak in Uniscribe Helper https://bugs.webkit.org/show_bug.cgi?id=68598 Reviewed by Darin Fisher. For some reason the Script functions on Windows sometimes return E_PENDING even with a non-NULL DC, so we must handle that case. Also, we should not use the screen DC to select font since this refreshes the whole desktop, so I added a cached compatible DC. Note that this doesn't reproduce with WebKit alone, it only reproduces within Chrome, so we can't write a WebKit test for it. A chromium browser test will be added once this change gets rolled in the chromium DEPS file. * platform/graphics/chromium/UniscribeHelper.cpp: (WebCore::UniscribeHelper::shape): (WebCore::UniscribeHelper::EnsureCachedDCCreated): (WebCore::UniscribeHelper::fillShapes): * platform/graphics/chromium/UniscribeHelper.h: 2011-11-23 Anna Cavender Move readyState from TextTrack to HTMLTrackElement https://bugs.webkit.org/show_bug.cgi?id=72553 Reviewed by Eric Carlson. * html/HTMLTrackElement.cpp: (WebCore::HTMLTrackElement::HTMLTrackElement): Set initial readyState to NONE. (WebCore::HTMLTrackElement::didCompleteLoad): Set readyState based on load completed status. (WebCore::HTMLTrackElement::setReadyState): This replaces textTrackReadyStateChanged() because only LoadableTextTrack needs to notify HTMLTrackElement of readyState changes (i.e. textTrackReadyStateChanged() is no longer required of TextTrackClient). * html/HTMLTrackElement.h: ReadyState enum and m_readyState member variable moved from TextTrack. (WebCore::HTMLTrackElement::readyState): New: readyState() getter. * html/HTMLTrackElement.idl: Add readyState attribute and associated constants. * html/LoadableTextTrack.cpp: (WebCore::LoadableTextTrack::loadTimerFired): Set readyState on HTMLTrackElement. (WebCore::LoadableTextTrack::cueLoadingStarted): Ditto. (WebCore::LoadableTextTrack::cueLoadingCompleted): Move code to set readyState to HTMLTrackElement (it can set it based on loading status). * html/TextTrack.cpp: Remove readyState from TextTrack. (WebCore::TextTrack::TextTrack): Ditto. * html/TextTrack.h: Ditto. * html/TextTrack.idl: Ditto. 2011-11-23 Raphael Kubo da Costa [CMake] Move the top-level logic to the top-level directory. https://bugs.webkit.org/show_bug.cgi?id=72685 Reviewed by Brent Fulgham. No new tests, this is a buildsystem changes. * CMakeLists.txt: Adjust the Source/ directory. * PlatformBlackBerry.cmake: Ditto. 2011-11-23 Mihnea Ovidenie CSS Exclusions: update the name of the shape CSS properties https://bugs.webkit.org/show_bug.cgi?id=71898 Instead of a single wrap-shape property, we have wrap-shape-inside and wrap-shape-outside. Reviewed by Dean Jackson. Tests: fast/exclusions/parsing-wrap-shape-inside.html fast/exclusions/parsing-wrap-shape-outside.html * css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): * css/CSSParser.cpp: (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseWrapShape): * css/CSSParser.h: * css/CSSProperty.cpp: (WebCore::CSSProperty::isInheritedProperty): * css/CSSPropertyNames.in: * css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): * rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::diff): * rendering/style/RenderStyle.h: (WebCore::InheritedFlags::setWrapShapeInside): (WebCore::InheritedFlags::wrapShapeInside): (WebCore::InheritedFlags::setWrapShapeOutside): (WebCore::InheritedFlags::wrapShapeOutside): (WebCore::InheritedFlags::initialWrapShapeInside): (WebCore::InheritedFlags::initialWrapShapeOutside): * rendering/style/StyleRareNonInheritedData.cpp: (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData): (WebCore::StyleRareNonInheritedData::operator==): * rendering/style/StyleRareNonInheritedData.h: 2011-11-23 Andrey Kosyakov Web Inspector: [Extensions API] avoid exception in initExtensions() if elements panel is not present https://bugs.webkit.org/show_bug.cgi?id=73007 Reviewed by Yury Semikhatsky. * inspector/front-end/ExtensionServer.js: 2011-11-23 Brian Salomon Use new name for pixel config field of GrTextureDesc https://bugs.webkit.org/show_bug.cgi?id=72543 Reviewed by Stephen White. Tested by every canvas2d layout test. * platform/graphics/skia/ImageBufferSkia.cpp: (WebCore::createAcceleratedCanvas): 2011-11-23 Emil A Eklund Change remaining scrollTop/Left/Width/Height methods back to int https://bugs.webkit.org/show_bug.cgi?id=72771 Reviewed by Eric Seidel. Change remaining scrollTop/Left/Width/Height, setScrollLeft/Top and verticalScrollbarWidth, horizontalScrollbarHeight methods back to int as scrolling will remain int based to line up with device pixels. No new tests. * rendering/RenderBox.cpp: (WebCore::RenderBox::scrollWidth): (WebCore::RenderBox::scrollHeight): (WebCore::RenderBox::scrollLeft): (WebCore::RenderBox::scrollTop): (WebCore::RenderBox::setScrollLeft): (WebCore::RenderBox::setScrollTop): (WebCore::RenderBox::verticalScrollbarWidth): (WebCore::RenderBox::horizontalScrollbarHeight): * rendering/RenderBox.h: (WebCore::RenderBox::scrollbarLogicalHeight): * rendering/RenderListBox.cpp: (WebCore::RenderListBox::verticalScrollbarWidth): (WebCore::RenderListBox::scrollHeight): (WebCore::RenderListBox::scrollLeft): (WebCore::RenderListBox::setScrollLeft): (WebCore::RenderListBox::scrollTop): (WebCore::RenderListBox::setScrollTop): * rendering/RenderListBox.h: * rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::scrollWidth): (WebCore::RenderTextControlSingleLine::scrollHeight): (WebCore::RenderTextControlSingleLine::scrollLeft): (WebCore::RenderTextControlSingleLine::scrollTop): (WebCore::RenderTextControlSingleLine::setScrollLeft): (WebCore::RenderTextControlSingleLine::setScrollTop): * rendering/RenderTextControlSingleLine.h: 2011-11-22 Kenneth Russell [chromium] Support Core Animation plugins in compositor https://bugs.webkit.org/show_bug.cgi?id=72921 Reviewed by Stephen White. Added support to PluginLayerChromium and CCPluginLayerImpl for using an IOSurface as the backing store for a plugin. Added minimal ARB_texture_rectangle support to Extensions3D.h and a Chromium- specific extension for binding an IOSurface to a texture. These changes themselves do not have any effect. A follow-on Chromium CL will make the switch to this new code path. Tested manually both with and without the Chromium side changes; Chromium's DumpRenderTree port does not support Core Animation plugins. Ran video and Stage3D in Flash, and Unity 3D content, to verify. * platform/graphics/Extensions3D.h: * platform/graphics/chromium/Extensions3DChromium.h: * platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::initialize): (WebCore::LayerRendererChromium::pluginLayerTexRectProgram): (WebCore::LayerRendererChromium::pluginLayerTexRectProgramFlip): * platform/graphics/chromium/LayerRendererChromium.h: * platform/graphics/chromium/PluginLayerChromium.cpp: (WebCore::PluginLayerChromium::PluginLayerChromium): (WebCore::PluginLayerChromium::setIOSurfaceProperties): (WebCore::PluginLayerChromium::getIOSurfaceId): (WebCore::PluginLayerChromium::pushPropertiesTo): * platform/graphics/chromium/PluginLayerChromium.h: * platform/graphics/chromium/ShaderChromium.cpp: (WebCore::FragmentShaderRGBATexRectFlipAlpha::getShaderString): (WebCore::FragmentShaderRGBATexRectAlpha::getShaderString): * platform/graphics/chromium/ShaderChromium.h: * platform/graphics/chromium/cc/CCPluginLayerImpl.cpp: (PluginProgramBinding::TexStretchPluginProgramBinding::set): (PluginProgramBinding::TexTransformPluginProgramBinding::set): (WebCore::CCPluginLayerImpl::CCPluginLayerImpl): (WebCore::CCPluginLayerImpl::~CCPluginLayerImpl): (WebCore::CCPluginLayerImpl::draw): (WebCore::CCPluginLayerImpl::setIOSurfaceProperties): (WebCore::CCPluginLayerImpl::cleanupResources): * platform/graphics/chromium/cc/CCPluginLayerImpl.h: 2011-11-22 Daniel Cheng [chromium] Fix plumbing for differentiating between clipboard/selection pastes. https://bugs.webkit.org/show_bug.cgi?id=72056 Reviewed by Tony Chang. Add a buffer parameter when retrieving the clipboard sequence number and fix several call sites that incorrectly assume use of the standard buffer in pastes. * platform/chromium/ChromiumDataObject.cpp: (WebCore::ChromiumDataObject::types): (WebCore::ChromiumDataObject::getData): (WebCore::ChromiumDataObject::containsFilenames): * platform/chromium/ChromiumDataObject.h: * platform/chromium/ClipboardChromium.cpp: (WebCore::ClipboardChromium::ClipboardChromium): (WebCore::ClipboardChromium::getData): (WebCore::ClipboardChromium::platformClipboardChanged): * platform/chromium/ClipboardUtilitiesChromium.cpp: (WebCore::currentPasteboardBuffer): * platform/chromium/ClipboardUtilitiesChromium.h: * platform/chromium/DataTransferItemChromium.cpp: (WebCore::DataTransferItemChromium::getAsString): * platform/chromium/PlatformSupport.h: 2011-11-22 Andrey Kosyakov Layout Test inspector/extensions/extensions-events.html is timing out https://bugs.webkit.org/show_bug.cgi?id=72966 Reviewed by Pavel Feldman. - always bind to {add,remove}EventListener() of event target, not WebInspector.Object * inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer.prototype._registerAutosubscriptionHandler): 2011-11-22 Adam Klein Move splitView.css (added in r100991) to the correct target. * WebCore.gypi: 2011-11-22 Andreas Kling CSSProperty: Remove unnecessary operator overloads. Reviewed by Antti Koivisto. * css/CSSProperty.cpp: * css/CSSProperty.h: Remove operator= and operator== from CSSProperty. They were neither implemented correctly nor used anywhere. 2011-11-22 Andreas Kling CSSStyleDeclaration: Kill FIXME in setProperty(). Reviewed by Antonio Gomes. Remove FIXME about possibly throwing an exception when setProperty() is called with an invalid property name. CSSOM specifies that the method should simply return in this case. Spec: http://dev.w3.org/csswg/cssom/#dom-cssstyledeclaration-setproperty * css/CSSStyleDeclaration.cpp: (WebCore::CSSStyleDeclaration::setProperty): 2011-11-22 Shinya Kawanaka Spellcheck should be able to run asynchronously. https://bugs.webkit.org/show_bug.cgi?id=71991 Reviewed by Hajime Morita. Run asynchronous spell checker if both asynchronous flag and unified text checker flag are ON. When multiple asynchronous spellchecking are requested, only the first request will be processed. Test: editing/spelling/spellcheck-async.html * editing/Editor.cpp: (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): Uses asynchronous spell checker if asynchronous flag is ON. 2011-11-22 Alexander Pavlov Web Inspector: [SuggestBox] Grayed prompt displayed with non-collapsed selection in place https://bugs.webkit.org/show_bug.cgi?id=72951 Reviewed by Pavel Feldman. * inspector/front-end/TextPrompt.js: (WebInspector.TextPrompt.prototype.complete): 2011-11-22 Pavel Feldman Not reviewed: fix inspector front-end compilation. * inspector/front-end/externs.js: (WebInspector.showPanel): 2011-11-22 Adam Bergkvist Add WebCore platform interface needed by updated MediaStream API design https://bugs.webkit.org/show_bug.cgi?id=70895 Reviewed by Adam Barth. This is one in a series of patches that update the MediaStream feature to use WebCore platform interfaces. Tests will be provided by http://webkit.org/b/56587 * GNUmakefile.list.am: * WebCore.gypi: * mediastream/LocalMediaStream.cpp: (WebCore::LocalMediaStream::stopTimerFired): * mediastream/MediaStream.h: * mediastream/MediaStreamTrack.cpp: (WebCore::MediaStreamTrack::setEnabled): * mediastream/PeerConnection.cpp: (WebCore::PeerConnection::didRemoveRemoteStream): * mediastream/UserMediaRequest.cpp: (WebCore::UserMediaRequest::start): * mediastream/UserMediaRequest.h: * platform/mediastream/MediaStreamCenter.cpp: Added. (WebCore::MediaStreamCenter::instance): (WebCore::MediaStreamCenter::endLocalMediaStream): (WebCore::MediaStreamCenter::MediaStreamCenter): (WebCore::MediaStreamCenter::~MediaStreamCenter): (WebCore::MediaStreamCenter::queryMediaStreamSources): (WebCore::MediaStreamCenter::didSetMediaStreamTrackEnabled): (WebCore::MediaStreamCenter::didStopLocalMediaStream): * platform/mediastream/MediaStreamCenter.h: Added. (WebCore::MediaStreamSourcesQueryClient::~MediaStreamSourcesQueryClient): * platform/mediastream/MediaStreamDescriptor.h: (WebCore::MediaStreamDescriptorOwner::~MediaStreamDescriptorOwner): (WebCore::MediaStreamDescriptor::owner): (WebCore::MediaStreamDescriptor::setOwner): 2011-11-22 Pavel Feldman Web Inspector: remove Inspector::bringToFront from the protocol. https://bugs.webkit.org/show_bug.cgi?id=72937 Inspector::bringToFront protocol method is currently used on the backend in order to reveal the front-end window. We should do that by means of the inspector client interface instead. Reviewed by Yury Semikhatsky. * inspector/Inspector.json: * inspector/InspectorClient.h: * inspector/InspectorController.cpp: (WebCore::InspectorController::show): * loader/EmptyClients.h: (WebCore::EmptyInspectorClient::bringFrontendToFront): 2011-11-21 Andrey Kosyakov Web Inspector: [Extensions API][refactoring] remove dependencies on the ExtensionsServer from most of the insepctor https://bugs.webkit.org/show_bug.cgi?id=72899 Reviewed by Pavel Feldman. * inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype._selectedNodeChanged): * inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer.prototype._notifyResourceContentCommitted): (WebInspector.ExtensionServer.prototype._notifyElementsSelectionChanged): * inspector/front-end/Resource.js: (WebInspector.Resource.prototype.addRevision): * inspector/front-end/externs.js: 2011-11-22 Zoltan Horvath [Qt] Build fix for MHTML support * Target.pri: Add missing includepath. 2011-11-22 Vsevolod Vlasov Web Inspector: Extract SplitView from Panel.createSidebar() method and reuse in Elements and Scripts panels. https://bugs.webkit.org/show_bug.cgi?id=72920 Reviewed by Pavel Feldman. * WebCore.gypi: * WebCore.vcproj/WebCore.vcproj: * inspector/compile-front-end.sh: * inspector/front-end/ApplicationCacheModel.js: * inspector/front-end/AuditsPanel.js: (WebInspector.AuditsPanel): * inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel): (WebInspector.ElementsPanel.prototype.wasShown): (WebInspector.ElementsPanel.prototype.sidebarResized): (WebInspector.ElementsPanel.prototype.toggleSearchingForNode): * inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel.prototype.wasShown): (WebInspector.NetworkPanel.prototype._showResource): (WebInspector.NetworkPanel.prototype._closeVisibleResource): (WebInspector.NetworkPanel.prototype._toggleGridMode): (WebInspector.NetworkPanel.prototype._toggleViewingResourceMode): * inspector/front-end/Panel.js: (WebInspector.Panel.prototype.wasShown): (WebInspector.Panel.prototype.createSplitView): (WebInspector.Panel.prototype.createSplitViewWithSidebarTree): (WebInspector.Panel.prototype.sidebarResized): * inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel.prototype._reset): (WebInspector.ProfilesPanel.prototype.sidebarResized): * inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.sidebarResized): * inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.wasShown): (WebInspector.ScriptsPanel.prototype.sidebarResized): * inspector/front-end/SplitView.js: Added. (WebInspector.SplitView): * inspector/front-end/TimelineOverviewPane.js: (WebInspector.TimelineOverviewPane.prototype.sidebarResized): * inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel): (WebInspector.TimelinePanel.prototype.sidebarResized): (WebInspector.TimelinePanel.prototype._refreshRecords): * inspector/front-end/WebKit.qrc: * inspector/front-end/auditsPanel.css: * inspector/front-end/elementsPanel.css: * inspector/front-end/inspector.css: (.sidebar): * inspector/front-end/inspector.html: * inspector/front-end/networkLogView.css: * inspector/front-end/networkPanel.css: (#network-views): * inspector/front-end/profilesPanel.css: (#profile-views): * inspector/front-end/resourcesPanel.css: * inspector/front-end/scriptsPanel.css: (#scripts-split-view): * inspector/front-end/splitView.css: Added. * inspector/front-end/timelinePanel.css: (.timeline .sidebar): (.timeline-sidebar-background): (#resources-container-content): 2011-11-22 Sheriff Bot Unreviewed, rolling out r100988. http://trac.webkit.org/changeset/100988 https://bugs.webkit.org/show_bug.cgi?id=72941 "Broke pixel tests on Chromium-Linux" (Requested by kbalazs on #webkit). * platform/graphics/filters/FEConvolveMatrix.cpp: (WebCore::FEConvolveMatrix::platformApplySoftware): * platform/graphics/filters/FEConvolveMatrix.h: * platform/graphics/filters/FEGaussianBlur.cpp: (WebCore::FEGaussianBlur::platformApply): * platform/graphics/filters/FEGaussianBlur.h: * platform/graphics/filters/FELighting.cpp: (WebCore::FELighting::platformApplyGeneric): * platform/graphics/filters/FELighting.h: * platform/graphics/filters/FEMorphology.cpp: (WebCore::FEMorphology::platformApply): * platform/graphics/filters/FEMorphology.h: * platform/graphics/filters/FETurbulence.cpp: (WebCore::FETurbulence::platformApplySoftware): * platform/graphics/filters/FETurbulence.h: * platform/graphics/filters/arm/FELightingNEON.cpp: * platform/graphics/filters/arm/FELightingNEON.h: (WebCore::FELighting::platformApplyNeon): 2011-11-21 Balazs Kelemen Enable ParallelJobs by default https://bugs.webkit.org/show_bug.cgi?id=70032 Reviewed by Zoltan Herczeg. Covered by existing tests. According to measurements on Mac and Linux it is a considerable speedup for SVG on multicore. Remove the ENABLE(PARALLEL_JOBS) guard. Fix the Windows build by qualifying ParallelJobs with the WTF namespace (otherwise MSVC believes it belongs to WebCore which is likely a compiler bug). * platform/graphics/filters/FEConvolveMatrix.cpp: (WebCore::FEConvolveMatrix::setInteriorPixelsWorker): (WebCore::FEConvolveMatrix::platformApplySoftware): * platform/graphics/filters/FEConvolveMatrix.h: * platform/graphics/filters/FEGaussianBlur.cpp: (WebCore::FEGaussianBlur::platformApplyWorker): (WebCore::FEGaussianBlur::platformApply): * platform/graphics/filters/FEGaussianBlur.h: * platform/graphics/filters/FELighting.cpp: (WebCore::FELighting::platformApplyGenericWorker): (WebCore::FELighting::platformApplyGeneric): * platform/graphics/filters/FELighting.h: * platform/graphics/filters/FEMorphology.cpp: (WebCore::FEMorphology::platformApplyWorker): (WebCore::FEMorphology::platformApply): * platform/graphics/filters/FEMorphology.h: * platform/graphics/filters/FETurbulence.cpp: (WebCore::FETurbulence::fillRegionWorker): (WebCore::FETurbulence::platformApplySoftware): * platform/graphics/filters/FETurbulence.h: * platform/graphics/filters/arm/FELightingNEON.cpp: (WebCore::FELighting::platformApplyNeonWorker): * platform/graphics/filters/arm/FELightingNEON.h: (WebCore::FELighting::platformApplyNeon): 2011-11-22 Alexander Pavlov Web Inspector: [protocol] actual JSON messages do not conform to Inspector.json in CSS https://bugs.webkit.org/show_bug.cgi?id=72733 Reviewed by Pavel Feldman. * inspector/Inspector.json: * inspector/InspectorCSSAgent.cpp: (WebCore::InspectorCSSAgent::getComputedStyleForNode): * inspector/InspectorCSSAgent.h: * inspector/InspectorStyleSheet.cpp: (WebCore::InspectorStyle::buildArrayForComputedStyle): * inspector/InspectorStyleSheet.h: * inspector/front-end/CSSStyleModel.js: (WebInspector.CSSStyleModel.prototype.getComputedStyleAsync): (WebInspector.CSSStyleDeclaration.parseComputedStylePayload): 2011-11-22 Pavel Feldman Web Inspector: strip unused InspectorController methods. https://bugs.webkit.org/show_bug.cgi?id=72886 This is a follow up to the https://bugs.webkit.org/show_bug.cgi?id=63009. I am now able to remove following InspectorController methods: ::startUserInitiatedProfiling, ::isRecordingUserInitiatedProfile, ::stopUserInitiatedProfiling, ::showAndEnableDebugger, ::debuggerEnabled, ::disableDebugger, ::startTimelineProfiler, ::stopTimelineProfiler, ::timelineProfilerEnabled, ::showConsole. Reviewed by Yury Semikhatsky. * WebCore.exp.in: * WebCore.order: * inspector/Inspector.json: * inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::setFrontend): * inspector/InspectorAgent.h: * inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::connectFrontend): * inspector/InspectorController.h: * inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::enable): (WebCore::InspectorDebuggerAgent::disable): * inspector/InspectorDebuggerAgent.h: * inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::didCommitLoadImpl): * inspector/InspectorProfilerAgent.cpp: (WebCore::InspectorProfilerAgent::resetState): (WebCore::InspectorProfilerAgent::clearFrontend): (WebCore::InspectorProfilerAgent::restore): (WebCore::InspectorProfilerAgent::start): (WebCore::InspectorProfilerAgent::stop): * inspector/InspectorProfilerAgent.h: * inspector/InspectorTimelineAgent.cpp: (WebCore::InspectorTimelineAgent::start): (WebCore::InspectorTimelineAgent::stop): * inspector/InspectorTimelineAgent.h: * inspector/front-end/DebuggerModel.js: (WebInspector.DebuggerModel.prototype.enableDebugger): (WebInspector.DebuggerModel.prototype.disableDebugger): * inspector/front-end/TimelineManager.js: (WebInspector.TimelineManager.prototype.start): (WebInspector.TimelineManager.prototype.stop): (WebInspector.TimelineManager.prototype._started): (WebInspector.TimelineManager.prototype._stopped): * inspector/front-end/inspector.js: 2011-11-17 Nat Duca [chromium] Route willDraw/setNeedsRedraw to CCInputHandler and fix double-drawing issues that result https://bugs.webkit.org/show_bug.cgi?id=72688 This allows CCInputFilter and CCLayerTreeHostImpl to perform requestAnimationFrame-style animations. The bulk of work here is to make the scheduler recover gracefully when you call setNeedsRedraw inside scheduledActionDraw. Reviewed by James Robinson. * WebCore.gypi: * platform/graphics/chromium/cc/CCInputHandler.h: (WebCore::CCInputHandlerTarget::CCInputHandlerTarget): (WebCore::CCInputHandlerTarget::~CCInputHandlerTarget): * platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp: (WebCore::CCLayerTreeHostImpl::currentTimeMs): (WebCore::CCLayerTreeHostImpl::setNeedsRedraw): * platform/graphics/chromium/cc/CCLayerTreeHostImpl.h: * platform/graphics/chromium/cc/CCScheduler.cpp: (WebCore::CCScheduler::CCScheduler): (WebCore::CCScheduler::setVisible): (WebCore::CCScheduler::setNeedsRedraw): (WebCore::CCScheduler::beginFrame): (WebCore::CCScheduler::processScheduledActions): * platform/graphics/chromium/cc/CCScheduler.h: * platform/graphics/chromium/cc/CCSchedulerStateMachine.cpp: (WebCore::CCSchedulerStateMachine::CCSchedulerStateMachine): (WebCore::CCSchedulerStateMachine::nextAction): (WebCore::CCSchedulerStateMachine::updateState): (WebCore::CCSchedulerStateMachine::setInsideVSync): (WebCore::CCSchedulerStateMachine::setOutsideVSync): * platform/graphics/chromium/cc/CCSchedulerStateMachine.h: * platform/graphics/chromium/cc/CCScrollController.h: Removed. * platform/graphics/chromium/cc/CCSingleThreadProxy.cpp: * platform/graphics/chromium/cc/CCThreadProxy.cpp: (WebCore::CCThreadProxy::scheduledActionDrawAndSwap): 2011-11-22 Alexander Pavlov Web Inspector: Design of the autocomplete suggest https://bugs.webkit.org/show_bug.cgi?id=72798 Reviewed by Pavel Feldman. Implemented a combination of grayed text for the first/only completion and hid the suggest box for a single suggestion (the grayed text is displayed instead.) Drive-by fix for the "trailing spaces in the prompt" issue (got regressed when the suggest box was introduced for the first time.) * inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView): Fix the "trailing spaces" issue * inspector/front-end/TextPrompt.js: (WebInspector.TextPrompt): (WebInspector.TextPrompt.prototype.renderAsBlock): Fix the "trailing spaces" issue (WebInspector.TextPrompt.prototype._attachInternal): (WebInspector.TextPrompt.prototype.acceptAutoComplete): (WebInspector.TextPrompt.prototype._completionsReady): (WebInspector.TextPrompt.prototype.applySuggestion): (WebInspector.TextPrompt.prototype.acceptSuggestion): (WebInspector.TextPrompt.SuggestBox.prototype._completionsReady): 2011-11-21 David Barr REGRESSION(r98542): Chromium: CSS text is rendered on page https://bugs.webkit.org/show_bug.cgi?id=71703 Reviewed by Dimitri Glazkov. Matched UA declarations uncacheable when using simpleDefaultStyleSheet. Test: fast/css/style-tag-display-none.html * css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::matchUARules): 2011-11-21 Rob Brackett If an event listener is a function, it should be called and not checked for handleEvent. This also covers callbacks, which follow the same spec but are implemented separately. https://bugs.webkit.org/show_bug.cgi?id=62518 Reviewed by Sam Weinig. Tests: fast/events/dispatch-to-function-with-handle-event.html fast/js/callback-function-with-handle-event.html * bindings/js/JSCallbackData.cpp: (WebCore::JSCallbackData::invokeCallback): * bindings/js/JSEventListener.cpp: (WebCore::JSEventListener::handleEvent): 2011-11-21 Rakesh KN Need support for dirname attribute https://bugs.webkit.org/show_bug.cgi?id=65542 Reviewed by Eric Seidel. Implemented 'dirname' form attribute. Tests: fast/forms/form-dirname-attribute.html fast/forms/submit-form-with-dirname-attribute-with-ancestor-dir-attribute.html fast/forms/submit-form-with-dirname-attribute-with-nonhtml-ancestor.html fast/forms/submit-form-with-dirname-attribute.html * html/HTMLAttributeNames.in: Added "dirname" attribute. * html/HTMLInputElement.idl: Add "dirName" property to HTMLInputElement interface. * html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::appendFormData): Append dirname form data. * html/HTMLTextAreaElement.idl: Add "dirName" property to HTMLTextAreaElement interface. * html/HTMLTextFormControlElement.cpp: (WebCore::parentHTMLElement): Helper function which returns only HTML parent element. (WebCore::HTMLTextFormControlElement::directionForFormData): Helper function for finding directionality of the Element. * html/HTMLTextFormControlElement.h: Helper function for finding directionality of the Element. * html/TextFieldInputType.cpp: (WebCore::TextFieldInputType::appendFormData): Append dirname form data. * html/TextFieldInputType.h: Append dirname form data. 2011-11-21 Joshua Bell IndexedDB: Close database connections, abort transactions, and terminate requests on stop() https://bugs.webkit.org/show_bug.cgi?id=72066 Reviewed by Tony Chang. No new tests; addresses race conditions on document navigate/script context stop. * dom/DocumentEventQueue.cpp: (WebCore::DocumentEventQueue::enqueueEvent): * dom/DocumentEventQueue.h: * dom/EventQueue.h: * storage/IDBDatabase.cpp: (WebCore::IDBDatabase::IDBDatabase): (WebCore::IDBDatabase::~IDBDatabase): (WebCore::IDBDatabase::transaction): (WebCore::IDBDatabase::close): (WebCore::IDBDatabase::onVersionChange): (WebCore::IDBDatabase::enqueueEvent): (WebCore::IDBDatabase::stop): * storage/IDBDatabase.h: * storage/IDBFactory.cpp: (WebCore::IDBFactory::IDBFactory): (WebCore::IDBFactory::getDatabaseNames): (WebCore::IDBFactory::open): (WebCore::IDBFactory::deleteDatabase): * storage/IDBFactory.h: * storage/IDBObjectStore.cpp: (WebCore::IDBObjectStore::IDBObjectStore): (WebCore::IDBObjectStore::name): (WebCore::IDBObjectStore::keyPath): (WebCore::IDBObjectStore::indexNames): (WebCore::IDBObjectStore::get): (WebCore::IDBObjectStore::add): (WebCore::IDBObjectStore::put): (WebCore::IDBObjectStore::deleteFunction): (WebCore::IDBObjectStore::clear): (WebCore::IDBObjectStore::createIndex): (WebCore::IDBObjectStore::index): (WebCore::IDBObjectStore::deleteIndex): (WebCore::IDBObjectStore::openCursor): * storage/IDBObjectStore.h: * storage/IDBRequest.cpp: (WebCore::IDBRequest::IDBRequest): (WebCore::IDBRequest::abort): (WebCore::IDBRequest::onSuccess): (WebCore::IDBRequest::onSuccessWithContinuation): (WebCore::IDBRequest::stop): (WebCore::IDBRequest::dispatchEvent): (WebCore::IDBRequest::enqueueEvent): * storage/IDBRequest.h: * storage/IDBTransaction.cpp: (WebCore::IDBTransaction::IDBTransaction): (WebCore::IDBTransaction::abort): (WebCore::IDBTransaction::onAbort): (WebCore::IDBTransaction::onComplete): (WebCore::IDBTransaction::dispatchEvent): (WebCore::IDBTransaction::stop): (WebCore::IDBTransaction::enqueueEvent): * storage/IDBTransaction.h: * storage/IDBTransactionBackendImpl.cpp: (WebCore::IDBTransactionBackendImpl::abort): (WebCore::IDBTransactionBackendImpl::commit): * workers/WorkerEventQueue.cpp: (WebCore::WorkerEventQueue::enqueueEvent): * workers/WorkerEventQueue.h: 2011-11-21 James Robinson [chromium] Avoid pushing dirty tiles to the impl layer https://bugs.webkit.org/show_bug.cgi?id=72765 Reviewed by Kenneth Russell. If a tile has invalidations at pushPropertiesTo, then we know the contents of that tile are no longer valid even if they still have valid backing textures. This avoids pushing that texture to the impl side so it is not displayed to the user. The texture is still kept around (managed by the TextureManager) so that when we later do decide to update the contents for that tile we can use partial results if they are still valid. Covered by new unit test in TiledLayerChromiumTest.cpp * platform/graphics/chromium/TiledLayerChromium.cpp: (WebCore::UpdatableTile::isDirty): (WebCore::TiledLayerChromium::updateTileSizeAndTilingOption): (WebCore::TiledLayerChromium::setTileSize): (WebCore::TiledLayerChromium::setLayerTreeHost): (WebCore::TiledLayerChromium::createTiler): (WebCore::TiledLayerChromium::updateCompositorResources): (WebCore::TiledLayerChromium::pushPropertiesTo): * platform/graphics/chromium/TiledLayerChromium.h: (WebCore::TiledLayerChromium::setTextureFormat): * platform/graphics/chromium/cc/CCTiledLayerImpl.cpp: (WebCore::CCTiledLayerImpl::hasTileAt): (WebCore::CCTiledLayerImpl::drawTiles): * platform/graphics/chromium/cc/CCTiledLayerImpl.h: 2011-11-21 Simon Hausmann [Qt] Speed up debug builds. https://bugs.webkit.org/show_bug.cgi?id=72882 Reviewed by Tor Arne Vestbø. * Target.pri: Make BUILDING_WebCore available earlier, so it can be used by the build system. 2011-11-17 Robert Hogan CSS 2.1 failure: empty-inline-003.htm fails https://bugs.webkit.org/show_bug.cgi?id=72638 Reviewed by Ryosuke Niwa. Empty inline elements need to share their inline height with siblings. * rendering/RenderBlockLineLayout.cpp: (WebCore::inlineFlowRequiresLineBox): In strict mode, add a LineBox for an empty element if it is going to affect the line-height. (WebCore::requiresLineBox): Pass LineInfo to inlineFlowRequiresLineBox (WebCore::RenderBlock::LineBreaker::nextLineBreak): Pass LineInfo to inlineFlowRequiresLineBox 2011-11-21 Adrienne Walker [chromium] Remove incorrect render surface layer list asserts from compositor https://bugs.webkit.org/show_bug.cgi?id=72744 Reviewed by James Robinson. These asserts are incorrect, because it's valid for the default render surface to be created but to have a root layer that doesn't draw. It won't get added to the single render surface and it'll have an empty layer list. Test: compositor_unittests * platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::drawLayersOntoRenderSurfaces): * platform/graphics/chromium/cc/CCLayerTreeHost.cpp: (WebCore::CCLayerTreeHost::paintLayerContents): (WebCore::CCLayerTreeHost::updateCompositorResources): 2011-11-21 Andreas Kling StyleSheet: Move completeURL() to CSSStyleSheet. Reviewed by Antti Koivisto. Since completeURL() is only used on CSSStyleSheets, move it there (and make it non-virtual) to make StyleSheet a little leaner. * css/CSSStyleSheet.cpp: (WebCore::CSSStyleSheet::completeURL): * css/CSSStyleSheet.h: * css/StyleSheet.cpp: * css/StyleSheet.h: 2011-11-21 Robin Dunn [wx] Fix image translation calculations. https://bugs.webkit.org/show_bug.cgi?id=72892 Reviewed by Kevin Ollivier. * platform/graphics/wx/ImageWx.cpp: (WebCore::Image::drawPattern): 2011-11-21 Scott Graham copyright comment style to C from C++ for gamepad module https://bugs.webkit.org/show_bug.cgi?id=72894 Reviewed by Sam Weinig. Just changes comment format, no code/test changes. * Modules/gamepad/Gamepad.cpp: * Modules/gamepad/Gamepad.h: * Modules/gamepad/Gamepad.idl: * Modules/gamepad/GamepadList.cpp: * Modules/gamepad/GamepadList.h: * Modules/gamepad/GamepadList.idl: 2011-11-21 Andreas Kling JSC/CSSOM: Merge root() for style declaration objects. Reviewed by Antti Koivisto. Fold root(CSSMutableStyleDeclaration*) into root(CSSStyleDeclaration*), removing a duplicated chunk and making it a little easier on the eyes. * bindings/js/JSDOMBinding.h: (WebCore::root): 2011-11-21 Igor Oliveira [WK2][Qt] Move Accelerated Composite animations to UIProcess https://bugs.webkit.org/show_bug.cgi?id=72753 Add helper method to synchronize animations in TextureMapper. Reviewed by Noam Rosenthal. * platform/graphics/texmap/TextureMapperNode.cpp: (WebCore::TextureMapperNode::syncAnimationsRecursively): * platform/graphics/texmap/TextureMapperNode.h: 2011-11-21 Sheriff Bot Unreviewed, rolling out r100913. http://trac.webkit.org/changeset/100913 https://bugs.webkit.org/show_bug.cgi?id=72885 "Break Windows build" (Requested by kbalazs on #webkit). * platform/graphics/filters/FEConvolveMatrix.cpp: (WebCore::FEConvolveMatrix::platformApplySoftware): * platform/graphics/filters/FEConvolveMatrix.h: * platform/graphics/filters/FEGaussianBlur.cpp: (WebCore::FEGaussianBlur::platformApply): * platform/graphics/filters/FEGaussianBlur.h: * platform/graphics/filters/FELighting.cpp: (WebCore::FELighting::platformApplyGeneric): * platform/graphics/filters/FELighting.h: * platform/graphics/filters/FEMorphology.cpp: (WebCore::FEMorphology::platformApply): * platform/graphics/filters/FEMorphology.h: * platform/graphics/filters/FETurbulence.cpp: (WebCore::FETurbulence::platformApplySoftware): * platform/graphics/filters/FETurbulence.h: * platform/graphics/filters/arm/FELightingNEON.cpp: * platform/graphics/filters/arm/FELightingNEON.h: (WebCore::FELighting::platformApplyNeon): 2011-11-21 Balazs Kelemen Enable ParallelJobs by default https://bugs.webkit.org/show_bug.cgi?id=70032 Reviewed by Zoltan Herczeg. Covered by existing tests. According to measurements on Mac and Linux it is a considerable speedup for SVG on multicore. Remove the ENABLE(PARALLEL_JOBS) guard. Fix the Windows build by qualifying ParallelJobs with the WTF namespace (otherwise MSVC believes it belongs to WebCore which is likely a compiler bug). * platform/graphics/filters/FEConvolveMatrix.cpp: (WebCore::FEConvolveMatrix::setInteriorPixelsWorker): (WebCore::FEConvolveMatrix::platformApplySoftware): * platform/graphics/filters/FEConvolveMatrix.h: * platform/graphics/filters/FEGaussianBlur.cpp: (WebCore::FEGaussianBlur::platformApplyWorker): (WebCore::FEGaussianBlur::platformApply): * platform/graphics/filters/FEGaussianBlur.h: * platform/graphics/filters/FELighting.cpp: (WebCore::FELighting::platformApplyGenericWorker): (WebCore::FELighting::platformApplyGeneric): * platform/graphics/filters/FELighting.h: * platform/graphics/filters/FEMorphology.cpp: (WebCore::FEMorphology::platformApplyWorker): (WebCore::FEMorphology::platformApply): * platform/graphics/filters/FEMorphology.h: * platform/graphics/filters/FETurbulence.cpp: (WebCore::FETurbulence::fillRegionWorker): (WebCore::FETurbulence::platformApplySoftware): * platform/graphics/filters/FETurbulence.h: * platform/graphics/filters/arm/FELightingNEON.cpp: (WebCore::FELighting::platformApplyNeonWorker): * platform/graphics/filters/arm/FELightingNEON.h: (WebCore::FELighting::platformApplyNeon): 2011-11-21 Antti Koivisto Remove CSSStyleSelector::m_additionalAttributeStyleDecls field https://bugs.webkit.org/show_bug.cgi?id=72876 Reviewed by Andreas Kling. There is no reason for this temporary to be a field. * css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::matchAllRules): * css/CSSStyleSelector.h: 2011-11-21 Pavel Feldman Web Inspector: [REGRESSION] Assertion failed in ScriptsPanel.js https://bugs.webkit.org/show_bug.cgi?id=72877 Reviewed by Yury Semikhatsky. * inspector/front-end/ScriptsPanel.js: 2011-11-18 Pavel Feldman Web Inspector: get rid of Panel::reset in the front-end. https://bugs.webkit.org/show_bug.cgi?id=72587 I'm slowly getting rid of the Inspector protocol domain. It currently contains methods that did not find their home in the meaningful domains. This change removes reset protocol method. Reviewed by Yury Semikhatsky. * inspector/Inspector.json: * inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::didCommitLoad): * inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::didClearMainFrameWindowObject): * inspector/InspectorDebuggerAgent.h: * inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::didClearWindowObjectInWorldImpl): (WebCore::InspectorInstrumentation::didCommitLoadImpl): * inspector/front-end/ApplicationCacheModel.js: (WebInspector.ApplicationCacheModel.prototype._frameNavigated): (WebInspector.ApplicationCacheModel.prototype._frameDetached): * inspector/front-end/DebuggerModel.js: (WebInspector.DebuggerModel.prototype._globalObjectCleared): (WebInspector.DebuggerDispatcher.prototype.globalObjectCleared): * inspector/front-end/DebuggerPresentationModel.js: (WebInspector.DebuggerPresentationModel): (WebInspector.DebuggerPresentationModel.prototype._debuggerReset): * inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer): (WebInspector.ExtensionServer.prototype._mainFrameNavigated): * inspector/front-end/JavaScriptContextManager.js: (WebInspector.JavaScriptContextManager.prototype._frameDetached): (WebInspector.FrameEvaluationContext.prototype.get frameId): * inspector/front-end/NetworkLog.js: (WebInspector.NetworkLog): (WebInspector.NetworkLog.prototype._mainFrameNavigated): * inspector/front-end/NetworkPanel.js: (WebInspector.NetworkLogView): (WebInspector.NetworkLogView.prototype._mainFrameNavigated): * inspector/front-end/ResourceTreeModel.js: (WebInspector.ResourceTreeModel.prototype._frameNavigated): (WebInspector.ResourceTreeModel.prototype._frameDetached): (WebInspector.ResourceTreeModel.prototype._clearChildFramesAndResources): * inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype._reset): (WebInspector.ResourcesPanel.prototype._frameDetached): * inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._debuggerWasDisabled): (WebInspector.ScriptsPanel.prototype._reset): * inspector/front-end/WorkerManager.js: (WebInspector.WorkerManager): (WebInspector.WorkerManager.prototype._mainFrameNavigated): * inspector/front-end/inspector.js: 2011-06-20 Pavel Feldman Web Inspector: introduce InspectorFrontendAPI for actions initiated from the application menu. https://bugs.webkit.org/show_bug.cgi?id=62985 Both: inspector protocol and WebCore/InspectorController have a number of unnecessary methods for plumbing the menu action handlers through the WebKit and WebCore. I intend to remove this menu support from the protocol and WebCore/InspectorController API. I am starting with exposing the new front-end API in the WebCore and using it in the WebKit/mac port. WebKit/win and WebKit2 to follow. Reviewed by Yury Semikhatsky. * WebCore.exp.in: * WebCore.gypi: * WebCore.vcproj/WebCore.vcproj: * inspector/InspectorFrontendClientLocal.cpp: (WebCore::InspectorFrontendClientLocal::InspectorFrontendClientLocal): (WebCore::InspectorFrontendClientLocal::frontendLoaded): (WebCore::InspectorFrontendClientLocal::setAttachedWindow): (WebCore::InspectorFrontendClientLocal::isDebuggingEnabled): (WebCore::InspectorFrontendClientLocal::setDebuggingEnabled): (WebCore::InspectorFrontendClientLocal::isJavaScriptProfilingEnabled): (WebCore::InspectorFrontendClientLocal::setJavaScriptProfilingEnabled): (WebCore::InspectorFrontendClientLocal::isTimelineProfilingEnabled): (WebCore::InspectorFrontendClientLocal::setTimelineProfilingEnabled): (WebCore::InspectorFrontendClientLocal::isProfilingJavaScript): (WebCore::InspectorFrontendClientLocal::startProfilingJavaScript): (WebCore::InspectorFrontendClientLocal::stopProfilingJavaScript): (WebCore::InspectorFrontendClientLocal::evaluateAsBoolean): (WebCore::InspectorFrontendClientLocal::evaluateOnLoad): * inspector/InspectorFrontendClientLocal.h: * inspector/front-end/InspectorFrontendAPI.js: Added. (InspectorFrontendAPI.isDebuggingEnabled): (InspectorFrontendAPI.setDebuggingEnabled): (InspectorFrontendAPI.isJavaScriptProfilingEnabled): (InspectorFrontendAPI.setJavaScriptProfilingEnabled): (InspectorFrontendAPI.isTimelineProfilingEnabled): (InspectorFrontendAPI.setTimelineProfilingEnabled): (InspectorFrontendAPI.isProfilingJavaScript): (InspectorFrontendAPI.startProfilingJavaScript): (InspectorFrontendAPI.stopProfilingJavaScript): (InspectorFrontendAPI.setAttachedWindow): * inspector/front-end/ProfileView.js: (WebInspector.CPUProfileType): (WebInspector.CPUProfileType.prototype.isRecordingProfile): (WebInspector.CPUProfileType.prototype.startRecordingProfile): (WebInspector.CPUProfileType.prototype.stopRecordingProfile): * inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel.prototype.get profilerEnabled): (WebInspector.ProfilesPanel.prototype.enableProfiler): (WebInspector.ProfilesPanel.prototype.disableProfiler): * inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype.get debuggingEnabled): (WebInspector.ScriptsPanel.prototype.enableDebugging): (WebInspector.ScriptsPanel.prototype.disableDebugging): (WebInspector.ScriptsPanel.prototype.toggleDebugging): * inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.prototype._memoryOverviewItemSelected): (WebInspector.TimelinePanel.prototype.setTimelineProfilingEnabled): (WebInspector.TimelinePanel.prototype.get timelineProfilingEnabled): * inspector/front-end/WebKit.qrc: * inspector/front-end/inspector.html: * inspector/front-end/inspector.js: 2011-11-18 Alexander Pavlov Web Inspector: [Protocol] Retain a single universal method for loading a required combination of element styles https://bugs.webkit.org/show_bug.cgi?id=72701 Reviewed by Pavel Feldman. * inspector/Inspector.json: * inspector/InspectorCSSAgent.cpp: (WebCore::InspectorCSSAgent::getMatchedStylesForNode): (WebCore::InspectorCSSAgent::getInlineStylesForNode): (WebCore::InspectorCSSAgent::getComputedStyleForNode): * inspector/InspectorCSSAgent.h: * inspector/front-end/AuditRules.js: (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun): (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun.getStyles.inlineCallback): (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun.getStyles.matchedCallback): (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun.getStyles): * inspector/front-end/CSSStyleModel.js: (WebInspector.CSSStyleModel.prototype.getMatchedStylesAsync): (WebInspector.CSSStyleModel.prototype.getComputedStyleAsync): (WebInspector.CSSStyleModel.prototype.getInlineStylesAsync): * inspector/front-end/MetricsSidebarPane.js: (WebInspector.MetricsSidebarPane.prototype._innerUpdate): * inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype.get forcedPseudoClasses): (WebInspector.StylesSidebarPane.prototype._executeRebuildUpdate): (WebInspector.StylesSidebarPane.prototype._executeRebuildUpdate.inlineCallback): (WebInspector.StylesSidebarPane.prototype._executeRebuildUpdate.computedCallback): (WebInspector.StylesSidebarPane.prototype._innerUpdate): 2011-11-21 Sheriff Bot Unreviewed, rolling out r100856. http://trac.webkit.org/changeset/100856 https://bugs.webkit.org/show_bug.cgi?id=72867 New test fast/css/style-tag-display-none.html fails on Chromium (Requested by steveblock on #webkit). * css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::matchUARules): 2011-11-21 Jochen Eisinger Implement Meta referrer https://bugs.webkit.org/show_bug.cgi?id=72674 Reviewed by Adam Barth. http://wiki.whatwg.org/wiki/Meta_referrer Tests: http/tests/security/referrer-policy-always.html http/tests/security/referrer-policy-default.html http/tests/security/referrer-policy-https-always.html http/tests/security/referrer-policy-https-default.html http/tests/security/referrer-policy-https-never.html http/tests/security/referrer-policy-https-origin.html http/tests/security/referrer-policy-never.html http/tests/security/referrer-policy-origin.html http/tests/security/referrer-policy-redirect.html http/tests/security/referrer-policy-rel-noreferrer.html * WebCore.exp.in: updated * dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::processReferrerPolicy): * dom/Document.h: (WebCore::Document::referrerPolicy): * html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::handleClick): * html/HTMLMetaElement.cpp: (WebCore::HTMLMetaElement::process): * loader/FrameLoader.cpp: (WebCore::FrameLoader::loadFrameRequest): (WebCore::FrameLoader::loadResourceSynchronously): * loader/PingLoader.cpp: (WebCore::PingLoader::loadImage): (WebCore::PingLoader::sendPing): (WebCore::PingLoader::reportContentSecurityPolicyViolation): * loader/SubframeLoader.cpp: (WebCore::SubframeLoader::loadSubframe): * loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::create): * page/SecurityPolicy.cpp: (WebCore::SecurityPolicy::generateReferrerHeader): * page/SecurityPolicy.h: 2011-11-21 Vsevolod Vlasov Web Inspector: ApplicationCache view should show navigator.onLine indicator. https://bugs.webkit.org/show_bug.cgi?id=72618 Reviewed by Pavel Feldman. * inspector/InspectorApplicationCacheAgent.cpp: (WebCore::InspectorApplicationCacheAgent::enable): * inspector/front-end/ApplicationCacheItemsView.js: (WebInspector.ApplicationCacheItemsView): (WebInspector.ApplicationCacheItemsView.prototype.wasShown): * inspector/front-end/ApplicationCacheModel.js: (WebInspector.ApplicationCacheModel): (WebInspector.ApplicationCacheModel.prototype.get onLine): (WebInspector.ApplicationCacheModel.prototype._networkStateUpdated): * inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.showApplicationCache): (WebInspector.ResourcesPanel.prototype._applicationCacheNetworkStateChanged): 2011-11-21 Carlos Garcia Campos Unreviewed. Fix make distcheck build. * GNUmakefile.list.am: 2011-11-21 Dominic Mazzoni Accessibility: Multiselect list boxes need to report the active option in addition to which items are selected. https://bugs.webkit.org/show_bug.cgi?id=72479 Reviewed by Chris Fleizach. Test: accessibility/multiselect-list-reports-active-option.html * accessibility/AccessibilityListBoxOption.cpp: (WebCore::AccessibilityListBoxOption::isSelectedOptionActive): * accessibility/AccessibilityListBoxOption.h: * accessibility/AccessibilityObject.h: (WebCore::AccessibilityObject::isSelectedOptionActive): 2011-11-21 Yuta Kitamura [Qt] WebSocket close tests are failing https://bugs.webkit.org/show_bug.cgi?id=72865 Reviewed by Simon Hausmann. * platform/network/qt/SocketStreamHandleQt.cpp: (WebCore::SocketStreamHandlePrivate::close): Emit didCloseSocketStream() callback even before the connection is established. Call m_socket->abort() to prevent "connected" signal from firing. 2011-11-21 Shinya Kawanaka Refactoring: SpellChecker::requestCheckingFor should take Range instead of Node. https://bugs.webkit.org/show_bug.cgi?id=72847 Reviewed by Hajime Morita. Covered by existing test. * editing/Editor.cpp: (WebCore::Editor::replaceSelectionWithFragment): Passes Range to requestCheckingFor instead of Node. * editing/SpellChecker.cpp: Changed argument type from Node to Range. The corresponding changes are also done in dependent methods. (WebCore::SpellChecker::initRequest): (WebCore::SpellChecker::clearRequest): (WebCore::SpellChecker::canCheckAsynchronously): (WebCore::SpellChecker::isBusy): (WebCore::SpellChecker::isValid): (WebCore::SpellChecker::isCheckable): (WebCore::SpellChecker::requestCheckingFor): Changed argument type from Node to Range. (WebCore::SpellChecker::doRequestCheckingFor): (WebCore::SpellChecker::didCheck): * editing/SpellChecker.h: 2011-11-20 Kenichi Ishibashi [Chromium] Remove old getFontFamilyForCharacters() and familyForChars() APIs. https://bugs.webkit.org/show_bug.cgi?id=72844 Respects bold and italic properties that is given by fontconfig. Reviewed by Darin Fisher. * platform/graphics/chromium/FontCacheLinux.cpp: (WebCore::FontCache::getFontDataForCharacters): Removed #if and old logic. 2011-11-20 Noel Gordon [chromium] Remove qt/QtMobileWebStyle from the gyp projects https://bugs.webkit.org/show_bug.cgi?id=72843 Reviewed by Antonio Gomes. platform/qt/QtMobileWebStyle.{h,cpp} were removed in r100123 * WebCore.gypi: remove platform/qt/QtMobileWebStyle.{h,cpp} 2011-11-20 Kentaro Hara Unreviewed. Rebaselined run-bindings-tests results. * bindings/scripts/test/CPP/WebDOMFloat64Array.cpp: (WebDOMFloat64Array::WebDOMFloat64Array): (WebDOMFloat64Array::impl): (toWebCore): (toWebKit): * bindings/scripts/test/CPP/WebDOMFloat64Array.h: 2011-11-20 Adam Barth REGRESSION(r100691): Safari error pages and Growl notifications fail to load stylesheets https://bugs.webkit.org/show_bug.cgi?id=72836 Reviewed by Sam Weinig. This patch removes a (minor) security mitigation. Previously, we tried sequester "directory listings" into unique origins to make it more difficult for an attacker to crawl the user's local file system. Unfortunately, this mitigation doesn't really buy us much security because if the attacker has access to local files, we've probably lost anyway. The larger problem, however, is that this condition is overly complicated and has broken in sublte ways several times in its (relatively short) lifetime. In the cases reported in this bug, we see that this check affects error pages in Safari and Growl notifications, even those have nothing to do with directory listings. If we have our heart set on this directory listing mitigation, we'll need a more robust way of triggering the behavior than examining URLs and guess whether they contain directory listings. For example, if we implement Allow-From or Access-Control-Deny-Origin, then the embedder can supply those policies along with the directory listings. Those seem like much better solutions than the in-engine hack this patch removes. * page/SecurityOrigin.cpp: (WebCore::shouldTreatAsUniqueOrigin): 2011-10-17 Antonio Gomes Pass a Frame* parameter in EditorClient::respondToChangedSelection https://bugs.webkit.org/show_bug.cgi?id=70248 Reviewed by Ryosuke Niwa. Most of the port specific implementations of EditorClient::respondToChangedSelection (like EditorClient{Qt,Gtk,etc}) are wrongly relying on FocusController::focusedOrMainFrame method to get the Frame where the selection is happening on. It is not right, since a selection can be easily triggered in an inner frame that is not focused. No new tests since it is a hard thing to test without to hook into editor client in layout tests. We could change the "Dumped Delegate" messages, but it would require a rebasile of +1200 for a minor change. * editing/Editor.cpp: Pass the Frame on where the selection is changing to the client. (WebCore::Editor::respondToChangedSelection): Ditto. (WebCore::Editor::changeSelectionAfterCommand): Ditto. (WebCore::EmptyEditorClient::respondToChangedSelection): * page/EditorClient.h: Pass Frame* to indicate where the selection is happening. * loader/EmptyClients.h: Changed signature as per base class change. 2011-11-17 Mark Rowe Disable deprecation warnings around code where we cannot easily switch away from the deprecated APIs. Reviewed by Sam Weinig. * platform/mac/WebCoreNSStringExtras.mm: * platform/network/cf/SocketStreamHandleCFNet.cpp: (WebCore::SocketStreamHandle::reportErrorToClient): 2011-11-19 Kevin Ollivier [wx] C++ bindings build fix for move of array classes to WTF. * bindings/scripts/CodeGeneratorCPP.pm: (GetCPPTypeGetter): (GetNamespaceForClass): (GenerateHeader): (GenerateImplementation): 2011-11-19 Scott Graham Move gamepad to Modules/ (+ some cleanup) https://bugs.webkit.org/show_bug.cgi?id=72785 Reviewed by Adam Barth. Move main files from page/ to Modules/gamepad/. #include guard the gamepad header inclusions in Navigator.cpp to avoid including for ports that do not enable GAMEPAD. * Modules/gamepad/Gamepad.cpp: Renamed from Source/WebCore/page/Gamepad.cpp. (WebCore::Gamepad::Gamepad): (WebCore::Gamepad::axes): (WebCore::Gamepad::buttons): (WebCore::Gamepad::~Gamepad): * Modules/gamepad/Gamepad.h: Renamed from Source/WebCore/page/Gamepad.h. * Modules/gamepad/Gamepad.idl: Renamed from Source/WebCore/page/Gamepad.idl. * Modules/gamepad/GamepadList.cpp: Renamed from Source/WebCore/page/GamepadList.cpp. (WebCore::GamepadList::~GamepadList): (WebCore::GamepadList::set): (WebCore::GamepadList::length): (WebCore::GamepadList::item): * Modules/gamepad/GamepadList.h: Renamed from Source/WebCore/page/GamepadList.h. (WebCore::GamepadList::create): (WebCore::GamepadList::GamepadList): * Modules/gamepad/GamepadList.idl: Renamed from Source/WebCore/page/GamepadList.idl. * WebCore.gyp/WebCore.gyp: * WebCore.gypi: * page/Navigator.cpp: 2011-11-19 Sheriff Bot Unreviewed, rolling out r100834. http://trac.webkit.org/changeset/100834 https://bugs.webkit.org/show_bug.cgi?id=72806 this patch makes Qt run-webkit-test exit before finishing (Requested by igoroliveira on #webkit). * platform/graphics/texmap/TextureMapperNode.cpp: * platform/graphics/texmap/TextureMapperNode.h: 2011-11-19 Huang Dongsung Remove WebCore/ForwardingHeaders/runtime/JSObjectWithGlobalObject.h because JSObjectWithGlobalObject.h has been removed. https://bugs.webkit.org/show_bug.cgi?id=72794 r94701 removed JSObjectWithGlobalObject.h. Reviewed by Oliver Hunt. * ForwardingHeaders/runtime/JSObjectWithGlobalObject.h: Removed. 2011-11-19 Vsevolod Vlasov Web Inspector:[protocol] actual JSON messages do not conform to Inspector.json in InspectorApplicationCacheAgent.cpp https://bugs.webkit.org/show_bug.cgi?id=72734 Reviewed by Timothy Hatcher. * inspector/Inspector.json: 2011-11-19 David Barr REGRESSION(r98542): Chromium: CSS text is rendered on page https://bugs.webkit.org/show_bug.cgi?id=71703 Reviewed by Antti Koivisto. Matched UA declarations uncacheable when using simpleDefaultStyleSheet. Test: fast/css/style-tag-display-none.html * css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::matchUARules): 2011-11-19 Jay Civelli When loading a MHTML document, make sure we set the base URL before we notify the frame was committed (so the document has the right base URL when the notification happens). https://bugs.webkit.org/show_bug.cgi?id=72788 Reviewed by Adam Barth. * loader/FrameLoader.cpp: (WebCore::FrameLoader::receivedFirstData): 2011-11-19 Adam Barth Integrate Source/WTF with the Chromium build system https://bugs.webkit.org/show_bug.cgi?id=72790 Reviewed by Eric Seidel. Add a dependency on the new WTF. * WebCore.gyp/WebCore.gyp: 2011-11-18 Takashi Toyoshima [Chromium] [WebSocket] export WebSocketChannel interface for plugins https://bugs.webkit.org/show_bug.cgi?id=72016 Reviewed by Darin Fisher. Add a interface to send raw binary data. This interface is used by WebWebSocketChannel implementation in WebKit API. No new tests because just export a interface. * websockets/WebSocketChannel.cpp: (WebCore::WebSocketChannel::send): * websockets/WebSocketChannel.h: 2011-11-18 Vineet Chaudhary https://bugs.webkit.org/show_bug.cgi?id=72591 Remove document.width / document.height Reviewed by Darin Adler. Removed document.width/document.height from JS bindings, but keeping the same for ObjC bindings. Also it should use document.body.clientWidth and document.body.clientHeight instead. * html/HTMLDocument.idl: 2011-11-18 Martin Robinson Fix the GTK+ build. * page/Navigator.idl: Properly disable the webkitGamepads API if gamepad isn't enabled at compile time. 2011-11-18 Daniel Bates Add CMake build infrastructure for the BlackBerry port https://bugs.webkit.org/show_bug.cgi?id=72768 Reviewed by Antonio Gomes. * CMakeLists.txt: At this time the BlackBerry port doesn't support generating DOM bindings from the SVG IDLs. See WebKit bug #72773. * PlatformBlackBerry.cmake: Added. 2011-11-18 Sheriff Bot Unreviewed, rolling out r100826. http://trac.webkit.org/changeset/100826 https://bugs.webkit.org/show_bug.cgi?id=72786 Broke Chromium Mac build (Requested by aklein on #webkit). * page/ChromeClient.h: * page/FrameView.cpp: * page/FrameView.h: * platform/ScrollView.cpp: (WebCore::ScrollView::wheelEvent): * platform/ScrollView.h: * platform/ScrollableArea.h: (WebCore::ScrollableArea::scrollbarStyleChanged): * platform/mac/ScrollAnimatorMac.mm: (WebCore::ScrollAnimatorMac::updateScrollerStyle): 2011-11-18 Alpha Lam [chromium] composited layers are blurry with a zoom-in page scale factor https://bugs.webkit.org/show_bug.cgi?id=71225 Reviewed by James Robinson. Pass contents scale factor to the compositor such that it can: 1. Adjust contentBounds() of the compositoer layers with content scale. 2. Apply the content scale in the painter for texture update in better resolution. 3. Apply the content scale to the dirty rect in CanvasLayerTextureUpdater. This change fixed blurry problem for all tiled layer types and is not limited to position:fixed layers. Tests: compositing/geometry/fixed-position-composited-page-scale-down.html compositing/geometry/fixed-position-composited-page-scale.html compositing/geometry/fixed-position-iframe-composited-page-scale-down.html compositing/geometry/fixed-position-iframe-composited-page-scale.html compositing/geometry/fixed-position-transform-composited-page-scale-down.html compositing/geometry/fixed-position-transform-composited-page-scale.html * platform/graphics/chromium/GraphicsLayerChromium.cpp: (WebCore::GraphicsLayerChromium::setTransform): (WebCore::GraphicsLayerChromium::updateLayerPreserves3D): (WebCore::GraphicsLayerChromium::updateContentsScale): (WebCore::GraphicsLayerChromium::contentsScale): (WebCore::GraphicsLayerChromium::deviceOrPageScaleFactorChanged): * platform/graphics/chromium/GraphicsLayerChromium.h: * platform/graphics/chromium/ImageLayerChromium.cpp: (WebCore::ImageLayerTextureUpdater::prepareToUpdate): (WebCore::ImageLayerChromium::needsContentsScale): * platform/graphics/chromium/ImageLayerChromium.h: * platform/graphics/chromium/LayerChromium.cpp: (WebCore::LayerChromium::LayerChromium): (WebCore::LayerChromium::setContentsScale): * platform/graphics/chromium/LayerChromium.h: (WebCore::LayerChromium::needsContentsScale): (WebCore::LayerChromium::contentsScale): * platform/graphics/chromium/LayerTextureUpdater.h: * platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp: (WebCore::LayerTextureUpdaterCanvas::paintContents): (WebCore::LayerTextureUpdaterBitmap::prepareToUpdate): (WebCore::LayerTextureUpdaterSkPicture::prepareToUpdate): * platform/graphics/chromium/LayerTextureUpdaterCanvas.h: * platform/graphics/chromium/TiledLayerChromium.cpp: (WebCore::TiledLayerChromium::needsContentsScale): (WebCore::TiledLayerChromium::contentBounds): (WebCore::TiledLayerChromium::prepareToUpdate): * platform/graphics/chromium/TiledLayerChromium.h: 2011-11-18 Igor Oliveira [WK2][Qt] Move Accelerated Composite animations to UIProcess https://bugs.webkit.org/show_bug.cgi?id=72753 Add helper method to synchronize animations in TextureMapper. Reviewed by Noam Rosenthal. * platform/graphics/texmap/TextureMapperNode.cpp: (WebCore::TextureMapperNode::syncAnimationsRecursively): * platform/graphics/texmap/TextureMapperNode.h: 2011-11-18 Scott Graham IDL changes for gamepad support https://bugs.webkit.org/show_bug.cgi?id=71753 Reviewed by Adam Barth. IDL changes and associated plumbing to expose list of gamepad objects on navigator object (per current spec). Full patch is https://bugs.webkit.org/show_bug.cgi?id=69451. Only basic existence test until more plumbing in future patches. Test: gamepad/gamepad-api.html * WebCore.gypi: * bindings/generic/RuntimeEnabledFeatures.h: (WebCore::RuntimeEnabledFeatures::setWebkitGamepadsEnabled): (WebCore::RuntimeEnabledFeatures::webkitGamepadsEnabled): * page/Gamepad.cpp: Added. (WebCore::Gamepad::Gamepad): (WebCore::Gamepad::axes): (WebCore::Gamepad::buttons): (WebCore::Gamepad::~Gamepad): * page/Gamepad.h: Added. * page/Gamepad.idl: Added. * page/GamepadList.cpp: Added. (WebCore::GamepadList::~GamepadList): (WebCore::GamepadList::set): (WebCore::GamepadList::length): (WebCore::GamepadList::item): * page/GamepadList.h: Added. (WebCore::GamepadList::create): (WebCore::GamepadList::GamepadList): * page/GamepadList.idl: Added. * page/Navigator.cpp: (WebCore::Navigator::webkitGamepads): * page/Navigator.h: * page/Navigator.idl: 2011-11-18 Sheriff Bot Unreviewed, rolling out r100693. http://trac.webkit.org/changeset/100693 https://bugs.webkit.org/show_bug.cgi?id=72779 This patch caused a rendering regression (see bug 72770) (Requested by philip__ on #webkit). * rendering/RenderObject.cpp: (WebCore::RenderObject::setStyle): * rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::diff): 2011-11-18 Simon Fraser Reflection on composited element doesn't update if the element changes to show no content https://bugs.webkit.org/show_bug.cgi?id=72774 Reviewed by Chris Marrin. When a style change results in a reflected element losing its backing store, we need to clear the backing stores on the layer clones as well. Test: compositing/reflections/become-simple-composited-reflection.html * platform/graphics/ca/GraphicsLayerCA.cpp: (WebCore::GraphicsLayerCA::updateLayerDrawsContent): 2011-11-18 Daniel Cheng [chromium] Use correct backing store for ChromiumDataObject in pasteboard writes. https://bugs.webkit.org/show_bug.cgi?id=72767 Reviewed by Tony Chang. Covered by existing tests. * editing/chromium/EditorChromium.cpp: (WebCore::Editor::newGeneralClipboard): * page/chromium/EventHandlerChromium.cpp: (WebCore::EventHandler::createDraggingClipboard): * platform/chromium/ChromiumDataObject.cpp: (WebCore::ChromiumDataObject::types): (WebCore::ChromiumDataObject::getData): (WebCore::ChromiumDataObject::containsFilenames): (WebCore::ChromiumDataObject::ChromiumDataObject): * platform/chromium/ChromiumDataObject.h: (WebCore::ChromiumDataObject::createFromPasteboard): (WebCore::ChromiumDataObject::create): (WebCore::ChromiumDataObject::storageMode): * platform/chromium/ClipboardChromium.cpp: (WebCore::ClipboardChromium::hasData): 2011-11-18 Chris Evans Crash with ranges across a detached, reparented node tree https://bugs.webkit.org/show_bug.cgi?id=72757 Reviewed by Adam Barth. Test: fast/dom/move-detached-child-in-range.html * dom/RangeBoundaryPoint.h: (WebCore::RangeBoundaryPoint::childBefore): protect the raw child node from getting pulled from under us. 2011-11-18 Beth Dakin https://bugs.webkit.org/show_bug.cgi?id=72551 When the recommended scrollbar style changes, WKView's tracking options should adjust accordingly -and corresponding- Reviewed by Darin Adler. This new ChromeClient function is called when the recommended scrollbar style changes. This way, WebKit can respond to the change by adjusting its mouse tracking. * page/ChromeClient.h: (WebCore::ChromeClient::recommendedScrollbarStyleDidChange): Existing ScrollableArea function scrollbarStyleChanged() now takes an int indicating the new scrollbar style and a bool indicating whether it is necessary to force an update. It used to be the case that this function was ONLY used to force an update (and only called when an updated was needed), but now that it must also call into the ChromeClient, it is necessary to include a bool tracking whether we need to force an update. New implementation on FrameView is responsible for calling ChromeClient, and then that calls into the pre-existing ScrollView function for the forceUpdate part. * page/FrameView.cpp: (WebCore::FrameView::scrollbarStyleChanged): * page/FrameView.h: * platform/ScrollView.cpp: (WebCore::ScrollView:: scrollbarStyleChanged): * platform/ScrollView.h: * platform/ScrollableArea.h: (WebCore::ScrollableArea::scrollbarStyleChanged): * platform/mac/ScrollAnimatorMac.mm: (WebCore::ScrollAnimatorMac::updateScrollerStyle): 2011-11-18 Kelly Norton Fixes several more void functions in RenderObject that return values. https://bugs.webkit.org/show_bug.cgi?id=72750 Reviewed by Adam Barth. * rendering/RenderBlock.cpp: (WebCore::RenderBlock::updateBeforeAfterContent): (WebCore::RenderBlock::addChildToContinuation): (WebCore::RenderBlock::addChildToAnonymousColumnBlocks): (WebCore::RenderBlock::addChild): (WebCore::RenderBlock::addChildIgnoringContinuation): 2011-11-18 Shawn Singh [chromium] Add some useful text to existing debug dump https://bugs.webkit.org/show_bug.cgi?id=72576 Reviewed by James Robinson. No new tests needed. * platform/graphics/chromium/cc/CCLayerImpl.cpp: (WebCore::CCLayerImpl::dumpLayerProperties): * platform/graphics/chromium/cc/CCRenderSurface.cpp: (WebCore::CCRenderSurface::dumpSurface): 2011-11-18 Xiaomei Ji REGRESSION: rtl horizontal scrollbar / resize bug - Body shifts on resize when scrolled all the way to the left https://bugs.webkit.org/show_bug.cgi?id=70395 Reviewed by Tony Chang. This patch fixes the problem in Mac and Chromium Mac. The existing test fast/dom/rtl-scroll-to-leftmost-and-resize.html seems does not really work in Mac DRT (the browswer window is not resized). It works in Chromium-Mac. And Chromium-Mac's code is forked from Mac. * platform/chromium/ScrollAnimatorChromiumMac.mm: (WebCore::ScrollAnimatorChromiumMac::immediateScrollToPoint): * platform/mac/ScrollAnimatorMac.mm: (WebCore::ScrollAnimatorMac::immediateScrollToPoint): 2011-11-18 Martin Robinson REGRESSION (r99924): broke 2 pasteboard tests on GTK https://bugs.webkit.org/show_bug.cgi?id=72131 Reviewed by Tony Chang. * platform/gtk/ClipboardGtk.cpp: (WebCore::ClipboardGtk::clearData): Call clearAll now. (WebCore::ClipboardGtk::clearAllData): Call clearAllExceptFilenames now. * platform/gtk/DataObjectGtk.cpp: (WebCore::DataObjectGtk::clearAllExceptFilenames): Renamed from clear. (WebCore::DataObjectGtk::clearAll): Added this method which also clear filenames. * platform/gtk/DataObjectGtk.h: * platform/gtk/PasteboardGtk.cpp: Call clear before setting new clipboard data. (WebCore::Pasteboard::writeSelection): Ditto. (WebCore::Pasteboard::writePlainText): Ditto. (WebCore::Pasteboard::writeURL): Ditto. (WebCore::Pasteboard::writeImage): Ditto. * platform/gtk/PasteboardHelper.cpp: (WebCore::clearClipboardContentsCallback): Use the clearAll method now. 2011-11-18 Vineet Chaudhary Access key should work on all elements. https://bugs.webkit.org/show_bug.cgi?id=71854 Reviewed by Ryosuke Niwa. All HTML elements can have the accesskey content attribute set. Specification http://dev.w3.org/html5/spec/Overview.html#the-accesskey-attribute Adding "accessKey" attribute to HTMLElement.idl file as [Reflect]. Test: fast/forms/access-key-for-all-elements.html * bindings/objc/PublicDOMInterfaces.h: Moved properties form subclass to base class. * html/BaseButtonInputType.cpp: (WebCore::BaseButtonInputType::accessKeyAction): Renamed variable sendToAnyElement to sendMouseEvents. * html/BaseButtonInputType.h: Ditto * html/BaseCheckableInputType.cpp: (WebCore::BaseCheckableInputType::accessKeyAction): Ditto * html/BaseCheckableInputType.h: Ditto * html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::accessKeyAction): Ditto * html/HTMLAnchorElement.h: Ditto * html/HTMLAnchorElement.idl: Removed redundant IDL attribute entries. * html/HTMLAreaElement.idl: Removed redundant IDL attribute entries. * html/HTMLButtonElement.cpp: (WebCore::HTMLButtonElement::accessKeyAction): Renamed variable sendToAnyElement to sendMouseEvents. * html/HTMLButtonElement.h: Ditto * html/HTMLButtonElement.idl: Removed redundant IDL attribute entries. * html/HTMLElement.cpp: (WebCore::HTMLElement::accessKeyAction): Renamed variable sendToAnyElement to sendMouseEvents. If the element does not have a defined activation behavior, fire a click event at the element. * html/HTMLElement.h: Ditto * html/HTMLElement.idl: Added accessKey IDL attribute. * html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::accessKeyAction): Renamed variable sendToAnyElement to sendMouseEvents. * html/HTMLInputElement.h: Ditto * html/HTMLInputElement.idl: Removed redundant IDL attribute entries. * html/HTMLLabelElement.cpp: (WebCore::HTMLLabelElement::accessKeyAction): Renamed variable sendToAnyElement to sendMouseEvents. * html/HTMLLabelElement.h: Ditto * html/HTMLLabelElement.idl: Removed redundant IDL attribute entries. * html/HTMLLegendElement.cpp: (WebCore::HTMLLegendElement::accessKeyAction): Renamed variable sendToAnyElement to sendMouseEvents. * html/HTMLLegendElement.h: Ditto * html/HTMLLegendElement.idl: Removed redundant IDL attribute entries. * html/HTMLOptGroupElement.h: Renamed variable sendToAnyElement to sendMouseEvents. * html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::accessKeyAction): Ditto * html/HTMLSelectElement.h: Ditto * html/HTMLTextAreaElement.h: Ditto * html/HTMLTextAreaElement.idl: Removed redundant IDL attribute entries. * html/HiddenInputType.h: Renamed variable sendToAnyElement to sendMouseEvents. * html/InputType.h: Ditto * html/RangeInputType.cpp: (WebCore::RangeInputType::accessKeyAction): Ditto * html/RangeInputType.h: Ditto 2011-11-18 Simon Fraser Appearance of compound transform animations under apps linked on SnowLeopard is incorrect https://bugs.webkit.org/show_bug.cgi?id=72641 and Reviewed by Dean Jackson. GraphicsLayerCA contains a "linked on or after" check to account for a bug in Core Animation on SnowLeopard and earlier, which is that CA would apply the list of animations in reverse order. Our previous fix was incorrect, because it only adjusted the 'additive' property of the animation list based on ordering, rather than flipping the entire list. This change reverses the list of animations before giving them to CA, which fixes the bug. Test: animations/additive-transform-animations.html * platform/graphics/ca/GraphicsLayerCA.cpp: (WebCore::GraphicsLayerCA::appendToUncommittedAnimations): (WebCore::GraphicsLayerCA::createTransformAnimationsFromKeyframes): * platform/graphics/ca/GraphicsLayerCA.h: 2011-11-18 Tim Horton -webkit-cross-fade rendered incorrectly in overflow divs https://bugs.webkit.org/show_bug.cgi?id=72693 Reviewed by Simon Fraser. Respect the desired source rectangle when rendering the cross-fade. Test: css3/images/cross-fade-overflow-position.html * platform/graphics/CrossfadeGeneratedImage.cpp: (WebCore::CrossfadeGeneratedImage::drawCrossfade): (WebCore::CrossfadeGeneratedImage::draw): (WebCore::CrossfadeGeneratedImage::drawPattern): * platform/graphics/CrossfadeGeneratedImage.h: 2011-11-18 Raphael Kubo da Costa Unreviewed build fix; r100686 broke the EFL build when Geolocation support is enabled. * platform/efl/GeolocationServiceEfl.cpp: Only declare s_factoryFunction if CLIENT_BASED_GEOLOCATION is off, otherwise it is also declared in GeolocationService.cpp. 2011-11-18 Igor Oliveira [TextureMapper] computePerspectiveTransformIfNeeded is called twice in TextureMapperNode::syncCompositingState https://bugs.webkit.org/show_bug.cgi?id=72727 TextureMapperNode::computeAllTransforms already has a call to TextureMapperNode::computePerspectiveTransformIfNeeded, so it does not need to be called again after TextureMapperNode::computeAllTransforms. Reviewed by Noam Rosenthal. * platform/graphics/texmap/TextureMapperNode.cpp: (WebCore::TextureMapperNode::syncCompositingState): 2011-11-18 Mihnea Ovidenie Fix compilation warning in ComplexTextControllerCoreText.mm https://bugs.webkit.org/show_bug.cgi?id=72702 Reviewed by Andreas Kling. No functionality changed, so no new tests. * platform/graphics/mac/ComplexTextControllerCoreText.mm: (WebCore::ComplexTextController::collectComplexTextRunsForCharactersCoreText): 2011-11-18 Pavel Feldman Not reviewed: restore front-end compilability via updating externs and JS generator. * inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype.jumpToNextSearchResult): (WebInspector.ElementsPanel.prototype.jumpToPreviousSearchResult): * inspector/front-end/externs.js: (WebInspector.showPanelForAnchorNavigation): * inspector/generate-protocol-externs: 2011-11-17 Pavel Feldman Web Inspector: dispatch messages from the front-end to the backend asynchronously. https://bugs.webkit.org/show_bug.cgi?id=72621 We should align the way we dispatch messages from the front-end to backend across the environments: - WebKit has it synchronoulsly - Chromium has it asynchronously - Remote debugging has it asynchronously Making it asynchronous made a number of flaky Qt tests pass. Tests uncovered console agent problem that was also fixed. Reviewed by Yury Semikhatsky. * inspector/InspectorConsoleAgent.cpp: (WebCore::InspectorConsoleAgent::clearFrontend): * inspector/InspectorFrontendClient.h: * inspector/InspectorFrontendClientLocal.cpp: (WebCore::InspectorBackendDispatchTask::InspectorBackendDispatchTask): (WebCore::InspectorBackendDispatchTask::dispatch): (WebCore::InspectorBackendDispatchTask::reset): (WebCore::InspectorBackendDispatchTask::onTimer): (WebCore::InspectorFrontendClientLocal::InspectorFrontendClientLocal): (WebCore::InspectorFrontendClientLocal::windowObjectCleared): (WebCore::InspectorFrontendClientLocal::sendMessageToBackend): * inspector/InspectorFrontendClientLocal.h: 2011-11-18 Iain Merrick [chromium] Pass screen refresh rate into compositor. https://bugs.webkit.org/show_bug.cgi?id=71040 Reviewed by Tony Gentilcore. Covered by CCLayerTreeHostTest. * platform/PlatformScreen.h: * platform/chromium/PlatformScreenChromium.cpp: (WebCore::screenRefreshRate): * platform/chromium/PlatformSupport.h: * platform/graphics/chromium/cc/CCLayerTreeHost.h: (WebCore::CCSettings::CCSettings): * platform/graphics/chromium/cc/CCThreadProxy.cpp: (WebCore::CCThreadProxy::initializeImplOnImplThread): 2011-11-18 Alexandru Chiculita [CSSShaders] Implement the computed style for mesh parameters of the custom() filter https://bugs.webkit.org/show_bug.cgi?id=72478 Reviewed by Dean Jackson. Added parsing and computed style for the mesh rows, columns, mesh box type (filter-box, border-box, content-box and padding-box) and the detached mode. Also fixed a case where "custom(none, 10, 10 filter-box)" was incorrectly treated as "custom(none, 10)". * css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::valueForFilter): * css/CSSParser.cpp: (WebCore::CSSParser::parseCustomFilter): Fixed a case where invalid syntax was parsed as correct syntax. * css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): (WebCore::CSSPrimitiveValue::operator CustomFilterOperation::MeshBoxType): * css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::createCustomFilterOperation): * css/CSSValueList.h: (WebCore::CSSValueListIterator::isPrimitiveValue): * platform/graphics/filters/CustomFilterOperation.h: 2011-11-18 Adam Barth Remove unneeded include (and ifdef) from V8DOMWindowCustom.cpp https://bugs.webkit.org/show_bug.cgi?id=72705 Reviewed by Eric Seidel. Death to ifdefs! * bindings/v8/custom/V8DOMWindowCustom.cpp: 2011-11-18 Adam Barth Move some mediastream related files into the mediastream directory https://bugs.webkit.org/show_bug.cgi?id=72695 Reviewed by Eric Seidel. Just moving the files to the proper directory. * GNUmakefile.list.am: * WebCore.gypi: * mediastream/NavigatorUserMediaError.h: Renamed from Source/WebCore/page/NavigatorUserMediaError.h. (WebCore::NavigatorUserMediaError::create): (WebCore::NavigatorUserMediaError::~NavigatorUserMediaError): (WebCore::NavigatorUserMediaError::code): (WebCore::NavigatorUserMediaError::NavigatorUserMediaError): * mediastream/NavigatorUserMediaError.idl: Renamed from Source/WebCore/page/NavigatorUserMediaError.idl. * mediastream/NavigatorUserMediaErrorCallback.h: Renamed from Source/WebCore/page/NavigatorUserMediaErrorCallback.h. (WebCore::NavigatorUserMediaErrorCallback::~NavigatorUserMediaErrorCallback): * mediastream/NavigatorUserMediaErrorCallback.idl: Renamed from Source/WebCore/page/NavigatorUserMediaErrorCallback.idl. * mediastream/NavigatorUserMediaSuccessCallback.h: Renamed from Source/WebCore/page/NavigatorUserMediaSuccessCallback.h. (WebCore::NavigatorUserMediaSuccessCallback::~NavigatorUserMediaSuccessCallback): * mediastream/NavigatorUserMediaSuccessCallback.idl: Renamed from Source/WebCore/page/NavigatorUserMediaSuccessCallback.idl. 2011-11-18 Andrey Kosyakov Web Inspector: [Extensions API] Provide a way for extension to create a status bar icon https://bugs.webkit.org/show_bug.cgi?id=45955 Reviewed by Pavel Feldman. * inspector/front-end/ExtensionAPI.js: (injectedExtensionAPI.ExtensionPanelImpl.prototype.createStatusBarButton): (injectedExtensionAPI): (injectedExtensionAPI.ButtonImpl.prototype.update): * inspector/front-end/ExtensionPanel.js: (WebInspector.ExtensionPanel): (WebInspector.ExtensionPanel.prototype.get statusBarItems): (WebInspector.ExtensionPanel.prototype.addStatusBarItem): (WebInspector.ExtensionButton): (WebInspector.ExtensionButton.prototype.update): (WebInspector.ExtensionButton.prototype._onClicked): * inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer): (WebInspector.ExtensionServer.prototype.notifyButtonClicked): (WebInspector.ExtensionServer.prototype._onCreateStatusBarButton): (WebInspector.ExtensionServer.prototype._onUpdateButton): (WebInspector.ExtensionServer.prototype._onCreateSidebarPane): * inspector/front-end/inspector.css: (button.status-bar-item.extension): 2011-11-18 Tommy Widenflycht MediaStream API: Merging the PeerConnectionHandler.h files https://bugs.webkit.org/show_bug.cgi?id=72611 Reviewed by Adam Barth. No actual code changes. * GNUmakefile.am: * GNUmakefile.list.am: * WebCore.gyp/WebCore.gyp: * WebCore.gypi: * platform/mediastream/PeerConnectionHandler.h: Renamed from Source/WebCore/platform/mediastream/chromium/PeerConnectionHandler.h. * platform/mediastream/gstreamer/PeerConnectionHandler.h: Removed. 2011-11-17 Simon Hausmann [Qt] Layer violation: ThirdPartyCookiesQt.cpp uses QWebSettings in two places https://bugs.webkit.org/show_bug.cgi?id=72597 Reviewed by Kenneth Rohde Christiansen. Moved code that queries the third party cookie policy from QWebSettings out of WebCore. Instead NetworkingContext has now the interface that allows delegating the functionality into WebKit/qt. In order to do that we need to pass the NetworkingContext around, which is used to retrieve the cookie jar and the originating frame object pointer. * platform/network/NetworkingContext.h: Add interface. * platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyHandler::QNetworkReplyHandler): Pass NetworkingContext to ResourceRequest::toNetworkRequest. (WebCore::QNetworkReplyHandler::redirect): Ditto. * platform/network/qt/ResourceRequest.h: Replaced originatingObject parameter with NetworkingContext, which can also provide the same plus more (cookie jar, policy callback). * platform/network/qt/ResourceRequestQt.cpp: (WebCore::ResourceRequest::toNetworkRequest): Ditto. * platform/qt/CookieJarQt.cpp: Simplify to use NetworkingContext to get cookie jar and call new thirdPartyCookiePolicyPermits API that takes the context as parameter. (WebCore::networkingContext): (WebCore::setCookies): (WebCore::cookies): (WebCore::cookieRequestHeaderFieldValue): (WebCore::cookiesEnabled): * platform/qt/ThirdPartyCookiesQt.cpp: Replace up-casting to QWebFrame and use of QWebSettings with useage of NetworkingContext. (WebCore::thirdPartyCookiePolicyPermits): * platform/qt/ThirdPartyCookiesQt.h: 2011-11-17 Kenichi Ishibashi crash: WebCore::FontPlatformData::roundsGlyphAdvances on Lion https://bugs.webkit.org/show_bug.cgi?id=71997 Reviewed by Dan Bernstein. The cause is a null dereference of a fontData that is stored in ComplexTextRun. The fontData is initialized by using the fontCache, but it could be null when the font is in fallback list. The reason a font from the fallback list might not be in the font Cache is that it may be a web font. Before looking up the fontCache, try to see whether the font is in the fallback list. No new tests. We don't have webfonts that can produce the problem. * platform/graphics/mac/ComplexTextControllerCoreText.mm: (WebCore::ComplexTextController::collectComplexTextRunsForCharactersCoreText): See fallback list first, then lookup cache. 2011-11-17 Kaustubh Atrawalkar Remove initProgressEvent method https://bugs.webkit.org/show_bug.cgi?id=71340 Reviewed by Adam Barth. This method has been removed from the spec draft. http://www.w3.org/TR/progress-events/#interface-progressevent No new tests. Removed method. * dom/ProgressEvent.cpp: * dom/ProgressEvent.h: * dom/ProgressEvent.idl: 2011-11-17 Eunmi Lee [EFL] Move keyIdentifierForEvasKeyName() and windowsKeyCodeForEvasKeyName() to the EflKeyboardUtilities.cpp to use in the WebKit2 https://bugs.webkit.org/show_bug.cgi?id=62451 Reviewed by Martin Robinson. The keyIdentifierForEvasKeyName() and windowsKeyCodeForEvasKeyName() were static functions in the PlatformKeyboardEventEfl.cpp. But they are also needed in the WebKit2 EFL port, so I moved them to the separated file - EflKeyboardUtilities.cpp. * PlatformEfl.cmake: * platform/efl/EflKeyboardUtilities.cpp: Copied from Source/WebCore/platform/efl/PlatformKeyboardEventEfl.cpp. (WebCore::createKeyMap): (WebCore::createWindowsKeyMap): (WebCore::keyIdentifierForEvasKeyName): (WebCore::windowsKeyCodeForEvasKeyName): * platform/efl/EflKeyboardUtilities.h: Added. * platform/efl/PlatformKeyboardEventEfl.cpp: 2011-11-17 Martin Robinson [GTK] The process freezes when you right click on windowless Flash https://bugs.webkit.org/show_bug.cgi?id=69123 Reviewed by Xan Lopez. No new tests. I tried to create a layout test that exercised this issue, but it appears that EventSender clicks do not trigger it. This is covered by the manual tests containing Flash. * plugins/PluginPackage.cpp: (WebCore::PluginPackage::determineQuirks): Always activate the windowless Flash quirk if on x86_64 and X11. * plugins/gtk/PluginViewGtk.cpp: (WebCore::PluginView::handleMouseEvent): Avoid sending right-click events if we have the quirk. 2011-11-17 Peter Rybin Web Inspector: clear fixme in generator script https://bugs.webkit.org/show_bug.cgi?id=71372 Remove unnecessary field name map and update license year number. Reviewed by Pavel Feldman. * inspector/CodeGeneratorInspector.py: 2011-11-17 Raphael Kubo da Costa [EFL] Clean up the use of DATA_DIR in the buildsystem https://bugs.webkit.org/show_bug.cgi?id=72681 Reviewed by Daniel Bates. Add the -DDATA_DIR definition here instead of defining it globally in OptionsEfl.cmake, as WebCore is the only place which needs it. No new tests, this is a buildsystem change. * PlatformEfl.cmake: 2011-11-17 Adam Klein Move JS recursion counter from V8Proxy to V8BindingPerIsolateData https://bugs.webkit.org/show_bug.cgi?id=72645 Reviewed by Adam Barth. With the JS recursion level stored as a member of V8Proxy, it's tied to a frame. But this is incorrect, as there's no reason that a JS call stack need be restricted to a single frame (see my new test case for an example of code going across frames). In order to get the correct accounting of JS recursion level, per-Isolate is the right granularity (per dslomov), which is what this patch accomplishes. Test: storage/indexeddb/transaction-abort-with-js-recursion-cross-frame.html * bindings/v8/V8Binding.cpp: (WebCore::V8BindingPerIsolateData::V8BindingPerIsolateData): * bindings/v8/V8Binding.h: (WebCore::V8BindingPerIsolateData::recursionLevel): (WebCore::V8BindingPerIsolateData::incrementRecursionLevel): (WebCore::V8BindingPerIsolateData::decrementRecursionLevel): (WebCore::V8RecursionScope::V8RecursionScope): (WebCore::V8RecursionScope::~V8RecursionScope): * bindings/v8/V8Proxy.cpp: (WebCore::incrementRecursionLevel): (WebCore::decrementRecursionLevel): (WebCore::recursionLevel): (WebCore::V8Proxy::V8Proxy): (WebCore::V8Proxy::runScript): (WebCore::V8Proxy::callFunction): (WebCore::V8Proxy::didLeaveScriptContext): * bindings/v8/V8Proxy.h: 2011-11-17 Robin Cao [chromium] Font::drawComplexText can not draw a segment of text run https://bugs.webkit.org/show_bug.cgi?id=72095 Reviewed by Adam Barth. drawComplexText() should respect the 'from' and 'to' arguments. Drawing the whole text run may result in text overlapping. Test: platform/chromium-linux/fast/text/international/draw-complex-text-from-to.html * platform/graphics/chromium/ComplexTextControllerLinux.cpp: (WebCore::ComplexTextController::glyphsForRange): * platform/graphics/chromium/ComplexTextControllerLinux.h: * platform/graphics/chromium/FontLinux.cpp: (WebCore::Font::drawComplexText): 2011-11-17 Adam Barth Unique SecurityOrigins shouldn't remember their old schemes and hosts https://bugs.webkit.org/show_bug.cgi?id=71745 Reviewed by Darin Adler. This is the final step in this series of patches. This patch removes the forceUnique flag from SecurityOrigin::create. Now, we create unique origins without passing in the document's URL, preventing information from the document's URL from leaking into the unique origin. * WebCore.exp.in: * dom/Document.cpp: (WebCore::Document::setIsViewSource): (WebCore::Document::initSecurityContext): * loader/cache/MemoryCache.cpp: (WebCore::MemoryCache::getOriginsWithCache): - Update this callsite to use createFromString, which does exactly what this code is doing manually. * page/SecurityOrigin.cpp: (WebCore::SecurityOrigin::create): * page/SecurityOrigin.h: 2011-11-17 Vincent Scheib Pointer Lock: Page Settings unecessary https://bugs.webkit.org/show_bug.cgi?id=72662 Reviewed by Darin Fisher. No new tests. * page/Settings.cpp: (WebCore::Settings::Settings): * page/Settings.h: 2011-11-17 James Robinson [chromium] Disable incremental uploading in threaded compositing path https://bugs.webkit.org/show_bug.cgi?id=72669 Reviewed by Kenneth Russell. Since we don't currently support atomic incremental uploads, incremental uploads in the threaded path result in very strange-looking texture popping as tiles come in on pages that require more than 16 tile uploads per frame. This disables that logic (by setting the upload limit per frame to 99999) until we handle the incremental updates in an atomic fashion. * platform/graphics/chromium/cc/CCThreadProxy.cpp: (WebCore::CCThreadProxy::scheduledActionUpdateMoreResources): 2011-11-06 Nat Duca [chromium] Fix handling of setNeedsCommit and setNeedsAnimate in threaded mode https://bugs.webkit.org/show_bug.cgi?id=71638 Reviewed by James Robinson. * platform/graphics/chromium/cc/CCThreadProxy.cpp: (WebCore::CCThreadProxy::CCThreadProxy): (WebCore::CCThreadProxy::setNeedsAnimate): (WebCore::CCThreadProxy::beginFrameAndCommit): 2011-11-17 Adam Barth Remove bogus ASSERT. * page/SecurityOrigin.cpp: (WebCore::SecurityOrigin::SecurityOrigin): 2011-11-17 Peter Kasting Unreviewed, rolling out r100698. http://trac.webkit.org/changeset/100698 https://bugs.webkit.org/show_bug.cgi?id=72239 This change wasn't the problem either. * dom/Document.cpp: (WebCore::Document::implicitClose): 2011-11-17 David Reveman [Chromium] Calls to paintContentsIfDirty() and updateCompositorResources() should be balanced. https://bugs.webkit.org/show_bug.cgi?id=72630 Reviewed by James Robinson. Layer property changes during paintContent() can leave the layer in an invalid state as paintContentsIfDirty() has been called without a matching updateCompositorResources() call. Removing conditionals around these calls ensure they are balanced. This patch is tested by the following unit test: - CCLayerTreeHostTestOpacityChange.runMultiThread * platform/graphics/chromium/ContentLayerChromium.cpp: (WebCore::ContentLayerChromium::paintContentsIfDirty): * platform/graphics/chromium/VideoLayerChromium.cpp: (WebCore::VideoLayerChromium::updateCompositorResources): * platform/graphics/chromium/cc/CCLayerTreeHost.cpp: (WebCore::CCLayerTreeHost::paintMaskAndReplicaForRenderSurface): (WebCore::CCLayerTreeHost::paintLayerContents): (WebCore::CCLayerTreeHost::updateCompositorResources): * platform/graphics/chromium/cc/CCLayerTreeHost.h: 2011-11-17 Peter Kasting Unreviewed, rolling out r100584. http://trac.webkit.org/changeset/100584 https://bugs.webkit.org/show_bug.cgi?id=72239 See if this change caused Linux dbg crashes. * dom/Document.cpp: (WebCore::Document::implicitClose): 2011-11-17 Adam Barth Remove cargo-cult copy/pasting of ScriptExecutionContext namespace https://bugs.webkit.org/show_bug.cgi?id=72676 Reviewed by Eric Seidel. It looks like this cargo-cult started with initDNSPrefetch being hacked into setSecurityOrigin. I've removed this hack along with the copy/paste code. * dom/DOMImplementation.cpp: * dom/Document.cpp: (WebCore::Document::setIsViewSource): (WebCore::Document::open): (WebCore::Document::initSecurityContext): (WebCore::Document::setSecurityOrigin): * dom/Document.h: * xml/XSLTProcessor.cpp: 2011-11-17 Peter Kasting Unreviewed, rolling out r100676. http://trac.webkit.org/changeset/100676 https://bugs.webkit.org/show_bug.cgi?id=72393 Looks like r100572 was not the source of the crashes. * bindings/js/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::canSetScriptSource): * bindings/js/ScriptDebugServer.h: * bindings/v8/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::stepOutOfFunction): (WebCore::ScriptDebugServer::canSetScriptSource): * bindings/v8/ScriptDebugServer.h: * inspector/CodeGeneratorInspector.py: * inspector/Inspector.json: * inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::getCapabilities): * inspector/InspectorDebuggerAgent.h: * inspector/front-end/DebuggerModel.js: (WebInspector.DebuggerModel): (WebInspector.DebuggerModel.prototype.enableDebugger): (WebInspector.DebuggerModel.prototype.disableDebugger): (WebInspector.DebuggerModel.prototype.canSetScriptSource): * inspector/front-end/DebuggerPresentationModel.js: (WebInspector.DebuggerPresentationModel.prototype.canEditScriptSource): * inspector/front-end/Settings.js: 2011-11-17 Konstantin Scheglov Absolute child is not repainted when parent opacity changes https://bugs.webkit.org/show_bug.cgi?id=68777 Reviewed by Simon Fraser. First time when we change opacity for parent we don't have layer, so diff=StyleDifferenceRepaint is used instead of diff=StyleDifferenceRepaintLayer. Layer is created later, in styleDidChange(). So, when we recalculate later diff, we now check for diff=StyleDifferenceRepaintLayer and performs repaintIncludingDescendants(). Test: fast/layers/layer-absolute-parent-opacity.html * rendering/RenderObject.cpp: (WebCore::RenderObject::setStyle): Call repaintIncludingDescendants() instead of repaint(). * rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::diff): Add ContextSensitivePropertyOpacity when change opacity. 2011-11-17 Nate Chapin r100311 dropped a RefPtr that is very helpful. Add it back. https://bugs.webkit.org/show_bug.cgi?id=72647 Reviewed by Adam Barth. http/tests/misc/xslt-bad-import.html should stop crashing in full chromium builds. * loader/cache/CachedResourceLoader.cpp: (WebCore::CachedResourceLoader::loadDone): 2011-11-17 Adam Barth Refactor SecurityOrigin::create to be easier to understand https://bugs.webkit.org/show_bug.cgi?id=72342 Reviewed by Eric Seidel. Over time, the SecurityOrigin constructor has grown a bit out of control. This patch attempts to separate the different concerns into free functions. The general approach is to put more logic in the "create" function and introduce a simple constructor for unique origins. This patch shouldn't change any behavior. * page/SecurityOrigin.cpp: (WebCore::schemeRequiresAuthority): (WebCore::shouldUseInnerURL): (WebCore::extractInnerURL): (WebCore::isDirectory): (WebCore::shouldTreatAsUniqueOrigin): (WebCore::SecurityOrigin::SecurityOrigin): (WebCore::SecurityOrigin::create): (WebCore::SecurityOrigin::createUnique): (WebCore::SecurityOrigin::databaseIdentifier): * page/SecurityOrigin.h: 2011-11-17 Shawn Singh [chromium] Fix minor style nit in CCLayerImpl https://bugs.webkit.org/show_bug.cgi?id=71070 Reviewed by James Robinson. Fixes if-statements on several settors to follow WebKit conventions. Existing CCLayerImplTest unit tests already cover this change. * platform/graphics/chromium/cc/CCLayerImpl.cpp: (WebCore::CCLayerImpl::setBounds): (WebCore::CCLayerImpl::setMaskLayer): (WebCore::CCLayerImpl::setReplicaLayer): (WebCore::CCLayerImpl::setDrawsContent): (WebCore::CCLayerImpl::setAnchorPoint): (WebCore::CCLayerImpl::setAnchorPointZ): (WebCore::CCLayerImpl::setBackgroundColor): (WebCore::CCLayerImpl::setMasksToBounds): (WebCore::CCLayerImpl::setOpaque): (WebCore::CCLayerImpl::setOpacity): (WebCore::CCLayerImpl::setPosition): (WebCore::CCLayerImpl::setPreserves3D): (WebCore::CCLayerImpl::setZoomAnimatorTransform): (WebCore::CCLayerImpl::setSublayerTransform): (WebCore::CCLayerImpl::setTransform): (WebCore::CCLayerImpl::setDebugBorderColor): (WebCore::CCLayerImpl::setDebugBorderWidth): (WebCore::CCLayerImpl::setContentBounds): (WebCore::CCLayerImpl::setScrollPosition): (WebCore::CCLayerImpl::setScrollDelta): (WebCore::CCLayerImpl::setScaleDelta): (WebCore::CCLayerImpl::setDoubleSided): 2011-11-17 Michael Saboff Leaks seen in MemoryPressureHandlerMac.mm on Leaks bot https://bugs.webkit.org/show_bug.cgi?id=72416 Added code to release _cache_event_source and _timer_event_source after they are canceled. Also added defensive code to clean up the _timer_event_source in uninstall(). Reviewed by Geoffrey Garen. No new tests, fixing leaks caught by leaks bot. * platform/mac/MemoryPressureHandlerMac.mm: (WebCore::MemoryPressureHandler::uninstall): (WebCore::MemoryPressureHandler::holdOff): 2011-11-17 Ken Buchanan Crash from positioned generated content under run-in https://bugs.webkit.org/show_bug.cgi?id=70456 Reviewed by David Hyatt. Modified handling of run-in children to clear generated children before removing the parent from the render tree. This caused problems with absolute positioned children being not properly removed from the positioned object list of the RenderView. * rendering/RenderBlock.cpp: (WebCore::RenderBlock::handleRunInChild): 2011-11-17 Peter Kasting Unreviewed, rolling out r100572. https://bugs.webkit.org/show_bug.cgi?id=72393 https://bugs.webkit.org/show_bug.cgi?id=72651 May have caused seg faults on Chromium Linux dbg bot. * bindings/js/ScriptDebugServer.cpp: * bindings/js/ScriptDebugServer.h: * bindings/v8/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::stepOutOfFunction): * bindings/v8/ScriptDebugServer.h: * inspector/CodeGeneratorInspector.py: * inspector/Inspector.json: * inspector/InspectorDebuggerAgent.cpp: * inspector/InspectorDebuggerAgent.h: * inspector/front-end/DebuggerModel.js: (WebInspector.DebuggerModel): (WebInspector.DebuggerModel.prototype.enableDebugger): (WebInspector.DebuggerModel.prototype.disableDebugger): * inspector/front-end/DebuggerPresentationModel.js: (WebInspector.DebuggerPresentationModel.prototype.canEditScriptSource): * inspector/front-end/Settings.js: 2011-11-17 Sheriff Bot Unreviewed, rolling out r100652. http://trac.webkit.org/changeset/100652 https://bugs.webkit.org/show_bug.cgi?id=72648 "Caused outline-offset-min-assert.html to assert on debug builds" (Requested by mwenge2 on #webkit). * rendering/RenderObject.cpp: (WebCore::RenderObject::paintOutline): 2011-11-17 Mark Rowe Stop performing runtime version checks on OS versions where the check can never possibly fail. Reviewed by Simon Fraser. * platform/graphics/cg/ImageBufferDataCG.cpp: (WebCore::haveVImageRoundingErrorFix): When not targeting Snow Leopard we always have the fix. 2011-11-17 Chris Fleizach AX: The scrollArea is not correctly returning the scrollbars https://bugs.webkit.org/show_bug.cgi?id=70247 Reviewed by Beth Dakin. A few bugs that were preventing this from working. 1) In accessibilityAttributeValue: when an element did not have a renderer() we were returning earlier than we should have 2) We were not updating and clearing the scrollbars correctly when children were cleared or when asked for. Test: platform/mac/accessibility/scrollbars.html * accessibility/AccessibilityScrollView.cpp: (WebCore::AccessibilityScrollView::scrollBar): (WebCore::AccessibilityScrollView::clearChildren): * accessibility/AccessibilityScrollView.h: * accessibility/mac/WebAccessibilityObjectWrapper.mm: (-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]): 2011-11-14 Adam Barth Unique origins shouldn't remember their scheme, host, or port https://bugs.webkit.org/show_bug.cgi?id=72308 Reviewed by Eric Seidel. This patch contains the bulk (all?) of the behavior differences in this patch series. Unique origins shouldn't remember their schemes. Doing so causes some privileges (e.g., local access) to leak into unique origins. * page/SecurityOrigin.cpp: (WebCore::SecurityOrigin::SecurityOrigin): - Explicitly clear out the protocol, host, and port for unique origins. A future patch will refactor all this code to be more elegant. * platform/SchemeRegistry.cpp: (WebCore::schemesWithUniqueOrigins): - Merge "about" and "javascript" in with the general case now that we don't have a separate notion of an empty origin. 2011-11-17 Chris Fleizach AX: cleanup style and naming and code in accessibility search mechanism https://bugs.webkit.org/show_bug.cgi?id=72570 Reviewed by Beth Dakin. Cleanup the naming and code style within the element searching mechanism. * accessibility/AccessibilityObject.cpp: (WebCore::AccessibilityObject::isAccessibilityObjectSearchMatch): (WebCore::AccessibilityObject::isAccessibilityTextSearchMatch): (WebCore::AccessibilityObject::firstAccessibleObjectFromNode): (WebCore::AccessibilityObject::findMatchingObjects): * accessibility/AccessibilityObject.h: * accessibility/mac/WebAccessibilityObjectWrapper.mm: (-[WebAccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]): 2011-11-17 Julien Chaffraix CSS table with 100% width can overflow their containing block https://bugs.webkit.org/show_bug.cgi?id=72180 Reviewed by David Hyatt. Tests: fast/table/table-in-table-percent-width-collapsing-border-quirks-mode.html fast/table/table-in-table-percent-width-collapsing-border.html fast/table/table-in-table-percent-width-quirks-mode.html fast/table/table-in-table-percent-width.html After r97555, we would include the borders in a CSS table's logical width even if the 'width' property was a percent. This does not match what Firefox and IE are doing. Thus don't apply this behavior to percent 'width'. * rendering/RenderTable.cpp: (WebCore::RenderTable::computeLogicalWidth): 2011-11-17 Adrienne Walker [chromium] Implicitly skip render surfaces that won't be drawn https://bugs.webkit.org/show_bug.cgi?id=71038 Rather than having redundant checks in three places for how to walk through a render surface list, instead don't add render surfaces that don't need to get rendered to the render surface list. Reviewed by James Robinson. Covered by existing layout tests and unit tests. * platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::drawLayersOntoRenderSurfaces): * platform/graphics/chromium/cc/CCLayerTreeHost.cpp: (WebCore::CCLayerTreeHost::paintLayerContents): (WebCore::CCLayerTreeHost::updateCompositorResources): * platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp: (WebCore::calculateDrawTransformsAndVisibilityInternal): 2011-11-17 Simon Hausmann [Qt] Layer violation: qt_runtime.cpp accesses QWebElement and QTDRTNode https://bugs.webkit.org/show_bug.cgi?id=72595 Reviewed by Noam Rosenthal. Removed QWebElement and QtDRTNode usage that reached from WebCore into WebKit/qt and replaced it with the ability to register custom JSValue conversion functions. The old code has been moved to WebKit/qt. * bridge/qt/qt_instance.cpp: (JSC::Bindings::QtInstance::QtInstance): Remove unnecessary meta type registration (now done in QtWebElementRuntime::initialize in WebKit/qt). * bridge/qt/qt_runtime.cpp: (JSC::Bindings::registerCustomType): (JSC::Bindings::convertValueToQVariant): (JSC::Bindings::convertQVariantToValue): * bridge/qt/qt_runtime.h: 2011-11-17 Fady Samuel Pass Aspect Ratio to RenderStyle https://bugs.webkit.org/show_bug.cgi?id=72350 Reviewed by Ojan Vafai. * css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): * css/CSSStyleApplyProperty.cpp: (WebCore::ApplyPropertyAspectRatio::applyInheritValue): (WebCore::ApplyPropertyAspectRatio::applyInitialValue): (WebCore::ApplyPropertyAspectRatio::applyValue): (WebCore::ApplyPropertyAspectRatio::createHandler): (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty): * css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): * css/CSSValue.h: (WebCore::CSSValue::isAspectRatioValue): * rendering/style/RenderStyle.h: (WebCore::InheritedFlags::hasAspectRatio): (WebCore::InheritedFlags::aspectRatio): (WebCore::InheritedFlags::aspectRatioDenominator): (WebCore::InheritedFlags::aspectRatioNumerator): (WebCore::InheritedFlags::setHasAspectRatio): (WebCore::InheritedFlags::setAspectRatioDenominator): (WebCore::InheritedFlags::setAspectRatioNumerator): (WebCore::InheritedFlags::initialHasAspectRatio): (WebCore::InheritedFlags::initialAspectRatioDenominator): (WebCore::InheritedFlags::initialAspectRatioNumerator): * rendering/style/StyleRareNonInheritedData.cpp: (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData): (WebCore::StyleRareNonInheritedData::operator==): * rendering/style/StyleRareNonInheritedData.h: 2011-11-09 Robert Hogan CSS 2.1 failure: outline-color-* tests fail https://bugs.webkit.org/show_bug.cgi?id=71931 Reviewed by Julien Chaffraix. WebKit wasn't displaying the top block in these tests because it did not paint the outline of divs with zero size. * rendering/RenderObject.cpp: (WebCore::RenderObject::paintOutline): paint the outline even when the block has zero size 2011-11-17 Sergio Villar Senin [GTK] plugins/get-url-notify-with-url-that-fails-to-load.html on bots after r100466 https://bugs.webkit.org/show_bug.cgi?id=72613 Reviewed by Martin Robinson. Do not assume that a SoupRequest always exists, it is not generated for example when the provided URL is invalid. ResourceHandle::platformSetDefersLoading was crashing because of that. * platform/network/soup/ResourceHandleSoup.cpp: (WebCore::ResourceHandle::platformSetDefersLoading): 2011-11-17 Vsevolod Vlasov Web Inspector: Remove onlineDetectionEnabled from Preferences https://bugs.webkit.org/show_bug.cgi?id=72617 Reviewed by Pavel Feldman. * inspector/front-end/ApplicationCacheItemsView.js: (WebInspector.ApplicationCacheItemsView): (WebInspector.ApplicationCacheItemsView.prototype.get statusBarItems): * inspector/front-end/Settings.js: 2011-11-17 Ken Buchanan Crash from nested tables with generated content https://bugs.webkit.org/show_bug.cgi?id=68811 Reviewed by David Hyatt. When adding a child to a table that has generated content, this change ensures that we leave alone any generated content renderers that belong to descendants in the tree. They don't need to be touched, and doing so can create confusion about who the content belongs to. This patch also simplifies some existing code for finding pseudoelement renderers. * rendering/RenderBlock.cpp: (WebCore::RenderBlock::addChildIgnoringAnonymousColumnBlocks): * rendering/RenderObject.cpp: (WebCore::RenderObject::addChild): (WebCore::RenderObject::isBeforeAfterContentGeneratedByAncestor): Added * rendering/RenderObject.h: (WebCore::RenderObject::findAfterContentRenderer): Deleted (WebCore::RenderObject::findBeforeContentRenderer): Deleted * rendering/RenderObjectChildList.cpp: (WebCore::RenderObjectChildList::beforePseudoElementRenderer): (WebCore::RenderObjectChildList::afterPseudoElementRenderer): * rendering/RenderTable.cpp: (WebCore::RenderTable::addChild): * rendering/RenderTableRow.cpp: (WebCore::RenderTableRow::addChild): * rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::addChild): 2011-11-17 Patrick Gansterer Unreviewed WinCE build fix for r94119. MSVC throws multiply defined symbols linker error when using local class in inline function. * bindings/js/JSDictionary.h: (WebCore::JSDictionary::IdentitySetter::identitySetter): (WebCore::JSDictionary::tryGetProperty): 2011-11-17 Eric Carlson TextTrackList not sorted correctly https://bugs.webkit.org/show_bug.cgi?id=72545 Reviewed by Darin Adler. Test: media/track/track-texttracks.html * WebCore.xcodeproj/project.pbxproj: Add TextTrack.h to WebCore private headers because it is included by HTMLMediaElement.h. * html/LoadableTextTrack.cpp: (WebCore::LoadableTextTrack::LoadableTextTrack): Pass track type to base class constructor. (WebCore::LoadableTextTrack::trackElementIndex): New, return the element's tree order for sorting. * html/LoadableTextTrack.h: * html/TextTrack.cpp: (WebCore::TextTrack::TextTrack): Set track type. * html/TextTrack.h: (WebCore::TextTrack::create): Ditto. (WebCore::TextTrack::trackType): Ditto. * html/track/TextTrackList.cpp: (TextTrackList::length): Update to deal with two TextTrack vectors. (TextTrackList::item): Ditto. (TextTrackList::append): Ditto. (TextTrackList::remove): Ditto * html/track/TextTrackList.h: Store the two types of TextTracks in separate Vectors to make it simpler to keep them in the correct order. 2011-11-17 Simon Hausmann [Qt] Layer violation: WebCore::dnsPrefetch uses QWebSettings::globalSettings() https://bugs.webkit.org/show_bug.cgi?id=72596 Reviewed by Kenneth Rohde Christiansen. We don't need to use QWebSettings here, because we now propagate the DNS prefetch setting to WebCore::Settings and the rest of WebCore checks the setting before calling WebCore::prefetchDNS. * platform/network/qt/DnsPrefetchHelper.cpp: (WebCore::prefetchDNS): Removed the use of QWebSettings. * platform/network/qt/DnsPrefetchHelper.h: Remove offending qwebsettings.h inclusion. 2011-11-17 Simon Hausmann [Qt] Layer violation: Image::loadPlatformResource uses QWebSettings::webGraphic https://bugs.webkit.org/show_bug.cgi?id=72594 Reviewed by Kenneth Rohde Christiansen. Move the cache for the resource pixmaps into ImageQt.cpp. * platform/graphics/Image.h: Add Qt specific setter for resource pixmaps. * platform/graphics/qt/ImageQt.cpp: Moved resource pixmap hash from qwebsettings. (earlyClearGraphics): (graphics): (loadResourcePixmap): (WebCore::Image::setPlatformResource): 2011-11-17 Zeno Albisser [Qt][WK2] Touch/Mouse events are delivered with wrong coordinates. https://bugs.webkit.org/show_bug.cgi?id=72604 When using the QtViewportInterationEngine for zooming/panning, no additional scroll offset should be applied to input events by the ScrollView. This patch is based on work by Andreas Kling. Reviewed by Kenneth Rohde Christiansen. * platform/ScrollView.cpp: (WebCore::ScrollView::windowToContents): (WebCore::ScrollView::contentsToWindow): 2011-11-17 Ben Murdoch Unreviewed build fix. Fix the Windows builds by adding WorkerEventQueue.cpp|h to the vcproj. Build break was introduced in https://bugs.webkit.org/show_bug.cgi?id=72528 * WebCore.vcproj/WebCore.vcproj: Add missing files. 2011-11-17 Mihnea Ovidenie CSS Exclusions: parse the wrap-margin and wrap-padding properties https://bugs.webkit.org/show_bug.cgi?id=71900 Reviewed by Dean Jackson. Tests: fast/exclusions/wrap-margin-parsing.html fast/exclusions/wrap-padding-parsing.html * css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): * css/CSSParser.cpp: (WebCore::isSimpleLengthPropertyID): (WebCore::CSSParser::parseValue): * css/CSSProperty.cpp: (WebCore::CSSProperty::isInheritedProperty): * css/CSSPropertyNames.in: * css/CSSStyleApplyProperty.cpp: (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty): * css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): * rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::diff): * rendering/style/RenderStyle.h: (WebCore::InheritedFlags::wrapPadding): (WebCore::InheritedFlags::setWrapPadding): (WebCore::InheritedFlags::initialWrapPadding): (WebCore::InheritedFlags::wrapMargin): (WebCore::InheritedFlags::setWrapMargin): (WebCore::InheritedFlags::initialWrapMargin): * rendering/style/StyleRareNonInheritedData.cpp: (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData): (WebCore::StyleRareNonInheritedData::operator==): * rendering/style/StyleRareNonInheritedData.h: 2011-11-17 Kenichi Ishibashi [chromium] don't call fontconfig twice in complex text path https://bugs.webkit.org/show_bug.cgi?id=38701 Adds a new API for getting font family. For now, FontCacheLinux calls the new API, but don't use additional properties for compatibility. The old API will be removed when Chromium is ready to use new API. Reviewed by Tony Chang. No new tests. No behavior changes for now. * platform/chromium/PlatformSupport.h: Added FontFamily struct and changed the declaration of getFontFamilyForCharacters(). * platform/graphics/chromium/FontCacheLinux.cpp: (WebCore::FontCache::getFontDataForCharacters): Uses new PlatformSupport::getFontFamilyForCharacters(). * platform/graphics/chromium/FontPlatformDataLinux.h: (WebCore::FontPlatformData::setFakeBold): Added. (WebCore::FontPlatformData::setFakeItalic): Added. 2011-11-17 Mario Sanchez Prada [GTK] Consider parent AtkObject in webkit_accessible_get_parent(), if already set https://bugs.webkit.org/show_bug.cgi?id=72525 Reviewed by Xan Lopez. * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_get_parent): Call to the implementation of atk_object_get_parent in AtkObject class to check whether a parent AtkObject has been previously set, before trying to find one. 2011-11-17 Pavel Feldman Not reviewed: fix IE user agents strings in the inspector. * inspector/front-end/SettingsScreen.js: (WebInspector.SettingsScreen.prototype._createUserAgentSelectRowElement.get const): 2011-11-16 Kenneth Rohde Christiansen Make use-fixed-layout work reliable https://bugs.webkit.org/show_bug.cgi?id=72511 Reviewed by Simon Hausmann. Always send a viewport update per page load as we depend on that, to reset all viewport handling before doing layout. * page/Page.cpp: (WebCore::Page::updateViewportArguments): 2011-11-16 Alexander Pavlov Web Inspector: inspector follows javascript: hrefs as relative https://bugs.webkit.org/show_bug.cgi?id=72373 javascript: hrefs should never be linkified for security. Reviewed by Yury Semikhatsky. * inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype._buildAttributeDOM): * inspector/front-end/ResourceUtils.js: (WebInspector.completeURL): 2011-11-17 Nikolas Zimmermann Not reviewed. Fix 32bit builds. * platform/ClockGeneric.cpp: (ClockGeneric::now): Use narrowPrecisionToFloat. * rendering/FilterEffectRenderer.cpp: (WebCore::FilterEffectRenderer::build): Use it correctly. 2011-11-17 Dominic Mazzoni Accessibility: Chromium requires an AX notification when an iframe loads. https://bugs.webkit.org/show_bug.cgi?id=72239 When a document finishes loading, we were sending an AXLoadComplete if it was the top document. Now, if it's a document in an iframe, send an AXLayoutComplete on the iframe. Reviewed by Chris Fleizach. Test: accessibility/loading-iframe-sends-notification.html * dom/Document.cpp: (WebCore::Document::implicitClose): 2011-11-16 Mark Rowe Remove unnecessary use of CarbonCore APIs from Audio code Reviewed by Andy Estes. * platform/audio/mac/AudioDestinationMac.cpp: (WebCore::AudioDestinationMac::AudioDestinationMac): Switch from using the Carbon Component Manager to using AudioUnit's own component interface. (WebCore::AudioDestinationMac::~AudioDestinationMac): Ditto. * platform/audio/mac/AudioFileReaderMac.cpp: (WebCore::AudioFileReader::AudioFileReader): Remove an unncessary trip through the Carbon File Manager when converting a char* path to a CFURLRef representing the same. 2011-11-17 Adam Barth CSP report-only mode doesn't work from an HTTP header https://bugs.webkit.org/show_bug.cgi?id=71958 Reviewed by Eric Seidel. "It's tested or it's broken." -- Adam Leventhal Test: http/tests/security/contentSecurityPolicy/report-only-from-header.php * loader/FrameLoader.cpp: (WebCore::FrameLoader::didBeginDocument): 2011-11-15 Pavel Feldman Web Inspector: introduce Debugger domain capabilities concept. https://bugs.webkit.org/show_bug.cgi?id=72393 Many of the Preferences that we have in Settings.js and override in DevTools.js are really not preferences, but capabilities. Protocol clients should have a way of figuring out whether some capability is present before using it. Reviewed by Yury Semikhatsky. * bindings/js/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::canSetScriptSource): * bindings/js/ScriptDebugServer.h: * bindings/v8/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::canSetScriptSource): * bindings/v8/ScriptDebugServer.h: * inspector/CodeGeneratorInspector.py: * inspector/Inspector.json: * inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::getCapabilities): * inspector/InspectorDebuggerAgent.h: * inspector/front-end/DebuggerModel.js: (WebInspector.DebuggerModel): (WebInspector.DebuggerModel.prototype.enableDebugger): (WebInspector.DebuggerModel.prototype.canSetScriptSource): * inspector/front-end/DebuggerPresentationModel.js: (WebInspector.DebuggerPresentationModel.prototype.canEditScriptSource): * inspector/front-end/Settings.js: 2011-11-17 Mihnea Ovidenie CSS exclusions: parse the wrap-flow and wrap-through properties https://bugs.webkit.org/show_bug.cgi?id=71904 Reviewed by Dean Jackson. Tests: fast/exclusions/wrap-flow-parsing.html fast/exclusions/wrap-through-parsing.html * css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): * css/CSSParser.cpp: (WebCore::CSSParser::parseValue): * css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): (WebCore::CSSPrimitiveValue::operator WrapFlow): (WebCore::CSSPrimitiveValue::operator WrapThrough): * css/CSSProperty.cpp: (WebCore::CSSProperty::isInheritedProperty): * css/CSSPropertyNames.in: * css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): * css/CSSValueKeywords.in: * rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::diff): * rendering/style/RenderStyle.h: (WebCore::InheritedFlags::wrapFlow): (WebCore::InheritedFlags::wrapThrough): (WebCore::InheritedFlags::setWrapFlow): (WebCore::InheritedFlags::setWrapThrough): (WebCore::InheritedFlags::initialWrapFlow): (WebCore::InheritedFlags::initialWrapThrough): * rendering/style/RenderStyleConstants.h: * rendering/style/StyleRareNonInheritedData.cpp: (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData): (WebCore::StyleRareNonInheritedData::operator==): * rendering/style/StyleRareNonInheritedData.h: 2011-11-16 Dean Jackson Implement filter function shorthands https://bugs.webkit.org/show_bug.cgi?id=68475 Reviewed by Simon Fraser. Implement the shorthand functions for filter effects. This includes grayscale, sepia, invert, hue-rotate, saturate, opacity, gamma, drop-shadow and blur. At the moment sharpen and url are not supported. CSSParser needed to be updated because it was mistakenly clamping saturation values to [0,1]. Any positive number is allowed so you can produce super-saturated images. The biggest change was the API to FilterEffectRenderer. It now builds a list of effects and applies the filter itself. Note that the drop-shadow and blur operations don't yet provide accurate results because they produce an output image that is larger than the input. See https://bugs.webkit.org/show_bug.cgi?id=71929 https://bugs.webkit.org/show_bug.cgi?id=71930 While I was there, I fixed a small style issue in CustomFilterOperation. Tests: css3/filters/effect-blur.html css3/filters/effect-combined.html css3/filters/effect-drop-shadow.html css3/filters/effect-gamma.html css3/filters/effect-grayscale.html css3/filters/effect-hue-rotate.html css3/filters/effect-invert.html css3/filters/effect-opacity.html css3/filters/effect-saturate.html css3/filters/effect-sepia.html * WebCore.xcodeproj/project.pbxproj: Add StyleShader.h to the project (missing from earlier commit). * css/CSSParser.cpp: (WebCore::CSSParser::isValidFilterArgument): Don't clamp saturate to [0,1] * platform/graphics/filters/CustomFilterOperation.h: * rendering/FilterEffectRenderer.cpp: (WebCore::endMatrixRow): (WebCore::lastMatrixRow): (WebCore::FilterEffectRenderer::FilterEffectRenderer): (WebCore::FilterEffectRenderer::inputContext): (WebCore::FilterEffectRenderer::build): (WebCore::FilterEffectRenderer::prepare): (WebCore::FilterEffectRenderer::apply): * rendering/FilterEffectRenderer.h: (WebCore::FilterEffectRenderer::setSourceImageRect): (WebCore::FilterEffectRenderer::output): (WebCore::FilterEffectRenderer::setMaxEffectRects): (WebCore::FilterEffectRenderer::lastEffect): * rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintLayer): (WebCore::RenderLayer::updateOrRemoveFilterEffect): (WebCore::RenderLayer::updateFilterBackingStore): 2011-11-16 Kentaro Hara Remove all custom constructors of Events from JSC https://bugs.webkit.org/show_bug.cgi?id=72577 Reviewed by Adam Barth. - Makes CodeGeneratorJS.pm generate Event constructors if [ConstructorTemplate=Event] IDL is specified. - Removes EventConstructors.h and JSEventConstructors.cpp. - Replaces all JSC custom constructors of Events with the generated code by [ConstructorTemplate=Event] IDL. Tests: fast/events/constructors/before-load-event-constructor.html fast/events/constructors/close-event-constructor.html fast/events/constructors/custom-event-constructor.html fast/events/constructors/error-event-constructor.html fast/events/constructors/event-constructors.html fast/events/constructors/hash-change-event-constructor.html fast/events/constructors/message-event-constructor.html fast/events/constructors/overflow-event-constructor.html fast/events/constructors/page-transition-event-constructor.html fast/events/constructors/pop-state-event-constructor.html fast/events/constructors/progress-event-constructor.html fast/events/constructors/track-event-constructor.html fast/events/constructors/webkit-animation-event-constructor.html fast/events/constructors/webkit-transition-event-constructor.html * bindings/generic/EventConstructors.h: Removed. This is what we wanted to do in this patch. * bindings/js/JSEventConstructors.cpp: Ditto. * GNUmakefile.list.am: Removed EventConstructors.h and JSEventConstructors.cpp. * Target.pri: Ditto. * UseJSC.cmake: Ditto. * WebCore.gypi: Ditto. * WebCore.vcproj/WebCore.vcproj: Ditto. * WebCore.xcodeproj/project.pbxproj: Ditto. * bindings/js/JSBindingsAllInOne.cpp: Ditto. * bindings/scripts/CodeGeneratorJS.pm: (GenerateHeader): Added JSDictionary.h. (GenerateConstructorDeclaration): Added a header for fillXXXXEventInit(...). (GenerateConstructorDefinition): Generates an Event constructor. The generated code is the same as the code that had been written in JSEventConstructors.cpp. (IsConstructable): Judges if a given interface is constructable. (IsConstructorTemplate): Judges if a given interface has a given template, e.g. judges if an interface has [ConstructorTemplate=Event]. * bindings/scripts/test/TestEventConstructor.idl: Changed 'CustomConstructor=Event' to 'ConstructorTemplate=Event'. We should have changed this in r100108. * bindings/scripts/test/JS/JSTestEventConstructor.cpp: Updated a run-bindings-tests result. (WebCore::JSTestEventConstructorConstructor::constructJSTestEventConstructor): (WebCore::fillTestEventConstructorInit): * bindings/scripts/test/JS/JSTestEventConstructor.h: Ditto. * bindings/scripts/test/V8/V8TestEventConstructor.cpp: Ditto. (WebCore::V8TestEventConstructor::constructorCallback): (WebCore::fillTestEventConstructorInit): * bindings/scripts/test/V8/V8TestEventConstructor.h: Ditto. * dom/BeforeLoadEvent.idl: In essence, replaced [JSCustomConstructor] IDL with [JSConstructorTemplate=Event] IDL. * dom/CustomEvent.idl: Ditto. * dom/ErrorEvent.idl: Ditto. * dom/Event.idl: Ditto. * dom/HashChangeEvent.idl: Ditto. * dom/MessageEvent.idl: Ditto. * dom/OverflowEvent.idl: Ditto. * dom/PageTransitionEvent.idl: Ditto. * dom/PopStateEvent.idl: Ditto. * dom/ProgressEvent.idl: Ditto. * dom/WebKitAnimationEvent.idl: Ditto. * dom/WebKitTransitionEvent.idl: Ditto. * html/track/TrackEvent.idl: Ditto. * websockets/CloseEvent.idl: Ditto. 2011-11-16 Dean Jackson Build fix for Apple WebKit due to r100560. When I removed the violating header file it lost the reference to Color. No review. * platform/graphics/filters/FilterOperation.h: 2011-11-16 Dean Jackson DropShadowFilterOperation violates platform isolation https://bugs.webkit.org/show_bug.cgi?id=72544 Reviewed by Simon Fraser. Move ShadowData properties into the DropShadowFilterOperation to avoid depending on something outside platform. * css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::valueForFilter): * css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::createFilterOperations): * platform/graphics/filters/FilterOperation.h: (WebCore::DropShadowFilterOperation::create): (WebCore::DropShadowFilterOperation::x): (WebCore::DropShadowFilterOperation::y): (WebCore::DropShadowFilterOperation::stdDeviation): (WebCore::DropShadowFilterOperation::color): (WebCore::DropShadowFilterOperation::operator==): (WebCore::DropShadowFilterOperation::DropShadowFilterOperation): 2011-11-16 Adam Bergkvist Use a simple page client for user consent in getUserMedia() https://bugs.webkit.org/show_bug.cgi?id=70897 Reviewed by Adam Barth. This is one in a series of patches that update the MediaStream feature to use WebCore platform interfaces. Covered by existing tests. * GNUmakefile.list.am: * WebCore.gypi: * mediastream/MediaStreamClient.h: Removed. * mediastream/MediaStreamController.cpp: Removed. * mediastream/MediaStreamController.h: Removed. * mediastream/MediaStreamFrameController.cpp: Removed. * mediastream/MediaStreamFrameController.h: Removed. * mediastream/UserMediaClient.h: Added. (WebCore::UserMediaClient::~UserMediaClient): * mediastream/UserMediaRequest.cpp: Added. (WebCore::UserMediaRequest::create): (WebCore::UserMediaRequest::UserMediaRequest): (WebCore::UserMediaRequest::~UserMediaRequest): (WebCore::UserMediaRequest::start): (WebCore::UserMediaRequest::mediaStreamSourcesQueryCompleted): (WebCore::UserMediaRequest::succeed): (WebCore::UserMediaRequest::fail): (WebCore::UserMediaRequest::contextDestroyed): (WebCore::UserMediaRequest::parseOptions): * mediastream/UserMediaRequest.h: Added. (WebCore::UserMediaRequest::audio): (WebCore::UserMediaRequest::video): (WebCore::UserMediaRequest::cameraPreferenceUser): (WebCore::UserMediaRequest::cameraPreferenceEnvironment): (WebCore::UserMediaRequest::successCallback): (WebCore::UserMediaRequest::errorCallback): * page/CallbackTask.h: Removed. * page/Frame.cpp: (WebCore::Frame::Frame): (WebCore::Frame::~Frame): (WebCore::Frame::pageDestroyed): (WebCore::Frame::transferChildFrameToNewDocument): * page/Frame.h: * page/Navigator.cpp: (WebCore::Navigator::webkitGetUserMedia): * page/NavigatorUserMediaErrorCallback.h: * page/Page.cpp: (WebCore::Page::Page): (WebCore::Page::~Page): (WebCore::Page::PageClients::PageClients): * page/Page.h: (WebCore::Page::userMediaClient): 2011-11-16 David Grogan instantiate WorkerEventQueue in WorkerContext https://bugs.webkit.org/show_bug.cgi?id=72528 Reviewed by David Levin. No new tests - nothing uses it yet. * workers/WorkerContext.cpp: (WebCore::WorkerContext::WorkerContext): Instantiate WorkerEventQueue in InitializerList * workers/WorkerEventQueue.h: Don't inherit from RefCounted, WorkerContext has an OwnPtr to it 2011-11-16 Kentaro Hara Unreviewed. Rebaselined run-bindings-tests results. * bindings/scripts/test/JS/JSTestEventConstructor.cpp: (WebCore::JSTestEventConstructor::JSTestEventConstructor): (WebCore::JSTestEventConstructorOwner::finalize): * bindings/scripts/test/JS/JSTestEventConstructor.h: (WebCore::JSTestEventConstructor::impl): (WebCore::JSTestEventConstructor::releaseImpl): * bindings/scripts/test/JS/JSTestInterface.cpp: (WebCore::JSTestInterface::JSTestInterface): (WebCore::JSTestInterfaceOwner::finalize): * bindings/scripts/test/JS/JSTestInterface.h: (WebCore::JSTestInterface::impl): (WebCore::JSTestInterface::releaseImpl): * bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp: (WebCore::JSTestMediaQueryListListener::JSTestMediaQueryListListener): (WebCore::JSTestMediaQueryListListenerOwner::finalize): * bindings/scripts/test/JS/JSTestMediaQueryListListener.h: (WebCore::JSTestMediaQueryListListener::impl): (WebCore::JSTestMediaQueryListListener::releaseImpl): * bindings/scripts/test/JS/JSTestNamedConstructor.cpp: (WebCore::JSTestNamedConstructor::JSTestNamedConstructor): (WebCore::JSTestNamedConstructorOwner::finalize): * bindings/scripts/test/JS/JSTestNamedConstructor.h: (WebCore::JSTestNamedConstructor::impl): (WebCore::JSTestNamedConstructor::releaseImpl): * bindings/scripts/test/JS/JSTestObj.cpp: (WebCore::JSTestObj::JSTestObj): (WebCore::JSTestObjOwner::finalize): * bindings/scripts/test/JS/JSTestObj.h: (WebCore::JSTestObj::impl): (WebCore::JSTestObj::releaseImpl): * bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp: (WebCore::JSTestSerializedScriptValueInterface::JSTestSerializedScriptValueInterface): (WebCore::JSTestSerializedScriptValueInterfaceOwner::finalize): * bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h: (WebCore::JSTestSerializedScriptValueInterface::impl): (WebCore::JSTestSerializedScriptValueInterface::releaseImpl): 2011-11-16 Jay Civelli Make sure MHTML documents use the domain of the MHTML file. https://bugs.webkit.org/show_bug.cgi?id=72445 Reviewed by Adam Barth. * dom/Document.h: (WebCore::Document::setBaseURL): * loader/FrameLoader.cpp: (WebCore::FrameLoader::receivedFirstData): 2011-11-16 Julien Chaffraix Update supported display list after -webkit-grid and -webkit-inline-grid addition https://bugs.webkit.org/show_bug.cgi?id=72559 Reviewed by Tony Chang. * css/CSSParser.cpp: (WebCore::CSSParser::parseValue): Added the 2 new supported values (forgotten in the previous change). 2011-11-11 Adrienne Walker [chromium] Expose mock scrollbars to window.internals https://bugs.webkit.org/show_bug.cgi?id=72195 Reviewed by James Robinson. * testing/Internals.cpp: (WebCore::Internals::setMockScrollbarsEnabled): * testing/Internals.h: * testing/Internals.idl: 2011-11-16 Michael Nordman ApplicationCache manifest should work with any MIME type. https://bugs.webkit.org/show_bug.cgi?id=72082 Reviewed by Alexey Proskuryakov. * loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::didReceiveManifestResponse): Remove the test for a particular type. 2011-11-16 Daniel Sievers [Chromium] Avoid color mask operations for root layers https://bugs.webkit.org/show_bug.cgi?id=72452 Instead of relying on the combination of clearing the surface and initializing the alpha channel to 1.0 followed by disabling alpha in the color mask when rendering the root layer tiles, add shaders to support writing out opaque layers (alpha channel values written as 1.0). Reviewed by James Robinson. No functional change made that requires new tests. * platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::drawLayersInternal): (WebCore::LayerRendererChromium::initializeSharedObjects): (WebCore::LayerRendererChromium::tilerProgramOpaque): (WebCore::LayerRendererChromium::tilerProgramOpaqueAA): (WebCore::LayerRendererChromium::tilerProgramSwizzleOpaque): (WebCore::LayerRendererChromium::tilerProgramSwizzleOpaqueAA): (WebCore::LayerRendererChromium::cleanupSharedObjects): * platform/graphics/chromium/LayerRendererChromium.h: * platform/graphics/chromium/ShaderChromium.cpp: (WebCore::FragmentTexOpaqueBinding::FragmentTexOpaqueBinding): (WebCore::FragmentTexOpaqueBinding::init): (WebCore::FragmentShaderRGBATexOpaque::getShaderString): (WebCore::FragmentShaderRGBATexSwizzleOpaque::getShaderString): (WebCore::FragmentTexClampOpaqueAABinding::FragmentTexClampOpaqueAABinding): (WebCore::FragmentTexClampOpaqueAABinding::init): (WebCore::FragmentShaderRGBATexClampOpaqueAA::getShaderString): (WebCore::FragmentShaderRGBATexClampSwizzleOpaqueAA::getShaderString): * platform/graphics/chromium/ShaderChromium.h: (WebCore::FragmentTexOpaqueBinding::alphaLocation): (WebCore::FragmentTexOpaqueBinding::samplerLocation): (WebCore::FragmentTexClampOpaqueAABinding::alphaLocation): (WebCore::FragmentTexClampOpaqueAABinding::samplerLocation): (WebCore::FragmentTexClampOpaqueAABinding::fragmentTexTransformLocation): (WebCore::FragmentTexClampOpaqueAABinding::edgeLocation): * platform/graphics/chromium/cc/CCTiledLayerImpl.cpp: (WebCore::CCTiledLayerImpl::draw): * platform/graphics/chromium/cc/CCTiledLayerImpl.h: 2011-11-16 Tim Horton Implement CSS3 Images cross-fade() image function https://bugs.webkit.org/show_bug.cgi?id=52162 Reviewed by Simon Fraser. Render -webkit-cross-fade. Only cross-fades entirely composed of images will render for now, cross-fades involving generated images are not yet implemented. Reorganize GeneratedImage to be the base class for GeneratorGeneratedImage and CrossfadeGeneratedImage. Add a pending state to CSSImageGeneratorValue, which is used to enable the pending-images loading mechanism for -webkit-cross-fade's sub-images. Rework the logic in CSSStyleSelector to support pending generated images. Support parsing fractional values for the cross-fade amount (for example, 0.5 = 50%). Clamp cross-fade amount to 0-1 range. Tests: css3/images/cross-fade-invalidation.html css3/images/cross-fade-simple.html css3/images/cross-fade-sizing.html css3/images/cross-fade-tiled.html * CMakeLists.txt: * GNUmakefile.list.am: * Target.pri: * WebCore.gypi: * WebCore.xcodeproj/project.pbxproj: * css/CSSCanvasValue.h: (WebCore::CSSCanvasValue::isPending): (WebCore::CSSCanvasValue::loadSubimages): * css/CSSCrossfadeValue.cpp: (WebCore::CSSCrossfadeValue::isPending): (WebCore::CSSCrossfadeValue::loadSubimages): (WebCore::subimageIsPending): (WebCore::loadSubimage): (WebCore::cachedImageForCSSValue): (WebCore::CSSCrossfadeValue::image): (WebCore::CSSCrossfadeValue::crossfadeChanged): * css/CSSCrossfadeValue.h: (WebCore::CSSCrossfadeValue::create): (WebCore::CSSCrossfadeValue::~CSSCrossfadeValue): (WebCore::CSSCrossfadeValue::fixedSize): (WebCore::CSSCrossfadeValue::CSSCrossfadeValue): (WebCore::CSSCrossfadeValue::CrossfadeObserverProxy::CrossfadeObserverProxy): * css/CSSGradientValue.cpp: (WebCore::CSSGradientValue::image): * css/CSSGradientValue.h: (WebCore::CSSGradientValue::isPending): (WebCore::CSSGradientValue::loadSubimages): * css/CSSImageGeneratorValue.cpp: (WebCore::CSSImageGeneratorValue::generatedOrPendingImage): (WebCore::CSSImageGeneratorValue::generatedImage): (WebCore::CSSImageGeneratorValue::isPending): (WebCore::CSSImageGeneratorValue::loadSubimages): * css/CSSImageGeneratorValue.h: * css/CSSParser.cpp: (WebCore::CSSParser::parseCrossfade): * css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::styleImage): (WebCore::CSSStyleSelector::generatedOrPendingFromValue): (WebCore::CSSStyleSelector::loadPendingImage): (WebCore::CSSStyleSelector::loadPendingImages): * css/CSSStyleSelector.h: * platform/graphics/BitmapImage.h: * platform/graphics/CrossfadeGeneratedImage.cpp: Added. (WebCore::CrossfadeGeneratedImage::CrossfadeGeneratedImage): (WebCore::CrossfadeGeneratedImage::~CrossfadeGeneratedImage): (WebCore::CrossfadeGeneratedImage::drawCrossfade): (WebCore::CrossfadeGeneratedImage::draw): (WebCore::CrossfadeGeneratedImage::drawPattern): (WebCore::CrossfadeGeneratedImage::imageChanged): * platform/graphics/CrossfadeGeneratedImage.h: Added. (WebCore::CrossfadeGeneratedImage::create): (WebCore::CrossfadeSubimageObserverProxy::CrossfadeSubimageObserverProxy): (WebCore::CrossfadeSubimageObserverProxy::setReady): * platform/graphics/GeneratedImage.h: (WebCore::GeneratedImage::GeneratedImage): * platform/graphics/GeneratorGeneratedImage.cpp: Renamed from Source/WebCore/platform/graphics/GeneratedImage.cpp. (WebCore::GeneratorGeneratedImage::draw): (WebCore::GeneratorGeneratedImage::drawPattern): (WebCore::GeneratedImage::computeIntrinsicDimensions): * platform/graphics/GeneratorGeneratedImage.h: Copied from Source/WebCore/platform/graphics/GeneratedImage.h. (WebCore::GeneratorGeneratedImage::create): (WebCore::GeneratorGeneratedImage::~GeneratorGeneratedImage): (WebCore::GeneratorGeneratedImage::GeneratorGeneratedImage): * platform/graphics/Image.h: * platform/graphics/ImageBuffer.h: * rendering/style/StylePendingImage.h: (WebCore::StylePendingImage::create): (WebCore::StylePendingImage::data): (WebCore::StylePendingImage::cssImageValue): (WebCore::StylePendingImage::cssImageGeneratorValue): (WebCore::StylePendingImage::StylePendingImage): 2011-11-16 Dan Bernstein WebCore part of Add API for paginated display https://bugs.webkit.org/show_bug.cgi?id=72537 Reviewed by Anders Carlsson. * WebCore.exp.in: Exported Page::pageCount(). * page/Page.cpp: (WebCore::Page::pageCount): Added this getter. * page/Page.h: 2011-11-16 Shawn Singh [chromium] Track property changes for render surfaces. https://bugs.webkit.org/show_bug.cgi?id=72521 Reviewed by James Robinson. Created CCRenderSurfaceTest for testing. * platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::drawLayersOntoRenderSurfaces): * platform/graphics/chromium/cc/CCLayerImpl.cpp: (WebCore::CCLayerImpl::resetPropertyChangedFlagForSubtree): * platform/graphics/chromium/cc/CCLayerImpl.h: * platform/graphics/chromium/cc/CCRenderSurface.cpp: (WebCore::CCRenderSurface::CCRenderSurface): (WebCore::CCRenderSurface::setClipRect): (WebCore::CCRenderSurface::setContentRect): (WebCore::CCRenderSurface::surfacePropertyChanged): * platform/graphics/chromium/cc/CCRenderSurface.h: (WebCore::CCRenderSurface::resetPropertyChangedFlag): 2011-11-16 Ben Wells Seaming on border corners with mixed colour alpha borders https://bugs.webkit.org/show_bug.cgi?id=70471 Reviewed by Simon Fraser. Seaming is fixed by antialiasing mitred corners for edges that have alpha and are joining a side that is of a different color. Test: fast/borders/border-mixed-alpha.html * rendering/RenderBoxModelObject.cpp: (WebCore::colorNeedsAntiAliasAtCorner): (WebCore::RenderBoxModelObject::paintOneBorderSide): 2011-11-16 Sam Weinig JS wrappers of DOM objects should have no-op constructors https://bugs.webkit.org/show_bug.cgi?id=72556 Reviewed by Geoffrey Garen. Stop using a RefPtr to hold DOM objects contained by JavaScript wrappers and instead use a raw pointer. We were already releasing the underlying object before the destructor ran (via the finalizer) so the default behavior of destroying the RefPtr is always unnecessary busy work. * bindings/js/JSCSSValueCustom.cpp: (WebCore::JSCSSValueOwner::finalize): * bindings/js/JSNodeCustom.cpp: (WebCore::JSNodeOwner::finalize): (WebCore::JSNode::visitChildren): Call releaseImpl() instead of clearImpl(). * bindings/scripts/CodeGeneratorJS.pm: (GenerateHeader): Stop storing m_impl in a RefPtr and instead use a raw pointer. Switch clearImpl() to releaseImpl(), which explicitly derefs the pointer and clear it. (GenerateImplementation): Use leakPtr() to explicitly adopt the PassRefPtr into the raw pointer. Change default finalize to call releaseImpl() instead of clearImpl(). 2011-11-16 Michael Saboff Enable 8 Bit Strings in JavaScriptCore https://bugs.webkit.org/show_bug.cgi?id=71337 This patch turns on 8 bit strings in StringImpl and enables their use in JavaScriptCore. Some of the changes are to turn on code that had been staged (Lexer.cpp, Identifier.cpp, SmallStrings.cpp and some of StringImpl.{h,cpp}). Other changes are minor fixes to make 8 bit strings work (UString.h, StringImpl::getData16SlowCase()). Changed StringBuffer to be a templated class based on character type. This change riplled into WebCore code as well. Reviewed by Geoffrey Garen. No new tests - Changes in response to refactoring StringBuffer to be a template on character type. * css/CSSParser.cpp: (WebCore::quoteCSSString): * css/CSSPrimitiveValue.cpp: (WebCore::formatNumber): * dom/Document.cpp: (WebCore::canonicalizedTitle): * platform/Length.cpp: (WebCore::newCoordsArray): * platform/sql/SQLiteStatement.cpp: (WebCore::SQLiteStatement::prepare): * platform/text/TextCodecUTF16.cpp: (WebCore::TextCodecUTF16::decode): * platform/text/TextCodecUTF8.cpp: (WebCore::TextCodecUTF8::decode): * rendering/RenderText.cpp: (WebCore::makeCapitalized): * xml/XSLTProcessorLibxslt.cpp: (WebCore::writeToStringBuilder): 2011-11-16 Alexandre Elias [chromium] Improvements for page scale delta during commit https://bugs.webkit.org/show_bug.cgi?id=72471 Reviewed by James Robinson. Page scale now follows the same commit flow as scroll position: the delta is folded into m_pageScale at BFAC time, and a "sent" value is preserved for temporary use until the commit finishes. I also merged setPageScaleFactor and setPageScaleFactorLimits into one function on the impl side. The reason is that setPageFactor must be applied after the limits are updated, but on the other hand setting the limits first may cause an unnecessary clamp of the scale delta. Merging the methods avoids this bind. No new tests. (planning to add later: https://bugs.webkit.org/show_bug.cgi?id=71529) * platform/graphics/chromium/cc/CCLayerTreeHost.cpp: (WebCore::CCLayerTreeHost::finishCommitOnImplThread): (WebCore::CCLayerTreeHost::applyScrollAndScale): * platform/graphics/chromium/cc/CCLayerTreeHostCommon.h: * platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp: (WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl): (WebCore::CCLayerTreeHostImpl::setPageScaleFactorAndLimits): (WebCore::CCLayerTreeHostImpl::adjustScrollsForPageScaleChange): (WebCore::CCLayerTreeHostImpl::setScaleDelta): (WebCore::CCLayerTreeHostImpl::applyScaleDeltaToScrollLayer): (WebCore::CCLayerTreeHostImpl::scrollRootLayer): (WebCore::CCLayerTreeHostImpl::processScrollDeltas): * platform/graphics/chromium/cc/CCLayerTreeHostImpl.h: 2011-11-16 Joshua Bell IndexedDB: Reduce nested key depth threshold, re-enable flaky test https://bugs.webkit.org/show_bug.cgi?id=72529 Reviewed by Adam Barth. Drop maximum array key depth from 20k to 2k. * bindings/v8/IDBBindingUtilities.cpp: 2011-11-16 Nate Chapin Fix incorrect multipart handling in r100311. SubresourceLoader::didReceiveData() is getting called twice, which has unintended side effects. https://bugs.webkit.org/show_bug.cgi?id=72436 Reviewed by Adam Barth. http/tests/multipart/invalid-image-data.html should stop asserting after this. * loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::didReceiveResponse): (WebCore::SubresourceLoader::didReceiveData): (WebCore::SubresourceLoader::sendDataToResource): * loader/SubresourceLoader.h: 2011-11-16 Justin Schuh Clear SVG filter client when its node is detached https://bugs.webkit.org/show_bug.cgi?id=71741 Reviewed by Eric Seidel. Test: svg/filters/reparent-animated-filter-target.html * rendering/svg/SVGResourcesCache.cpp: (WebCore::SVGResourcesCache::clientDestroyed): 2011-11-16 John Bates Page/layer flashes after GPU-accelerated CSS transition https://bugs.webkit.org/show_bug.cgi?id=72343 LayerRendererChromium was resizing the window to 1x1 at initialization. In some cases, there is no drawLayers before switching back to software rendering. This left the window resized to 1x1 and the following software paints would therefore not be visible. This change moves the reshape call into drawLayers so that it will only be called if rendering will occur. Reviewed by James Robinson. New test: CCLayerTreeHostImplTest.reshapeNotCalledUntilDraw. * platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::viewportChanged): (WebCore::LayerRendererChromium::doViewportChanged): (WebCore::LayerRendererChromium::drawLayersInternal): * platform/graphics/chromium/LayerRendererChromium.h: 2011-11-16 Alexandre Elias [chromium] Add null pointer check in setDeviceScaleFactor https://bugs.webkit.org/show_bug.cgi?id=72464 Reviewed by James Robinson. No new tests. (Tiny fix.) * page/Page.cpp: (WebCore::Page::setDeviceScaleFactor): 2011-11-16 Sheriff Bot Unreviewed, rolling out r100438. http://trac.webkit.org/changeset/100438 https://bugs.webkit.org/show_bug.cgi?id=72536 Broke unit tests (Requested by jamesr_ on #webkit). * platform/PlatformScreen.h: * platform/chromium/PlatformScreenChromium.cpp: * platform/chromium/PlatformSupport.h: * platform/graphics/chromium/cc/CCLayerTreeHost.h: (WebCore::CCSettings::CCSettings): * platform/graphics/chromium/cc/CCThreadProxy.cpp: (WebCore::CCThreadProxy::initializeImplOnImplThread): 2011-11-16 Andy Estes Assertion failure in LayerFlushScheduler::resume() when running some layout tests in WebKitTestRunner https://bugs.webkit.org/show_bug.cgi?id=72535 Reviewed by Anders Carlsson. LayerFlushScheduler attempted to use a counter strategy for calls to suspend() and resume(), which allowed us to assert that these calls were balanced. Unfortunately it is hard to guarantee this in WebKit2, where we sometimes try to call suspend() before we've entered compositing mode (hence before we have a LayerTreeHost and a LayerFlushScheduler). When we later call resume(), this call ends up being unbalanced and asserts. For now, remove the assertions and allow unbalanced calls to suspend() and resume(). * platform/graphics/ca/LayerFlushScheduler.cpp: (WebCore::LayerFlushScheduler::suspend): (WebCore::LayerFlushScheduler::resume): * platform/graphics/ca/LayerFlushScheduler.h: * platform/graphics/ca/mac/LayerFlushSchedulerMac.cpp: (WebCore::LayerFlushScheduler::LayerFlushScheduler): (WebCore::LayerFlushScheduler::runLoopObserverCallback): (WebCore::LayerFlushScheduler::schedule): 2011-11-16 Sheriff Bot Unreviewed, rolling out r100473. http://trac.webkit.org/changeset/100473 https://bugs.webkit.org/show_bug.cgi?id=72534 "Broke the Mac Build" (Requested by mwenge2 on #webkit). * CMakeLists.txt: * GNUmakefile.list.am: * Target.pri: * WebCore.gypi: * rendering/RenderBlock.cpp: (WebCore::RenderBlock::addChildIgnoringAnonymousColumnBlocks): * rendering/RenderObject.cpp: (WebCore::RenderObject::createObject): (WebCore::RenderObject::addChild): * rendering/RenderObject.h: * rendering/RenderTable.cpp: (WebCore::RenderTable::addChild): * rendering/RenderTable.h: * rendering/RenderTableCaption.cpp: Removed. * rendering/RenderTableCaption.h: Removed. 2011-11-16 Sheriff Bot Unreviewed, rolling out r100479. http://trac.webkit.org/changeset/100479 https://bugs.webkit.org/show_bug.cgi?id=72533 "Broke the Mac Build" (Requested by mwenge2 on #webkit). * WebCore.vcproj/WebCore.vcproj: * WebCore.xcodeproj/project.pbxproj: * rendering/RenderingAllInOne.cpp: 2011-11-16 Chris Fleizach WebKitTestRunner needs to support accessibility-related DRT APIs https://bugs.webkit.org/show_bug.cgi?id=42131 Minor changes needed to support AX testing in WKTestRunner. Reviewed by Beth Dakin. * WebCore.exp.in: Expose focusedUIElementForPage so that the WK2 injected bundle can retrieve it. * accessibility/mac/WebAccessibilityObjectWrapper.mm: (accessibilitySearchKeyForString): Remove an unncessary assert that was causing issues with the WK2 test run. 2011-11-16 Sergio Villar Senin [Soup] Somet tests fail with FAIL Unexpected response data received: Wrong method: GET https://bugs.webkit.org/show_bug.cgi?id=69219 Reviewed by Martin Robinson. Do not stop appending data to the request body if any of the blob items to upload is not accesible. * platform/network/soup/ResourceHandleSoup.cpp: (WebCore::addEncodedBlobToSoupMessageBody): 2011-11-16 Beth Dakin https://bugs.webkit.org/show_bug.cgi?id=72400 Scrollbar uiStateTransitionProgress requires tracking the mouse all the time -and corresponding- Reviewed by Darin Adler. This patch makes it so we track the mouse all the time when we have legacy scrollbars (rather than only tracking the mouse when the window is key). When we're in that mode, we want to do as little work as possible when handling the mouseMoved event so that this extra tracking has little to no performance impact. Also, we don't want to change basic behaviors by having normal web content hover effects start happening when a window is in the background. So this patch also introduces a way to handle a mouseMoved event that will only affect scrollbars. EventHandler::mouseMoved() and EventHandler::handleMouseEvent() both now take a boolean parameter that indicates if we are only updating scrollbars. If that is the case, then we make our HitTestRequest ReadOnly, and we return early once updateLastScrollbarUnderMouse() is called. * WebCore.exp.in: * page/EventHandler.cpp: (WebCore::EventHandler::mouseMoved): (WebCore::EventHandler::handleMouseMoveEvent): In addition to calling Scrollbar::mouseExited() when appropriate, this function now calls a new function, Scrollbar::mouseEntered() when appropriate. (WebCore::EventHandler::updateLastScrollbarUnderMouse): * page/EventHandler.h: Scrollbar::mouseMoved() used to be responsible for calling ScrollAnimator::mouseEnteredScrollbar(), but now Scrollbar::mouseEntered() takes care of that instead, much like how Scrollbar::mouseExited() takes care of calling the animator's exit function. * platform/Scrollbar.cpp: (WebCore::Scrollbar::mouseMoved): (WebCore::Scrollbar::mouseEntered): * platform/Scrollbar.h: 2011-11-16 Andreas Kling CSSValue: isInheritedValue() doesn't need a dedicated bit. Reviewed by Antti Koivisto. Remove CSSValue::m_isInherited and have isInheritedValue() check the class type instead. There's no compelling reason for CSSInheritedValue to have a dedicated bit, since nobody subclasses it anyway. * css/CSSValue.h: (WebCore::CSSValue::isInheritedValue): (WebCore::CSSValue::CSSValue): 2011-11-16 Robert Hogan Fix build on Windows and Mac after r100473 Unreviewed, fix build. * WebCore.vcproj/WebCore.vcproj: * WebCore.xcodeproj/project.pbxproj: * rendering/RenderingAllInOne.cpp: 2011-11-16 Philip Rogers Remove extra GraphicsContextStateSaver restore() call. https://bugs.webkit.org/show_bug.cgi?id=72497 Reviewed by Andreas Kling. * html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::drawTextInternal): 2011-11-08 Robert Hogan CSS 2.1 failure: border-collapse-offset-002.htm fails https://bugs.webkit.org/show_bug.cgi?id=71705 Table captions are implemented as children of the table but have a special requirement to expand to the full width of the table rather than just the 'available' width, i.e. the full width minus padding and borders. To accomodate this create a RenderTableCaption object that reimplements containingBlockLogicalWidthForContent() to return the full width of the containing block (i.e. the table) rather than the available width. Reviewed by Antti Koivisto. * CMakeLists.txt: Add RenderTableCaption.[cpp|h] * GNUmakefile.list.am: Add RenderTableCaption.[cpp|h] * Target.pri: Add RenderTableCaption.[cpp|h] * WebCore.gypi: Add RenderTableCaption.[cpp|h] * rendering/RenderBlock.cpp: (WebCore::RenderBlock::addChildIgnoringAnonymousColumnBlocks): Use RenderTableCaption * rendering/RenderObject.cpp: (WebCore::RenderObject::createObject): Add RenderTableCaption.[cpp|h] (WebCore::RenderObject::addChild): ditto * rendering/RenderObject.h: (WebCore::RenderObject::isTableCaption): * rendering/RenderTable.cpp: (WebCore::RenderTable::addChild): * rendering/RenderTable.h: * rendering/RenderTableCaption.cpp: Added. (WebCore::RenderTableCaption::RenderTableCaption): Implement RenderTableCaption (WebCore::RenderTableCaption::~RenderTableCaption): (WebCore::RenderTableCaption::containingBlockLogicalWidthForContent): Return the containing block's full width rather than it's available width. * rendering/RenderTableCaption.h: Added. (WebCore::RenderTableCaption::isTableCaption): (WebCore::toRenderTableCaption): 2011-11-16 Antaryami Pandia [Gtk] display:none has no effect on