2012-02-21 Dirk Pranke webkitpy: update names after deleting message_broker https://bugs.webkit.org/show_bug.cgi?id=79000 Reviewed by Eric Seidel. Part 3 of 3 in deleting message_broker.py; this change just adjusts the names for the newly merged symbols so that they are private as appropriate. * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py: (get): (_Broker): (_BrokerConnection): (_BrokerConnection.__init__): (AbstractWorker.__init__): (_ManagerConnection): (_ManagerConnection.__init__): (_WorkerConnection): (_WorkerConnection.__init__): 2012-02-21 Dirk Pranke webkitpy: merge message_broker.py into manager_worker_broker.py https://bugs.webkit.org/show_bug.cgi?id=78999 Reviewed by Tony Chang. This is pretty much a straight cut-and-paste of one file into another (broken up so that docstrings and imports are in the right place). * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py: (BrokerClient): (BrokerClient.is_done): (BrokerClient.name): (Broker): (Broker.__init__): (Broker.add_topic): (Broker._get_queue_for_topic): (Broker.post_message): (Broker.run_message_loop): (Broker.run_all_pending): (Broker._run_loop): (Broker._dispatch_message): (_Message): (_Message.loads): (_Message.__init__): (_Message.dumps): (_Message.__repr__): (BrokerConnection): (BrokerConnection.__init__): (BrokerConnection.run_message_loop): (BrokerConnection.post_message): (BrokerConnection.raise_exception): * Scripts/webkitpy/layout_tests/controllers/message_broker.py: Removed. 2012-02-21 Dirk Pranke webkitpy: prepare to delete message_broker.py https://bugs.webkit.org/show_bug.cgi?id=78997 Reviewed by Eric Seidel. This is part 1 of 3 changes to fix bug 78187. This change prepares the code for merging message_broker.py into manager_worker_broker.py; the tests in message_broker_unittest are merged into manager_worker_broker_unittest, the symbols needed by the tests are exported from manager_worker_broker.py, and manager_worker_broker itself is updated to refer to the symbols directly (without the module prefix). * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py: (get): (AbstractWorker): (AbstractWorker.__init__): (_ManagerConnection): (_ManagerConnection.__init__): (_WorkerConnection): (_WorkerConnection.__init__): * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py: (InterfaceTest.test_brokerclient_is_abstract): (InterfaceTest.test_brokerclient_is_abstract.methods): (MessageTest): (MessageTest.test__no_body): (MessageTest.test__body): * Scripts/webkitpy/layout_tests/controllers/message_broker_unittest.py: Removed. 2012-02-21 Sam Weinig Attempt to fix the Snow Leopard build. * DumpRenderTree/mac/Configurations/Base.xcconfig: * MiniBrowser/Configurations/Base.xcconfig: * TestWebKitAPI/Configurations/Base.xcconfig: * WebKitTestRunner/Configurations/Base.xcconfig: 2012-02-21 Sam Weinig Use libc++ when building with Clang on Mac https://bugs.webkit.org/show_bug.cgi?id=78981 Reviewed by Dan Bernstein. * DumpRenderTree/mac/Configurations/Base.xcconfig: * MiniBrowser/Configurations/Base.xcconfig: * TestWebKitAPI/Configurations/Base.xcconfig: * WebKitTestRunner/Configurations/Base.xcconfig: 2012-02-21 Adam Roben Roll out r108309, r108323, and r108326 They broke the 32-bit Lion build. Original bugs is . * DumpRenderTree/efl/CMakeLists.txt: 2012-02-21 Andras Becsi [Qt][WK2] Get rid of the dependency to QtWidgets https://bugs.webkit.org/show_bug.cgi?id=76276 Reviewed by Simon Hausmann. * MiniBrowser/qt/MiniBrowser.pro: * MiniBrowser/qt/MiniBrowserApplication.cpp: (MiniBrowserApplication::MiniBrowserApplication): (MiniBrowserApplication::notify): (MiniBrowserApplication::sendTouchEvent): * MiniBrowser/qt/MiniBrowserApplication.h: (MiniBrowserApplication): * QtTestBrowser/locationedit.h: * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp: (WTR::activateFonts): * WebKitTestRunner/qt/PlatformWebViewQt.cpp: 2012-02-20 Adam Barth mastercfg_unittest.py fails without simplejson https://bugs.webkit.org/show_bug.cgi?id=79070 Reviewed by Csaba Osztrogonác. Now that we require Python 2.6 (and higher) we can import json rather than simplejson. We still need to use the simplejson name because that's what the master.cfg script expects. * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: (BuildBotConfigLoader._add_dependant_modules_to_sys_modules): 2012-02-20 Filip Pizlo JSC should be a triple-tier VM https://bugs.webkit.org/show_bug.cgi?id=75812 Reviewed by Gavin Barraclough. Changed EFL's build system to include a new directory in JavaScriptCore. * DumpRenderTree/efl/CMakeLists.txt: 2012-02-20 Kenichi Ishibashi Update pywebsocket to 0.7.2 https://bugs.webkit.org/show_bug.cgi?id=79066 This version includes vendor-prefixed deflate-frame extension support. Reviewed by Kent Tamura. * Scripts/webkitpy/thirdparty/__init__.py: (AutoinstallImportHook._install_pywebsocket): 2012-02-20 Martin Robinson [UNIX] Plugin information fields are not interpreted as UTF-8 https://bugs.webkit.org/show_bug.cgi?id=78635 Reviewed by Gustavo Noronha Silva. Interpret plugin metadata as UTF8 aways. This matches the behavior of Chromium and the Totem plugin. * DumpRenderTree/TestNetscapePlugIn/main.cpp: (NPP_GetValue): Include a UTF-8 character in the description string for testing purposes. 2012-02-20 Martin Robinson [GTK] [Qt] Move the unix forwarding headers for TestNetscapePlugin to the TestNetscapePlugin directory https://bugs.webkit.org/show_bug.cgi?id=78935 Reviewed by Gustavo Noronha Silva. Move the TestNetscapePlugin headers to a more appropriate directory and update the build files to match. * DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npapi.h: Renamed from Tools/DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npapi.h. * DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npfunctions.h: Renamed from Tools/DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npfunctions.h. * DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npruntime.h: Renamed from Tools/DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npruntime.h. * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: Update build. * GNUmakefile.am: Ditto. 2012-02-20 Kihong Kwon Add a new API for the Vibration API(W3C). https://bugs.webkit.org/show_bug.cgi?id=72010 Reviewed by Hajime Morita. * Scripts/build-webkit: Enable ENABLE_VIBRATION feature. 2012-02-20 János Badics [Qt] run-qtwebkit-tests doesn't consider timeouts as failures https://bugs.webkit.org/show_bug.cgi?id=71816 RunQtAPITests will notify if a timeout occurs during testing. Added unittest to the master.cfg Reviewed by Csaba Osztrogonác. * BuildSlaveSupport/build.webkit.org-config/master.cfg: (RunQtAPITests.evaluateCommand): * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: (RunQtAPITestsTest): (RunQtAPITestsTest.assertResults): (RunQtAPITestsTest.test_timeout): (test_success): (test_failure): (test_timeout_and_failure): 2012-02-20 Andy Wingo Add wingo as a committer. Unreviewed. * Scripts/webkitpy/common/config/committers.py: Add myself to the committers list. 2012-02-20 Jochen Eisinger [chromium] check that we're not running multiple modal dialogs at the same time https://bugs.webkit.org/show_bug.cgi?id=78486 Reviewed by Kent Tamura. * DumpRenderTree/chromium/TestShell.cpp: (TestShell::TestShell): * DumpRenderTree/chromium/TestShell.h: (TestShell::setIsDisplayingModalDialog): (TestShell::isDisplayingModalDialog): (TestShell): * DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::runModal): 2012-02-20 Martin Robinson Fix WebKit2GTK+ for 'make distcheck'. Instead of conditionally including WebKit2 GNUmakefiles, always include them and conditionally activate the final targets. * MiniBrowser/gtk/GNUmakefile.am: * WebKitTestRunner/GNUmakefile.am: 2012-02-20 Gyuyoung Kim Enable video option for EFL port in build-webkit. https://bugs.webkit.org/show_bug.cgi?id=79006 Reviewed by Daniel Bates. * Scripts/build-webkit: 2012-02-19 JungJik Lee [EFL] Use modifier keys to execute pre-rendering. https://bugs.webkit.org/show_bug.cgi?id=77933 Reviewed by Chang Shu. Use modifier key to execute pre-rendering instead of using reserved function keys. * EWebLauncher/main.c: (on_key_down): 2012-02-18 Dirk Pranke Fix one more dangling reference to worker_connection.name, delete unused code. Unreviewed, build fix. * Scripts/webkitpy/layout_tests/controllers/manager.py: (Manager.update): (_WorkerState.__init__): 2012-02-18 Dirk Pranke Add a change that should've been in r108005. Unreviewed, build fix. In the refactoring/cleanup in r108005 I should've changed the implementation of WorkerConnection to make it match BrokerClient (and everything else) so that objects had a name() method instead of a name property. * Scripts/webkitpy/layout_tests/controllers/manager.py: (Manager._run_tests): * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py: (_WorkerConnection.__init__): (_WorkerConnection.name): * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py: (_TestWorker.__init__): (_TestsMixin.name): (_TestsMixin.test_name): (_TestsMixin.test_cancel): (_TestsMixin.test_unknown_message): 2012-02-18 Dirk Pranke webkitpy: remove webkitpy.common.array_stream https://bugs.webkit.org/show_bug.cgi?id=78952 Reviewed by Eric Seidel. Turns out array_stream didn't really do anything that StringIO didn't do (at least as of Python 2.6). This change removes it and updates all of the callers. Where possible, I changed the test assertions in order to capture the intent more clearly, e.g., instead of calling self.assertTrue('foo' in stream.get()), we have self.assertContainsLine(stream, 'foo'), and instead of self.assertTrue(stream.empty()), we have self.assertEmpty(stream) - the latter isn't that much more readable, but StringIO doesn't export an empty() method. * Scripts/webkitpy/common/array_stream.py: Removed. * Scripts/webkitpy/common/array_stream_unittest.py: Removed. * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: (passing_run): (run_and_capture): (StreamTestingMixin): (StreamTestingMixin.assertContains): (StreamTestingMixin.assertContainsLine): (StreamTestingMixin.assertEmpty): (StreamTestingMixin.assertNotEmpty): (LintTest): (LintTest.test_lint_test_files): (LintTest.test_lint_test_files__errors): (MainTest): (MainTest.test_child_process_1): (MainTest.test_child_processes_2): (MainTest.test_child_processes_min): (MainTest.test_help_printing): (MainTest.test_hung_thread): (MainTest.test_no_tests_found): (MainTest.test_no_tests_found_2): (MainTest.test_repeat_each_iterations_num_tests): (MainTest.test_test_list): (MainTest.test_unexpected_failures): (MainTest.test_worker_model__inline_with_child_processes): (MainTest.test_additional_platform_directory): (RebaselineTest): (RebaselineTest.assertBaselines): (RebaselineTest.test_reset_results): (RebaselineTest.test_missing_results): (RebaselineTest.test_new_baseline): * Scripts/webkitpy/layout_tests/views/metered_stream.py: (MeteredStream.update): * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py: (TestMeteredStream.test_regular): * Scripts/webkitpy/layout_tests/views/printing_unittest.py: (TestUtilityFunctions.assertEmpty): (TestUtilityFunctions): (TestUtilityFunctions.assertNotEmpty): (TestUtilityFunctions.assertWritten): (TestUtilityFunctions.test_configure_logging): (Testprinter.assertEmpty): (Testprinter): (Testprinter.assertNotEmpty): (Testprinter.assertWritten): (Testprinter.reset): (Testprinter.get_printer): (Testprinter.test_help_printer): (Testprinter.do_switch_tests.do_helper): (Testprinter.test_print_one_line_summary): (Testprinter.test_print_test_result): (Testprinter.test_print_progress): (Testprinter.test_write_nothing): (Testprinter.test_write_misc): (Testprinter.test_write_everything): (Testprinter.test_write_verbose): (Testprinter.test_print_unexpected_results): * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py: (MainTest.assertWritten): (create_runner): (test_run_test_set): (test_run_test_set_kills_drt_per_run): (test_run_test_set_for_parser_tests): (test_run_test_set_with_json_output): (test_run_test_set_with_json_source): (test_run_test_set_with_multiple_repositories): (test_upload_json): 2012-02-18 Kevin Ollivier [wx] Add the WebCore/page/scrolling directory to the build dirs. * waf/build/settings.py: 2012-02-18 Kevin Ollivier [wx] Unreviewed build fix. Don't error out or hang if we have downloaded dependencies but server update check fails. * waf/build/build_utils.py: (download_if_newer): 2012-02-17 Dirk Pranke The new run-webkit-tests needs to dump out pixel hash failures even if the pixel test passes. https://bugs.webkit.org/show_bug.cgi?id=69444 Reviewed by Tony Chang. Currently if a test's image checksum doesn't match the checksum in the baseline, but the images themselves match according to ImageDiff, new-run-webkit-tests ignores the problem. This is probably bad, but it's not yet clear what the right thing to do is. This patch will log a warning to stderr, at least (but the test will still pass). * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py: (SingleTestRunner._compare_image): (SingleTestRunner._run_reftest): * Scripts/webkitpy/layout_tests/port/test.py: (unit_test_list): * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: 2012-02-17 Dirk Pranke NRWT does not report failure for a skipped test https://bugs.webkit.org/show_bug.cgi?id=78750 Reviewed by Eric Seidel. If a test is listed in a Skipped file and you run it anyway with --force, and the test fails, currently NRWT will print "test ran as expected"; this is confusing, because you probably expect the test to fail and yet this might lead you to think the test passed. This patch changes the expected behavior to "PASS", so tests that fail will be reported. * Scripts/webkitpy/layout_tests/models/test_expectations.py: (result_was_expected): (TestExpectationParser): (TestExpectationParser.expectation_for_skipped_test): (TestExpectations): * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: (test_add_skipped_tests): * Scripts/webkitpy/layout_tests/port/test.py: (unit_test_list): Add some tests that are expected to be in a Skipped file. (TestPort.skipped_tests): This adds actual integration test coverage of Skipped files. 2012-02-17 Dirk Pranke webkitpy: fix test code after bug 78181 https://bugs.webkit.org/show_bug.cgi?id=78870 Reviewed by Adam Barth. I forgot to update the test code as per Tony's suggestion in bug 78181 (r108005). This change does that, and in doing so it revealed a subtle bug in _InlineWorkerConnection.run() that I am fixing as part of this (_alive would not be cleared if an exception was thrown). * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py: (_InlineWorkerConnection.run): * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py: (_TestWorker.__init__): (_TestWorker.handle_stop): (_TestWorker.handle_test): (_TestWorker.run): (_TestsMixin.handle_exception): (_TestsMixin.test_unknown_message): 2012-02-17 Adam Roben Mac build fix after r108119 * DumpRenderTree/mac/DumpRenderTree.mm: (runThread): (runPthread): (testThreadIdentifierMap): Updated to match current WTF threading APIs. 2012-02-17 Dirk Pranke revert r107147 - breaks webkit-patch on Mac SL https://bugs.webkit.org/show_bug.cgi?id=78866 Reviewed by Adam Barth. It appears that zipfile.ExtractAll is broken on Python 2.6.1, which is the version that ships on Mac SL. Reverting this change until we no longer have to worry about that version. * Scripts/webkitpy/common/system/autoinstall.py: (AutoInstaller): (AutoInstaller._extract_all): Added a comment about SL. (AutoInstaller._unzip): 2012-02-17 Mihnea Ovidenie CSS regions enabled by default https://bugs.webkit.org/show_bug.cgi?id=78525 Reviewed by David Hyatt. Add a runtime preference to enable/disable regions functionality at runtime(WebKitCSSRegionsEnabled). CSSRegions are still enabled by default. In DRT, use layoutTestController.overridePreference("WebKitCSSRegionsEnabled", "0") to disable the css regions functionality. * DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::overridePreference): * DumpRenderTree/chromium/WebPreferences.cpp: (WebPreferences::reset): (WebPreferences::applyTo): * DumpRenderTree/chromium/WebPreferences.h: (WebPreferences): * DumpRenderTree/mac/DumpRenderTree.mm: (resetDefaultsToConsistentValues): 2012-02-17 Maciej Stachowiak Some API tests erroneously use = instead of == (causing build failures) https://bugs.webkit.org/show_bug.cgi?id=78915 Reviewed by Sam Weinig. * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp: (TestWebKitAPI::decidePolicyForNavigationAction): Replace an = with an == (TestWebKitAPI::decidePolicyForNewWindowAction): ditto 2012-02-17 Peter Beverloo [Chromium] Include TestShellLinux.cpp in the build for Android https://bugs.webkit.org/show_bug.cgi?id=78865 Reviewed by Eric Seidel. Android will be re-using the TestShellLinux.cpp file. I already added this r104033, but it seems to have gotten lost in the recent refactorings. * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: 2012-02-17 Gyuyoung Kim Unreviewed, disable video build on EFL until it can be supported by EFL build bot. * Scripts/build-webkit: 2012-02-17 Carlos Garcia Campos [GTK] Implement zoom in/out in MiniBrowser https://bugs.webkit.org/show_bug.cgi?id=75253 Reviewed by Gustavo Noronha Silva. * MiniBrowser/gtk/BrowserWindow.c: (browserWindowCanZoomIn): (browserWindowCanZoomOut): (browserWindowUpdateZoomActions): (webViewZoomLevelChanged): (zoomInCallback): (zoomOutCallback): (browser_window_init): (browserWindowConstructed): 2012-02-17 Nikolas Zimmermann layoutTestController.display() is flaky for SVG tests https://bugs.webkit.org/show_bug.cgi?id=78021 Reviewed by Adam Roben. Apply the same fix to DRT/Win, as previously applied to DRT/Mac. Size the web view before running the test, not when dumping. All platforms handle this correctly now. * DumpRenderTree/win/DumpRenderTree.cpp: (dump): (sizeWebViewForCurrentTest): (runTest): 2012-02-16 Carlos Garcia Campos [GTK] Make install is broken when building without --enable-gtk-doc https://bugs.webkit.org/show_bug.cgi?id=78828 Reviewed by Martin Robinson. * gtk/generate-gtkdoc: (rebase_installed_docs): Check documentation has been generated before trying to rebase it. 2012-02-16 Dirk Pranke nrwt: simplify worker interface https://bugs.webkit.org/show_bug.cgi?id=78181 Reviewed by Tony Chang. This change moves code in name(), is_done(), run(), and cancel() from Worker to AbstractWorker, since the logic is pretty much boilerplate code that any implementation would want to use. * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py: (get.should): (AbstractWorker.__init__): (AbstractWorker): (AbstractWorker.name): (AbstractWorker.stop_handling_messages): (AbstractWorker.run): (AbstractWorker.is_done): (AbstractWorker.cancel): * Scripts/webkitpy/layout_tests/controllers/worker.py: (Worker.__init__): (Worker.run): (Worker.handle_stop): 2012-02-16 Michael Saboff ENH: Add ability to run subset of JavaScript layout tests with JSC https://bugs.webkit.org/show_bug.cgi?id=78764 Reviewed by Gavin Barraclough. New simple test drive shell script that runs a defined list of javascript tests using jsc and the standalone-{pre,post}.js wrappers. * Scripts/run-fast-jsc: Added. 2012-02-16 Csaba Osztrogonác Add new Qt performance tester bot to build.webkit.org https://bugs.webkit.org/show_bug.cgi?id=78795 Reviewed by Adam Roben. * BuildSlaveSupport/build.webkit.org-config/config.json: 2012-02-16 Patrick Gansterer Disable inspector on WinCE. Avoid compiling InspectorBackendDispatcher.cpp, which causes an internal compiler error. * Scripts/build-webkit: 2012-02-16 Patrick Gansterer WinCE build fix after r107656. Disable FTPDIR on WinCE, since it does not compile there. * Scripts/build-webkit: 2012-02-15 Leo Yang Build fix after r107863. * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp: 2012-02-15 Tony Chang [chromium] add linux dbg back to garden-o-matic https://bugs.webkit.org/show_bug.cgi?id=78752 Reviewed by Adam Barth. This reflects the current linux debug bot name (there's only one bot). I'm also remove the mac clang builder since it doesn't exist (mac always uses clang now). * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js: * Scripts/webkitpy/layout_tests/port/builders.py: 2012-02-15 Sam Weinig Add style check for ctype functions that are generally frowned upon in WebKit https://bugs.webkit.org/show_bug.cgi?id=78748 Reviewed by Anders Carlsson. Not every platform has DisallowCType.h to check for uses of the ctype.h functions, so add a style check for them as well. * Scripts/webkitpy/style/checkers/cpp.py: (check_ctype_functions): (check_style): (CppChecker): Add check. * Scripts/webkitpy/style/checkers/cpp_unittest.py: (WebKitStyleTest.test_ctype_fucntion): Add checker. 2012-02-15 Szilard Ledan [Qt][WK2] WebKitTestRunner should use 480x360 sized view for W3C SVG tests https://bugs.webkit.org/show_bug.cgi?id=76546 Reviewed by Simon Hausmann. Resize the web view programatically because the declarative property binding does not work. Seems like our qml environment is not initialized fully but it needs more investigation. * WebKitTestRunner/qt/PlatformWebViewQt.cpp: (WTR::WrapperWindow::handleStatusChanged): (WTR::PlatformWebView::resizeTo): 2012-02-15 Dirk Pranke webkitpy: add a worker_args concept to start_worker() https://bugs.webkit.org/show_bug.cgi?id=78572 Reviewed by Tony Chang. This change replaces the three NRWT-specific arguments passed through the broker to the worker with a generic WorkerArguments wrapper class and a separate set_inline_arguments() call that can be used to pass additional data to the worker when it is running in the same process as the manager (this is needed for testing). With the addition of set_inline_arguments() we also no longer need to pass an optional argument to the worker.run() call. Note that this method is *only* implemented on inline workers, so calling this on a regular (child process) worker will result in a runtime error. * Scripts/webkitpy/layout_tests/controllers/manager.py: (Manager._run_tests): * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py: (AbstractWorker.__init__): (AbstractWorker.run): (_ManagerConnection.start_worker): (_InlineManager.start_worker): (_InlineManager.set_inline_arguments): (_InlineManager.run_message_loop): (_MultiProcessManager.start_worker): Reworked signature. (_WorkerConnection.__init__): (_InlineWorkerConnection.__init__): (_InlineWorkerConnection.set_inline_arguments): New method. (_InlineWorkerConnection): (_InlineWorkerConnection.run): (_Process.run): (_MultiProcessWorkerConnection.__init__): * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py: (_TestWorker.__init__): (_TestWorker.set_inline_arguments): (_TestWorker.handle_test): (_TestWorker.run): (_TestsMixin.test_cancel): (_TestsMixin.test_done): (_TestsMixin.test_unknown_message): (InlineBrokerTests): New class for more testing. (InlineBrokerTests.setUp): (InlineBrokerTests.test_inline_arguments): New test. (InterfaceTest.test_managerconnection_is_abstract): (InterfaceTest.test_workerconnection_is_abstract): * Scripts/webkitpy/layout_tests/controllers/worker.py: (WorkerArguments): (WorkerArguments.__init__): (Worker.__init__): (Worker.set_inline_arguments): (Worker): (Worker.run): * Scripts/webkitpy/layout_tests/controllers/worker_unittest.py: (WorkerTest.test_default_platform_in_worker): 2012-02-15 Adam Klein Unreviewed, rolling out r107704. http://trac.webkit.org/changeset/107704 https://bugs.webkit.org/show_bug.cgi?id=78486 Caused layout test crashes in debug builds. Specific crashing tests: fast/events/show-modal-dialog-onblur-onfocus.html fast/harness/show-modal-dialog.html inspector/console/console-long-eval-crash.html * DumpRenderTree/chromium/TestShell.cpp: (TestShell::TestShell): * DumpRenderTree/chromium/TestShell.h: (TestShell): * DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::runModal): 2012-02-15 Michael Brüning [Qt] Add UI for HTTP authentication in the Qt MiniBrowser https://bugs.webkit.org/show_bug.cgi?id=76347 Reviewed by Kenneth Rohde Christiansen. * MiniBrowser/qt/MiniBrowser.qrc: * MiniBrowser/qt/qml/AuthenticationDialog.qml: Added. * MiniBrowser/qt/qml/BrowserWindow.qml: * MiniBrowser/qt/qml/DialogLineInput.qml: 2012-02-15 Simon Hausmann [Qt] Fix WebGL in QtTestBrowser Reviewed by Tor Arne Vestbø. * QtTestBrowser/QtTestBrowser.pro: Set the OpenGL define so that when passing the options for enabling GL we also pass them on properly. 2012-02-14 Sam Weinig Add #include of unistd.h on the mac for getcwd. Reviewed by Anders Carlsson. This is necessary when building with libc++. * WebKitTestRunner/TestInvocation.cpp: 2012-02-14 Sam Weinig In DRT, don't #define min or max on non-Windows platforms, it just isn't needed https://bugs.webkit.org/show_bug.cgi?id=78663 Reviewed by Anders Carlsson. * DumpRenderTree/DumpRenderTreePrefix.h: * DumpRenderTree/cg/ImageDiffCG.cpp: 2012-02-14 Adam Barth Implement an adb-based driver for the ChromiumAndroidPort https://bugs.webkit.org/show_bug.cgi?id=78627 Reviewed by Eric Seidel. This driver mostly just wires up the ChromiumDriver through adb. In some cases, it translates protocol elements, such as URIs, so that the rest of webkitpy is insulated from the "remoteness" of the target device. * Scripts/webkitpy/layout_tests/port/chromium_android.py: (ChromiumAndroidPort.start_helper): (ChromiumAndroidPort._driver_class): (ChromiumAndroidPort._update_version): (ChromiumAndroidPort._get_stderr): (ChromiumAndroidPort): (ChromiumAndroidPort._get_last_stacktrace): (ChromiumAndroidPort._teardown_performance): (ChromiumAndroidDriver): (ChromiumAndroidDriver.__init__): (ChromiumAndroidDriver._start): (ChromiumAndroidDriver.run_test): (ChromiumAndroidDriver.stop): (ChromiumAndroidDriver._test_shell_command): (ChromiumAndroidDriver._write_command_and_read_line): (ChromiumAndroidDriver._output_image): (ChromiumAndroidDriver._has_crash_hint): 2012-02-14 Dirk Pranke webkitpy: the real_name() method in the Port class is no longer needed https://bugs.webkit.org/show_bug.cgi?id=78651 Reviewed by Eric Seidel. The change in bug 78565 / r107718 made it no longer necessary (we can use options.platform instead). * Scripts/webkitpy/layout_tests/port/base.py: (Port.name): * Scripts/webkitpy/layout_tests/port/mock_drt.py: (MockDRTPort.__init__): 2012-02-14 Dirk Pranke webkitpy: clean up options, port handling in manager_worker_broker https://bugs.webkit.org/show_bug.cgi?id=78568 Reviewed by Tony Chang. manager_worker_broker no longer needs options or port objects directly, so we make them only be passed in start_worker(). * Scripts/webkitpy/layout_tests/controllers/manager.py: (Manager._run_tests): * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py: (get): (_ManagerConnection.__init__): (_ManagerConnection.start_worker): (_InlineManager.__init__): (_InlineManager.start_worker): (_InlineManager.run_message_loop): (_MultiProcessManager.__init__): (_MultiProcessManager): (_MultiProcessManager.start_worker): (_InlineWorkerConnection.__init__): (_InlineWorkerConnection.run): (_Process.__init__): (_MultiProcessWorkerConnection.__init__): * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py: (make_broker): (_TestWorker.run): (_TestsMixin.test_cancel): (_TestsMixin.test_done): (_TestsMixin.test_unknown_message): (MultiProcessBrokerTests.setUp): (InterfaceTest.test_managerconnection_is_abstract): * Scripts/webkitpy/layout_tests/controllers/message_broker.py: (Broker.__init__): 2012-02-14 Dirk Pranke nrwt: add a unit test for regression introduced in bug 78565 https://bugs.webkit.org/show_bug.cgi?id=78646 Reviewed by Tony Chang. * Scripts/webkitpy/layout_tests/controllers/worker_unittest.py: Added. (FakeConnection): (FakeConnection.run_message_loop): (FakeConnection.post_message): (WorkerTest): (WorkerTest.test_default_platform_in_worker): 2012-02-14 Dirk Pranke NRWT is broken for the default port https://bugs.webkit.org/show_bug.cgi?id=78640 Reviewed by Tony Chang. The change in r107718 (bug 78565) broke NRWT if you didn't specify any sort of --platform flag or equivalent. I didn't catch this because it's a full integration test (which we don't have an automated test for) and I missed this command line variant when testing interactively. * Scripts/webkitpy/layout_tests/controllers/worker.py: (Worker.run): 2012-02-14 Ramya Chandrasekaran Last character display for passwords in Android. https://bugs.webkit.org/show_bug.cgi?id=78532 Reviewed by Adam Barth. * DumpRenderTree/chromium/WebPreferences.cpp: (WebPreferences::applyTo): 2012-02-14 Adam Barth Finish implementing start_helper for ChromiumAndroidPort https://bugs.webkit.org/show_bug.cgi?id=78582 Reviewed by Eric Seidel. This patch contains the remaining odds and ends for the start_helper function. * Scripts/webkitpy/layout_tests/port/chromium_android.py: (ChromiumAndroidPort.start_helper): (ChromiumAndroidPort._synchronize_datetime): (ChromiumAndroidPort): (ChromiumAndroidPort._check_version): (ChromiumAndroidPort._run_adb_command): (ChromiumAndroidPort._copy_device_file): 2012-02-14 Dirk Pranke webkitpy: create ports in Workers, not in manager_worker_broker https://bugs.webkit.org/show_bug.cgi?id=78565 Reviewed by Tony Chang. We will now create the Port object (if necessary) in the Worker directly, so that the manager_worker_broker module doesn't need all of this layout_test-specific logic. Part of the fixes for bug 78171. These changes are all well-tested by the existing tests in run_webkit_tests_integrationtest.py. * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py: (_Process.run): * Scripts/webkitpy/layout_tests/controllers/worker.py: (Worker.__init__): (Worker.safe_init): (Worker.run): (Worker.cleanup): * Scripts/webkitpy/layout_tests/run_webkit_tests.py: (parse_args): (main): Fix a minor bug where running the 'mock-test' port didn't work right. 2012-02-14 Jochen Eisinger [chromium] check that we're not running multiple modal dialogs at the same time https://bugs.webkit.org/show_bug.cgi?id=78486 Reviewed by Kent Tamura. * DumpRenderTree/chromium/TestShell.cpp: (TestShell::TestShell): * DumpRenderTree/chromium/TestShell.h: (TestShell::setIsDisplayingModalDialog): (TestShell::isDisplayingModalDialog): (TestShell): * DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::runModal): 2012-02-14 Adam Barth Enable the GPU codepath in the chromium-android port https://bugs.webkit.org/show_bug.cgi?id=78580 Reviewed by James Robinson. Suprise! There is no ChromiumGpuAndroidPort! Instead, Chromium Android always uses the GPU codepath, so we set the GPU flags on the main chromium-android port instead. * Scripts/webkitpy/layout_tests/port/chromium_android.py: (ChromiumAndroidPort.__init__): 2012-02-14 Adam Barth NRWT should expose --adb-args flag for Android https://bugs.webkit.org/show_bug.cgi?id=78579 Reviewed by Eric Seidel. This flag is already wired up to the ChromiumAndroidPort. * Scripts/webkitpy/layout_tests/run_webkit_tests.py: (parse_args): 2012-02-14 Alexey Proskuryakov [Mac][Win][WK2] Switch to RFC 6455 protocol for WebSockets https://bugs.webkit.org/show_bug.cgi?id=78541 Reviewed by Kent Tamura. * DumpRenderTree/mac/DumpRenderTree.mm: (resetDefaultsToConsistentValues): * DumpRenderTree/win/DumpRenderTree.cpp: (resetDefaultsToConsistentValues): After each test, reset to using new protocol. 2012-02-11 Nikolas Zimmermann Convert svg/animations to use SMIL methods for driving the timeline https://bugs.webkit.org/show_bug.cgi?id=78422 Reviewed by Dirk Schulze. Remove no longer needed SVG specific animation sampling functionality from DRT. Instead we switched the svg/animations tests to use SVGSVGElement.setCurrentTime. * DumpRenderTree/LayoutTestController.cpp: (LayoutTestController::staticFunctions): * DumpRenderTree/LayoutTestController.h: (LayoutTestController): * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp: * DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): * DumpRenderTree/chromium/LayoutTestController.h: (LayoutTestController): * DumpRenderTree/efl/LayoutTestControllerEfl.cpp: * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: * DumpRenderTree/mac/LayoutTestControllerMac.mm: * DumpRenderTree/qt/LayoutTestControllerQt.cpp: * DumpRenderTree/qt/LayoutTestControllerQt.h: (LayoutTestController): * DumpRenderTree/win/LayoutTestControllerWin.cpp: * DumpRenderTree/wx/LayoutTestControllerWx.cpp: 2012-02-13 Rob Flack Add Linux ChromiumOS test results to flakiness dashboard. https://bugs.webkit.org/show_bug.cgi?id=78495 Reviewed by Ojan Vafai. * TestResultServer/static-dashboards/builders.js: * TestResultServer/static-dashboards/dashboard_base.js: 2012-02-13 ChangSeok Oh [GTK] Mutation Observers build is broken https://bugs.webkit.org/show_bug.cgi?id=78433 Reviewed by Martin Robinson. Enabled mutation observers as a default feature for GTK port, too. * Scripts/build-webkit: 2012-02-13 Loïc Yhuel Allow to configure ENABLE_FTPDIR in build-webkit https://bugs.webkit.org/show_bug.cgi?id=65098 Reviewed by Eric Seidel. Allow to disable ENABLE_FTPDIR by command line. Remove ENABLE_FTPDIR from --minimal build * Scripts/build-webkit: Add entries for ENABLE_FTPDIR (enabled by default) * qmake/mkspecs/features/features.prf: ENABLE_FTPDIR must be set to match Platform.h, as, for Qt platform, build-webkit does not add on command line what it thinks to be default values 2012-02-13 Shinya Kawanaka Add shinyak as committer. Unreviewed. * Scripts/webkitpy/common/config/committers.py: 2012-02-13 Adam Barth Implement start/stop_helper for ChromiumAndroidPort https://bugs.webkit.org/show_bug.cgi?id=78558 Reviewed by Dirk Pranke. These functions (and their dependencies) set up the Android device for testing. This patch also includes a few tweaks on the previous patch recommended by dpranke. * Scripts/webkitpy/layout_tests/port/chromium_android.py: (ChromiumAndroidPort.__init__): (ChromiumAndroidPort.start_helper): (ChromiumAndroidPort.stop_helper): (ChromiumAndroidPort._shut_down_http_server): (ChromiumAndroidPort): (ChromiumAndroidPort._push_executable): (ChromiumAndroidPort._push_fonts): (ChromiumAndroidPort._restore_system_font): (ChromiumAndroidPort._push_test_resources): (ChromiumAndroidPort._push_to_device): (ChromiumAndroidPort._pull_from_device): (ChromiumAndroidPort._kill_device_process): (ChromiumAndroidPort._setup_performance): (ChromiumAndroidPort._teardown_performance): * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py: (ChromiumAndroidPortTest): * Scripts/webkitpy/layout_tests/port/port_testcase.py: (PortTestCase): (PortTestCase.make_port): (PortTestCase.test_default_worker_model): 2012-02-13 Adam Barth Implement enough of ChromiumAndroidPort to make ChromiumAndroidPortTest pass https://bugs.webkit.org/show_bug.cgi?id=78550 Reviewed by Eric Seidel. Much of this code just forwards to the "host" port, which seems like a reasonable thing to do. * Scripts/webkitpy/layout_tests/port/chromium_android.py: (ChromiumAndroidPort.__init__): (ChromiumAndroidPort.stop_helper): (ChromiumAndroidPort): (ChromiumAndroidPort._build_path): (ChromiumAndroidPort._path_to_apache): (ChromiumAndroidPort._path_to_apache_config_file): (ChromiumAndroidPort._path_to_driver): (ChromiumAndroidPort._path_to_helper): (ChromiumAndroidPort._path_to_image_diff): (ChromiumAndroidPort._path_to_lighttpd): (ChromiumAndroidPort._path_to_lighttpd_modules): (ChromiumAndroidPort._path_to_lighttpd_php): (ChromiumAndroidPort._path_to_wdiff): (ChromiumAndroidPort._shut_down_http_server): * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py: (ChromiumAndroidPortTest): * Scripts/webkitpy/layout_tests/port/port_testcase.py: (PortTestCase): (PortTestCase.make_port): (PortTestCase.test_default_worker_model): 2012-02-13 Adam Barth chromium_android.py should implement "virtual" methods from ChromiumPort https://bugs.webkit.org/show_bug.cgi?id=78545 Reviewed by Dirk Pranke. This patch adds basic implementations that specialize a bunch of functions from ChromiumPort. * Scripts/webkitpy/layout_tests/port/chromium_android.py: (ChromiumAndroidPort): (ChromiumAndroidPort.__init__): (ChromiumAndroidPort.default_child_processes): (ChromiumAndroidPort.baseline_search_path): (ChromiumAndroidPort.check_build): (ChromiumAndroidPort.check_sys_deps): (ChromiumAndroidPort.default_worker_model): (ChromiumAndroidPort.test_expectations): (ChromiumAndroidPort.start_http_server): (ChromiumAndroidPort.stop_http_server): (ChromiumAndroidPort.start_helper): (ChromiumAndroidPort.stop_helper): 2012-02-13 Adam Barth Add a skeleton ChromiumAndroid port to webkitpy https://bugs.webkit.org/show_bug.cgi?id=78543 Reviewed by Eric Seidel. This patch just adds an empty ChromiumAndroid port object to webkitpy and wires it up to the factory objects. An actual implementation will follow. * Scripts/webkitpy/layout_tests/port/chromium.py: (ChromiumPort): * Scripts/webkitpy/layout_tests/port/chromium_android.py: Added. (ChromiumAndroidPort): (ChromiumAndroidPort.__init__): * Scripts/webkitpy/layout_tests/port/chromium_unittest.py: (ChromiumPortTest.test_all_test_configurations): * Scripts/webkitpy/layout_tests/port/factory.py: (PortFactory): 2012-02-13 Adam Barth NRWT's HTTP servers should support additional directories for resources https://bugs.webkit.org/show_bug.cgi?id=78528 Reviewed by Eric Seidel. This functionality will be used by the Chromium-Android port. * Scripts/webkitpy/layout_tests/port/base.py: (Port.to.start_http_server): * Scripts/webkitpy/layout_tests/servers/apache_http_server.py: (LayoutTestApacheHttpd.__init__): * Scripts/webkitpy/layout_tests/servers/http_server.py: (Lighttpd.__init__): (Lighttpd._prepare_config): 2012-02-13 Ami Fischman Add fischman as committer. Unreviewed * Scripts/webkitpy/common/config/committers.py: 2012-02-06 Raphael Kubo da Costa [EFL] Drop support for the Curl network backend. https://bugs.webkit.org/show_bug.cgi?id=77874 Reviewed by Eric Seidel. Nobody seems to be maintaining the Curl backend in WebCore, the EFL port developers all seem to be using the Soup backend and the port itself has many features which are only implemented for the latter. * DumpRenderTree/efl/CMakeLists.txt: Always link to glib/libsoup and always add the required include directories. * EWebLauncher/CMakeLists.txt: Add the required glib/libsoup include directories and link to them. 2012-02-13 Kenichi Ishibashi [WebSocket] Update pywebsocket to 0.7.1 https://bugs.webkit.org/show_bug.cgi?id=78484 pywebsocket-0.7.1 follow the current draft of WebSocket deflate-frame extension. Reviewed by Kent Tamura. * Scripts/webkitpy/thirdparty/__init__.py: (AutoinstallImportHook._install_pywebsocket): 2012-02-12 Kangil Han [EFL][DRT] Implement zoomPage{In,Out} and textZoom{In,Out} events. https://bugs.webkit.org/show_bug.cgi?id=78091 Reviewed by Hajime Morita. Implemented zoomPageIn, zoomPageOut, textZoomIn and textZoomOut events on EFL DRT. This patch will activate around 1,900 test cases from skipped list in EFL port. * DumpRenderTree/efl/EventSender.cpp: (textZoom): (pageZoom): (textZoomInCallback): (textZoomOutCallback): (zoomPageInCallback): (zoomPageOutCallback): 2012-02-12 Ashod Nakashian KeywordLookupGenerator.py script fails in some cases https://bugs.webkit.org/show_bug.cgi?id=77886 Reviewed by Benjamin Poulain. * Scripts/webkitpy/style/checker.py: New rule for Keywords.table to not have CR. * Scripts/webkitpy/style/checker_unittest.py: New UT for Keywords.table rule. (GlobalVariablesTest.test_path_rules_specifier): 2012-02-12 Joe Thomas Add toText and isTextNode helpers in Text class. https://bugs.webkit.org/show_bug.cgi?id=78140 Unit test case for the new style checker introduced. Reviewed by Adam Barth. * Scripts/webkitpy/style/checkers/cpp_unittest.py: (CppStyleTest): (CppStyleTest.test_static_cast_readability): Added a unit test case. 2012-02-12 Gyuyoung Kim Enable features supported by EFL port in build-webkit. https://bugs.webkit.org/show_bug.cgi?id=78348 Reviewed by Ryosuke Niwa. Sync build-webkit with OptionEfl.cmake, as some features enabled in OptionEfl.cmake are not enabled in build-webkit. * Scripts/build-webkit: 2012-02-12 Joe Thomas Add toText and isTextNode helpers in Text class. https://bugs.webkit.org/show_bug.cgi?id=78140 Added a style checker to use toText rather than static_cast. Reviewed by Adam Barth. * Scripts/webkitpy/style/checkers/cpp.py: (check_language): Style checker for static_cast. 2012-02-12 Philippe Normand Unreviewed, disable Mutation observers build on GTK until it can actually build. * Scripts/build-webkit: 2012-02-11 Benjamin Poulain Add back WTFURL to WebKit https://bugs.webkit.org/show_bug.cgi?id=77291 Reviewed by Adam Barth. Add a flag to build-webkit to easily build WebKit with WTFURL. * Scripts/build-webkit: 2012-02-10 Adam Klein Enable MUTATION_OBSERVERS by default on all platforms https://bugs.webkit.org/show_bug.cgi?id=78196 Reviewed by Ojan Vafai. * Scripts/build-webkit: 2012-02-10 Adam Barth Move garden-o-matic's All Failures out of experimental https://bugs.webkit.org/show_bug.cgi?id=78395 Reviewed by Dimitri Glazkov. Several folks have tried this feature and found it useful. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js: 2012-02-10 Tim Horton NRWT should categorize options in --help https://bugs.webkit.org/show_bug.cgi?id=76221 Reviewed by Eric Seidel. Use optparse's OptionGroup mechanism to logically group NRWT's options, providing a better experience when scanning all the options. * Scripts/webkitpy/layout_tests/run_webkit_tests.py: (parse_args): 2012-02-10 Jesus Sanchez-Palencia [Qt][WK2] Refactor on Qt5 Layout tests' structure https://bugs.webkit.org/show_bug.cgi?id=77450 Reviewed by Csaba Osztrogonác. Fix the scripts and related unittest due to the rename of qt-wk2 and qt-wk1 to qt-5.0-wk2 and qt-5.0-wk1. * Scripts/old-run-webkit-tests: (buildPlatformResultHierarchy): (readSkippedFiles): * Scripts/webkitpy/layout_tests/port/qt.py: (QtPort._wk2_port_name): (QtPort._skipped_file_search_paths): * Scripts/webkitpy/layout_tests/port/qt_unittest.py: (QtPortTest.test_baseline_search_path): * Scripts/webkitpy/layout_tests/port/webkit.py: (WebKitPort._wk2_port_name): 2012-02-09 Philippe Normand [GTK] EWS command-line option to run the tests https://bugs.webkit.org/show_bug.cgi?id=78211 Reviewed by Adam Barth. New --run-tests option (defaults to False) for the EWS commands. * Scripts/webkitpy/tool/commands/earlywarningsystem.py: (AbstractEarlyWarningSystem): (AbstractEarlyWarningSystem.__init__): (AbstractEarlyWarningSystem.review_patch): (ChromiumLinuxEWS): * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py: (EarlyWarningSytemTest._test_builder_ews): 2012-02-09 Eric Seidel Rename compare_text and compare_audio to make it clear that they're != https://bugs.webkit.org/show_bug.cgi?id=78301 Reviewed by Adam Barth. I also removed the maybe_create_directory function which was redundant. * Scripts/webkitpy/layout_tests/controllers/manager.py: (Manager.set_up_run): * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py: (TestResultWriter._make_output_directory): * Scripts/webkitpy/layout_tests/port/base.py: (Port.do_text_results_differ): (Port.do_audio_results_differ): (Port.diff_text): (Port.driver_name): (Port.skips_perf_test): * Scripts/webkitpy/layout_tests/port/win.py: (WinPort.do_text_results_differ): * Scripts/webkitpy/layout_tests/port/win_unittest.py: (WinPortTest.test_do_text_results_differ): * Scripts/webkitpy/layout_tests/servers/apache_http_server.py: (LayoutTestApacheHttpd.__init__): * Scripts/webkitpy/layout_tests/servers/http_server_base.py: (HttpServerBase.__init__): * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py: (Rebaseliner._diff_baselines): 2012-02-09 Zan Dobersek [GTK] Add DRT support for modal dialogs https://bugs.webkit.org/show_bug.cgi?id=53600 Reviewed by Martin Robinson. Implement the modal dialogs handling in DumpRenderTree and GtkLauncher. Most significantly, when creating a new web view in GtkLauncher, the window of the web view opener is passed around. In DumpRenderTree, the window of the main web view is always considered as the opener. This is required so the modal dialog's toplevel can be made transient for the opener's toplevel. * DumpRenderTree/gtk/DumpRenderTree.cpp: (webViewRunModalDialog): (createWebView): * GtkLauncher/main.c: (createWebViewCb): (runModalDialogCb): (createBrowser): (createWindow): (main): 2012-02-09 Zan Dobersek [Gtk] security/set-form-autocomplete-attribute.html fails https://bugs.webkit.org/show_bug.cgi?id=78261 Reviewed by Martin Robinson. Use the new helper in DumpRenderTreeSupportGtk to properly test whether an element performs autocompletion. * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::elementDoesAutoCompleteForElementWithId): 2012-02-09 James Robinson [chromium] Enable mock scrollbars for compositing layout tests https://bugs.webkit.org/show_bug.cgi?id=78299 Reviewed by Dirk Pranke. This enables mock scrollbars by default for compositing tests. These pixel tests are intended to test the compositor behavior, not native theming, and having real scrollbars causes us to have to maintain significantly more pngs than we should and expose weird alpha bugs in our theming that doesn't impact real users. * DumpRenderTree/chromium/TestShell.cpp: (TestShell::runFileTest): * DumpRenderTree/chromium/WebPreferences.cpp: (WebPreferences::reset): (WebPreferences::applyTo): * DumpRenderTree/chromium/WebPreferences.h: (WebPreferences): 2012-02-09 Eric Seidel Remove more uses of "os" from our webkitpy code https://bugs.webkit.org/show_bug.cgi?id=78292 Reviewed by Adam Barth. * Scripts/webkitpy/common/checkout/checkout_mock.py: (MockCheckout.__init__): (MockCheckout.is_path_to_changelog): * Scripts/webkitpy/common/net/bugzilla/bugzilla.py: * Scripts/webkitpy/common/system/filesystem_mock.py: (MockFileSystem._split): * Scripts/webkitpy/common/system/zipfileset_unittest.py: * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py: * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py: * Scripts/webkitpy/layout_tests/port/webkit.py: * Scripts/webkitpy/tool/bot/queueengine.py: * Scripts/webkitpy/tool/bot/sheriff_unittest.py: * Scripts/webkitpy/tool/commands/download.py: * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py: * Scripts/webkitpy/tool/commands/rebaselineserver.py: * Scripts/webkitpy/tool/commands/sheriffbot.py: * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py: * Scripts/webkitpy/tool/commands/upload.py: (CreateBug.prompt_for_bug_title_and_comment): * Scripts/webkitpy/tool/servers/reflectionhandler.py: * Scripts/webkitpy/tool/steps/attachtobug.py: (AttachToBug.run): * Scripts/webkitpy/tool/steps/checkstyle.py: * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py: * Scripts/webkitpy/tool/steps/commit_unittest.py: * Scripts/webkitpy/tool/steps/editchangelog.py: * Scripts/webkitpy/tool/steps/preparechangelog.py: * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py: (PrepareChangeLogTest.test_ensure_bug_url): * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py: * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py: * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py: * Scripts/webkitpy/tool/steps/validatereviewer.py: 2012-02-09 Eric Seidel Remove the cr-mac-ews (it's long been dead) https://bugs.webkit.org/show_bug.cgi?id=78267 Reviewed by Adam Barth. * QueueStatusServer/model/queues.py: (Queue): * Scripts/webkitpy/tool/commands/earlywarningsystem.py: (ChromiumWindowsEWS): * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py: (EarlyWarningSytemTest._test_builder_ews): (EarlyWarningSytemTest._test_testing_ews): 2012-02-09 Dirk Pranke some tests in webkitpy are being run three times https://bugs.webkit.org/show_bug.cgi?id=78283 Reviewed by Ryosuke Niwa. It turns out that if you import a class derived from unittest.TestCase as a base name (e.g., from ... import ChangeLogTest), the unittest framework treats it as if the class was defined in the file (as well in the original file). This led us to running the tests in ChangeLogTest three times. * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py: (PrepareChangeLogTest): * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py: (_assert_message_for_revert_output): 2012-02-09 Adam Barth Remove extraneous line in previous patch. I forgot to remove this before landing. * Scripts/webkitpy/layout_tests/port/driver.py: (DriverProxy.start): 2012-02-09 Adam Barth run-perf-tests should have an option to pause before running tests so we can attach Instruments https://bugs.webkit.org/show_bug.cgi?id=78271 Reviewed by Ryosuke Niwa. This lets me attach instruments to profile the performance of the test. * Scripts/webkitpy/layout_tests/port/chromium.py: (ChromiumDriver.start): * Scripts/webkitpy/layout_tests/port/driver.py: (Driver.start): (DriverProxy.start): * Scripts/webkitpy/layout_tests/port/server_process.py: (ServerProcess.start): * Scripts/webkitpy/layout_tests/port/test.py: (TestDriver.start): * Scripts/webkitpy/layout_tests/port/webkit.py: (WebKitDriver.start): * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: (get_tests_run.RecordingTestDriver.start): * Scripts/webkitpy/performance_tests/perftestsrunner.py: (PerfTestsRunner._parse_args): (PerfTestsRunner._run_tests_set): * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py: (start): (test_run_test_set_kills_drt_per_run.TestDriverWithStopCount): (test_run_test_set_kills_drt_per_run): (test_run_test_set_kills_drt_per_run.TestDriverWithStartCount): (test_run_test_set_kills_drt_per_run.TestDriverWithStartCount.start): 2012-02-09 Adam Barth run-perf-tests --chromium should run the chromium port https://bugs.webkit.org/show_bug.cgi?id=78266 Reviewed by Ryosuke Niwa. This patch makes run-perf-tests work more like run-webkit-tests. * Scripts/webkitpy/performance_tests/perftestsrunner.py: (PerfTestsRunner._parse_args): 2012-02-09 Jesus Sanchez-Palencia [Qt][WK2] run-webkit-tests --qt crashes if WEBKIT_TESTFONTS is not set https://bugs.webkit.org/show_bug.cgi?id=77466 Reviewed by Dirk Pranke. Replicate the behavior of old-run-webkit-tests and check if WEBKIT_TESTFONTS is set or if we should raise an error. A unit test was added. * Scripts/webkitpy/layout_tests/port/qt.py: (QtPort.operating_system): (QtPort): (QtPort.check_sys_deps): * Scripts/webkitpy/layout_tests/port/qt_unittest.py: (QtPortTest.test_operating_system): (QtPortTest): (QtPortTest.test_check_sys_deps): 2012-02-09 Eric Seidel Rename ports.WebKitPort to DeprecatedPort and make it stop being all class methods https://bugs.webkit.org/show_bug.cgi?id=78263 Reviewed by Adam Barth. * Scripts/webkitpy/common/config/ports.py: (DeprecatedPort): (DeprecatedPort.name): (DeprecatedPort.flag): (DeprecatedPort.script_path): (DeprecatedPort.script_shell_command): (DeprecatedPort.port): (DeprecatedPort.makeArgs): (DeprecatedPort.update_webkit_command): (DeprecatedPort.check_webkit_style_command): (DeprecatedPort.prepare_changelog_command): (DeprecatedPort.build_webkit_command): (DeprecatedPort.run_javascriptcore_tests_command): (DeprecatedPort.run_webkit_unit_tests_command): (DeprecatedPort.run_webkit_tests_command): (DeprecatedPort.run_python_unittests_command): (DeprecatedPort.run_perl_unittests_command): (DeprecatedPort.layout_tests_results_path): (MacPort): (WinPort): (GtkPort): (GtkPort.build_webkit_command): (GtkPort.run_webkit_tests_command): (QtPort): (QtPort.build_webkit_command): (EflPort): (EflPort.build_webkit_command): (ChromiumPort): (ChromiumPort.update_webkit_command): (ChromiumPort.build_webkit_command): (ChromiumPort.run_webkit_tests_command): (ChromiumPort.run_javascriptcore_tests_command): (ChromiumXVFBPort): (ChromiumXVFBPort.run_webkit_tests_command): * Scripts/webkitpy/common/config/ports_unittest.py: (DeprecatedPortTest): (DeprecatedPortTest.test_mac_port): (DeprecatedPortTest.test_gtk_port): (DeprecatedPortTest.test_qt_port): (DeprecatedPortTest.test_chromium_port): (DeprecatedPortTest.test_chromium_xvfb_port): * Scripts/webkitpy/tool/commands/earlywarningsystem.py: (AbstractEarlyWarningSystem.__init__): * Scripts/webkitpy/tool/commands/sheriffbot.py: * Scripts/webkitpy/tool/main.py: (WebKitPatch): (WebKitPatch.handle_global_options): * Scripts/webkitpy/tool/steps/abstractstep.py: * Scripts/webkitpy/tool/steps/steps_unittest.py: (StepsTest.test_runtests_args): 2012-02-09 Jochen Eisinger [chromium] always initialize makeArgs in buildChromiumNinja https://bugs.webkit.org/show_bug.cgi?id=78231 Reviewed by Tony Gentilcore. * Scripts/webkitdirs.pm: (buildChromiumNinja): 2012-02-09 Carlos Garcia Campos [GTK] Show url of current hovered link in MiniBrowser https://bugs.webkit.org/show_bug.cgi?id=78098 Reviewed by Martin Robinson. * MiniBrowser/gtk/BrowserWindow.c: (webViewMouseTargetChanged): Check whether hit test result is a link and use the url to update the status bar text. (browserWindowConstructed): Connect to WebKitWebView::mouse-target-changed signal. 2012-02-09 Rob Buis [BlackBerry] Upstream DumpRenderTreeBlackBerry https://bugs.webkit.org/show_bug.cgi?id=78042 Reviewed by Antonio Gomes. Upstream final part of our DRT implementation. * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp: Added. * DumpRenderTree/blackberry/PNGImageEncoder.cpp: Added. * DumpRenderTree/blackberry/PNGImageEncoder.h: Added. * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp: Added. * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.h: Added. 2012-02-09 Ryosuke Niwa kill-old-processes should kill gcc and clang https://bugs.webkit.org/show_bug.cgi?id=78189 Reviewed by Eric Seidel. Added a bunch of processes names of gcc and clang to the list. * BuildSlaveSupport/kill-old-processes: 2012-02-07 MORITA Hajime Replacement text should be available from the marker. https://bugs.webkit.org/show_bug.cgi?id=77934 Made the mock requestCheckingOfText() implementation to return a replacement text for each misspelled word if available. Reviewed by Kent Tamura. * DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::finishLastTextCheck): 2012-02-08 Jesus Sanchez-Palencia [Qt][DRT] DumpRenderTreeQt should support --no-timeout and --timeout options https://bugs.webkit.org/show_bug.cgi?id=78146 Reviewed by Ryosuke Niwa. Our DumpRenderTree should support --no-timeout and --timeout options in order to be able to use run-perf-tests and have a Performance Bot. This patch adds setTimeout and setShouldTimeout functions to our LayoutTestController and the necessary code to handle such command line arguments to our DumpRenderTree. * DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::setTimeout): (WebCore): (WebCore::DumpRenderTree::setShouldTimeout): * DumpRenderTree/qt/DumpRenderTreeQt.h: (DumpRenderTree): * DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::waitUntilDone): (LayoutTestController::notifyDone): * DumpRenderTree/qt/LayoutTestControllerQt.h: (LayoutTestController::setTimeout): (LayoutTestController::setShouldTimeout): (LayoutTestController): * DumpRenderTree/qt/main.cpp: (isOption): (printUsage): (main): 2012-02-08 Gustavo Noronha Silva Rubber-stamped by Martin Robinson. * gtk/common.py: (get_build_path): Move test for current directory being a valid directory up so it takes precedence over WebKitBuild/Release and WebKitBuild/Debug when they exist as well. 2012-02-08 Gustavo Noronha Silva [GTK] doc rebasing does not respect DESTDIR https://bugs.webkit.org/show_bug.cgi?id=78177 Reviewed by Martin Robinson. * GNUmakefile.am: Pass DESTDIR on to generate-gtkdoc, when calling it for rebasing. * gtk/generate-gtkdoc: (get_common_options): Handle the new --virtual-root option. * gtk/gtkdoc.py: (GTKDoc.rebase_installed_docs): If a virtual-root has been given, pass it on to gtkdoc-rebase as dest-dir, and prefix the htmldir with it. 2012-02-08 Adam Barth Remove Python 2.5 support from WebKit https://bugs.webkit.org/show_bug.cgi?id=71593 Reviewed by Eric Seidel. This is the last vestige of our Python 2.5 support. * Scripts/webkitpy/tool/commands/queues_unittest.py: (AbstractQueueTest.test_log_from_script_error_for_upload): 2012-02-08 Adam Barth version_check.py should inform users that we don't support Python 2.5 anymore https://bugs.webkit.org/show_bug.cgi?id=78179 Reviewed by Eric Seidel. We don't support Python 2.5 anymore. * Scripts/webkitpy/common/version_check.py: 2012-02-08 Adam Barth test_configuration.py shouldn't re-implement itertools https://bugs.webkit.org/show_bug.cgi?id=78178 Reviewed by Eric Seidel. * Scripts/webkitpy/layout_tests/models/test_configuration.py: (TestConfigurationConverter.to_specifiers_list): (TestConfigurationConverter.to_specifiers_list.try_collapsing): (TestConfigurationConverter.to_specifiers_list.try_abbreviating): (TestConfigurationConverter): 2012-02-08 Adam Barth webkitpy should reply upon the multiprocessing package existing https://bugs.webkit.org/show_bug.cgi?id=78176 Reviewed by Eric Seidel. Now that we don't support Python 2.5, this import can't fail. * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py: (get): (_Process): (_Process.__init__): (_Process.run): * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py: (FunctionTests.test_get__processes): (MultiProcessBrokerTests.setUp): * Scripts/webkitpy/layout_tests/port/base.py: (Port.__init__): (Port.default_worker_model): * Scripts/webkitpy/layout_tests/port/chromium_mac.py: (ChromiumMacPort.check_build): * Scripts/webkitpy/layout_tests/port/port_testcase.py: (PortTestCase.test_default_worker_model): * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: 2012-02-08 Gustavo Noronha Silva Unreviewed typo fix that makes docs build again for the gtk2-based library. * gtk/generate-gtkdoc: 2012-02-08 Adam Barth Don't re-implement ZipFile.extractall https://bugs.webkit.org/show_bug.cgi?id=78173 Reviewed by Eric Seidel. We can use ZipFile.extractall now that we don't support Python 2.5. * Scripts/webkitpy/common/system/autoinstall.py: (AutoInstaller._extract_targz): (AutoInstaller._unzip): 2012-02-08 Adam Barth Remove the ospath compat shim from webkitpy https://bugs.webkit.org/show_bug.cgi?id=78170 Reviewed by Eric Seidel. We no longer need this compat shim now that we don't support Python 2.5. * Scripts/webkitpy/common/checkout/scm/git.py: * Scripts/webkitpy/common/checkout/scm/svn.py: * Scripts/webkitpy/common/system/filesystem.py: (FileSystem.relpath): * Scripts/webkitpy/common/system/filesystem_mock.py: (MockFileSystem.relpath): * Scripts/webkitpy/common/system/ospath.py: Removed. * Scripts/webkitpy/common/system/ospath_unittest.py: Removed. 2012-02-08 Ryosuke Niwa Build fix attempt after r107053. * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py: (test_collect_tests): 2012-02-08 Adam Barth Remove simplejson because it's no longer used by webkitpy https://bugs.webkit.org/show_bug.cgi?id=78164 Reviewed by Eric Seidel. All the importers of this code were removed in a previous patch. * Scripts/webkitpy/thirdparty/simplejson: Removed. * Scripts/webkitpy/thirdparty/simplejson/LICENSE.txt: Removed. * Scripts/webkitpy/thirdparty/simplejson/README.txt: Removed. * Scripts/webkitpy/thirdparty/simplejson/__init__.py: Removed. * Scripts/webkitpy/thirdparty/simplejson/_speedups.c: Removed. * Scripts/webkitpy/thirdparty/simplejson/decoder.py: Removed. * Scripts/webkitpy/thirdparty/simplejson/encoder.py: Removed. * Scripts/webkitpy/thirdparty/simplejson/jsonfilter.py: Removed. * Scripts/webkitpy/thirdparty/simplejson/ordered_dict.py: Removed. * Scripts/webkitpy/thirdparty/simplejson/scanner.py: Removed. * Scripts/webkitpy/thirdparty/simplejson/tool.py: Removed. 2012-02-08 Adam Barth webkitpy still imports simplejson https://bugs.webkit.org/show_bug.cgi?id=78161 Reviewed by Eric Seidel. We no longer support Python 2.5, so we can rely upon Python's built-in JSON package. * Scripts/webkitpy/common/net/buildbot/buildbot.py: * Scripts/webkitpy/common/net/resultsjsonparser.py: * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor.py: * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py: * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py: * Scripts/webkitpy/layout_tests/models/test_expectations.py: * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: * Scripts/webkitpy/style/checkers/jsonchecker.py: * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py: * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py: * Scripts/webkitpy/tool/servers/reflectionhandler.py: 2012-02-08 Gustavo Noronha Silva [GTK] Fails to build docs with non-standard build directories https://bugs.webkit.org/show_bug.cgi?id=78118 * gtk/common.py: (get_build_path): add comment to document changes done in r107098, as requested by the reviewer and forgotten by me. 2012-02-08 Adam Barth Stop importing with_statement from the mysterious future https://bugs.webkit.org/show_bug.cgi?id=78156 Reviewed by Eric Seidel. The future is now! (Well, at least 2008, when Python 2.6 was released, is no longer the __future__.) * Scripts/webkitpy/common/checkout/changelog_unittest.py: * Scripts/webkitpy/common/checkout/checkout_unittest.py: * Scripts/webkitpy/common/checkout/scm/scm_unittest.py: * Scripts/webkitpy/common/net/credentials_unittest.py: * Scripts/webkitpy/common/net/file_uploader.py: * Scripts/webkitpy/common/newstringio_unittest.py: * Scripts/webkitpy/common/system/autoinstall.py: * Scripts/webkitpy/common/system/crashlogs.py: * Scripts/webkitpy/common/system/fileset.py: * Scripts/webkitpy/common/system/filesystem.py: * Scripts/webkitpy/common/system/filesystem_unittest.py: * Scripts/webkitpy/common/system/path.py: * Scripts/webkitpy/common/thread/threadedmessagequeue.py: * Scripts/webkitpy/layout_tests/controllers/manager.py: * Scripts/webkitpy/layout_tests/port/base.py: (of): * Scripts/webkitpy/layout_tests/port/gtk.py: * Scripts/webkitpy/layout_tests/port/test.py: * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: * Scripts/webkitpy/style/filereader_unittest.py: * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py: * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py: * Scripts/webkitpy/tool/commands/analyzechangelog.py: * Scripts/webkitpy/tool/commands/queues.py: * Scripts/webkitpy/tool/servers/reflectionhandler.py: * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py: 2012-02-08 Rob Buis [BlackBerry] Upstream DumpRenderTreeBlackBerry https://bugs.webkit.org/show_bug.cgi?id=78042 Reviewed by Antonio Gomes. Upstream more parts of our DRT implementation. * DumpRenderTree/blackberry/AccessibilityControllerBlackBerry.cpp: Added. * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp: Added. * DumpRenderTree/blackberry/EventSender.cpp: Added. * DumpRenderTree/blackberry/EventSender.h: Added. * DumpRenderTree/blackberry/GCControllerBlackBerry.cpp: Added. * DumpRenderTree/blackberry/WorkQueueItemBlackBerry.cpp: Added. 2012-02-08 Dirk Pranke check-webkit-style failing with "Path does not exist." https://bugs.webkit.org/show_bug.cgi?id=77873 Reviewed by Ojan Vafai. This change fixes the way the style checker determines which Port class to use for a given test_expectations.txt path; the previous version used a heuristic that didn't really work in the first place. * Scripts/webkitpy/style/checkers/test_expectations.py: (TestExpectationsChecker._determine_port_from_expectations_path): (TestExpectationsChecker.__init__): * Scripts/webkitpy/style/checkers/test_expectations_unittest.py: (TestExpectationsTestCase._expect_port_for_expectations_path): (TestExpectationsTestCase.test_determine_port_from_expectations_path): 2012-02-08 Fehér Zsolt nrwt: make --skip-pixel-test-if-no-baseline option https://bugs.webkit.org/show_bug.cgi?id=70484 Reviewed by Dirk Pranke. * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py: (SingleTestRunner.__init__): (SingleTestRunner._should_fetch_expected_checksum): * Scripts/webkitpy/layout_tests/controllers/worker.py: (Worker.handle_test_list): * Scripts/webkitpy/layout_tests/models/test_input.py: (TestInput.__init__): * Scripts/webkitpy/layout_tests/port/webkit.py: (WebKitDriver.cmd_line): * Scripts/webkitpy/layout_tests/run_webkit_tests.py: (_set_up_derived_options): (parse_args): * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: (MainTest.test_skip_pixel_test_if_no_baseline_option): * WebKitTestRunner/TestController.cpp: (WTR::TestController::TestController): (WTR::TestController::initialize): (WTR::TestController::runTest): * WebKitTestRunner/TestController.h: (TestController): * WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::TestInvocation): (WTR::TestInvocation::setIsPixelTest): * WebKitTestRunner/TestInvocation.h: (WTR::TestInvocation::setSkipPixelTestOption): (TestInvocation): 2012-02-08 Rob Buis [BlackBerry] Upstream DumpRenderTreeBlackBerry https://bugs.webkit.org/show_bug.cgi?id=78042 Reviewed by Antonio Gomes. Add implementation for our DumpRenderTree solution. * DumpRenderTree/blackberry/DumpRenderTree.cpp: Added. * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h: Added. 2012-02-08 Antti Koivisto REGRESSION (r106681): Null check missing in [WebFrame(WebInternal) _typingStyle] https://bugs.webkit.org/show_bug.cgi?id=78080 Reviewed by Andreas Kling, Darin Adler and Dan Bernstein. Add API test. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/mac/TypingStyleCrash.mm: Added. (TestWebKitAPI): (TestWebKitAPI::TEST): 2012-02-08 Gustavo Noronha Silva [GTK] Fails to build docs with non-standard build directories https://bugs.webkit.org/show_bug.cgi?id=78118 Reviewed by Martin Robinson. * gtk/common.py: (get_build_path): also try the current directory as a valid build dir, which makes non-standard build directories such as build-2.0 and build-3.0 work 2012-02-08 Carlos Garcia Campos [GTK] Open links in a new window when clicking with the middle button in MiniBrowser https://bugs.webkit.org/show_bug.cgi?id=78099 Reviewed by Martin Robinson. * MiniBrowser/gtk/BrowserWindow.c: (webViewDecidePolicy): Check whether it's a link clicked with the middle mouse button and load the request in a new window. (browserWindowConstructed): Connect to WebKitWebView::decide-policy signal. 2012-02-08 Ryosuke Niwa Revert a part of the change in r106687 as a build fix. Since Chromium port doesn't checkout the entire WebKit trunk, we can't run "svn info" on webkit_base. * Scripts/webkitpy/layout_tests/port/base.py: (Port.repository_paths): 2012-02-07 Ryosuke Niwa run-perf-tests doesn't recognize paths that start with PerformanceTests https://bugs.webkit.org/show_bug.cgi?id=78012 Reviewed by Adam Barth. Use resolve paths using filesystem.relpath before passing it to find_files.find. * Scripts/webkitpy/performance_tests/perftestsrunner.py: (PerfTestsRunner): (PerfTestsRunner._collect_tests): * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py: (test_collect_tests): (test_collect_tests.add_file): 2012-02-07 Justin Novosad [Chromium] add option for 2d canvas defered rendering to DumpRenderTree https://bugs.webkit.org/show_bug.cgi?id=78039 Reviewed by Stephen White. Adding the --enable-deferred-2d-canvas switch to DumpRenderTree * DumpRenderTree/chromium/DumpRenderTree.cpp: (main): * DumpRenderTree/chromium/TestShell.cpp: (TestShell::TestShell): (TestShell::resetWebSettings): (TestShell::runFileTest): * DumpRenderTree/chromium/TestShell.h: (TestShell::setDeferred2dCanvasEnabled): (TestShell): * DumpRenderTree/chromium/WebPreferences.cpp: (WebPreferences::reset): (WebPreferences::applyTo): * DumpRenderTree/chromium/WebPreferences.h: (WebPreferences): 2012-02-07 Gyuyoung Kim [CMAKE] Use *bin* and *lib* directories for executable and libraries. https://bugs.webkit.org/show_bug.cgi?id=77928 Reviewed by Daniel Bates. CMake has used *Programs* directory for executable. In addition, shared libraries are being built in source directory. It is better to set common places in order to maintain executable and libraries. *bin* is for executable and *lib* is for library. * DumpRenderTree/efl/CMakeLists.txt: * EWebLauncher/CMakeLists.txt: * Scripts/run-launcher: * Scripts/webkitdirs.pm: (jscProductDir): * Scripts/webkitpy/layout_tests/port/efl.py: (EflPort._path_to_driver): (EflPort._path_to_image_diff): 2012-02-07 Adam Klein Add JSC support for delivering mutations when the outermost script context exits https://bugs.webkit.org/show_bug.cgi?id=70289 Reviewed by Eric Seidel. * DumpRenderTree/mac/EventSendingController.mm: Add support for eventSender.scheduleAsynchronousKeyDown. (+[EventSendingController isSelectorExcludedFromWebScript:]): (+[EventSendingController webScriptNameForSelector:]): (-[EventSendingController keyDownWrapper:withModifiers:withLocation:]): (-[EventSendingController scheduleAsynchronousKeyDown:withModifiers:withLocation:]): * Scripts/build-webkit: Properly alphabetize --mutation-observers in the --help output. 2012-02-07 Chris Rogers Add Chris Rogers to reviewers section https://bugs.webkit.org/show_bug.cgi?id=78016 Reviewed by Adam Barth. * Scripts/webkitpy/common/config/committers.py: 2012-02-07 Nikolas Zimmermann layoutTestController.display() is flaky for SVG tests https://bugs.webkit.org/show_bug.cgi?id=78021 Reviewed by Dan Bernstein. Fix race condition in repaint rect tracking. When running a test using the repaint.js harness right after a test starting with "svg/W3C-SVG-1.1" the repaint test will fail, the gray overlay isn't contained in the pixel dump anymore. This is because of a specific hack that forces 480x360 instead of 800x600 pixel test dumps for any test starting with svg/W3C-SVG-1.1. The resizing of the web view was done when dumping the render tree, after the repaint test already run, thus invalidating the previously tracked repaint rects. * DumpRenderTree/mac/DumpRenderTree.mm: (dump): (runTest): 2012-02-07 Hans Wennborg Chromium: remove WebSpeechInputResult::set https://bugs.webkit.org/show_bug.cgi?id=77977 Reviewed by Darin Fisher. It was renamed to assign() in r106475. * DumpRenderTree/chromium/MockWebSpeechInputController.cpp: (makeRectResult): 2012-02-07 Allan Sandfeld Jensen [Qt] Give emulated touch-point a radius https://bugs.webkit.org/show_bug.cgi?id=77985 Increase the radius of touch-point and show the actual size of the touch point in the touch-point mockup. Reviewed by Kenneth Rohde Christiansen. * MiniBrowser/qt/BrowserWindow.cpp: (BrowserWindow::updateVisualMockTouchPoints): * MiniBrowser/qt/MiniBrowserApplication.cpp: (MiniBrowserApplication::notify): * MiniBrowser/qt/qml/MockTouchPoint.qml: 2012-02-07 Mario Sanchez Prada [GTK] Include gdk-pixbuf in the jhbuild modules https://bugs.webkit.org/show_bug.cgi?id=77980 Reviewed by Gustavo Noronha Silva. * gtk/jhbuild.modules: Add gdk-pixbuf to the jhbuild moduleset. 2012-02-07 Simon Hausmann [Qt] Prevent early test termination with newer Qt 5 https://bugs.webkit.org/show_bug.cgi?id=77945 Reviewed by Csaba Osztrogonác. QTBUG-24120 tracks a regression in Qt that would make layout tests terminate early. This patch works around it in a Qt 4 + 5 safe manner by disabling the quitOnLastWindowClosed feature, which we don't want/need for DRT anyway. * DumpRenderTree/qt/main.cpp: (main): Don't quit on last window closed. 2012-02-06 Martin Robinson Fix some miscellaneous 'make dist' error for WebKitGTK+. * MiniBrowser/gtk/GNUmakefile.am: The MiniBrowser generated files should not be distributed. 2012-02-02 Hajime Morrita [PerformanceTests] Each Dromaeo test needs its landing html. https://bugs.webkit.org/show_bug.cgi?id=77504 Reviewed by Ryosuke Niwa. Added an ignorable pattern which happens in some Dromaeo tests. * Scripts/webkitpy/performance_tests/perftestsrunner.py: (PerfTestsRunner): 2012-02-06 Kalev Lember [GTK] Add missing pango include dir to fix build https://bugs.webkit.org/show_bug.cgi?id=77832 Reviewed by Martin Robinson. * GNUmakefile.am: Added $(PANGO_CFLAGS) to libWebCoreInternals_la_CPPFLAGS. 2012-02-06 Martin Robinson [GTK] Fix remaining errors in GTK+ WebKit2 API https://bugs.webkit.org/show_bug.cgi?id=77890 Reviewed by Gustavo Noronha Silva. Verify that WebKit2 GTK+ test files are not skipped during style checks. Skip soup_server_new when checking for NULL versus 0 usage. * Scripts/webkitpy/style/checker_unittest.py: (CheckerDispatcherSkipTest.test_should_skip_with_warning): * Scripts/webkitpy/style/checkers/cpp.py: (check_for_null): 2012-02-06 Eric Seidel webkit-patch apply-from-bug should be able to apply non-reviewed patches https://bugs.webkit.org/show_bug.cgi?id=77883 Reviewed by Adam Barth. This is very helpful if you use bugzilla as a replacement for git-stash. Makes it simpler to re-apply the patch w/o having to look up the patch id. * Scripts/webkitpy/tool/commands/download.py: (ProcessBugsMixin._fetch_list_of_patches_to_process): * Scripts/webkitpy/tool/commands/download_unittest.py: (DownloadCommandsTest.test_apply_from_bug): 2012-02-06 Philippe Normand [webkitpy] cpp style-checker complains about readability/naming in GStreamer elements source files https://bugs.webkit.org/show_bug.cgi?id=77866 Reviewed by Martin Robinson. * Scripts/webkitpy/style/checker.py: Ignore readability/naming errors in some gstreamer source code files defining new GStreamer elements. * Scripts/webkitpy/style/checker_unittest.py: (GlobalVariablesTest.test_path_rules_specifier): 2012-02-06 Carlos Garcia Campos [GTK] Make sure html_dir exists before calling gtkdoc-rebase https://bugs.webkit.org/show_bug.cgi?id=77869 Reviewed by Philippe Normand. * gtk/gtkdoc.py: (GTKDoc.rebase_installed_docs): Check html_dir exists. 2012-02-03 Jocelyn Turcotte [Qt] Don't version QtWebKit.experimental. https://bugs.webkit.org/show_bug.cgi?id=77739 Reviewed by Tor Arne Vestbø. * MiniBrowser/qt/qml/BrowserWindow.qml: 2012-02-06 Carlos Garcia Campos [GTK] Fix several gtkdoc-fixxref warnings https://bugs.webkit.org/show_bug.cgi?id=77613 Reviewed by Martin Robinson. * gtk/generate-gtkdoc: (get_webkit1_options): Add webkitspellcheckerenchant.* to the list of ignored files, since it's private. * gtk/gtkdoc.py: (GTKDoc._ignored_files_basenames): Helper function that returns a string with the list of ignored files basenames separated by a spaces, as expected by several gtkdoc commands. (GTKDoc._run_gtkdoc_scan): Use _ignored_files_basenames for --ignore-headers option. (GTKDoc._run_gtkdoc_mkdb): Use _ignored_files_basenames for --ignore-files option. 2012-02-06 Carlos Garcia Campos [GTK] Fix xrefs after installing API documentation https://bugs.webkit.org/show_bug.cgi?id=77551 Reviewed by Martin Robinson. * GNUmakefile.am: Call generate-gtkdoc --rebase after installing api docs. * gtk/common.py: (prefix_of_pkg_config_file): Get the prefix variable of the given pkg-config file. (gtk_version_of_pkg_config_file): Get the gtk version required by the given pkg-config file. * gtk/generate-gtkdoc: Add --rebase command line option to rebase installed documentation. (get_gtkdoc_module_paths): Get paths where API doc is installed for the dependencies of the given pkg-config file. (get_common_xref_deps): Get API doc directories of dependencies common to WebKit1 and WebKit2. (get_webkit2_options): Add cross_reference_deps option. (get_webkit1_options): Ditto (rebase_installed_docs): Helper function to create a generator for the given pkg-config file and options and call rebase_installed_docs. * gtk/gtkdoc.py: (GTKDoc.__init__): Initialize cross_reference_deps. (GTKDoc._run_gtkdoc_fixxref): Add API doc directories of dependencies. (GTKDoc.rebase_installed_docs): Call gtkdoc-rebase to fix xref links of installed documentation. (PkgConfigGTKDoc.__init__): Get the prefix from the pkg-config file. 2012-02-06 Sergio Villar Senin Incorrect statistics shown when running run-webkit-tests with --repeat-each or --iterations https://bugs.webkit.org/show_bug.cgi?id=77672 Reviewed by Dirk Pranke. Test repetitions must be taken into account when working out the statistics shown by run-webkit-tests. * Scripts/webkitpy/layout_tests/controllers/manager.py: (Manager.prepare_lists_and_print_output): (Manager._print_result_summary): * Scripts/webkitpy/layout_tests/models/result_summary.py: (ResultSummary.__init__): (ResultSummary.add): * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: (MainTest.test_repeat_each_iterations_num_tests): 2012-02-05 Dan Bernstein WebKit2’s WebFrameLoaderClient::shouldUseCredentialStorage() always returns true https://bugs.webkit.org/show_bug.cgi?id=77823 Reviewed by Anders Carlsson. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::InjectedBundlePage): Updated for the additional callback. 2012-02-04 Dan Bernstein Clients cannot prevent caching of individual responses https://bugs.webkit.org/show_bug.cgi?id=77822 Reviewed by Sam Weinig. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::InjectedBundlePage): Updated for the additional callback. 2012-02-04 Sam Weinig Add ability to send WKURLRequests in WebKit2 API user messages https://bugs.webkit.org/show_bug.cgi?id=77819 Reviewed by Anders Carlsson. Add testing for round-tripping WKTypes from the UIProcess, to the WebProcess, and back. - This commit adds a test fixture and tests for WKURLRequestRef, WKURLRef, and WKStringRef. More can easily be added. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKit2/UserMessage.cpp: Added. (TestWebKitAPI): (WebKit2UserMessageRoundTripTest): (TestWebKitAPI::WebKit2UserMessageRoundTripTest::WebKit2UserMessageRoundTripTest): (TestWebKitAPI::WebKit2UserMessageRoundTripTest::didReceiveMessageFromInjectedBundle): (TestWebKitAPI::WebKit2UserMessageRoundTripTest::didFinishLoadForFrame): (TestWebKitAPI::WebKit2UserMessageRoundTripTest::setInjectedBundleClient): (TestWebKitAPI::WebKit2UserMessageRoundTripTest::setPageLoaderClient): (TestWebKitAPI::WebKit2UserMessageRoundTripTest::SetUp): (TestWebKitAPI::WebKit2UserMessageRoundTripTest::roundTrip): (TestWebKitAPI::TEST_F): * TestWebKitAPI/Tests/WebKit2/UserMessage_Bundle.cpp: Added. (TestWebKitAPI): (UserMessageTest): (TestWebKitAPI::UserMessageTest::UserMessageTest): (TestWebKitAPI::UserMessageTest::didReceiveMessage): * TestWebKitAPI/mac/PlatformWebViewMac.mm: (TestWebKitAPI::PlatformWebView::resizeTo): (TestWebKitAPI): * TestWebKitAPI/win/TestWebKitAPI.vcproj: * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj: 2012-02-04 Dan Bernstein WKPreferences instances cannot be copied https://bugs.webkit.org/show_bug.cgi?id=77816 Reviewed by Sam Weinig. * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp: (TestWebKitAPI::TEST): 2012-02-04 Adam Barth garden-o-matic's All Failure tab should let you examine and rebaseline expected failures https://bugs.webkit.org/show_bug.cgi?id=77802 Reviewed by Eric Seidel. This patch refactors our directory grouping code into base.js where it can be shared between failures.js and notifications.js. It then adds an Examine action to each group of failures that triggers the "results" view. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js: * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js: * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js: * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/failures.css: 2012-02-04 Ojan Vafai check-webkit-style is throwing an exception https://bugs.webkit.org/show_bug.cgi?id=77744 Reviewed by David Levin. If the test_list is None, then we don't need to check for unsupported feature tests to skip. * Scripts/webkitpy/layout_tests/port/webkit.py: (WebKitPort._has_test_in_directories): * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: (test_skipped_tests_for_unsupported_features_empty_test_list): 2012-02-03 Adam Barth List of all failures in garden-o-matic should actually list all the failures https://bugs.webkit.org/show_bug.cgi?id=77796 Reviewed by Eric Seidel. This patch wires a bit more data into the new "All Failures" tab. I've also iterated on how we enable this experimental feature. The tab is still just a dumb list, but we'll make it smarter. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js: * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js: * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js: * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js: 2012-02-03 Ryosuke Niwa Windows build fix after r106692. * Scripts/webkitpy/layout_tests/port/base_unittest.py: (PortTest.test_reference_files): 2012-02-03 Beth Dakin https://bugs.webkit.org/show_bug.cgi?id=77782 WebPageProxy::didNewFirstVisuallyNonEmptyLayout should is called more than once on some pages with frames -and corresponding- Reviewed by Sam Weinig. One new test. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames.cpp: Added. (TestWebKitAPI): (TestWebKitAPI::didForceRepaint): (TestWebKitAPI::didFinishLoadForFrame): (TestWebKitAPI::didNewFirstVisuallyNonEmptyLayout): (TestWebKitAPI::setPageLoaderClient): (TestWebKitAPI::TEST): * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames_Bundle.cpp: Added. (TestWebKitAPI): (NewFirstVisuallyNonEmptyLayoutFramesTest): (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutFramesTest::NewFirstVisuallyNonEmptyLayoutFramesTest): (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutFramesTest::didCreatePage): * TestWebKitAPI/Tests/WebKit2/lots-of-iframes.html: Added. 2012-02-03 Dirk Pranke webkitpy: change exit() calls to sys.exit(), fix a leak in outputcapture https://bugs.webkit.org/show_bug.cgi?id=77781 Reviewed by Eric Seidel. This change fixes a couple of issues discovered while debugging test-webkitpy; both calling exit() instead of sys.exit() -- which is discouraged in program code instead of the interpreter -- and a particular usage of outputcapture were stdin to get whacked and preventing debugging. This change introduces a couple of common _exit() methods that will standardize how webkit-patch exit's, in case we need to do something different in the future. * Scripts/webkitpy/common/system/deprecated_logging.py: (error): * Scripts/webkitpy/common/system/outputcapture.py: (OutputCapture.assert_outputs): * Scripts/webkitpy/tool/bot/queueengine.py: (QueueEngine.exit_after_handled_error): * Scripts/webkitpy/tool/commands/abstractsequencedcommand.py: (AbstractSequencedCommand.execute): * Scripts/webkitpy/tool/commands/queues.py: (StyleQueue.handle_script_error): * Scripts/webkitpy/tool/commands/upload.py: (MarkBugFixed.execute): * Scripts/webkitpy/tool/multicommandtool.py: (Command._exit): * Scripts/webkitpy/tool/steps/abstractstep.py: (AbstractStep._exit): * Scripts/webkitpy/tool/steps/checkstyle.py: (CheckStyle.run): * Scripts/webkitpy/tool/steps/commit.py: (Commit._check_test_expectations): * Scripts/webkitpy/tool/steps/confirmdiff.py: (ConfirmDiff.run): 2012-02-03 Ryosuke Niwa Perf bot build fix. * Scripts/webkitpy/performance_tests/perftestsrunner.py: (PerfTestsRunner._generate_json): 2012-02-03 Adam Barth Add a blank "Expected Failures" tab to garden-o-matic https://bugs.webkit.org/show_bug.cgi?id=77793 Reviewed by Eric Seidel. This tab will help us explore and manage our expected failures. The tab is hidden by default via a new "experimental features" flag. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js: * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js: * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js: * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js: * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css: (#unexpected): (#onebar.partytime #unexpected): 2012-02-03 Lucas Forschler update-webkit-support-libraries is broken with the change from http to https on developer.apple.com https://bugs.webkit.org/show_bug.cgi?id=77785 Fix the build bots. Pass the -k and --sslv3 keys to make curl work with https on https://developer.apple.com * Scripts/update-webkit-support-libs: (downloadExpectedVersionNumber): 2012-02-03 Lucas Forschler Add a Mac Lion Performance bot. https://bugs.webkit.org/show_bug.cgi?id=77765 Reviewed by Adam Roben. This will update the master configuration in the following ways: Add a new performance slave (apple-xseve-11) Add a new Factory to download a build and run perf tests. * BuildSlaveSupport/build.webkit.org-config/config.json: * BuildSlaveSupport/build.webkit.org-config/master.cfg: (DownloadAndPerfTestFactory): (DownloadAndPerfTestFactory.__init__): 2012-02-03 Dirk Pranke Extra TestWebKitAPI.gyp/TestWebKitAPI.target.chromium.mk in repository https://bugs.webkit.org/show_bug.cgi?id=77752 Reviewed by James Robinson. Delete unneeded file accidentally checked in in r106481. * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.target.chromium.mk: Removed. 2012-02-03 Ryosuke Niwa Ref Tests should support plain SVG files https://bugs.webkit.org/show_bug.cgi?id=77685 Reviewed by Tony Chang. Don't assume reference files always use .html as the extension. Instead, use the list of supported extension to look for -expected.* and -mismatch.* Also fix various bugs in MockFileSystem and TestPort. * Scripts/webkitpy/common/system/filesystem_mock.py: (MockFileSystem.isdir): * Scripts/webkitpy/layout_tests/port/base.py: (Port.reference_files): * Scripts/webkitpy/layout_tests/port/base_unittest.py: (PortTest.test_is_test_file): (PortTest.test_reference_files): * Scripts/webkitpy/layout_tests/port/test.py: (TestInstance.__init__): 2012-02-03 Ryosuke Niwa perf-o-matic should store chromium svn revision https://bugs.webkit.org/show_bug.cgi?id=77725 Reviewed by Dirk Pranke. Report both WebKit and Chromium revisions to the graph server. Renamed test_repository_paths to repository_paths since it's nothing to do with tests. Also refactored scm so that head_svn_revision is implemented in terms of newly added svn_revision. * Scripts/webkitpy/common/checkout/scm/git.py: (Git.svn_revision): * Scripts/webkitpy/common/checkout/scm/scm.py: (SCM.head_svn_revision): (SCM): (SCM.svn_revision): * Scripts/webkitpy/common/checkout/scm/scm_mock.py: (MockSCM.svn_revision): * Scripts/webkitpy/common/checkout/scm/svn.py: (SVN.svn_revision): * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py: (JSONLayoutResultsGenerator.__init__): * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py: (JSONResultsGeneratorBase._insert_generic_metadata): * Scripts/webkitpy/layout_tests/port/base.py: (Port.repository_paths): * Scripts/webkitpy/layout_tests/port/chromium.py: (ChromiumPort.repository_paths): * Scripts/webkitpy/performance_tests/perftestsrunner.py: (PerfTestsRunner._generate_json): * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py: (test_run_test_set_with_json_output): (test_run_test_set_with_json_source): (test_run_test_set_with_multiple_repositories): 2012-02-03 Jocelyn Turcotte [Qt] Split QQuickWebViewPrivate in two classes, for desktop and touch behavior. https://bugs.webkit.org/show_bug.cgi?id=77632 Reviewed by Kenneth Rohde Christiansen. * MiniBrowser/qt/BrowserWindow.cpp: (BrowserWindow::BrowserWindow): * MiniBrowser/qt/MiniBrowserApplication.cpp: (MiniBrowserApplication::sendTouchEvent): (MiniBrowserApplication::handleUserOptions): * MiniBrowser/qt/MiniBrowserApplication.h: (WindowOptions): (WindowOptions::WindowOptions): * WebKitTestRunner/qt/PlatformWebViewQt.cpp: (WTR::PlatformWebView::PlatformWebView): * WebKitTestRunner/qt/main.cpp: (main): * qmake/mkspecs/features/default_post.prf: 2012-02-03 Simon Hausmann [Qt] Replace GNU linker script for exports with export macros in WTF/JSC https://bugs.webkit.org/show_bug.cgi?id=77723 Reviewed by Tor Arne Vestbø. * Tools.pro: Compile WTR again on all platforms with WK2. 2012-02-03 Sriram Neelakandan Ensure that inspector disabled build works https://bugs.webkit.org/show_bug.cgi?id=77604 Reviewed by Tor Arne Vestbø. * qmake/mkspecs/features/features.prf: 2012-02-02 Jochen Eisinger [chromium] add support for --makeargs to the ninja-based build https://bugs.webkit.org/show_bug.cgi?id=77688 Reviewed by Adam Barth. * Scripts/webkitdirs.pm: (buildChromiumNinja): 2012-02-02 Eric Seidel Run tests in serial on SnowLeopard to avoid CFURLCache crashes https://bugs.webkit.org/show_bug.cgi?id=75145 Reviewed by Dirk Pranke. * Scripts/webkitpy/layout_tests/port/mac.py: (MacPort.default_child_processes): * Scripts/webkitpy/layout_tests/port/mac_unittest.py: (test_operating_system): (test_default_child_processes): 2012-02-02 Dirk Pranke nrwt shouldn't blow up when there are errors in test_expectations.txt https://bugs.webkit.org/show_bug.cgi?id=73603 Reviewed by Ojan Vafai. This change removes the distinction between 'errors' and 'warnings' in the test expectations parser. Now, any problem is a 'warning', and if we are linting the file, warnings become fatal (errors). This will allow a normal run-webkit-tests run to proceed even if there are bad lines. * Scripts/webkitpy/layout_tests/models/test_expectations.py: (ParseError.__init__): (ParseError.__str__): (ParseError.__repr__): (TestExpectationSerializer.to_string): (TestExpectationParser._parse_modifiers): (TestExpectationParser._parse_expectations): (TestExpectationParser._check_modifiers_against_expectations): (TestExpectationParser._tokenize): (TestExpectationLine.__init__): (TestExpectationLine.is_invalid): (TestExpectationsModel.add_expectation_line): (TestExpectationsModel._already_seen_better_match): (TestExpectations.__init__): (TestExpectations._report_warnings): (TestExpectations.remove_rebaselined_tests.without_rebaseline_modifier): * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: (assert_bad_expectations): (test_parse_warning): (test_overrides__duplicate): (ExpectationSyntaxTests.test_missing_expectation): (ExpectationSyntaxTests.test_missing_colon): (ExpectationSyntaxTests.test_too_many_colons): (ExpectationSyntaxTests.test_too_many_equals_signs): (ExpectationSyntaxTests.test_unrecognized_expectation): (SemanticTests.test_bug_format): (SemanticTests.test_bad_bugid): (SemanticTests.test_slow_and_timeout): (test_ambiguous): (test_more_modifiers): (test_order_in_file): (test_macro_overrides): (RebaseliningTest.assertRemove): (TestExpectationParserTests.test_tokenize_blank): (TestExpectationParserTests.test_tokenize_missing_colon): (TestExpectationParserTests.test_tokenize_extra_colon): (TestExpectationParserTests.test_tokenize_empty_comment): (TestExpectationParserTests.test_tokenize_comment): (TestExpectationParserTests.test_tokenize_missing_equal): (TestExpectationParserTests.test_tokenize_extra_equal): (TestExpectationParserTests.test_tokenize_valid): (TestExpectationParserTests.test_tokenize_valid_with_comment): (TestExpectationParserTests.test_tokenize_valid_with_multiple_modifiers): (TestExpectationSerializerTests.test_unparsed_to_string): * Scripts/webkitpy/layout_tests/run_webkit_tests.py: (lint): * Scripts/webkitpy/style/checkers/test_expectations.py: (TestExpectationsChecker.check_test_expectations): 2012-02-02 Sheriff Bot Unreviewed, rolling out r106543. http://trac.webkit.org/changeset/106543 https://bugs.webkit.org/show_bug.cgi?id=77671 Made tests less stable (Requested by rniwa on #webkit). * Scripts/webkitpy/performance_tests/perftestsrunner.py: (PerfTestsRunner): (PerfTestsRunner.__init__): (PerfTestsRunner._run_tests_set): (PerfTestsRunner._run_single_test): * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py: (MainTest.TestDriver.run_test): (run_test): 2012-02-02 Beth Dakin https://bugs.webkit.org/show_bug.cgi?id=77664 Add API tests for didNewFirstVisuallyNonEmptyLayout Reviewed by Darin Adler. Two new tests. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout.cpp: Added. (TestWebKitAPI): (TestWebKitAPI::didNewFirstVisuallyNonEmptyLayout): (TestWebKitAPI::setPageLoaderClient): (TestWebKitAPI::TEST): * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails.cpp: Added. (TestWebKitAPI): (TestWebKitAPI::didForceRepaint): (TestWebKitAPI::didFinishLoadForFrame): (TestWebKitAPI::didNewFirstVisuallyNonEmptyLayout): (TestWebKitAPI::setPageLoaderClient): (TestWebKitAPI::TEST): * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails_Bundle.cpp: Added. (TestWebKitAPI): (NewFirstVisuallyNonEmptyLayoutFailsTest): (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutFailsTest::NewFirstVisuallyNonEmptyLayoutFailsTest): (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutFailsTest::didCreatePage): * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout_Bundle.cpp: Added. (TestWebKitAPI): (NewFirstVisuallyNonEmptyLayoutTest): (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutTest::NewFirstVisuallyNonEmptyLayoutTest): (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutTest::didCreatePage): 2012-02-02 Michael Saboff Add Michael Saboff to reviewers list. Rubber-stamped by Gavin Barraclough. * Scripts/webkitpy/common/config/committers.py: 2012-02-02 Kristóf Kosztyó Add myself as a committer Unreviewed * Scripts/webkitpy/common/config/committers.py: 2012-02-02 Ryosuke Niwa [PerformanceTests] tests have dependencies https://bugs.webkit.org/show_bug.cgi?id=77506 Reviewed by Hajime Morita. Load an initialization page before each test after starting a DRT so that warming up DRT won't affect the performance test results. * Scripts/webkitpy/performance_tests/perftestsrunner.py: (PerfTestsRunner): (PerfTestsRunner.__init__): (PerfTestsRunner._run_tests_set): (PerfTestsRunner._run_single_test): * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py: (MainTest.TestDriver.run_test): (test_initial_page_loaded): (test_initial_page_loaded.run_test): 2012-02-02 Ryosuke Niwa Re-land r106442 per Adam's suggestion. We'll do both restarting DRT and loading a fake test first. * Scripts/webkitpy/performance_tests/perftestsrunner.py: (PerfTestsRunner._run_tests_set): (PerfTestsRunner._run_single_test): * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py: (create_runner): (test_run_passing_test): (test_run_silent_test): (test_run_failed_test): (test_run_tonguey_test): (test_run_timeout_test): (test_run_crash_test): (test_run_test_set_kills_drt_per_run): (test_run_test_set_kills_drt_per_run.TestDriverWithStopCount): (test_run_test_set_kills_drt_per_run.TestDriverWithStopCount.__init__): (test_run_test_set_kills_drt_per_run.TestDriverWithStopCount.stop): 2012-02-01 Jacob Goldstein Webkit generate-coverage-data script needs update to use new test script https://bugs.webkit.org/show_bug.cgi?id=77597 Reviewed by Dirk Schulze. * Scripts/generate-coverage-data: 2012-02-01 Adam Barth Update the tests to show that the mac-ews processes patches from non-committers. * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py: (EarlyWarningSytemTest.test_committer_only_ewses): (EarlyWarningSytemTest.test_builder_ewses): 2012-02-01 Adam Barth Mac-ews logs are huge https://bugs.webkit.org/show_bug.cgi?id=77045 Reviewed by Eric Seidel. In order to get the cr-linux-ews bot to run tests on EC2, we created the chromium-xvfb port, which contained a number of tweaks to the Chromium port's behavior. This patch refactors those tweaks so they can be shared with the mac-ews, mostly by moving them into the non-interactive mode of RunTests. * Scripts/webkitpy/common/config/ports.py: (WebKitPort): (WebKitPort.layout_tests_results_path): (ChromiumPort.run_javascriptcore_tests_command): (ChromiumXVFBPort): (ChromiumXVFBPort.run_webkit_tests_command): * Scripts/webkitpy/common/config/ports_mock.py: (MockPort): (MockPort.layout_tests_results_path): * Scripts/webkitpy/common/config/ports_unittest.py: (WebKitPortTest.test_chromium_xvfb_port): * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py: (LayoutTestResultsReaderTest.test_missing_layout_test_results): * Scripts/webkitpy/tool/commands/queues_unittest.py: (CommitQueueTest.test_commit_queue): (test_rollout): (test_manual_reject_during_processing): * Scripts/webkitpy/tool/steps/runtests.py: (RunTests.run): * Scripts/webkitpy/tool/steps/runtests_unittest.py: (RunTestsTest.test_no_unit_tests): * Scripts/webkitpy/tool/steps/steps_unittest.py: (StepsTest.test_runtests_args): 2012-02-01 Ryosuke Niwa Roll out r106442. It made some tests more stable but others less stable. * Scripts/webkitpy/performance_tests/perftestsrunner.py: (PerfTestsRunner._run_tests_set): (PerfTestsRunner._run_single_test): * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py: (create_runner): (test_run_passing_test): (test_run_silent_test): (test_run_failed_test): (test_run_tonguey_test): (test_run_timeout_test): (test_run_crash_test): (test_run_test_set): 2012-02-01 Lucas Forschler Enable EWS for non-contributers. https://bugs.webkit.org/show_bug.cgi?id=77576 Reviewed by Adam Barth. * Scripts/webkitpy/tool/commands/earlywarningsystem.py: (MacEWS): 2012-02-01 Beth Dakin https://bugs.webkit.org/show_bug.cgi?id=77383 Add a different didFirstVisuallNonEmptyLayout heuristic to experiment with -and corresponding- Reviewed by Sam Weinig. WebKit2's WebLoaderClient has a temporary new function that must be accounted for. * MiniBrowser/mac/BrowserWindowController.m: (-[BrowserWindowController awakeFromNib]): * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize): 2012-02-01 Dirk Pranke TestWebKitAPI isn't being built on chromium bots any more https://bugs.webkit.org/show_bug.cgi?id=77563 Reviewed by Dimitri Glazkov. I accidentally dropped it in the refactoring in r105449. * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp: Added. 2012-02-01 Hans Wennborg Rename WebSpeechInputResult::set() to assign() https://bugs.webkit.org/show_bug.cgi?id=77540 Reviewed by Darin Fisher. * DumpRenderTree/chromium/MockWebSpeechInputController.cpp: (MockWebSpeechInputController::addMockRecognitionResult): (MockWebSpeechInputController::speechTaskFired): 2012-02-01 Carlos Garcia Campos [GTK] WebKit1 API documentation is not generated when building with gtk-2.0 https://bugs.webkit.org/show_bug.cgi?id=77542 Reviewed by Martin Robinson. * gtk/generate-gtkdoc: Check first whether there's webkitgtk-3.0.pc and if it doesn't exist use webkitgtk-1.0.pc instead. (get_webkit2_options): Return just the options since the pkg_config_path doesn't depend on options (get_webkit1_options): Ditto. (generate_doc): Helper function to create a generator and generate documentation for the given pkg-config file with the given options. * gtk/gtkdoc.py: (GTKDoc.__init__): Don't use ** for args parameter, since it's used as a dict and never expanded. (PkgConfigGTKDoc.__init__): Ditto. 2012-02-01 Carlos Garcia Campos [GTK] API documentation is not installed even when building with --enable-gtk-doc https://bugs.webkit.org/show_bug.cgi?id=77094 Reviewed by Martin Robinson. * GNUmakefile.am: Add install-data-local and uninstall-local rules to install/uninstall WebKit1 and WebKit2 API documentation. 2012-02-01 Sheriff Bot Unreviewed, rolling out r106460. http://trac.webkit.org/changeset/106460 https://bugs.webkit.org/show_bug.cgi?id=77552 It break unit tests if WEBKIT_TESTFONTS isn't defined. (Requested by Ossy on #webkit). * Scripts/webkitpy/layout_tests/port/qt.py: 2012-02-01 Nándor Huszka [Qt] Automatic clean build feature always do clean build with --no-webkit2 https://bugs.webkit.org/show_bug.cgi?id=74519 Reviewed by Tor Arne Vestbø. Set the PLUGIN_ARCHITECTURE_UNSUPPORTED define always. * qmake/mkspecs/features/features.prf: 2012-02-01 Jesus Sanchez-Palencia [Qt][WK2] run-webkit-tests --qt crashes if WEBKIT_TESTFONTS is not set https://bugs.webkit.org/show_bug.cgi?id=77466 Reviewed by Kenneth Rohde Christiansen. Replicate the behavior of old-run-webkit-tests and check if WEBKIT_TESTFONTS is set or if we should raise an error. * Scripts/webkitpy/layout_tests/port/qt.py: (QtPort.setup_environ_for_server): 2012-02-01 Philippe Normand and Sergio Villar Senin Reviewed by Martin Robinson. [GTK] Improve FrameLoader signals. Resource loading https://bugs.webkit.org/show_bug.cgi?id=49543 Support for the new loader signals in DRT. * DumpRenderTree/gtk/DumpRenderTree.cpp: (urlPath): (willSendRequestCallback): (urlSuitableForTestResult): (descriptionSuitableForTestResult): (didReceiveResponse): (didFinishLoading): (didFailLoadingWithError): (createWebView): 2012-02-01 Ryosuke Niwa run-perf-tests should restart DRT for each test https://bugs.webkit.org/show_bug.cgi?id=77506 Reviewed by Adam Barth. Always restart DRT when running performance tests in order to minimize the dependency between tests. * Scripts/webkitpy/layout_tests/port/chromium.py: (ChromiumDriver.stop): * Scripts/webkitpy/performance_tests/perftestsrunner.py: (PerfTestsRunner._run_tests_set): (PerfTestsRunner._run_single_test): * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py: (create_runner): (test_run_passing_test): (test_run_silent_test): (test_run_failed_test): (test_run_tonguey_test): (test_run_timeout_test): (test_run_crash_test): (test_run_test_set_kills_drt_per_run): (test_run_test_set_kills_drt_per_run.TestDriverWithStopCount): (test_run_test_set_kills_drt_per_run.TestDriverWithStopCount.__init__): (test_run_test_set_kills_drt_per_run.TestDriverWithStopCount.stop): 2012-01-31 Hans Wennborg Speech Input: Report speech element rect relative to window rather than frame https://bugs.webkit.org/show_bug.cgi?id=76443 Reviewed by Darin Fisher. Update LayoutTestController to allow for retrieving the speech element's position used in a request. In Chromium this is handled by the MockWebSpeechInputController; adding stubs for the other implementations. * DumpRenderTree/LayoutTestController.cpp: (setMockSpeechInputDumpRectCallback): (LayoutTestController::staticFunctions): * DumpRenderTree/LayoutTestController.h: (LayoutTestController): * DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::setMockSpeechInputDumpRect): * DumpRenderTree/chromium/LayoutTestController.h: (LayoutTestController): * DumpRenderTree/chromium/MockWebSpeechInputController.cpp: (MockWebSpeechInputController::setDumpRect): (MockWebSpeechInputController::clearResults): (MockWebSpeechInputController::startRecognition): (MockWebSpeechInputController::MockWebSpeechInputController): (makeRectResult): (MockWebSpeechInputController::speechTaskFired): * DumpRenderTree/chromium/MockWebSpeechInputController.h: (MockWebSpeechInputController): * DumpRenderTree/efl/LayoutTestControllerEfl.cpp: (LayoutTestController::setMockSpeechInputDumpRect): * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setMockSpeechInputDumpRect): * DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::setMockSpeechInputDumpRect): * DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::setMockSpeechInputDumpRect): * DumpRenderTree/qt/LayoutTestControllerQt.h: (LayoutTestController): * DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::setMockSpeechInputDumpRect): * DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::setMockSpeechInputDumpRect): 2012-01-31 Ryuan Choi [EFL] Add basic DRT/Efl implementation to support viewport test. https://bugs.webkit.org/show_bug.cgi?id=77320 Reviewed by Andreas Kling. * DumpRenderTree/efl/LayoutTestControllerEfl.cpp: (LayoutTestController::dumpConfigurationForViewport): call dumpConfigurationForViewport(). 2012-01-31 Alexey Proskuryakov REGRESSION (WebKit2): event.keyCode is always zero when typing in Russian https://bugs.webkit.org/show_bug.cgi?id=77473 Reviewed by Darin Adler. * DumpRenderTree/mac/EventSendingController.mm: (-[EventSendingController keyDown:withModifiers:withLocation:]): * WebKitTestRunner/mac/EventSenderProxy.mm: (WTR::EventSenderProxy::keyDown): Added a new special keyDown value to test this. 2012-01-31 Dirk Pranke nrwt: fix the mock port to work with DriverProxy, reftests https://bugs.webkit.org/show_bug.cgi?id=77170 Reviewed by Eric Seidel. The DryrunPort used for benchmarking and testing NRWT has been broken since we added the DriverProxy code. It isn't really needed any more, so I've removed it. The MockDRT port was also broken by DriverProxy, and moreover, never worked w/ reftests. Since we don't exercise this module in the unit tests, the code had also bitrotted some. I have cleaned it up and made it use DriverInput and DriverOutput for consistency. * Scripts/webkitpy/layout_tests/port/dryrun.py: (DryRunPort.__init__): (DryRunPort): (DryRunPort.real_name): (DryRunPort.create_driver): (DryRunPort.driver_cmd_line): (DryRunPort._driver_class): (DryrunDriver): (DryrunDriver.run_test): * Scripts/webkitpy/layout_tests/port/mock_drt.py: (MockDRTPort.create_driver): (MockChromiumDRT.run_one_test): 2012-01-31 Ojan Vafai run-webkit-tests calls out to webkit-build-directory twice https://bugs.webkit.org/show_bug.cgi?id=77248 Reviewed by Dirk Pranke. * Scripts/webkit-build-directory: If called with no arguments, print out both the top-level directory and the configuration directory * Scripts/webkitpy/layout_tests/port/config.py: (Config.build_directory): When called with no arguments, get and cache both the top-level and configuration directories. * Scripts/webkitpy/layout_tests/port/config_standalone.py: (main): * Scripts/webkitpy/layout_tests/port/config_unittest.py: (ConfigTest.assert_configuration): (ConfigTest.test_build_directory.mock_webkit_build_directory): (ConfigTest.test_build_directory): (ConfigTest.test_default_configuration__notfound): * Scripts/webkitpy/layout_tests/port/webkit.py: (WebKitPort._build_path): Cache the build directory in the options object so that other users of the options object don't need to call out to webkit-build-directory. Also, properly support the existing --build-directory argument. 2012-01-31 Ryosuke Niwa Bump up the timeout for performance tests since DOM/DOMTable.html and Parser/html5-full-render.html are timing out on the bot. * Scripts/webkitpy/performance_tests/perftestsrunner.py: (PerfTestsRunner._parse_args): 2012-01-31 Ehsan Akhgari Fix the update_webgl_conformance_tests.py script in order to enable it to detect the SCM being used correctly. https://bugs.webkit.org/show_bug.cgi?id=77462 Reviewed by Kenneth Russell. * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py: (default_out_dir): 2012-01-31 Eric Seidel webkit-patch apply-from-bug should work regardless of your CWD https://bugs.webkit.org/show_bug.cgi?id=77482 Reviewed by Adam Barth. webkit-patch only ever works with patches made from the root directory. We should pass the CWD to svn-apply in the case where we're running not from the webkit root. I believe this used to work in the past and regressed. * Scripts/webkitpy/common/checkout/checkout.py: (Checkout.apply_patch): * Scripts/webkitpy/common/checkout/checkout_unittest.py: (CheckoutTest.test_apply_patch): 2012-01-31 Sheriff Bot Unreviewed, rolling out r106302. http://trac.webkit.org/changeset/106302 https://bugs.webkit.org/show_bug.cgi?id=77472 Broke building DRT before running the tests (Requested by ojan on #webkit). * Scripts/webkit-build-directory: * Scripts/webkitpy/layout_tests/port/config.py: (Config.build_directory): * Scripts/webkitpy/layout_tests/port/config_standalone.py: (main): * Scripts/webkitpy/layout_tests/port/config_unittest.py: (ConfigTest.assert_configuration): (ConfigTest.test_build_directory.mock_webkit_build_directory): (ConfigTest.test_build_directory): (ConfigTest.test_default_configuration__notfound): * Scripts/webkitpy/layout_tests/port/webkit.py: (WebKitPort._build_path): 2012-01-31 Antoine Labour Merge WebGraphicsContext3D creation and initialization, and move it to WebViewClient. https://bugs.webkit.org/show_bug.cgi?id=76593 Reviewed by Darin Fisher. * DumpRenderTree/chromium/TestWebPlugin.cpp: (TestWebPlugin::TestWebPlugin): (TestWebPlugin::initialize): * DumpRenderTree/chromium/TestWebPlugin.h: * DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::createGraphicsContext3D): (WebViewHost::createPlugin): * DumpRenderTree/chromium/WebViewHost.h: 2012-01-31 Gabor Rapcsanyi [GTK] build-webkit warning. https://bugs.webkit.org/show_bug.cgi?id=77411 Reviewed by Philippe Normand. * Scripts/webkitdirs.pm: (isCrossCompilation): 2012-01-31 Dan Bernstein When generating derived sources, use the same compiler that is used to compile WebKitTestRunner. Reviewed by Anders Carlsson. * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: 2012-01-31 Csaba Osztrogonác If the QTDIR environment variable is set, the build system fails to compile WinCairo https://bugs.webkit.org/show_bug.cgi?id=77112 Reviewed by Daniel Bates. * Scripts/webkitdirs.pm: (determineIsQt): 2012-01-31 Adam Roben Only call -typingAttributes on WebViews, not WebHTMLViews Looks like this case was just missed in r105908. Fixes REGRESSION (r105908): WebKit1.InspectorBarTest is crashing Reviewed by Antti Koivisto. * TestWebKitAPI/Tests/mac/InspectorBar.mm: (TestWebKitAPI::TEST): Call -typingAttributes on the WebView, just like we do 2 lines earlier. 2012-01-31 Jocelyn Turcotte [Qt] MiniBrowser: Show touch mocking indicators only when Ctrl is held down. https://bugs.webkit.org/show_bug.cgi?id=77221 Reviewed by Kenneth Rohde Christiansen. This makes sure that the indicator isn't in the way when doing clicks or dealing with the rest of the UI. * MiniBrowser/qt/MiniBrowserApplication.cpp: (MiniBrowserApplication::sendTouchEvent): 2012-01-26 Hans Wennborg Speech Input: move MockSpeechInputClient into Chromium DumpRenderTree implementation https://bugs.webkit.org/show_bug.cgi?id=77083 Reviewed by Darin Fisher. Add MockWebSpeechInputController which provides a mock implementation of the WebSpeechInputController interface, and use that in DumpRenderTree. * DumpRenderTree/DumpRenderTree.gypi: * DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::addMockSpeechInputResult): * DumpRenderTree/chromium/LayoutTestController.h: (): * DumpRenderTree/chromium/MockWebSpeechInputController.cpp: Added. (MockWebSpeechInputController::create): (MockWebSpeechInputController::addMockRecognitionResult): (MockWebSpeechInputController::clearResults): (MockWebSpeechInputController::startRecognition): (MockWebSpeechInputController::cancelRecognition): (MockWebSpeechInputController::stopRecording): (MockWebSpeechInputController::MockWebSpeechInputController): (MockWebSpeechInputController::speechTaskFired): (MockWebSpeechInputController::SpeechTask::SpeechTask): (MockWebSpeechInputController::SpeechTask::stop): (MockWebSpeechInputController::SpeechTask::runIfValid): * DumpRenderTree/chromium/MockWebSpeechInputController.h: Added. (WebKit): (MockWebSpeechInputController): (MockWebSpeechInputController::taskList): (SpeechTask): * DumpRenderTree/chromium/TestShell.cpp: * DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::speechInputController): * DumpRenderTree/chromium/WebViewHost.h: (WebKit): (WebViewHost::speechInputControllerMock): (WebViewHost): (): 2012-01-31 Hajime Morrita [PerformanceTests] Add landing html for Dromaeo dom-query test https://bugs.webkit.org/show_bug.cgi?id=77329 Reviewed by Ryosuke Niwa. Added some more ignorable output patterns to allow warnings from a third party test suite. * Scripts/webkitpy/performance_tests/perftestsrunner.py: (PerfTestsRunner): (PerfTestsRunner._should_ignore_line_in_parser_test_result): 2012-01-30 Kevin Ollivier [wx] Unreviewed. Update download URLs to new domain. * waf/build/build_utils.py: (update_wx_deps): 2012-01-30 Kevin Ollivier [wx] Unreviewed. Build fix, add JavaScriptCore/tools to the list of build directories. * waf/build/settings.py: 2012-01-30 Kentaro Hara REGRESSION(r105797): prepare-ChangeLog for a .cpp file can output an empty method name (i.e. "()") https://bugs.webkit.org/show_bug.cgi?id=77336 Reviewed by Darin Adler. r105797 tried to detect a change outside methods, but it causes a bug that prepare-ChangeLog can output an empty method name, like this: * foo/bar/baz.cpp: (method1): (): (method2): This is because the cpp parser in prepare-ChangeLog cannot distinguish '{' as the beginning of a method with '{' as the beginning of an array definition at the top level. int a[] = { 1, 2, 3 }; // This '{' is the beginning of an array definition. void func() { // This '{' is the beginning of a method. ...; } This patch fixes prepare-ChangeLog so that it skips an array definition at the top level. * Scripts/prepare-ChangeLog: (get_function_line_ranges_for_cpp): Modified as described above. (generateFunctionLists): As a hack, modified so that prepare-ChangeLog does not output an empty method name. Ideally this should not happen but may happen, since the parsers are not perfect. * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp: Added test cases. (NameSpace7): (NameSpace8): (Class109): * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt: 2012-01-30 Ojan Vafai run-webkit-tests calls out to webkit-build-directory twice https://bugs.webkit.org/show_bug.cgi?id=77248 Reviewed by Dirk Pranke. This reduces to calls to webkit-build-directory to one call and saves 500ms for run-webkit-tests over a single file. * Scripts/webkit-build-directory: If called with no arguments, print out both the top-level directory and the configuration directory. * Scripts/webkit-build-directory: * Scripts/webkitpy/layout_tests/port/config.py: (Config.build_directory): When called with no arguments, get and cache both the top-level and configuration directories. * Scripts/webkitpy/layout_tests/port/config_standalone.py: (main): * Scripts/webkitpy/layout_tests/port/config_unittest.py: (ConfigTest.assert_configuration): (ConfigTest.test_build_directory.mock_webkit_build_directory): (ConfigTest.test_build_directory): (ConfigTest.test_default_configuration__notfound): * Scripts/webkitpy/layout_tests/port/webkit.py: (WebKitPort._build_path): Cache the root directory in the options object so that other users of the options object don't need to call out to webkit-build-directory. 2012-01-30 Ojan Vafai Parsing test_expecations.txt + Skipped lists takes too long https://bugs.webkit.org/show_bug.cgi?id=77059 Reviewed by Dirk Pranke. This saves ~100ms on the Apple Mac port. -memoize a bunch of path methods. -Avoid doing multiple disk accesses per line. -Parse the skipped list directly instead of turning it into a test_expecations.txt formatting string and parsing that. * Scripts/webkitpy/layout_tests/models/test_expectations.py: (TestExpectationParser): (TestExpectationParser.expectation_for_skipped_test): (TestExpectationParser._parse_line): (TestExpectationParser._collect_matching_tests): (TestExpectations.__init__): (TestExpectations._add_skipped_tests): * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: (test_add_skipped_tests): (test_add_skipped_tests_duplicate): * Scripts/webkitpy/layout_tests/port/base.py: (Port): (Port.test_isfile): (Port.normalize_test_name): (Port.layout_tests_dir): (Port.abspath_for_test): * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 2012-01-30 Alexis Menard Unreviewed. Add myself to CSS, GStreamer, Qt related watchlists. * Scripts/webkitpy/common/config/watchlist: 2012-01-30 Gavin Barraclough Unreviewed build fix following bug#76855 * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp: (): (TestWebKitAPI::TEST_F): 2012-01-26 No'am Rosenthal and Jocelyn Turcotte [Qt] WKTR: Use a software rendering pipiline when running tests. https://bugs.webkit.org/show_bug.cgi?id=76708 Reviewed by Kenneth Rohde Christiansen. * WebKitTestRunner/qt/PlatformWebViewQt.cpp: (WTR::WrapperWindow::WrapperWindow): (WTR::PlatformWebView::PlatformWebView): Use software rendering of layers since the wrapping QQuickView isn't shown. 2012-01-30 Tor Arne Vestbø [Qt] Store build config immediately instead of waiting for a successfull build Otherwise we will not pick up changes to the config if the build is aborted, for example due to build errors or if the user pressed Ctrl+Z. We now write the new config before starting a build, but still defer to write the SVN revision once the build completes successfully. Reviewed by Ossy. * Scripts/webkitdirs.pm: (buildQMakeProjects): 2012-01-30 Alexander Færøy [Qt] Add "New Window" button to the Qt MiniBrowser https://bugs.webkit.org/show_bug.cgi?id=77281 Reviewed by Tor Arne Vestbø. * MiniBrowser/qt/BrowserWindow.cpp: (BrowserWindow::BrowserWindow): * MiniBrowser/qt/MiniBrowser.qrc: * MiniBrowser/qt/icons/plus.png: Added. * MiniBrowser/qt/qml/BrowserWindow.qml: 2012-01-30 Csaba Osztrogonác Unreviewed rolling out r106222. * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py: (SingleTestRunner.__init__): * Scripts/webkitpy/layout_tests/controllers/worker.py: (Worker.handle_test_list): * Scripts/webkitpy/layout_tests/models/test_input.py: (TestInput.__init__): * Scripts/webkitpy/layout_tests/run_webkit_tests.py: (_set_up_derived_options): (parse_args): * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: (MainTest.test_repeat_each): * WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::setIsPixelTest): 2012-01-30 Hans Wennborg Unreviewed, rolling out r106219. http://trac.webkit.org/changeset/106219 https://bugs.webkit.org/show_bug.cgi?id=77083 This broke Chromium's test_shell. * DumpRenderTree/DumpRenderTree.gypi: * DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::addMockSpeechInputResult): * DumpRenderTree/chromium/LayoutTestController.h: (WebKit): (LayoutTestController): (): * DumpRenderTree/chromium/MockWebSpeechInputController.cpp: Removed. * DumpRenderTree/chromium/MockWebSpeechInputController.h: Removed. * DumpRenderTree/chromium/TestShell.cpp: * DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::speechInputController): * DumpRenderTree/chromium/WebViewHost.h: (WebKit): (WebViewHost::speechInputControllerMock): (WebViewHost): (): 2012-01-26 Hans Wennborg Speech Input: move MockSpeechInputClient into Chromium DumpRenderTree implementation https://bugs.webkit.org/show_bug.cgi?id=77083 Reviewed by Darin Fisher. Add MockWebSpeechInputController which provides a mock implementation of the WebSpeechInputController interface, and use that in DumpRenderTree. * DumpRenderTree/DumpRenderTree.gypi: * DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::addMockSpeechInputResult): * DumpRenderTree/chromium/LayoutTestController.h: (): * DumpRenderTree/chromium/MockWebSpeechInputController.cpp: Added. (MockWebSpeechInputController::create): (MockWebSpeechInputController::addMockRecognitionResult): (MockWebSpeechInputController::clearResults): (MockWebSpeechInputController::startRecognition): (MockWebSpeechInputController::cancelRecognition): (MockWebSpeechInputController::stopRecording): (MockWebSpeechInputController::MockWebSpeechInputController): (MockWebSpeechInputController::speechTaskFired): (MockWebSpeechInputController::SpeechTask::SpeechTask): (MockWebSpeechInputController::SpeechTask::stop): (MockWebSpeechInputController::SpeechTask::runIfValid): * DumpRenderTree/chromium/MockWebSpeechInputController.h: Added. (WebKit): (MockWebSpeechInputController): (MockWebSpeechInputController::taskList): (SpeechTask): * DumpRenderTree/chromium/TestShell.cpp: * DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::speechInputController): * DumpRenderTree/chromium/WebViewHost.h: (WebKit): (WebViewHost::speechInputControllerMock): (WebViewHost): (): 2012-01-29 Sheriff Bot Unreviewed, rolling out r106109. http://trac.webkit.org/changeset/106109 https://bugs.webkit.org/show_bug.cgi?id=77302 It made tests crash (Requested by Ossy_weekend on #webkit). * WebKitTestRunner/qt/PlatformWebViewQt.cpp: (WTR::WrapperWindow::WrapperWindow): (WTR::PlatformWebView::PlatformWebView): 2012-01-28 Nico Weber [chromium] Add support for building standalone webkit/chromium checkouts with ninja. https://bugs.webkit.org/show_bug.cgi?id=77243 Reviewed by Adam Barth. * Scripts/update-webkit: * Scripts/webkitdirs.pm: (isChromiumNinja): (determineIsChromiumNinja): (buildChromiumNinja): (buildChromium): 2012-01-27 Kentaro Hara The cpp parser of prepare-ChangeLog treats if(...) {} as a method https://bugs.webkit.org/show_bug.cgi?id=77241 Reviewed by Ryosuke Niwa. The cpp parser of prepare-ChangeLog is wrong, and an inner {} block in a method in some namespace or class is treated as a method. This patch fixes the bug. class C { void func() { if (1) { // This should not be treated as a method. } } }; * Scripts/prepare-ChangeLog: (get_function_line_ranges_for_cpp): * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt: * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp: (Class108): (Class108::func35): 2012-01-27 Enrica Casucci Followup to http://trac.webkit.org/changeset/106171. Dan Bernstein pointed out correctly that I should have used copy instead of initWithString. Reviewed by Dan Bernstein. * DumpRenderTree/mac/DumpRenderTreePasteboard.m: (-[LocalPasteboard initWithName:]): 2012-01-27 Enrica Casucci DRT pasteboard object should return the correct pasteboard name. https://bugs.webkit.org/show_bug.cgi?id=77260 Currently the name property always returns nil. Adding a memeber variable to store the pasteboard name and return its value from the name method instead of returning nil always. Reviewed by Dan Bernstein. * DumpRenderTree/mac/DumpRenderTreePasteboard.m: (+[DumpRenderTreePasteboard _pasteboardWithName:]): (-[LocalPasteboard initWithName:]): (-[LocalPasteboard name]): 2012-01-27 Martin Robinson [GTK] [WK2] Implement the policy client https://bugs.webkit.org/show_bug.cgi?id=76343 Reviewed by Gustavo Noronha Silva. * gtk/generate-gtkdoc: (get_webkit2_options): Update the list of skipped source files to include all clients. 2012-01-27 Ada Chan Add test for WKBundleFrameGetParentFrame(). https://bugs.webkit.org/show_bug.cgi?id=77161 Reviewed by Anders Carlsson. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add ParentFrame.cpp and ParentFrame_Bundle.cpp. * TestWebKitAPI/Tests/WebKit2/ParentFrame.cpp: Added. (TestWebKitAPI): (TestWebKitAPI::didReceiveMessageFromInjectedBundle): Get the check result from the injected bundle. (TestWebKitAPI::setInjectedBundleClient): (TestWebKitAPI::TEST): Load simple-iframe.html and then wait for the injected bundle to post result. Make sure the check is successful. * TestWebKitAPI/Tests/WebKit2/ParentFrame_Bundle.cpp: Added. (TestWebKitAPI): (ParentFrameTest): (TestWebKitAPI::ParentFrameTest::ParentFrameTest): (TestWebKitAPI::didFinishLoadForFrame): If the frame is a subframe, store it off for checking later. If the frame is the main frame, check whether it's indeed the subframe's parent frame and post the result to the test controller. (TestWebKitAPI::ParentFrameTest::didCreatePage): Set the page loader client on this page. 2012-01-27 Zan Dobersek [Gtk] DumpRenderTree lacks --no-timeout command line option https://bugs.webkit.org/show_bug.cgi?id=77196 Reviewed by Martin Robinson. Add the --no-timeout command line option and reorganize watchdog code to make running DumpRenderTree without timeout possible. * DumpRenderTree/gtk/DumpRenderTree.cpp: (setWaitToDumpWatchdog): (shouldSetWaitToDumpWatchdog): (initializeGlobalsFromCommandLineOptions): * DumpRenderTree/gtk/DumpRenderTreeGtk.h: * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (waitToDumpWatchdogFired): (LayoutTestController::setWaitToDump): 2012-01-27 Andras Becsi [Qt][WK2] Enable the automatic touch->mouse mocking on the new Qt5 hashes https://bugs.webkit.org/show_bug.cgi?id=77122 Reviewed by Kenneth Rohde Christiansen. * MiniBrowser/qt/MiniBrowserApplication.cpp: (MiniBrowserApplication::MiniBrowserApplication): 2012-01-27 Zeno Albisser [Qt][Mac] Build fails after adding ICU support (r105997). https://bugs.webkit.org/show_bug.cgi?id=77118 Define WTF_USE_ICU_UNICODE if we are on mac. Reviewed by Tor Arne Vestbø. * qmake/mkspecs/features/features.prf: 2012-01-27 Roland Takacs Update committers.py with new contributors. https://bugs.webkit.org/show_bug.cgi?id=77207 I added six new contributors into committers.py: - Adam Kallai - Balazs Ankes - Janos Badics - Nandor Huszka - Roland Takacs - Szilard Ledan-Muntean * Scripts/webkitpy/common/config/committers.py: 2012-01-27 Vsevolod Vlasov Add Vsevolod Vlasov to reviewers list. Reviewed by Pavel Feldman. * Scripts/webkitpy/common/config/committers.py: 2012-01-26 No'am Rosenthal and Jocelyn Turcotte [Qt] WKTR: Use a software rendering pipiline when running tests. https://bugs.webkit.org/show_bug.cgi?id=76708 Reviewed by Kenneth Rohde Christiansen. * WebKitTestRunner/qt/PlatformWebViewQt.cpp: (WTR::WrapperWindow::WrapperWindow): (WTR::PlatformWebView::PlatformWebView): Use software rendering of layers since the wrapping QQuickView isn't shown. 2012-01-26 Kevin Ollivier [wx] Unreviewed. Build fix, add WebCore/testing/js to the list of source directories we build. * waf/build/settings.py: 2012-01-26 Filip Pizlo Tools/Scripts/commit-log-editor is broken due to $_ getting clobbered https://bugs.webkit.org/show_bug.cgi?id=77177 Reviewed by Jon Honeycutt. * Scripts/commit-log-editor: 2012-01-26 Ojan Vafai Decrease sleep time when killing server_process on Mac. https://bugs.webkit.org/show_bug.cgi?id=77169 Reviewed by Eric Seidel. This shaves another ~70ms off single test runtime. * Scripts/webkitpy/layout_tests/port/server_process.py: (ServerProcess.stop): 2012-01-26 Ojan Vafai Remove builder name so http://trac.webkit.org/changeset/106035 actually works. https://bugs.webkit.org/show_bug.cgi?id=77164 Reviewed by Dirk Pranke. http://trac.webkit.org/changeset/106035 depends on builder_name being falsey by default. There's other code that requires it to be iterable by default. So, make it be the empty string. * Scripts/webkitpy/layout_tests/run_webkit_tests.py: (parse_args): 2012-01-26 Ryosuke Niwa run-perf-test should include relative file paths in test names https://bugs.webkit.org/show_bug.cgi?id=77144 Reviewed by Adam Birth. Include all directory names in the test name separated by "/". e.g. Bindings/event-target-wrapper.html translates to Bindings/event-target-wrapper * Scripts/webkitpy/performance_tests/perftestsrunner.py: (PerfTestsRunner): (PerfTestsRunner._process_parser_test_result): * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py: (test_run_test_set_with_json_output): (test_run_test_set_with_json_source): 2012-01-26 Dirk Pranke webkitpy: re-land cleanup of test scaffolding https://bugs.webkit.org/show_bug.cgi?id=77153 Reviewed by Eric Seidel. This is an attempt to reland the change in bug 76973 / r105935. My earlier attempt to manipulate PYTHONPATH seems to only work some of the time, for reasons that elude me. Directly adding Tools/Scripts to sys.path from inside the test script appears to work (more?) reliably. Also, it seemed like the files didn't actually get deleted the last time; I don't know why. * Scripts/test-webkitpy: * Scripts/webkitpy/common/system/executive_unittest.py: (command_line): (ExecutiveTest): (ExecutiveTest.test_run_command_args_type): (ExecutiveTest.test_run_command_with_unicode): (ExecutiveTest.test_running_pids): (main): * Scripts/webkitpy/common/system/fileutils.py: Removed. * Scripts/webkitpy/test/cat.py: Removed. * Scripts/webkitpy/test/cat_unittest.py: Removed. * Scripts/webkitpy/test/echo.py: Removed. * Scripts/webkitpy/test/echo_unittest.py: Removed. 2012-01-26 Ojan Vafai run-webkit-tests calls "nm" when it doesn't need to https://bugs.webkit.org/show_bug.cgi?id=77143 Reviewed by Dirk Pranke. If we are not running any test that can be skipped by checking the DRT feature list or looking at the list of symbols, avoid calling out to DRT or calling "nm". This saves ~700ms on my Mac Pro. In cases where you still have to call out to "nm" it's only a couple ms slower. * Scripts/webkitpy/layout_tests/models/test_expectations.py: (TestExpectations.__init__): * Scripts/webkitpy/layout_tests/port/base.py: (Port.skipped_tests): * Scripts/webkitpy/layout_tests/port/webkit.py: (WebKitPort._should_check_for_missing_features): (WebKitPort): (WebKitPort._should_check_for_missing_symbols): (WebKitPort._skipped_tests_for_unsupported_features): (WebKitPort.skipped_layout_tests): (WebKitPort.skipped_tests): * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: (WebKitPortTest.test_skipped_directories_for_symbols): (test_skipped_directories_for_features): (test_skipped_directories_for_features_no_matching_tests_in_test_list): (test_skipped_layout_tests): 2012-01-26 Benjamin Poulain Support a suffix on ChangeLog filenames based on a configuration file https://bugs.webkit.org/show_bug.cgi?id=76956 Reviewed by Kentaro Hara. Modify the tools used to generate, edit and resolve ChangeLogs to support the addition of a suffix to the ChangeLog filename. This patch makes it easier to support alternate ChangeLog files in branches. * Scripts/VCSUtils.pm: (changeLogSuffix): (changeLogFileName): * Scripts/commit-log-editor: * Scripts/prepare-ChangeLog: (getLatestChangeLogs): (generateNewChangeLogs): (generateFileList): * Scripts/resolve-ChangeLogs: (findChangeLog): 2012-01-26 Sheriff Bot Unreviewed, rolling out r106038. http://trac.webkit.org/changeset/106038 https://bugs.webkit.org/show_bug.cgi?id=77142 Caused a bunch of skipped tests to not be skipped. (Requested by ojan on #webkit). * Scripts/webkitpy/layout_tests/models/test_expectations.py: (TestExpectationParser): (TestExpectationParser.parse): (TestExpectationParser._parse_line): (TestExpectationParser._collect_matching_tests): (TestExpectations.__init__): (TestExpectations._add_skipped_tests): * Scripts/webkitpy/layout_tests/port/base.py: (Port.test_dirs): (Port.normalize_test_name): (Port.update_baseline): (Port.layout_tests_dir): (Port.relative_perf_test_filename): (Port.abspath_for_test): 2012-01-25 Ojan Vafai Parsing test_expecations.txt + Skipped lists takes too long https://bugs.webkit.org/show_bug.cgi?id=77059 Reviewed by Dirk Pranke. This saves ~100ms on the Apple Mac port. -memoize a bunch of path methods. -Avoid doing multiple disk accesses per line. -Parse the skipped list directly instead of turning it into a test_expecations.txt formatting string and parsing that. * Scripts/webkitpy/layout_tests/models/test_expectations.py: (TestExpectationParser): (TestExpectationParser.parse_skipped_tests): (TestExpectationParser._parse_line): (TestExpectationParser._collect_matching_tests): (TestExpectations.__init__): (TestExpectations._add_skipped_tests): * Scripts/webkitpy/layout_tests/port/base.py: (Port): (Port.test_isfile): (Port.normalize_test_name): (Port.layout_tests_dir): (Port.abspath_for_test): 2012-01-25 Ojan Vafai Only store the SVN revision in the summarized results if we're on a builder https://bugs.webkit.org/show_bug.cgi?id=76976 Reviewed by Dirk Pranke. This shaves another ~130ms off the single test run-webkit-tests runtime. * Scripts/webkitpy/layout_tests/controllers/manager.py: (summarize_results): * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py: (ResultSummaryTest.get_result): (ResultSummaryTest): (ResultSummaryTest.get_result_summary): (ResultSummaryTest.get_unexpected_results): (ResultSummaryTest.test_no_svn_revision): (ResultSummaryTest.test_svn_revision): * Scripts/webkitpy/layout_tests/port/base.py: (Port.use_trac_links_in_results_html): 2012-01-26 Luciano Wolf [Qt][WK2] fast/loader tests failed after r94178 https://bugs.webkit.org/show_bug.cgi?id=67388 Reviewed by Simon Hausmann. Applying the same fix used for Qt-WebKit1 from bug #67254 - [Qt][DRT] Normalize file:///tmp/LayoutTests in LayoutTestController::pathToLocalResource() https://bugs.webkit.org/show_bug.cgi?id=67254 Translate file:///tmp/LayoutTests/* urls into the repository LayoutTests directory, which is derived from the running location of DumpRenderTree binary. * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp: (WTR::LayoutTestController::pathToLocalResource): 2012-01-26 Caio Marcelo de Oliveira Filho Implement overridePreference for boolean preferences in WebKitTestRunner https://bugs.webkit.org/show_bug.cgi?id=77033 Reviewed by Alexey Proskuryakov. For now overridePreference supports boolean values. * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::LayoutTestController::setXSSAuditorEnabled): (WTR::LayoutTestController::overridePreference): * WebKitTestRunner/InjectedBundle/LayoutTestController.h: * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetStateToConsistentValues): Reset the overrides explicitly and properly disable the use of PageCache when resetting the state. Tests that use PageCache can now enable it via overridePreference. 2012-01-26 Alexander Færøy [Qt] Support opening multiple URL's from the command line in the Qt MiniBrowser https://bugs.webkit.org/show_bug.cgi?id=77100 Reviewed by Simon Hausmann. This patch makes the MiniBrowser read multiple URL's from the command line such that there will be one browser window opened for each URL. * MiniBrowser/qt/MiniBrowserApplication.cpp: (MiniBrowserApplication::handleUserOptions): 2012-01-26 Alexander Færøy [Qt] The Qt MiniBrowser crashes when given multiple URL's https://bugs.webkit.org/show_bug.cgi?id=77009 Reviewed by Simon Hausmann. This patch fixes a crash in BrowserWindow::newWindow() where a BrowserWindow-object is constructed with a 0 pointer as the WindowOptions parameter which leads to a crash. * MiniBrowser/qt/BrowserWindow.cpp: (BrowserWindow::BrowserWindow): (BrowserWindow::newWindow): * MiniBrowser/qt/BrowserWindow.h: 2012-01-26 Jesus Sanchez-Palencia [Qt] Use ICU if available https://bugs.webkit.org/show_bug.cgi?id=76821 Reviewed by Simon Hausmann. Adding unicode defines for a Qt 5 based build. * qmake/mkspecs/features/features.prf: 2012-01-26 Nándor Huszka [WK2] WebKitTestRunner needs layoutTestController.setGeolocationPermission https://bugs.webkit.org/show_bug.cgi?id=42545 Reviewed by Zoltan Herczeg. Implement the setGeolocationPermission method. * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::LayoutTestController::setGeolocationPermission): (WTR): * WebKitTestRunner/InjectedBundle/LayoutTestController.h: (LayoutTestController): 2012-01-26 Balazs Kelemen [NRWT] Support --ignore-metrics https://bugs.webkit.org/show_bug.cgi?id=76278 Reviewed by Tony Chang. Port the feature from ORWT. * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py: (SingleTestRunner._run_compare_test): * Scripts/webkitpy/layout_tests/port/driver.py: (DriverOutput): (DriverOutput.strip_metrics): * Scripts/webkitpy/layout_tests/port/driver_unittest.py: (DriverOutputTest): (DriverOutputTest.test_strip_metrics): * Scripts/webkitpy/layout_tests/run_webkit_tests.py: (_set_up_derived_options): (parse_args): 2012-01-26 Sheriff Bot Unreviewed, rolling out r105935 and r105954. http://trac.webkit.org/changeset/105935 http://trac.webkit.org/changeset/105954 https://bugs.webkit.org/show_bug.cgi?id=77080 test-webkitpy is still broken (Requested by abarth on #webkit). * Scripts/test-webkitpy: * Scripts/webkitpy/common/system/executive_unittest.py: (never_ending_command): (ExecutiveTest.test_run_command_args_type): (ExecutiveTest.test_run_command_with_unicode): (ExecutiveTest.test_running_pids): * Scripts/webkitpy/common/system/fileutils.py: (make_stdout_binary): * Scripts/webkitpy/test/cat.py: (command_arguments): (main): * Scripts/webkitpy/test/cat_unittest.py: (CatTest): (CatTest.assert_cat): (CatTest.test_basic): (CatTest.test_no_newline): (CatTest.test_unicode): (CatTest.test_as_command): * Scripts/webkitpy/test/echo.py: (command_arguments): (main): * Scripts/webkitpy/test/echo_unittest.py: (EchoTest): (EchoTest.test_basic): (EchoTest.test_no_newline): (EchoTest.test_unicode): (EchoTest.test_argument_order): (EchoTest.test_empty_arguments): (EchoTest.test_no_arguments): (EchoTest.test_as_command): 2012-01-26 Gabor Rapcsanyi [GTK] Detect cross-compilation in webkitdirs.pm to not generate gtkdoc https://bugs.webkit.org/show_bug.cgi?id=76138 Reviewed by Martin Robinson. * Scripts/webkitdirs.pm: (isCrossCompilation): (buildAutotoolsProject): 2012-01-25 Adam Barth Kentaro is a reviewer now. Yay! * Scripts/webkitpy/common/config/committers.py: 2012-01-25 Dirk Pranke nrwt: running w/ no arguments fails https://bugs.webkit.org/show_bug.cgi?id=77064 Unreviewed, build fix. This change fixes a regression introduced in r105944 where running without --platform or one of the other platform switches would cause a null deref :(. * Scripts/webkitpy/layout_tests/run_webkit_tests.py: (main): 2012-01-25 Eric Seidel Automatically CC someone from Apple on any changes to Obj-C public API https://bugs.webkit.org/show_bug.cgi?id=77053 Reviewed by Timothy Hatcher. This has long been de-facto practice, seems now that we have fancy watchlist support, we should just make the tools do this automatically. * Scripts/webkitpy/common/config/watchlist: 2012-01-25 Antoine Labour Updating status in committers.py. Unreviewed. * Scripts/webkitpy/common/config/committers.py: 2012-01-25 Dirk Pranke test-webkitpy: executive_unittest fails if PYTHONPATH isn't set https://bugs.webkit.org/show_bug.cgi?id=77058 Reviewed by Eric Seidel. r105935 broke executive_unittest by changing which script we were running and not ensuring that the PYTHONPATH was set up properly. This change also fixes a regression introduced recently where test-webkitpy wasn't figuring out the path to Tools/Scripts right, either (so running ./test-webkitpy would fail). * Scripts/test-webkitpy: * Scripts/webkitpy/common/system/executive_unittest.py: (script_dir): (ExecutiveTest.setUp): (ExecutiveTest): (ExecutiveTest.tearDown): 2012-01-25 Adam Barth Disable tests on the mac-ews while we sort out hte stability issues. * Scripts/webkitpy/tool/commands/earlywarningsystem.py: (MacEWS): 2012-01-23 Dirk Pranke investigate use of 'mac' and 'win' as fully-specified port names for the apple ports https://bugs.webkit.org/show_bug.cgi?id=76475 Reviewed by Eric Seidel. This patch cleans up the internal usage of port names for the Apple mac and Apple win ports so that 'mac' and 'win are never considered "fully specified" port names: they are still legal input to the PortFactory.get() routine, but only if run on the given platform (i.e. trying to PortFactory.get('mac') on windows or linux will return an error, since we don't know which version of the port is desired. This also cleans up handling of the webkit2 variants, so that the full port names consistently follow the -[-] convention. Lastly this patch adds some assertions and removes some try/catch logic to catch more programming and usage errors; previously mac-tiger might've been allowed -- and it would've translated into using just the baselines in platform/mac -- but now it should fail. * Scripts/webkitpy/layout_tests/port/apple.py: (ApplePort.determine_full_port_name): (ApplePort.__init__): (ApplePort): (ApplePort._port_name_with_version): * Scripts/webkitpy/layout_tests/port/builders.py: * Scripts/webkitpy/layout_tests/port/factory_unittest.py: (FactoryTest.test_mac): (FactoryTest.test_win): * Scripts/webkitpy/layout_tests/port/mac.py: (MacPort.baseline_search_path): * Scripts/webkitpy/layout_tests/port/mac_unittest.py: (MacTest.test_versions): * Scripts/webkitpy/layout_tests/port/win.py: (WinPort.baseline_search_path): * Scripts/webkitpy/layout_tests/port/win_unittest.py: (WinTest.test_versions): 2012-01-25 Dirk Pranke webkitpy: print nicer errors while linting expectations files, remove redundant tests https://bugs.webkit.org/show_bug.cgi?id=76955 Reviewed by Adam Barth. This change cleans up the errors that are printed so that the are more "quickfix" compatible (path:lineno). Also, there were a bunch of redundant tests between layout_tests.models.test_expectations_unittest and style.checkers.test_expectations_unittest. The latter should just expect the former to do most of the testing. * Scripts/webkitpy/layout_tests/models/test_expectations.py: (TestExpectationParser._parse_modifiers): (TestExpectations._report_errors): (TestExpectations._add_skipped_tests): * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: (test_parse_error_nonfatal): (SemanticTests.test_bad_bugid): * Scripts/webkitpy/style/checkers/test_expectations.py: (TestExpectationsChecker.__init__): * Scripts/webkitpy/style/checkers/test_expectations_unittest.py: (TestExpectationsTestCase.assert_lines_lint): (TestExpectationsTestCase.test_valid_expectations): (TestExpectationsTestCase.test_invalid_expectations): (TestExpectationsTestCase.test_tab): 2012-01-25 Eric Seidel webkit-patch apply-* should always continue after failures https://bugs.webkit.org/show_bug.cgi?id=77057 Reviewed by Adam Barth. As far as I can tell there is only one potential drawback to always forcing: that if you're somehow in the wrong directory it will create new directories for new files. Since webkit-patch always cd's to the root it seems that's not a drawback. The drawback of not using --force for svn-apply, is that it will stop after the first failure, which is rarely (if ever) the desired behavior. This just removes the force option (which was strangely hidden behind --non-interactive). This should make for a better user experiance. * Scripts/webkitpy/common/checkout/checkout.py: (Checkout.apply_patch): * Scripts/webkitpy/common/checkout/checkout_mock.py: (MockCheckout.apply_patch): * Scripts/webkitpy/common/checkout/checkout_unittest.py: (CheckoutTest.test_chromium_deps): (CheckoutTest): (CheckoutTest.test_apply_patch): * Scripts/webkitpy/tool/commands/download_unittest.py: (DownloadCommandsTest._default_options): * Scripts/webkitpy/tool/steps/applypatch.py: (ApplyPatch.options): (ApplyPatch.run): * Scripts/webkitpy/tool/steps/options.py: (Options): 2012-01-25 Dirk Pranke nrwt: should be able to run --platform test interactively https://bugs.webkit.org/show_bug.cgi?id=76959 Reviewed by Adam Barth. As part of refactoring the Port interfaces, in r103254 I made passing a Host object to the Port mandatory; previously TestPort objects would create their own (mock) hosts. However, new-run-webkit-tests always passed a real Host, not a MockHost, and so you couldn't run new-run-webkit-tests --platform test interactively to debug test failures. This change fixes that by creating a MockHost instead of a real host if you say --platform test*. * Scripts/webkitpy/layout_tests/run_webkit_tests.py: (main): 2012-01-25 Dirk Pranke run-webkit-tests --lint-test-files should lint all the ports by default https://bugs.webkit.org/show_bug.cgi?id=76749 Reviewed by Ojan Vafai. Currently run-webkit-tests --lint-test-files will only lint the test_expectations for the single port determined by the command line options. This is not obvious and can produce unintended results if you want to lint the chromium port (probably the normal case for using --lint-test-files) but don't specify a port name or --chromium. I think we should probably lint *all* of the ports if no port name is supplied. This change implements that, and also moves the linting logic out of the Manager class, since this really has nothing to do with Managers. It has little to do with run-webkit-tests, but splitting it into a different script would introduce compatibility issues. It might make sense to do that anyway, in a separate patch and combining that with cleaning up the style checker to share more code. * Scripts/webkitpy/layout_tests/controllers/manager.py: (Manager._strip_test_dir_prefix): * Scripts/webkitpy/layout_tests/run_webkit_tests.py: (lint): (run): * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: (LintTest.test_all_configurations): added. (LintTest.test_lint_test_files): added. (LintTest.test_lint_test_files__errors): added. (MainTest.test_lint_test_files): removed. (MainTest.test_lint_test_files__errors): removed. 2012-01-25 Dirk Pranke webkitpy: clean up a bunch of test scaffolding https://bugs.webkit.org/show_bug.cgi?id=76973 Reviewed by Eric Seidel. There were several helper modules in the webkitpy.test package that appear to only be used by executive_unittest.py. I am rolling them all into that file to make that clearer. * Scripts/webkitpy/common/system/executive_unittest.py: (ExecutiveTest.test_run_command_args_type): (ExecutiveTest.test_run_command_with_unicode): (ExecutiveTest.test_running_pids): (command_line): (main): * Scripts/webkitpy/common/system/fileutils.py: Removed. * Scripts/webkitpy/test/cat.py: Removed. * Scripts/webkitpy/test/cat_unittest.py: Removed. * Scripts/webkitpy/test/echo.py: Removed. * Scripts/webkitpy/test/echo_unittest.py: Removed. 2012-01-25 Dirk Pranke webkitpy: clean up a bunch of test scaffolding https://bugs.webkit.org/show_bug.cgi?id=76973 Reviewed by Eric Seidel. There were several helper modules in the webkitpy.test package that appear to only be used by executive_unittest.py. I am rolling them all into that file to make that clearer. * Scripts/webkitpy/common/system/executive_unittest.py: (ExecutiveTest.test_run_command_args_type): (ExecutiveTest.test_run_command_with_unicode): (ExecutiveTest.test_running_pids): (command_line): (main): * Scripts/webkitpy/common/system/fileutils.py: Removed. * Scripts/webkitpy/test/cat.py: Removed. * Scripts/webkitpy/test/cat_unittest.py: Removed. * Scripts/webkitpy/test/echo.py: Removed. * Scripts/webkitpy/test/echo_unittest.py: Removed. 2012-01-25 Eric Seidel Remove Python 2.5 support from WebKit https://bugs.webkit.org/show_bug.cgi?id=71593 Reviewed by Adam Barth. Just removing support from this one core file. I'll commit the rest of the (large) change once we've gone 24 hours and seen that no bots have exploded. We can roll out this one change if we break bots and then roll in the rest once those bots are fixed. * Scripts/webkitpy/common/system/executive.py: (Executive.cpu_count): 2012-01-25 Hajime Morita ENABLE_SHADOW_DOM should be available via build-webkit --shadow-dom https://bugs.webkit.org/show_bug.cgi?id=76863 Reviewed by Dimitri Glazkov. Added a feature flag. * Scripts/build-webkit: * qmake/mkspecs/features/features.prf: 2012-01-25 Martin Robinson [WK2] Navigation events not triggered by a mouse event claim to be triggered by the left mouse button during policy decisions https://bugs.webkit.org/show_bug.cgi?id=76344 Reviewed by Sam Weinig. Add a test verifying that the mouse button during policy decisions for events not triggered by mouse events is NoButton. * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp: (TestWebKitAPI::decidePolicyForNavigationAction): Added test. (TestWebKitAPI::decidePolicyForNewWindowAction): Added test. 2012-01-25 Ryosuke Niwa run-perf-tests should timeout sooner https://bugs.webkit.org/show_bug.cgi?id=77026 Reviewed by Adam Barth. Bump off the timeout from 10 minutes to 4 minutes. Also use float instead of str in test result values to compress the size of json files bots upload. * Scripts/webkitpy/performance_tests/perftestsrunner.py: (PerfTestsRunner._parse_args): (PerfTestsRunner._process_chromium_style_test_result): (PerfTestsRunner._process_parser_test_result): * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py: (test_run_test_set_for_parser_tests): (test_run_test_set_with_json_output): (test_run_test_set_with_json_source): 2012-01-25 Enrica Casucci WebView should implement typingAttributes methods to work correctly with the Inspector bar in Mail. https://bugs.webkit.org/show_bug.cgi?id=76951 Reviewed by Alexey Proskuryakov. * TestWebKitAPI/Tests/mac/InspectorBar.mm: Modified to reflect the changes to WebView and WebHTMLView. (TestWebKitAPI::TEST): 2012-01-23 MORITA Hajime [Refactoring][Internals] Should have InternalSettings https://bugs.webkit.org/show_bug.cgi?id=76424 Reviewed by Kent Tamura. * GNUmakefile.am: Added so new files. 2012-01-25 Takashi Toyoshima webkitpy: new-run-webkit-websocket is broken https://bugs.webkit.org/show_bug.cgi?id=76999 Reviewed by Dirk Pranke. r105674 broke new-run-webkit-websocket, since options.chromium doesn't exist any more. new-run-webkit-httpd was also broken and already fixed at r105835. * Scripts/new-run-webkit-websocketserver: (main): 2012-01-25 Nándor Huszka [WK2] WebKitTestRunner needs layoutTestController.setPopupBlockingEnabled https://bugs.webkit.org/show_bug.cgi?id=63458 Reviewed by Adam Roben. Implement the setPopupBlockingEnabled method. * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::LayoutTestController::setPopupBlockingEnabled): * WebKitTestRunner/InjectedBundle/LayoutTestController.h: 2012-01-24 Balazs Kelemen [Qt] Cleanup testfonts handling https://bugs.webkit.org/show_bug.cgi?id=76068 Reviewed by Simon Hausmann. Factor test font initialization into it's own file so test font users can share the implementation by adding the file to their build. Use fonts.conf from the test font directory to not require the current directory to be the WebKit root. Fix the -use-test-fonts option of QtTestBrowser by initializing the fonts earlier, before it is too late (namely before calling show on the main window). * DumpRenderTree/qt/DumpRenderTree.pro: * DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::open): * DumpRenderTree/qt/DumpRenderTreeQt.h: * DumpRenderTree/qt/QtInitializeTestFonts.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp. (WebKit::initializeTestFonts): * DumpRenderTree/qt/QtInitializeTestFonts.h: Added. * DumpRenderTree/qt/fonts.conf: Removed. No need for this since we will use the one from the test fonts directory. * DumpRenderTree/qt/main.cpp: (main): Fix the ifdefs to make it clear that the code to set up the Dpi has not been ported to Qt5 yet. * QtTestBrowser/QtTestBrowser.pro: * QtTestBrowser/launcherwindow.h: (WindowOptions::WindowOptions): * QtTestBrowser/main.cpp: (launcherMain): (LauncherApplication::handleUserOptions): * WebKitTestRunner/InjectedBundle/Target.pri: * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp: (WTR::activateFonts): Remove the code to set up the Dpi because it does not work with Qt5. 2012-01-25 Simon Hausmann [Qt] build-webkit --qt requires a git-svn or SVN checkout. Reviewed by Tor Arne Vestø. Don't require it by making svnRevisionForDirectory return "unknown" instead of bailing out with an error. * Scripts/VCSUtils.pm: (svnRevisionForDirectory): 2012-01-25 Adam Barth Temporarily disable running the unit tests on the Chromium EWS. These tests don't work properly (see https://bugs.webkit.org/show_bug.cgi?id=76979) and are currently blocking the EWS. * Scripts/webkitpy/common/config/ports.py: (ChromiumPort): 2012-01-25 Adam Barth Update results.html version of PixelZoomer https://bugs.webkit.org/show_bug.cgi?id=76965 Reviewed by Ojan Vafai. Improve readability as suggested by Ojan. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/pixelzoomer.js: 2012-01-25 Carlos Garcia Campos [GTK] Page clients don't need to be GObjects anymore in WebKit2 GTK+ API https://bugs.webkit.org/show_bug.cgi?id=76899 Reviewed by Martin Robinson. * gtk/generate-gtkdoc: (get_webkit2_options): WebKitWebLoaderClient has been renamed to WebKitLoaderClient. 2012-01-24 Ryosuke Niwa Build fix. Trigger Chromium Mac Release (Perf) on new commits. * BuildSlaveSupport/build.webkit.org-config/config.json: 2012-01-23 Ryosuke Niwa WebKit needs public performance tests running on public bots https://bugs.webkit.org/show_bug.cgi?id=10266 Reviewed by Adam Barth. Completes the initial implementation of WebKit Perf bots. Add a build step for run-perf-test and make google-mac-4 run it, and upload the results to webkit-perf.webkit.org. * BuildSlaveSupport/build.webkit.org-config/config.json: * BuildSlaveSupport/build.webkit.org-config/master.cfg: (RunAndUploadPerfTests): (RunAndUploadPerfTests.start): (UploadPerfTestResults): (BuildAndPerfTestFactory): (BuildAndPerfTestFactory.__init__): 2012-01-24 Ojan Vafai Initializing the browser property of the Bugzilla class takes too long https://bugs.webkit.org/show_bug.cgi?id=76960 Reviewed by Adam Barth. Lazily initialize it. This saves ~150ms on a no-op run-webkit-tests call on my Mac Pro. * Scripts/webkitpy/common/net/bugzilla/bugzilla.py: (Bugzilla.__init__): (Bugzilla._get_browser): (Bugzilla): (Bugzilla._set_browser): 2012-01-24 Mark Rowe Death to JavaScriptGlue. Rubber-stamped by Geoffrey Garen. * BuildSlaveSupport/build-launcher-app: (copyNightlyLauncher): * Scripts/build-webkit: * Scripts/do-file-rename: * Scripts/do-webcore-rename: * Scripts/webkitpy/common/config/build.py: (_should_file_trigger_build): * Scripts/webkitpy/common/config/build_unittest.py: Update the test to use another Mac-specific path in conjunction with a cross-platform path. (ShouldBuildTest): 2012-01-24 Kentaro Hara webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl should test stdout and stderr https://bugs.webkit.org/show_bug.cgi?id=75836 Reviewed by David Kilzer. Previously parser_unittests.pl can just test the returned value of get_function_line_ranges() in prepare-ChangeLog. This patch fixes parser_unittests.pl so that it also tests the stdout and stderr of get_function_line_ranges(). This patch adds css_unittests_warning.css, which contains test cases for warning messages of the CSS parser of prepare-ChangeLog. * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl: (captureOutput): Captures the stdout and stderr of a given method. (convertAbsolutepathToWebKitPath): Converts absolute paths in a given string to relative paths. * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests_warning-expected.txt: Added. * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests_warning.css: Added. (element1): (element2): (element3): (element4): (): (element5): (element6): * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt: Just updated the test results, i.e. added stdout and stderr results. No essential changes in the test results. * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests-expected.txt: Ditto. * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/java_unittests-expected.txt: Ditto. * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests-expected.txt: Ditto. * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests-expected.txt: Ditto. * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/python_unittests-expected.txt: Ditto. 2012-01-24 Dirk Pranke webkitpy: new-run-webkit-httpd is broken https://bugs.webkit.org/show_bug.cgi?id=76963 Reviewed by Adam Barth. r105674 broke new-run-webkit-httpd, since options.chromium doesn't exist any more. We didn't catch this because we don't run the integration tests by default anywhere :(. * Scripts/new-run-webkit-httpd: (run): (main): 2012-01-24 Adam Barth garden-o-matic pixel zoomer should let you look at every pixel of the image https://bugs.webkit.org/show_bug.cgi?id=76962 Reviewed by Ojan Vafai. Previously, you couldn't get up to the right and bottom pixels. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/pixelzoomer.js: 2012-01-24 Enrica Casucci WebHTMLView should implement typingAttributes methods to work correctly with the Inspector bar in Mail. https://bugs.webkit.org/show_bug.cgi?id=76951 Added test to verify that WebHTMLView supports the typingAttributes method and that it works as expected. Reviewed by Alexey Proskuryakov. * TestWebKitAPI/Tests/mac/InspectorBar.mm: (TestWebKitAPI::TEST): 2012-01-24 James Robinson Put a space between the trac link and ellipsis in sheriffbot rollout message so it linkifies better in some IRC clients https://bugs.webkit.org/show_bug.cgi?id=76884 Reviewed by Adam Barth. * Scripts/webkitpy/tool/bot/irc_command.py: (Rollout.execute): * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py: (SheriffIRCBotTest.test_rollout): (SheriffIRCBotTest.test_revert): (SheriffIRCBotTest.test_multi_rollout): (SheriffIRCBotTest.test_rollout_with_r_in_svn_revision): (SheriffIRCBotTest.test_multi_rollout_with_r_in_svn_revision): (SheriffIRCBotTest.test_rollout_invalidate_reason): (test_multi_rollout_invalidate_reason): 2012-01-24 Kentaro Hara The cpp parser of prepare-ChangeLog cannot detect a change in classes and namespaces https://bugs.webkit.org/show_bug.cgi?id=75531 Reviewed by David Kilzer. Previously, the cpp parser of prepare-ChangeLog could not detect a change outside methods. Consider the following cpp file. namespace N { int a; // this change does not appear on ChangeLog. class C { int b; // this change does not appear on ChangeLog. void f() { int c; // this change appears on ChangeLog. } int d; // this change does not appear on ChangeLog. }; int e; // this change does not appear on ChangeLog. }; The previous prepare-ChangeLog outputs just methods in which a change is found: (N::C::f): This patch fixes prepare-ChangeLog so that it outputs namespaces, classes and methods in which a change is found: (N): (N::C): (N::C::f): * Scripts/prepare-ChangeLog: (get_function_line_ranges_for_cpp): Modified as described above. * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp: Added test cases. (Class104): (Class105): (Class106): (Class106::func32): (Class106::func33): (NameSpace3): (NameSpace4): (NameSpace5): (NameSpace6): (Class107): (NameSpace5::NameSpace6::Class107::func34): * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt: 2012-01-24 Kentaro Hara prepare-ChangeLog outputs warnings for top-level { ... } blocks https://bugs.webkit.org/show_bug.cgi?id=75943 Reviewed by David Kilzer. Currently, prepare-ChangeLog outputs warnings for top-level { ... } blocks, because it does not distinguish '}' at the end of a subroutine with '}' at the end of a if or for statement. foo.pl: if (1) { } for (@v) { } output: nested functions found at top-level at foo.pl:2 nested functions found at top-level at foo.pl:4 This patch fixes the bug. * Scripts/prepare-ChangeLog: (get_function_line_ranges_for_perl): * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl: Added test cases. No change in the test results. 2012-01-24 Dirk Pranke r105674 broke check-webkit-style for chromium's test_expectations. Unreviewed, build fix. We now need to pass in a platform name of 'chromium' if we want the chromium port; options.chromium is no longer recognized. I will follow this patch up with a separate patch that has a test, but this at least fixes the build. * Scripts/webkitpy/style/checkers/test_expectations.py: (TestExpectationsChecker._determine_port_from_exepectations_path): 2012-01-20 Ojan Vafai check-webkit-style of the chromium test_expectations.txt file takes too long https://bugs.webkit.org/show_bug.cgi?id=76745 Reviewed by Dimitri Glazkov. When in lint mode, have TestExpectations test all configurations instead of looping over each configuration. This also has the benefit of making the error output considerably more concise. Also, got rid of the double-printing of errors when linting through check-webkit-style. * Scripts/webkitpy/layout_tests/controllers/manager.py: (Manager.lint): * Scripts/webkitpy/layout_tests/models/test_expectations.py: (TestExpectations._report_errors): (TestExpectations._add_expectations): * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: (test_parse_error_nonfatal): (test_error_on_different_platform): * Scripts/webkitpy/style/checkers/test_expectations.py: (TestExpectationsChecker.check_test_expectations): (TestExpectationsChecker.check): * Scripts/webkitpy/style/checkers/test_expectations_unittest.py: (TestExpectationsTestCase.test_determine_port_from_exepectations_path): (TestExpectationsTestCase.assert_lines_lint): 2012-01-24 Ryosuke Niwa Another build fix attempt after r105543. * Scripts/webkitpy/common/net/file_uploader.py: (FileUploader.upload_as_multipart_form_data): 2012-01-24 Ryosuke Niwa Build fix attempt after r105543. * Scripts/webkitpy/common/net/file_uploader.py: (FileUploader.upload_as_multipart_form_data): 2012-01-24 Vincent Scheib [Chromium] Add Pointer Lock test hooks and mock implementation to DumpRenderTree https://bugs.webkit.org/show_bug.cgi?id=76411 Reviewed by Adam Barth. Breaking up https://bugs.webkit.org/show_bug.cgi?id=75762 into a series of patches, this change adds a trivial pointer lock implementation to the Chromium port's DumpRenderTree and exposes LayoutTestController hooks to force failure conditions. * DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::didLosePointerLock): (LayoutTestController::setPointerLockWillFailAsynchronously): (LayoutTestController::setPointerLockWillFailSynchronously): * DumpRenderTree/chromium/LayoutTestController.h: * DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::requestPointerLock): (WebViewHost::requestPointerUnlock): (WebViewHost::isPointerLocked): (WebViewHost::didCompletePointerLock): (WebViewHost::didNotCompletePointerLock): (WebViewHost::didLosePointerLock): (WebViewHost::reset): * DumpRenderTree/chromium/WebViewHost.h: (WebViewHost::setPointerLockWillFailAsynchronously): (WebViewHost::setPointerLockWillFailSynchronously): 2012-01-24 Mario Sanchez Prada Unreviewed, skip WK2 API test timing out on some GTK bots. WebKit2APITests/TestDownloads is consistently timing out on the 32bit release and 64bit debug bots. * Scripts/run-gtk-tests: (TestRunner): Skip WebKit2APITests/TestDownloads. 2012-01-24 Andras Becsi [Qt] Fix the build with the newes Qt5 hashes https://bugs.webkit.org/show_bug.cgi?id=76657 Reviewed by Simon Hausmann. * MiniBrowser/qt/MiniBrowserApplication.cpp: (MiniBrowserApplication::MiniBrowserApplication): Disable the automatic touch->mouse event synthesis for now to prevent an infinite loop where Qt always creates mouse events out of our touch mock events. 2012-01-24 Tor Arne Vestbø [Qt] Distinguish between Cygwin and cmd.exe in the way we set env variables We can't use win32-msvc* to decide whether or not to use (set FOO=bar), as building with MinGW inside cmd.exe will require the same construct. Instead we assume that when the first character in PWD is a '/' we're running under Cygwin, and use the normal unix way of setting environment variables. Reviewed by Simon Hausmann. * qmake/mkspecs/features/default_pre.prf: 2012-01-24 Simon Hausmann Some qmake build files must include Qt5's "quick" module. https://bugs.webkit.org/show_bug.cgi?id=76671 Unreviewed build fix. * MiniBrowser/qt/MiniBrowser.pro: * WebKitTestRunner/Target.pri: 2012-01-24 Andras Becsi [Qt] Fix the event timestamps for touch mocking Reviewed by Simon Hausmann. * MiniBrowser/qt/MiniBrowserApplication.cpp: (MiniBrowserApplication::sendTouchEvent): We should not set QEvent::None as the timestamp argument in the QWindowSystemInterface::handleTouchEvent call. 2012-01-24 Carlos Garcia Campos [GTK] Implement DownloadClient in WebKit2 GTK+ API https://bugs.webkit.org/show_bug.cgi?id=72952 Reviewed by Martin Robinson. * gtk/generate-gtkdoc: (get_webkit2_options): Ignore WebKitDownloadClient. 2012-01-23 Zan Dobersek [GTK] editing/deleting/5408255.html results are incorrect https://bugs.webkit.org/show_bug.cgi?id=53644 Reviewed by Martin Robinson. WEBKIT_TOP_LEVEL environment variable is now set directly in either WebKitTestRunner or DumpRenderTree through usage of a compilation-time macro. This way both tools can be run outside the test harness without the need to manually set the environment variable. * DumpRenderTree/gtk/DumpRenderTree.cpp: (getTopLevelPath): * GNUmakefile.am: * Scripts/webkitpy/layout_tests/port/gtk.py: (GtkPort.setup_environ_for_server): * WebKitTestRunner/GNUmakefile.am: * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp: (WTR::InjectedBundle::platformInitialize): 2012-01-23 Dmitry Lomov [Chromium] Implement layoutTestController.workerThreadCount in DRT https://bugs.webkit.org/show_bug.cgi?id=74653. Reviewed by Darin Fisher. * DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::workerThreadCount): * DumpRenderTree/chromium/LayoutTestController.h: 2012-01-23 Dirk Pranke nrwt: make --chromium work like --qt https://bugs.webkit.org/show_bug.cgi?id=76875 Reviewed by Adam Barth. --chromium used to have to be handled differently from --qt due to the way the PortFactory was implemented; there's not really a good reason for that any more so this patch makes things slightly more consistent and eliminates the options.chromium flag (--chromium is now truly a synonym for --platform chromium). * Scripts/webkitpy/layout_tests/port/factory.py: (PortFactory._default_port): (PortFactory.get): * Scripts/webkitpy/layout_tests/port/factory_unittest.py: (FactoryTest.setUp): (FactoryTest.test_chromium_mac): (FactoryTest.test_chromium_linux): (FactoryTest.test_chromium_win): * Scripts/webkitpy/layout_tests/run_webkit_tests.py: (parse_args): 2012-01-23 Dirk Pranke run-webkit-tests needs to propagate --chromium https://bugs.webkit.org/show_bug.cgi?id=76870 Reviewed by Eric Seidel. run-webkit-tests removes '--chromium' argument from @ARGV when determining which port to run, which means that that doesn't propagate to new-run-webkit-tests. That's bad (and is handled for the other ports by re-adding the flag, but apparently we're just now noticing for Chromium). * Scripts/run-webkit-tests: 2012-01-23 Brian Weinstein More build fixing after r105646. * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp: (TestWebKitAPI::TestNode::key): 2012-01-23 Gavin Barraclough Unreviewed build fix - r105646 broke this. * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp: (TestWebKitAPI::TestNode::TestNode): (TestWebKitAPI::TestNode::key): (TestWebKitAPI::RedBlackTreeTest::assertEqual): (TestWebKitAPI::RedBlackTreeTest::assertSameValuesForKey): (TestWebKitAPI::RedBlackTreeTest::testDriver): 2012-01-23 Sheriff Bot Unreviewed, rolling out r105658. http://trac.webkit.org/changeset/105658 https://bugs.webkit.org/show_bug.cgi?id=76883 We want this eventually, but not right at this moment (Requested by abarth on #webkit). * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js: 2012-01-23 Adam Barth garden-o-matic should support Chromium Mac Lion https://bugs.webkit.org/show_bug.cgi?id=76880 Reviewed by Eric Seidel. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js: 2012-01-23 Emil A Eklund check-webkit-style whitespace/operators triggers on overloaded division operator https://bugs.webkit.org/show_bug.cgi?id=76650 Reviewed by Darin Adler. * Scripts/webkitpy/style/checkers/cpp.py: (check_spacing): * Scripts/webkitpy/style/checkers/cpp_unittest.py: (CppStyleTest.test_operator_methods): 2012-01-23 Ryosuke Niwa run-perf-tests should report server-side errors https://bugs.webkit.org/show_bug.cgi?id=76802 Reviewed by Tony Chang. Report errors whenever server's response doesn't match "OK". * Scripts/webkitpy/common/net/file_uploader.py: (FileUploader.upload_single_text_file): (FileUploader.upload_as_multipart_form_data): (FileUploader._upload_data.callback): (FileUploader): (FileUploader._upload_data): * Scripts/webkitpy/performance_tests/perftestsrunner.py: (PerfTestsRunner._upload_json): * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py: (test_upload_json): (test_upload_json.MockFileUploader.upload_single_text_file): 2012-01-22 Ryosuke Niwa run-perf-tests ignore Skipped list on chromium https://bugs.webkit.org/show_bug.cgi?id=76764 Reviewed by Dirk Pranke. Move skipped_perf_tests from WebKit port to Base port so that Chromium port can also find skipped list. Chromium port only uses test_expectations.txt for layout tests but performacne tests don't use test_expectations.txt so Chromium port also needs to use Skipped list. * Scripts/webkitpy/layout_tests/port/base.py: (Port._tests_from_skipped_file_contents): (Port): (Port._expectations_from_skipped_files): (Port.skipped_perf_tests): * Scripts/webkitpy/layout_tests/port/base_unittest.py: (PortTest.test_skipped_perf_tests): (PortTest.test_skipped_perf_tests.add_text_file): * Scripts/webkitpy/layout_tests/port/webkit.py: (WebKitPort._skipped_tests_for_unsupported_features): (WebKitPort._skipped_file_search_paths): (WebKitPort.skipped_layout_tests): 2012-01-23 Andy Estes Fix the build after r105635. * TestWebKitAPI/Tests/WTF/StringBuilder.cpp: (TestWebKitAPI::TEST): 2012-01-23 Xianzhu Wang Basic enhancements to StringBuilder https://bugs.webkit.org/show_bug.cgi?id=67081 Reviewed by Darin Adler. * TestWebKitAPI/Tests/WTF/StringBuilder.cpp: (TestWebKitAPI::TEST): 2012-01-23 Mario Sanchez Prada [GTK] run-gtk-tests randomly fails while running the xprop comand https://bugs.webkit.org/show_bug.cgi?id=76817 Reviewed by Gustavo Noronha Silva. No need to use xprop to remove the AT_SPI_BUS property since run-gtk-tests will always run new instances of Xvfb. * Scripts/run-gtk-tests: (TestRunner): Unskip TestWebKitAccessibility. (TestRunner.run): Uncomment lines for launching the accessibility bus and registry daemon, and remove lines for running xprop. 2012-01-23 Tor Arne Vestbø [Qt] Don't warn about override and final being C++11 extensions Clang will emit a warning when these extensions are used without passing --std=c++11, but we use feature checking to decide if we have the right extensions, so we can safely ignore these warnings. The XCode and Windows project files have the same workaround. The reason for adding the flag to QMAKE_OBJECTIVE_CFLAGS as well is that we only have one extra compiler for Objective-C, which is also used for Objective-C++ sources, so we have to pass the flag, even if it doesn't make sense for Objective-C. Reviewed by Simon Hausmann. * qmake/mkspecs/features/unix/default_post.prf: 2012-01-20 Tor Arne Vestbø [Qt] Change how build-webkit decides when to do full incremental builds Instead of relying on update-webkit (which isn't run on the bots) to decide when to do a full incremental build (make qmake), we let the build-webkit script itself check the current SVN revision against the previous build (by storing it in .webkit.config). If the two differ we assume a full incremental build is needed, since the new revisions might have introduced problematic things like new Q_OBJECT macros. If not, we assume the developer is doing changes locally, and revert to doing a plain 'make'. In addition, when the build fails in the latter case, we inform the developer of possible pitfalls and how to manually run 'make qmake'. Reviewed by Ossy. * Scripts/update-webkit: * Scripts/webkitdirs.pm: (buildQMakeProjects): 2012-01-23 Mario Sanchez Prada [GTK] run-gtk-tests randomly fails while running the xprop comand https://bugs.webkit.org/show_bug.cgi?id=76817 Reviewed by Philippe Normand. Temporarily comment the lines related to launching the ATSPI bus and registry daemon, which are making the bots to fail randomly. * Scripts/run-gtk-tests: (TestRunner): Skip TestWebKitAccessibility, as it won't run properly if the ATSPI infrastructure is not properly initialized. (TestRunner.run): Comment lines related to initialization of ATSPI. 2012-01-22 Ryosuke Niwa Windows python test build fix. * Scripts/webkitpy/performance_tests/perftestsrunner.py: (PerfTestsRunner.__init__): 2012-01-22 Sergio Villar Senin [GTK] DumpRenderTree converts "file:///" to a path differently https://bugs.webkit.org/show_bug.cgi?id=76631 Reviewed by Martin Robinson. DumpRenderTree should print "/" as the last path component if the path is a lone slash instead of empty output. * DumpRenderTree/gtk/DumpRenderTree.cpp: (webViewConsoleMessage): 2012-01-20 David Levin The leaky DC check should use adoptPtr as a signal instead of OwnPtr to get less false positives. https://bugs.webkit.org/show_bug.cgi?id=76752 Reviewed by Eric Seidel. * Scripts/webkitpy/style/checkers/cpp.py: (check_for_leaky_patterns): * Scripts/webkitpy/style/checkers/cpp_unittest.py: (LeakyPatternTest.test_create_dc): (LeakyPatternTest.test_create_compatible_dc): 2012-01-20 Shawn Singh Changed my status in commiters.py Unreviewed. * Scripts/webkitpy/common/config/committers.py: 2012-01-20 Ojan Vafai run-webkit-tests --lint-test-files crawls the whole LayoutTests subtree https://bugs.webkit.org/show_bug.cgi?id=76748 Reviewed by Ryosuke Niwa. It crawls the whole subtree and then doesn't use the data. Cutting this out saves 4 seconds warm and 17 seconds cold on my Mac Pro. * Scripts/webkitpy/layout_tests/run_webkit_tests.py: (run): 2012-01-20 Adam Barth Another tiny tweak to the garden-o-matic CSS. This makes things line up slightly nicer when there aren't any failures. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css: (#summary): 2012-01-19 Ryosuke Niwa run-perf-tests should support --test-results-server option https://bugs.webkit.org/show_bug.cgi?id=76680 Reviewed by Adam Barth. Add --test-results-server, --builder-name, and --build-number options to run-perf-tests to be used by perf bots. Also refactor file_uploader as needed. * Scripts/webkitpy/common/net/file_uploader.py: (FileUploader.__init__): (FileUploader.upload_single_file): (FileUploader.upload_as_multipart_form_data): (FileUploader): (FileUploader._upload_data): (FileUploader._upload_data.callback): * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py: (JSONResultsGeneratorBase.upload_json_files): * Scripts/webkitpy/performance_tests/perftestsrunner.py: (PerfTestsRunner): (PerfTestsRunner._parse_args): (PerfTestsRunner.run): (PerfTestsRunner._generate_json): (PerfTestsRunner._upload_json): (PerfTestsRunner._run_tests_set): * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py: (create_runner): (test_run_with_upload_json): (test_run_with_upload_json.mock_upload_json): (test_upload_json): (test_upload_json.MockFileUploader): (test_upload_json.MockFileUploader.__init__): (test_upload_json.MockFileUploader.upload_single_file): (test_parse_args): 2012-01-20 Adam Barth The party time image overlaps real content! This patch makes the image centered vertically. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css: (#onebar.partytime #summary): 2012-01-19 Ojan Vafai Refactor TestExpectationsParser in preparation for caching the results https://bugs.webkit.org/show_bug.cgi?id=76669 Reviewed by Dimitri Glazkov. Make everything private expect for the parse method. Eventually, we'll need the expectations lines to not be modified outside of TestExpectationsParser so we can cache the results. This makes check-webkit-style of the chromium test_expectations.txt file go from ~17 seconds to ~12 seconds on my Mac Pro. This patch is just a refactor in preparation, so no new tests. * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py: (TestExpectationEditorTests.make_parsed_expectation_lines): * Scripts/webkitpy/layout_tests/models/test_expectations.py: (TestExpectationParser.parse): (TestExpectationParser): (TestExpectationParser._parse_line): (TestExpectationParser._tokenize): (TestExpectationParser._tokenize_list): (TestExpectationsModel._clear_expectations_for_test): (TestExpectations.__init__): (TestExpectations._add_expectations): (TestExpectations._add_skipped_tests): * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: (TestExpectationParserTests.test_tokenize_blank): (TestExpectationParserTests.test_tokenize_missing_colon): (TestExpectationParserTests.test_tokenize_extra_colon): (TestExpectationParserTests.test_tokenize_empty_comment): (TestExpectationParserTests.test_tokenize_comment): (TestExpectationParserTests.test_tokenize_missing_equal): (TestExpectationParserTests.test_tokenize_extra_equal): (TestExpectationParserTests.test_tokenize_valid): (TestExpectationParserTests.test_tokenize_valid_with_comment): (TestExpectationParserTests.test_tokenize_valid_with_multiple_modifiers): (TestExpectationParserTests.test_parse_empty_string): (TestExpectationSerializerTests.assert_round_trip): (TestExpectationSerializerTests.assert_list_round_trip): * Scripts/webkitpy/tool/commands/expectations.py: (OptimizeExpectations.execute): * Scripts/webkitpy/tool/servers/gardeningserver.py: (GardeningExpectationsUpdater.update_expectations): 2012-01-20 Adam Barth Follow-up to previous patch: don't produce NaN when the revision number is missing. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js: * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model_unittests.js: 2012-01-20 Adam Barth Garden-o-matic should tell me which revisions have been checked by all the bots https://bugs.webkit.org/show_bug.cgi?id=76722 Reviewed by Dimitri Glazkov. This information helps me know when it's safe for me to roll a candidate revision. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js: * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js: * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model_unittests.js: 2012-01-20 Tor Arne Vestbø build-webkit: Don't spit out congratulations message on Ctrl+C Reviewed by Andreas Kling. * Scripts/build-webkit: 2012-01-20 Philippe Normand [GTK] Allow extra jhbuild modulesets https://bugs.webkit.org/show_bug.cgi?id=76691 Reviewed by Gustavo Noronha Silva. * gtk/jhbuildrc: Extra modulesets and modules can be added in JHBuild using the WEBKIT_EXTRA_MODULESETS and WEBKIT_EXTRA_MODULES env variables respectively. Use comma-separated values. Example: WEBKIT_EXTRA_MODULES=file:///path/to/module.set,file:///other/path. 2012-01-20 Mario Sanchez Prada [GTK] Expose accessibility hierarchy in WebKit2 to ATK/AT-SPI based ATs https://bugs.webkit.org/show_bug.cgi?id=72589 Reviewed by Martin Robinson. Ensure the accessibility infrastructure is available when running the unit tests, otherwise WK2's accessibility tests won't work. * Scripts/run-gtk-tests: (TestRunner): (TestRunner._lookup_atspi2_binary): New. Looks for the directory where at-spi2's stuff is located (like at-spi-bus-launcher and at-spi2-registryd). (TestRunner.run): Initialize the accessibility infrastructure. * gtk/generate-gtkdoc: (get_webkit2_options): Add 'WebKitWebViewBaseAccessible.*'. * gtk/jhbuild.modules: Added at-spi2-core and at-spi2-atk. 2012-01-20 Hayato Ito Add ShadowRoot.idl which is enabled by newly introduced SHADOW_DOM flag. https://bugs.webkit.org/show_bug.cgi?id=76353 Reviewed by Hajime Morita. Add ShadowRoot.idl, which is enabled only on chromium port since this is under development feature. ShadowRoot.idl contains minimum API so that we can test it. Other APIs should be added on other changes so that we can isolate issues. * DumpRenderTree/chromium/TestShell.cpp: (TestShell::TestShell): 2012-01-20 Mario Sanchez Prada [GTK] GTK's DRT not to log events for already defunct objects https://bugs.webkit.org/show_bug.cgi?id=76620 Reviewed by Martin Robinson. Do not log 'state-change:defunct' events. * DumpRenderTree/gtk/AccessibilityCallbacks.cpp: (printAccessibilityEvent): Early return if a 'state-change:defunct' signal is passed. (axObjectEventListener): Pass the signal name and value in separate parameters to printAccessibilityEvent. 2012-01-19 Gustavo Noronha Silva Unreviewed build fix. Wrong variable being used as the cwd for git remote update command. * gtk/run-with-jhbuild: (update_jhbuild): 2012-01-19 Gustavo Noronha Silva [GTK] ensure the jhbuild used by webkit is as up-to-date as needed https://bugs.webkit.org/show_bug.cgi?id=76585 Reviewed by Martin Robinson. This allows us to specify a minimum version of jhbuild required, while also providing stability against changes done to the master branch, by letting us choose what is the exact version that will be used. * gtk/run-with-jhbuild: refactored for more hackability and easier reading (jhbuild_installed): checks whether jhbuild is installed (jhbuild_cloned): checks whether jhbuild has been cloned (jhbuild_at_expected_revision): checks whether jhbuild is at the expected revision (update_jhbuild): brings jhbuild to the expected revision (clone_jhbuild): clones jhbuild (install_jhbuild): build and installs jhbuild (update_webkitgtk_libs): runs update-webkitgtk-libs (ensure_jhbuild): high-level logic to decide whether and which of the steps above are executed 2012-01-19 Alexey Proskuryakov [WK2] DumpRenderTree converts "file:///" to a path differently https://bugs.webkit.org/show_bug.cgi?id=76653 Reviewed by John Sullivan. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::lastFileURLPathComponent): Do print a slash if there are no path components. 2012-01-19 Eric Seidel webkit-patch cannot rollout patches without changelog/bug number https://bugs.webkit.org/show_bug.cgi?id=75962 Reviewed by Adam Barth. * Scripts/webkitpy/tool/commands/download.py: (AbstractRolloutPrepCommand._prepare_state): * Scripts/webkitpy/tool/commands/download_unittest.py: (AbstractRolloutPrepCommandTest.test_prepare_state): 2012-01-19 Alexey Proskuryakov [WK2] fast/url/degenerate-file-base.html fails https://bugs.webkit.org/show_bug.cgi?id=76619 Reviewed by Adam Roben. A URL generated form local path for loading had an extra slash, making document.URL incorrect in all WebKit2 tests (file://localhost//path/to/test.html). * WebKitTestRunner/TestInvocation.cpp: (WTR::createWKURL): 2012-01-18 Ojan Vafai check-webkit-style of the chromium test_expectations.txt file doesn't test all chromium ports https://bugs.webkit.org/show_bug.cgi?id=76510 Reviewed by Adam Barth. Unlike other style rules, if you get the syntax of the test_expectations.txt file wrong, the layout tests won't run. Also, this check is simple and only slows down committing if you actually modify one of the test_expectations.txt files. * Scripts/webkitpy/style/checkers/test_expectations.py: (TestExpectationsChecker.check_test_expectations): (TestExpectationsChecker.check): * Scripts/webkitpy/style/checkers/test_expectations_unittest.py: (TestExpectationsTestCase.test_check_covers_all_configurations): (TestExpectationsTestCase.test_check_covers_all_configurations.mock_check_test_expectations): (TestExpectationsTestCase): (assert_lines_lint): 2012-01-19 Ryosuke Niwa Build fix. Revert an unintentional change to WebKitDriver in r105443. * Scripts/webkitpy/layout_tests/port/driver.py: (DriverProxy.__init__): 2012-01-19 Dirk Pranke remove the duplicated build rules from WebKit.gyp, Tools.gyp https://bugs.webkit.org/show_bug.cgi?id=73384 Reviewed by Tony Chang. This patch removes the no-longer-necessary conditional logic for build_webkit_exes_from_webkit_gyp; we now always build the exes from their own dedicated gyp files. * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: 2012-01-19 Alexey Proskuryakov make-new-script-test should work with HTTP tests https://bugs.webkit.org/show_bug.cgi?id=76603 Reviewed by Adam Roben. * Scripts/make-new-script-test: (makePathToSharedSources): Renamed from makeTestRelativePathToSharedSources(), since it now also creates absolute paths for HTTP. 2012-01-19 Ryosuke Niwa Some perf tests time out when ran by run-perf-tests https://bugs.webkit.org/show_bug.cgi?id=76612 Reviewed by Dirk Pranke and Eric Seidel. Always pass --no-timeout to DumpRenderTree from run-perf-tests. Otherwise some tests such as Parser/xml-parser.html will timeout. --no-timeout option is currently supported by Chromium and Mac ports. * Scripts/webkitpy/layout_tests/port/base.py: (Port.to.create_driver): * Scripts/webkitpy/layout_tests/port/chromium.py: (ChromiumDriver.__init__): (ChromiumDriver._wrapper_options): * Scripts/webkitpy/layout_tests/port/driver.py: (Driver.__init__): (DriverProxy.__init__): * Scripts/webkitpy/layout_tests/port/webkit.py: (WebKitDriver.__init__): (WebKitDriver.cmd_line): * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: (WebKitDriverTest.test_read_binary_block): (WebKitDriverTest): (WebKitDriverTest.test_no_timeout): * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: (get_tests_run.RecordingTestDriver.__init__): * Scripts/webkitpy/performance_tests/perftestsrunner.py: (PerfTestsRunner._parse_args): (PerfTestsRunner._run_tests_set): * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py: (create_runner): 2012-01-19 Ben Wells Add support for window.print to chromium DRT https://bugs.webkit.org/show_bug.cgi?id=76479 When used in a test window.print goes into print mode and then straight out again. This will allow the afterprint event to be tested by having the afterprint event happen before the dump happens. Reviewed by Mihai Parparita. * DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::printPage): * DumpRenderTree/chromium/WebViewHost.h: 2012-01-18 Enrica Casucci editingAttributedStringFromRange in WebHTMLConverter does not handle NSUnderlineStyleAttributeName. https://bugs.webkit.org/show_bug.cgi?id=76588 Added test. Reviewed by Dan Bernstein. * TestWebKitAPI/Tests/mac/InspectorBar.mm: (TestWebKitAPI::TEST): 2012-01-19 Tor Arne Vestbø [Qt] Do full incremental builds until bots use update-webkit Rubber-stamped by Simon Hausmann. * Scripts/webkitdirs.pm: (buildQMakeProjects): 2012-01-19 Tor Arne Vestbø Fix the Qt build Unreviewed build fix. * Scripts/webkitdirs.pm: (buildQMakeProjects): 2012-01-19 Tor Arne Vestbø [Qt] Make build-webkit always do safe incremental builds after update-webkit When building against Qt5 with GCC we would just run 'make' in the build dir, and rely on the dependency files output by GCC (-MD) to handle dependency tracking, but that fails for special-cases like adding a Q_OBJECT macro to a header. To guarantee that an incrmental build will work, we have to run 'make qmake', which we now do on every build-webkit that's followed by a successful run of update-webkit. The reasoning is that update-webkit can result in such potential corner-cases being applied, and since we can't know for sure unless we inspect the diff and account for all the corner cases we assume the worst and always run 'make qmake'. After a succesful run of build-webkit we proceed to do just 'make' for any subsequent runs, since we assume that the developer knows what kind of changes he/she is doing, and when a 'make qmake' is needed. Reviewed by Simon Hausmann. * Scripts/update-webkit: * Scripts/webkitdirs.pm: (determineCurrentSVNRevision): (currentSVNRevision): (buildQMakeProjects): * qmake/mkspecs/features/default_post.prf: 2012-01-18 Ryosuke Niwa run-perf-tests should support Skipped list https://bugs.webkit.org/show_bug.cgi?id=76594 Reviewed by Adam Barth. Add a support for Skipped list in run-perf-tests; also skip files in resources directories. * Scripts/webkitpy/layout_tests/port/base.py: (Port.perf_tests_dir): (Port.skipped_perf_tests): (Port.skips_perf_test): (Port.relative_perf_test_filename): * Scripts/webkitpy/layout_tests/port/test.py: (TestPort.perf_tests_dir): * Scripts/webkitpy/layout_tests/port/webkit.py: (WebKitPort._expectations_from_skipped_files): (WebKitPort): (WebKitPort.skipped_layout_tests): (WebKitPort.skipped_perf_tests): * Scripts/webkitpy/performance_tests/perftestsrunner.py: (PerfTestsRunner._collect_tests): (PerfTestsRunner.run): * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py: (test_run_test_set_with_json_output): (test_run_test_set_with_json_source): (test_collect_tests_with_skipped_list): (test_collect_tests_with_skipped_list.add_file): 2012-01-18 Dirk Pranke Fix path to chromium_src_dir introduced in previous change. Unreviewed, build fix. * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: 2012-01-18 Alexey Proskuryakov Need infrastructure to test Content-Disposition filename encoding support https://bugs.webkit.org/show_bug.cgi?id=76572 Reviewed by Sam Weinig. Made policy delegate log suggested file name when resource has Content-Disposition: attachment. WebKitTestRunner does not have a policy delegate yet, bug 42546. * DumpRenderTree/mac/PolicyDelegate.mm: (dispositionTypeFromContentDispositionHeader): (-[PolicyDelegate webView:decidePolicyForMIMEType:request:frame:decisionListener:]): 2012-01-18 Ojan Vafai Fix tests from http://trac.webkit.org/changeset/105332. The code assumed that if you passed an options object with a configuration attribute that it would have a valid value. A bunch of the testing mocks do things like having a configuration value of None. * Scripts/webkitpy/layout_tests/port/base.py: (Port.__init__): 2012-01-18 Ojan Vafai Shave 0.5 seconds off check-webkit-style runtime for test_expectations.txt https://bugs.webkit.org/show_bug.cgi?id=76576 Reviewed by Adam Barth. Avoid calling default_configuration in base.py. We don't need it for checking test_expectations.txt style. It takes ~0.5 seconds to run on my Mac Pro. It's the call to "perl Tools/Scripts/webkit-build-directory --top-level" from common.executive. At some point someone should probably look into why that call is so slow since it's on the critical path for run-webkit-tests and build-webkit startup. * Scripts/webkitpy/layout_tests/port/base.py: (Port.__init__): * Scripts/webkitpy/style/checkers/test_expectations.py: (TestExpectationsChecker._determine_port_from_exepectations_path): 2012-01-18 Dirk Pranke [chromium] move Tools.gyp, switch build-webkit --chromium to All.gyp https://bugs.webkit.org/show_bug.cgi?id=76505 Reviewed by Tony Chang. Update chromium build script to use All.gyp instead of WebKit.gyp * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: Renamed from Source/WebKit/chromium/Tools.gyp. * Scripts/webkitdirs.pm: 2012-01-18 Sam Weinig Don’t hardcode the path to ‘make‘. Reviewed by Dan Bernstein. * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: 2012-01-18 Joshua Bell Adding myself to committers.py https://bugs.webkit.org/show_bug.cgi?id=76569 Unreviewed. * Scripts/webkitpy/common/config/committers.py: 2012-01-18 Adam Barth Up the cap on test failures tolerated by the EWS so the mac-ews can run to completion https://bugs.webkit.org/show_bug.cgi?id=76567 Reviewed by Eric Seidel. Current the AppleMac port has slightly more failures than we allow on the EWS, causing the mac-ews to spin. This patch ups the limit a bit, which should hopefully let the mac-ews run to completion. Once AppleMac has fewer failures, we can lower the cap again. * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py: (LayoutTestResultsReaderTest.test_layout_test_results): * Scripts/webkitpy/tool/steps/runtests.py: (RunTests): * Scripts/webkitpy/tool/steps/steps_unittest.py: 2012-01-18 Eric Carlson Provide access to user's list of preferred languages https://bugs.webkit.org/show_bug.cgi?id=76138 Reviewed by Alexey Proskuryakov. * GNUmakefile.am: Add JSInternalsCustom.cpp. 2012-01-18 Adam Barth Add Chromium Linux GPU 32 to the list of allowed Chromium Linux configurations. * Scripts/webkitpy/layout_tests/port/chromium_linux.py: (ChromiumLinuxPort.__init__): 2012-01-18 Dominic Mazzoni Accessibility: Chromium needs methods to scroll an object into view or to a specific location. https://bugs.webkit.org/show_bug.cgi?id=73460 Reviewed by Chris Fleizach. * DumpRenderTree/AccessibilityUIElement.h: * DumpRenderTree/chromium/AccessibilityUIElement.cpp: (AccessibilityUIElement::AccessibilityUIElement): (AccessibilityUIElement::scrollToMakeVisibleCallback): (AccessibilityUIElement::scrollToMakeVisibleWithSubFocusCallback): (AccessibilityUIElement::scrollToGlobalPointCallback): * DumpRenderTree/chromium/AccessibilityUIElement.h: * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: (AccessibilityUIElement::scrollToMakeVisible): (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus): (AccessibilityUIElement::scrollToGlobalPoint): * DumpRenderTree/mac/AccessibilityUIElementMac.mm: (AccessibilityUIElement::scrollToMakeVisible): (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus): (AccessibilityUIElement::scrollToGlobalPoint): * DumpRenderTree/win/AccessibilityUIElementWin.cpp: (AccessibilityUIElement::scrollToMakeVisible): (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus): (AccessibilityUIElement::scrollToGlobalPoint): 2012-01-17 Enrica Casucci Missing NSForegroundColorAttributeName should be treated as black instead of transparent. https://bugs.webkit.org/show_bug.cgi?id=76490 Added TestWebKitAPI test. Reviewed by Dan Bernstein. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new test file. * TestWebKitAPI/Tests/mac/InspectorBar.mm: Added test that calls changeAttributes to the WebView. 2012-01-18 Balazs Kelemen [Qt] Consolidate layout test crash logging https://bugs.webkit.org/show_bug.cgi?id=75088 Reviewed by Simon Hausmann. Move backtrace generating logic into WTFReportBacktrace and add a way to deinstall signal handlers if we know that we have already printed the backtrace. * DumpRenderTree/qt/main.cpp: (crashHandler): (setupSignalHandlers): (WTFCrashHook): (main): * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp: (WTR::crashHandler): (WTR::setupSignalHandlers): (WTR::crashHook): (WTR::InjectedBundle::platformInitialize): 2012-01-18 Ilya Tikhonovsky Unreviewed build fix after r105256. There was a cyclic dependency between self._port and self._host assigments. * Scripts/webkitpy/performance_tests/perftestsrunner.py: (PerfTestsRunner.__init__): 2012-01-18 Tor Arne Vestbø Add new watchlist rule for the Qt build system Reviewed by Simon Hausmann. * Scripts/webkitpy/common/config/watchlist: 2012-01-18 Tor Arne Vestbø [Qt] Move OTHER_FILES from WebKit.pro to Tools.pro Reviewed by Simon Hausmann. * Tools.pro: 2012-01-18 Tor Arne Vestbø [Qt] Allow building only a subset of the WebKit sub-projects Fixes build-jsc, broken in r104825. We no longer need the intermediate buildQMakeQtProject(), as we're the only port using qmake, and buildQMakeProject is now highly Qt specific. Reviewed by Simon Hausmann. * Scripts/build-jsc: * Scripts/build-webkit: * Scripts/webkitdirs.pm: (buildQMakeProjects): 2012-01-18 Ryosuke Niwa run-perf-tests should generate a json file that summaries the result https://bugs.webkit.org/show_bug.cgi?id=76504 Reviewed by Adam Barth. Add an ability to generate a json file to run-perf-test in the preparation for perf bots. New option --outout-json-path specifies the json file's path, and --source-json-path specifies another json file to be merged into the generated json file. Also fixed a bug that --build wasn't set by default. * Scripts/webkitpy/layout_tests/port/test.py: (TestPort.webkit_base): * Scripts/webkitpy/performance_tests/perftestsrunner.py: (PerfTestsRunner.__init__): (PerfTestsRunner): (PerfTestsRunner._parse_args): (PerfTestsRunner.run): (PerfTestsRunner._generate_json_if_specified): (PerfTestsRunner._process_chromium_style_test_result): (PerfTestsRunner._process_parser_test_result): * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py: (MainTest): (create_runner): (test_run_test_set): (test_run_test_set_for_parser_tests): (test_run_test_set_with_summary_json): (test_collect_tests): (test_parse_args): 2012-01-17 Sheriff Bot Unreviewed, rolling out r105244. http://trac.webkit.org/changeset/105244 https://bugs.webkit.org/show_bug.cgi?id=76518 broke Chromium Mac (Requested by rolandsteiner on #webkit). * DumpRenderTree/AccessibilityUIElement.h: * DumpRenderTree/chromium/AccessibilityUIElement.cpp: (AccessibilityUIElement::AccessibilityUIElement): * DumpRenderTree/chromium/AccessibilityUIElement.h: * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: (AccessibilityUIElement::removeSelection): * DumpRenderTree/mac/AccessibilityUIElementMac.mm: * DumpRenderTree/win/AccessibilityUIElementWin.cpp: (AccessibilityUIElement::removeSelection): 2012-01-17 Dominic Mazzoni Accessibility: Chromium needs methods to scroll an object into view or to a specific location. https://bugs.webkit.org/show_bug.cgi?id=73460 Reviewed by Chris Fleizach. * DumpRenderTree/AccessibilityUIElement.h: * DumpRenderTree/chromium/AccessibilityUIElement.cpp: (AccessibilityUIElement::AccessibilityUIElement): (AccessibilityUIElement::scrollToMakeVisibleCallback): (AccessibilityUIElement::scrollToMakeVisibleWithSubFocusCallback): (AccessibilityUIElement::scrollToGlobalPointCallback): * DumpRenderTree/chromium/AccessibilityUIElement.h: * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: (AccessibilityUIElement::scrollToMakeVisible): (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus): (AccessibilityUIElement::scrollToGlobalPoint): * DumpRenderTree/mac/AccessibilityUIElementMac.mm: (AccessibilityUIElement::scrollToMakeVisible): (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus): (AccessibilityUIElement::scrollToGlobalPoint): * DumpRenderTree/win/AccessibilityUIElementWin.cpp: (AccessibilityUIElement::scrollToMakeVisible): (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus): (AccessibilityUIElement::scrollToGlobalPoint): 2012-01-17 Adam Barth Enable tests on the mac-ews https://bugs.webkit.org/show_bug.cgi?id=76502 Reviewed by Simon Fraser. Apple now has five machines running the mac-ews. Lucas Forschler has asked that we try enabling tests to see if we have enough bandwidth. * Scripts/webkitpy/tool/commands/earlywarningsystem.py: (MacEWS): 2012-01-17 Sanjoy Das Add a check-webkit-style exception for GDBInterface.cpp https://bugs.webkit.org/show_bug.cgi?id=76187 Add an exception for Source/JavaScriptCore/jit/GDBInterface.cpp so that it does not fail the style check. Reviewed by Martin Robinson. * Scripts/webkitpy/style/checker.py: Tell the style checker to not run readability/naming tests on Source/JavaScriptCore/jit/GDBInterface.cpp. * Scripts/webkitpy/style/checker_unittest.py: (GlobalVariablesTest.test_path_rules_specifier): Add a test for the above exception. 2012-01-17 Hajime Morrita https://bugs.webkit.org/show_bug.cgi?id=76245 [Mac][DRT] should allow query string for the file URL. Reviewed by Tony Chang. Taught DRT about file:// as a url instead of a file path. We are now able to use a path file:///foo/bar.html?baz as a url with which DRT opens "/foo/bar.html" with "baz" as a query string. * DumpRenderTree/mac/DumpRenderTree.mm: (runTest): 2012-01-17 Ojan Vafai Check style on test_expectations.txt files before commit https://bugs.webkit.org/show_bug.cgi?id=76484 Reviewed by Adam Barth. Unlike other style rules, if you get the syntax of the test_expectations.txt file wrong, the layout tests won't run. Also, this check is simple and only slows down committing if you actually modify one of the test_expectations.txt files. * Scripts/webkitpy/tool/steps/commit.py: (Commit._check_test_expectations): (Commit.run): * Scripts/webkitpy/tool/steps/commit_unittest.py: Added. (CommitTest): (CommitTest.test_check_test_expectations): 2012-01-17 Viatcheslav Ostapenko [Qt] Debug build fails with debug qt5 https://bugs.webkit.org/show_bug.cgi?id=76463 Reviewed by Simon Hausmann. Add QNetworkCookie include in order to satisfy sizeof in QTypeInfo in debug builds. * QtTestBrowser/cookiejar.h: 2012-01-17 Dirk Pranke webkitpy: fix json import on linux https://bugs.webkit.org/show_bug.cgi?id=76481 Reviewed by Adam Barth. For some reason, the version of simplejson autoinstalled on my linux box seems to be broken. We should really only be using simplejson if json isn't available anyway, so this change looks for json first. * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py: (JSONGeneratorTest.test_test_timings_trie): 2012-01-17 Dirk Pranke Fix failures in test-webkitpy caused by r105177. Unreviewed, build fix. * Scripts/webkitpy/layout_tests/port/chromium_linux.py: (ChromiumLinuxPort._determine_driver_path_statically): (ChromiumLinuxPort._static_build_path): 2012-01-17 Dirk Pranke webkitpy: make PortFactory.get() be fully data-driven https://bugs.webkit.org/show_bug.cgi?id=76360 Reviewed by Eric Seidel. Refactor PortFactory.get() to be fully data-driven. * Scripts/webkitpy/layout_tests/port/factory.py: (PortFactory): (PortFactory._default_port): (PortFactory.get): (PortFactory.get.in): * Scripts/webkitpy/layout_tests/port/factory_unittest.py: (FactoryTest.assert_port): 2012-01-17 Dirk Pranke webkitpy: add determine_full_port_name(), clean up port.__init__() https://bugs.webkit.org/show_bug.cgi?id=76357 Reviewed by Adam Barth. Each Port class is now required to implement a 'port_name' field that will match the start of all ports constructed by this class and a 'determine_full_port_name' field that will make the port fully-qualified. * Scripts/webkitpy/layout_tests/port/apple.py: (ApplePort.__init__): * Scripts/webkitpy/layout_tests/port/base.py: (Port): (Port.determine_port_name): (Port.__init__): * Scripts/webkitpy/layout_tests/port/chromium.py: (ChromiumPort.for): (ChromiumPort.__init__): (ChromiumPort): (ChromiumPort._chromium_base_dir): (ChromiumPort.path_from_chromium_base): * Scripts/webkitpy/layout_tests/port/chromium_gpu.py: (ChromiumGpuLinuxPort): (ChromiumGpuLinuxPort.__init__): (ChromiumGpuMacPort): (ChromiumGpuMacPort.__init__): (ChromiumGpuWinPort): (ChromiumGpuWinPort.__init__): * Scripts/webkitpy/layout_tests/port/chromium_linux.py: (ChromiumLinuxPort): (ChromiumLinuxPort.determine_port_name): (ChromiumLinuxPort.__init__): * Scripts/webkitpy/layout_tests/port/chromium_mac.py: (ChromiumMacPort): (ChromiumMacPort.determine_port_name): (ChromiumMacPort.__init__): * Scripts/webkitpy/layout_tests/port/chromium_win.py: (ChromiumWinPort): (ChromiumWinPort.determine_port_name): (ChromiumWinPort.__init__): * Scripts/webkitpy/layout_tests/port/dryrun.py: (DryRunPort): (DryRunPort.determine_port_name): (DryRunPort.__init__): * Scripts/webkitpy/layout_tests/port/efl.py: (EflPort): * Scripts/webkitpy/layout_tests/port/factory.py: (PortFactory): (PortFactory._default_port): (PortFactory.get): (PortFactory.get.in): * Scripts/webkitpy/layout_tests/port/factory_unittest.py: (FactoryTest.assert_port): * Scripts/webkitpy/layout_tests/port/google_chrome.py: (GoogleChromeLinux32Port): (GoogleChromeLinux32Port.determine_port_name): (GoogleChromeLinux64Port): (GoogleChromeLinux64Port.determine_port_name): (GoogleChromeMacPort): (GoogleChromeMacPort.determine_port_name): (GoogleChromeWinPort): (GoogleChromeWinPort.determine_port_name): * Scripts/webkitpy/layout_tests/port/gtk.py: (GtkPort): * Scripts/webkitpy/layout_tests/port/mac.py: (MacPort): (MacPort.determine_port_name): (MacPort.__init__): * Scripts/webkitpy/layout_tests/port/mac_unittest.py: (test_versions): * Scripts/webkitpy/layout_tests/port/mock_drt.py: (MockDRTPort): (MockDRTPort.determine_port_name): (MockDRTPort.__init__): (MockDRT): (MockDRT.determine_port_name): * Scripts/webkitpy/layout_tests/port/port_testcase.py: (PortTestCase.make_port): * Scripts/webkitpy/layout_tests/port/qt.py: (QtPort): (QtPort.determine_port_name): (QtPort.__init__): * Scripts/webkitpy/layout_tests/port/test.py: (TestPort): (TestPort.determine_port_name): (TestPort.__init__): * Scripts/webkitpy/layout_tests/port/webkit.py: (WebKitPort.__init__): * Scripts/webkitpy/layout_tests/port/win.py: (WinPort): (WinPort.determine_port_name): * Scripts/webkitpy/tool/servers/rebaselineserver.py: (get_test_baselines.AllPlatformsPort.__init__): * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py: (get_test_config.TestMacPort): (get_test_config): 2012-01-17 Dirk Pranke webkitpy: clean up port code in preparation for static port names https://bugs.webkit.org/show_bug.cgi?id=76356 Reviewed by Adam Barth. To fix bug 76215 and be able to determine appropriate port names in webkitpy without actually constructing Port objects, we need to shuffle some logic in the chromium ports to be able to figure out whether we built DRT in 32 or 64-bit mode. * Scripts/webkitpy/layout_tests/port/chromium.py: (ChromiumPort): (ChromiumPort._chromium_base_dir): (ChromiumPort.__init__): (ChromiumPort.path_from_chromium_base): * Scripts/webkitpy/layout_tests/port/chromium_linux.py: (ChromiumLinuxPort): (ChromiumLinuxPort._determine_driver_path_statically): (ChromiumLinuxPort._static_build_path): (ChromiumLinuxPort._determine_architecture): (ChromiumLinuxPort.__init__): (ChromiumLinuxPort._build_path): 2012-01-17 Hao Zheng Do not remove pixel failures for ref tests. https://bugs.webkit.org/show_bug.cgi?id=76243 Reviewed by Tony Chang. 'NRWT --no-pixel-tests' complains when reftests are expected to be image mismatch. * Scripts/webkitpy/layout_tests/controllers/manager.py: (Manager._update_summary_with_result): * Scripts/webkitpy/layout_tests/models/test_failures.py: (is_reftest_failure): (determine_result_type): 2012-01-17 Balazs Ankes REGRESSION(r81225): ORWT should ignore reftests https://bugs.webkit.org/show_bug.cgi?id=67936 Reviewed by Csaba Osztrogonác. * Scripts/old-run-webkit-tests: (isUsedInReftest): $filename should be the first parameter (findTestsToRun): run test if it isn't reftest 2012-01-17 Gustavo Noronha Silva Unreviewed. Fix python unit test I broke with r105142 * Scripts/webkitpy/common/config/ports_unittest.py: (WebKitPortTest.test_gtk_port): 2012-01-17 Tor Arne Vestbø [Qt] Don't set the 'primary' flag when mocking touch-points in MiniBrowser Qt 5 no longer has that flag. Reviewed by Simon Hausmann. * MiniBrowser/qt/MiniBrowserApplication.cpp: (MiniBrowserApplication::notify): 2012-01-16 Gustavo Noronha Silva GTK+ EWS needs to run update-webkitgtk-libs after applying a patch https://bugs.webkit.org/show_bug.cgi?id=75857 Reviewed by Adam Barth. * Scripts/webkitdirs.pm: (buildAutotoolsProject): move cleaning the build to happen early, and handle --update-gtk right after that * Scripts/webkitpy/common/config/ports.py: (GtkPort.build_webkit_command): pass --update-gtk as an option to build-webkit, so that it is used in the EWS 2012-01-16 Tor Arne Vestbø [Qt] Don't add _debug postfix to targets when building debug only Reviewed by Simon Hausmann. * qmake/mkspecs/features/default_post.prf: * qmake/mkspecs/features/functions.prf: 2012-01-16 Tor Arne Vestbø [Qt] Add more files to project-files for easier navigation in Qt Creator Reviewed by Simon Hausmann. * Tools.pro: * qmake/config.tests/README: Added. 2012-01-17 Philippe Normand [GTK] fast/dom/constructed-objects-prototypes.html fails https://bugs.webkit.org/show_bug.cgi?id=75432 Reviewed by Martin Robinson. * Scripts/build-webkit: Enable video-track in GTK. 2012-01-16 Takashi Toyoshima Add toyoshim as a committer. https://bugs.webkit.org/show_bug.cgi?id=76390 Reviewed by Hajime Morita. * Scripts/webkitpy/common/config/committers.py: 2012-01-16 Brent Fulgham [WinCairo] Build fix after r104155. Several debug targets were not properly including the '*Common' property sheets. * DumpRenderTree/win/DumpRenderTreeLauncherDebugCairoCFLite.vsprops: * DumpRenderTree/win/ImageDiffLauncherDebugCairoCFLite.vsprops: * MiniBrowser/Configurations/MiniBrowserLauncherDebugCairoCFLite.vsprops: * WebKitTestRunner/win/WebKitTestRunnerLauncherDebugCairoCFLite.vsprops: * WinLauncher/WinLauncherLauncherDebugCairoCFLite.vsprops: 2012-01-16 Csaba Osztrogonác REGRESSION(r105072): It broke committers_unittest.py https://bugs.webkit.org/show_bug.cgi?id=76396 Reviewed by Adam Barth. * Scripts/webkitpy/common/config/committers_unittest.py: (CommittersTest._assert_fuzz_match): It should handle more names. (CommittersTest.test_contributors_by_fuzzy_match_with_legacy_names): Fix the testcase. 2012-01-16 Mario Sanchez Prada [GTK] Include gtk+3 in the jhbuild modules https://bugs.webkit.org/show_bug.cgi?id=76284 Reviewed by Philippe Normand. * gtk/jhbuild.modules: Add some gtk+3 to the jhbuild moduleset. 2012-01-16 Dan Winship Add myself as a committer Unreviewed * Scripts/webkitpy/common/config/committers.py: 2012-01-16 Raphael Kubo da Costa Unreviewed; fix the build when --as-needed and --no-copy-dt-needed-entries are passed to the linker. Some recent versions of a few Linux distributions have started passing --as-needed and --no-copy-dt-needed-entries by default to the linker, which broke the build when SHARED_CORE was turned on, as libwtf_efl.so needed a few symbols from libjavascriptcore_efl.so. * DumpRenderTree/efl/CMakeLists.txt: Explicitly pass WTF_LIBRARY_NAME before JavaScriptCore_LIBRARY_NAME in DumpRenderTree_LIBRARIES so the libraries are searched in the right order by the linker. 2012-01-16 Philippe Normand [GTK] set audio resources path in NRTW https://bugs.webkit.org/show_bug.cgi?id=76380 Reviewed by Martin Robinson. * Scripts/webkitpy/layout_tests/port/gtk.py: (GtkPort.setup_environ_for_server): Set $AUDIO_RESOURCES_PATH so the uninstalled audio resources are used during webaudio tests. 2012-01-16 Carlos Garcia Campos [GTK] ldflags and cflags should take precedence over the existing flags in gtkdoc.py https://bugs.webkit.org/show_bug.cgi?id=76369 Reviewed by Xan Lopez. If there's an installed version of webkit and there are new symbols in the build tree, gtkdoc-scanobj fails due to undefined references, because the env ldflags are given before the local ones. * gtk/gtkdoc.py: (GTKDoc._run_gtkdoc_scangobj): 2012-01-15 Pablo Flouret Fix compilation errors on build-webkit --debug --no-video on mac. https://bugs.webkit.org/show_bug.cgi?id=75867 Reviewed by Philippe Normand. Add --[no-]video-track to build-webkit, since video track feature depends on video. * Scripts/build-webkit: 2012-01-14 James Robinson [chromium] Failing webkit_unit_tests does not make the cr-linux EWS bubble red https://bugs.webkit.org/show_bug.cgi?id=76313 Reviewed by Adam Barth. The exit code of this script should be the exit code of webkit_unit_tests. Tested manually. * Scripts/run-chromium-webkit-unit-tests: 2012-01-14 Sheriff Bot Unreviewed, rolling out r105017. http://trac.webkit.org/changeset/105017 https://bugs.webkit.org/show_bug.cgi?id=76333 broke the build (Requested by philn-tp on #webkit). * gtk/jhbuild.modules: 2012-01-14 Mario Sanchez Prada [GTK] Include gtk+3 in the jhbuild modules https://bugs.webkit.org/show_bug.cgi?id=76284 Reviewed by Philippe Normand. * gtk/jhbuild.modules: Add some gtk+3 to the jhbuild moduleset. 2012-01-13 Adam Barth Remove --dry-run support from webkit-patch https://bugs.webkit.org/show_bug.cgi?id=76300 Reviewed by Dirk Pranke. This is the rest of the patch from Bug 76300. I landed it separtely because main.py had some stray conflict markers that I needed to clean up first. * Scripts/webkitpy/test/main.py: (Tester.parse_args): (Tester._run_tests): 2012-01-13 Adam Barth test-webkitpy does not run https://bugs.webkit.org/show_bug.cgi?id=76318 Unreviewed. Looks like some conflict markers got left in the file. * Scripts/webkitpy/test/main.py: (Tester.run): 2012-01-13 Adam Barth Remove --dry-run support from webkit-patch https://bugs.webkit.org/show_bug.cgi?id=76300 Reviewed by Dirk Pranke. We don't use this functionality for anything, and it doesn't really work. Someone in #webkit tried using it and and got sad/confused. We should just remove it. * Scripts/webkitpy/common/checkout/scm/git.py: (Git.push_local_commits_to_server): * Scripts/webkitpy/common/checkout/scm/scm.py: (SCM.__init__): * Scripts/webkitpy/common/checkout/scm/scm_unittest.py: (_shared_test_commit_with_message): (GitSVNTest.test_commit_text_parsing): * Scripts/webkitpy/common/checkout/scm/svn.py: (SVN.commit_with_message): * Scripts/webkitpy/common/net/bugzilla/bugzilla.py: (Bugzilla.__init__): (Bugzilla.quips): (Bugzilla.authenticate): (Bugzilla.add_attachment_to_bug): (Bugzilla.add_patch_to_bug): (Bugzilla.create_bug): (Bugzilla.clear_attachment_flags): (Bugzilla.set_flag_on_attachment): (Bugzilla.obsolete_attachment): (Bugzilla.add_cc_to_bug): (Bugzilla.post_comment_to_bug): (Bugzilla.close_bug_as_fixed): (Bugzilla.reassign_bug): (reopen_bug): * Scripts/webkitpy/test/main.py: (Tester.parse_args): (Tester.run_tests): 2012-01-13 David Levin check-webkit-style: should encourage the use of Own* classes for Windows DC. https://bugs.webkit.org/show_bug.cgi?id=76227 Reviewed by Dirk Pranke. * Scripts/webkitpy/style/checkers/cpp.py: (check_for_leaky_patterns): The new check. (process_line): Added a call to the new check. (CppChecker): Added the new error type. * Scripts/webkitpy/style/checkers/cpp_unittest.py: (CppStyleTestBase): (CppStyleTestBase.perform_leaky_pattern_check): The check for only leaky pattern errors. (LeakyPatternTest): Test cases. 2012-01-13 Dirk Pranke test-webkitpy: clean up handling of test directories, QueueStatusServer https://bugs.webkit.org/show_bug.cgi?id=76238 Reviewed by Adam Barth. This patch cleans up a bunch of hacks related to how we find all of the python unit tests and set up the sys.path variable in test-webkitpy. This patch changes how test-webkitpy works slightly in that we will now look for test files under Tools/Scripts and Source/WebKit2/Scripts rather than just Tools/Scripts/webkitpy and Source/WebKit2/Scripts/webkit. This greatly simplifies the mapping of paths to module names and appears to have no significant performance impact or other drawbacks. There are other ways that we could remove all of the hacks and still have a more flexible mapping of paths to module names, but the ones I've thought of so far add a decent amount of complexity to the implementation and don't seem to buy us much. * QueueStatusServer/__init__.py: * Scripts/test-webkitpy: * Scripts/webkitpy/test/main.py: (Tester._modules_from_paths): (Tester._is_module): 2012-01-13 Dirk Pranke test-webkitpy: should support classes and individual test names as well as modules https://bugs.webkit.org/show_bug.cgi?id=76233 Reviewed by Adam Barth. The default unittest.main() supports a list of individual TestCase classes or individual tests as well as modules. This change adds support for the same to test-webkitpy, so now you can say % test-wekbitpy webkitpy.test.cat_unittest.CatTest and % test-wekbitpy webkitpy.test.cat_unittest.CatTest.test_basic in addition to % test-wekbitpy webkitpy.test.cat_unittest * Scripts/test-webkitpy: * Scripts/webkitpy/test/cat_unittest.py: * Scripts/webkitpy/test/main.py: (Tester.parse_args): (Tester.run): (Tester): (Tester._find_modules): (Tester._exclude): (Tester._run_tests): (Tester._is_module): (Tester._log_exception): 2012-01-13 Dirk Pranke test-webkitpy: add basic code coverage support https://bugs.webkit.org/show_bug.cgi?id=76201 Reviewed by Adam Barth. This test adds basic code coverage support to test-webkitpy; if you pass the -c flag, we will generate a new coverage file. We can start simply with this and add more features as necessary. This patch requires coverage to be already installed on the machine. I am not auto-installing this for now. * Scripts/webkitpy/test/main.py: (Tester.parse_args): (Tester.run_tests): 2012-01-13 Dirk Pranke StatusBubbleTest.test_build_bubble is failing https://bugs.webkit.org/show_bug.cgi?id=76222 Reviewed by Adam Barth. * QueueStatusServer/handlers/statusbubble_unittest.py: (StatusBubbleTest.test_build_bubble): 2012-01-13 Kristóf Kosztyó nrwt should use multiple http shards https://bugs.webkit.org/show_bug.cgi?id=75958 Add --max-locked-shards option to the nrwt for manual set the maximum number of the locked shards Reviewed by Dirk Pranke. * Scripts/webkitpy/layout_tests/controllers/manager.py: (Manager._max_locked_shards): * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py: (ShardingTests.get_shards): (ShardingTests.test_multiple_locked_shards): * Scripts/webkitpy/layout_tests/run_webkit_tests.py: (parse_args): 2012-01-13 Raphael Kubo da Costa prepare-ChangeLog: Look for a text editor in a few more variables. https://bugs.webkit.org/show_bug.cgi?id=76289 Reviewed by Ryosuke Niwa. A text editor was looked for only in the CHANGE_LOG_EDITOR and CHANGE_LOG_EDIT_APPLICATION environment variables before falling back to the OS X-specific open(1) command. As there does not seem to be a common way of looking for a text editor among the scripts in Tools/Scripts right now, just look at $VISUAL and $EDITOR (set much more often than the other variables in Unix systems) before falling back to open(1). * Scripts/prepare-ChangeLog: (openChangeLogs): 2012-01-13 Gabor Rapcsanyi [GTK] gtkdoc.py ignoring LDFLAGS and CFLAGS environment variables https://bugs.webkit.org/show_bug.cgi?id=76269 Reviewed by Martin Robinson. * gtk/gtkdoc.py: (GTKDoc._run_gtkdoc_scangobj): 2012-01-13 Csaba Osztrogonác [Qt][WK2]REGRESSION(r104881):It broke hundreds of tests https://bugs.webkit.org/show_bug.cgi?id=76247 Reviewed by Kenneth Rohde Christiansen. * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetStateToConsistentValues): Disable mock scrollbars on Qt by default. (workaround) 2012-01-13 Hajime Morrita [Mac][DRT] Should support --no-timeout https://bugs.webkit.org/show_bug.cgi?id=76242 Reviewed by Darin Adler. * DumpRenderTree/mac/DumpRenderTree.mm: (initializeGlobalsFromCommandLineOptions): Added "--no-timeout" to the options list. (setWaitToDumpWatchdog): Added to encapsulate the waitToDumpWatchdog global variable. (shouldSetWaitToDumpWatchdog): Added to check the useTimeoutWatchdog flag set by the option. * DumpRenderTree/mac/DumpRenderTreeMac.h: * DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::setWaitToDump): Now calls shouldSetWaitToDumpWatchdog() to check the flag. 2012-01-12 Simon Fraser Mitigate scrollbar differences when running pixel tests https://bugs.webkit.org/show_bug.cgi?id=67217 Reviewed by Dan Bernstein. Enable mock scrollbars by default for tests. * DumpRenderTree/mac/DumpRenderTree.mm: (resetDefaultsToConsistentValues): * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetStateToConsistentValues): 2012-01-12 Ryosuke Niwa Need a script to run tests in PerformanceTests https://bugs.webkit.org/show_bug.cgi?id=76132 Reviewed by Adam Barth. Add run-perf-tests to run performance tests using parser/resources/runner.js. Unfortunately, there isn't an easy way of telling which test uses which format so hard-code directory that uses Chromium perf-bot style (only inspector perf. tests for now). All test outputs are re-formatted to match Chromium perf-bot style. * Scripts/run-inspector-perf-tests.py: * Scripts/run-perf-tests: Added. * Scripts/webkitpy/performance_tests/perftestsrunner.py: (PerfTestsRunner): (PerfTestsRunner.__init__): (PerfTestsRunner._collect_tests): (PerfTestsRunner.run): (PerfTestsRunner._print_status): (PerfTestsRunner._run_tests_set): (PerfTestsRunner._process_chromium_style_test_result): (PerfTestsRunner._should_ignore_line_in_parser_test_result): (PerfTestsRunner._process_parser_test_result): (PerfTestsRunner._run_single_test): * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py: (MainTest.TestDriver.run_test): (create_runner): (run_test): (test_run_test_set): (test_run_test_set_for_parser_tests): (test_collect_tests): 2012-01-12 Dirk Pranke webkitpy: clean up port unit tests in preparation for making port_name mandatory https://bugs.webkit.org/show_bug.cgi?id=76123 Reviewed by Adam Barth. This change updates the unit tests to be more consistent in how ports are created, in preparation for making port_name a mandatory parameter to the constructor and removing any version interpretation from it. There should be no functional changes in this patch, but some tests that are no longer relevant have been removed or reworked. * Scripts/webkitpy/layout_tests/port/base_unittest.py: (PortTest.test_get_option__default): * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py: (ChromiumLinuxPortTest): (ChromiumLinuxPortTest.assert_architecture): (ChromiumLinuxPortTest.test_determine_architecture_fails): * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py: (ChromiumMacPortTest): * Scripts/webkitpy/layout_tests/port/chromium_unittest.py: (ChromiumPortTest): (ChromiumPortTest.test_all_test_configurations): (ChromiumPortTest.TestMacPort.__init__): (ChromiumPortTest.TestLinuxPort.__init__): (ChromiumPortTest.TestWinPort.__init__): * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py: (ChromiumWinTest): * Scripts/webkitpy/layout_tests/port/efl_unittest.py: (EflPortTest): * Scripts/webkitpy/layout_tests/port/gtk_unittest.py: (GtkPortTest): * Scripts/webkitpy/layout_tests/port/mac_unittest.py: (MacTest): * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: (MockDRTPortTest): (MockDRTPortTest.make_port): * Scripts/webkitpy/layout_tests/port/qt.py: (QtPort._port_flag_for_scripts): (QtPort.__init__): * Scripts/webkitpy/layout_tests/port/qt_unittest.py: (QtPortTest): (QtPortTest._assert_search_path): (QtPortTest.test_baseline_search_path): (QtPortTest.test_operating_system): * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: (WebKitPortTest): * Scripts/webkitpy/layout_tests/port/win_unittest.py: (WinPortTest): (WinPortTest._assert_search_path): (WinPortTest.test_baseline_search_path): * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py: (get_test_config.TestMacPort.__init__): 2012-01-12 Dirk Pranke test-webkitpy: clean up logging and provide a real --help message https://bugs.webkit.org/show_bug.cgi?id=76142 Reviewed by Adam Barth. This test is mostly more refactoring - it calls objects in unittest directly instead of routing through unittest.main() -- in order to gain more control over the logging and to provide a correct --help message. This will also give us a better foundation for adding more feautures down the road. This patch adds different levels of logging controlled by the '-s', '-q', and '-v' options (see --help for details), and removes the --verbose-logging option. * Scripts/test-webkitpy: * Scripts/webkitpy/test/main.py: (Tester): (Tester.clean_packages): (Tester.__init__): (Tester.parse_args): (Tester.configure): (Tester._configure_logging): (Tester.find_modules): (Tester._exclude): (Tester._modules_from_paths): (Tester.run_tests): 2012-01-12 Simon Hausmann Make the new WTF module build on Qt https://bugs.webkit.org/show_bug.cgi?id=76163 Reviewed by Tor Arne Vestbø. * qmake/mkspecs/modules/wtf.prf: Pull in WTF from the new location. 2012-01-12 Vsevolod Vlasov Unreviewed, mac DumpRenderTree fix. * DumpRenderTree/mac/UIDelegate.mm: (-[UIDelegate webView:addMessageToConsole:withSource:]): 2012-01-12 Vsevolod Vlasov WebKitTestRunner should not print console message line number when it is equal to zero. https://bugs.webkit.org/show_bug.cgi?id=76167 Reviewed by Csaba Osztrogonác. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::willAddMessageToConsole): 2012-01-11 Vsevolod Vlasov Make default console messages line numbers consistent. https://bugs.webkit.org/show_bug.cgi?id=74075 Reviewed by Pavel Feldman. Unset line numbers are not printed to console now. Added Source/WebCore/inspector to efl DumpRenderTree include path. * DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::didAddMessageToConsole): * DumpRenderTree/efl/CMakeLists.txt: * DumpRenderTree/efl/DumpRenderTreeView.cpp: (onConsoleMessage): * DumpRenderTree/gtk/DumpRenderTree.cpp: (webViewConsoleMessage): * DumpRenderTree/mac/UIDelegate.mm: (-[UIDelegate webView:addMessageToConsole:withSource:]): * DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::WebPage::javaScriptConsoleMessage): * DumpRenderTree/win/UIDelegate.cpp: (UIDelegate::webViewAddMessageToConsole): * DumpRenderTree/wx/DumpRenderTreeWx.cpp: (LayoutWebViewEventHandler::OnConsoleMessageEvent): 2012-01-10 Dirk Pranke test-webkitpy: push more logic into webkitpy.test.main, clean up code https://bugs.webkit.org/show_bug.cgi?id=76021 Reviewed by Eric Seidel. I plan to add more functionality to test-webkitpy, but it is difficult to hack on now; this patch is the first of two that brings test-webkitpy more inline with current coding style by pushing more logic into the webkitpy.test.main.Tester class (so that it will be testable itself). There should be no functional changes in this patch. * Scripts/test-webkitpy: (_path_from_webkit_root): * Scripts/webkitpy/test/main.py: (Tester): (Tester.init): (Tester.configure_logging): (Tester.configure_logging.filter): (Tester.clean_packages): (Tester.run_tests): 2012-01-11 Wei Jia implement layout tests for