2012-03-23 Dirk Pranke LayoutTestHelper could get torn down earlier (mostly to reset color profile) https://bugs.webkit.org/show_bug.cgi?id=80567 Reviewed by Ryosuke Niwa. Move clean_up_run to occur right after we finish testing and before we start processing the results. Also makes set_up_run() and clean_up_run() private since there's no real need for callers to be aware of them. * Scripts/webkitpy/layout_tests/controllers/manager.py: (Manager._set_up_run): (Manager.run): (Manager._clean_up_run): * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py: (ManagerTest.test_http_locking): * Scripts/webkitpy/layout_tests/run_webkit_tests.py: (run): 2012-03-23 Dean Jackson Disable CSS_SHADERS in Apple builds https://bugs.webkit.org/show_bug.cgi?id=81996 Reviewed by Simon Fraser. Default enableCSSShaders to be 0 on all builds that use this script. Use the flag to turn it back on. * Scripts/build-webkit: 2012-03-23 Tony Chang [chromium] rename newwtf target back to wtf https://bugs.webkit.org/show_bug.cgi?id=82064 Reviewed by Adam Barth. * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: 2012-03-23 Jessie Berlin Assertion failure in PlatformPasteboardMac constructor causing multiple tests to "crash" on the Lion Intel WebKit2 Debug bots. https://bugs.webkit.org/show_bug.cgi?id=81012. Rubber-stamped by Dan Bernstein. Add a step to kill the pasteboard server while we investigate what is causing these assertion failures (to get the bots green). * BuildSlaveSupport/kill-old-processes: 2012-03-22 Martin Robinson [check-webkit-style] Alphabetical sorting errors in headers are reported for the line after the first out of order header https://bugs.webkit.org/show_bug.cgi?id=81986 Reviewed by David Levin. Track whether or not errors are filtered in error handlers. If an alphabetical sorting error is reported for a header and filtered, try reporting it for the other potential source of the error. This ensures that the style bot can still find new sorting errors in both potential situations: #include <-- 1. edited line #include <-- 2. edited line * Scripts/webkitpy/style/checkers/cpp.py: (check_include_line): Potentially report the error for both lines, if the first error is filtered. * Scripts/webkitpy/style/checkers/cpp_unittest.py: Implement a new style of test that allows only reporting errors for certain lines. This verifies that when one line of an ordering error is filtered, the error is reported on the other line. (ErrorCollector.__init__): (ErrorCollector.__call__): (CppStyleTestBase.perform_lint): (CppStyleTestBase.perform_language_rules_check): (CppStyleTestBase.assert_language_rules_check): (OrderOfIncludesTest.test_check_alphabetical_include_order_errors_reported_for_both_lines): Added a new test that verifies that when one line of the two lines of an ordering error occur, the error is reported on the other line. * Scripts/webkitpy/style/checkers/jsonchecker_unittest.py: (MockErrorHandler.__call__): Report True because the error is handled. * Scripts/webkitpy/style/checkers/test_expectations_unittest.py: (ErrorCollector.__call__): Ditto. * Scripts/webkitpy/style/checkers/watchlist_unittest.py: (MockErrorHandler.__call__): Ditto. * Scripts/webkitpy/style/checkers/xcodeproj_unittest.py: (TestErrorHandler.__call__): Ditto. * Scripts/webkitpy/style/checkers/xml_unittest.py: (MockErrorHandler.__call__): Ditto. * Scripts/webkitpy/style/error_handlers.py: (DefaultStyleErrorHandler.__call__): Report True if the error is handled and False if it is filtered. 2012-03-23 Patrick Gansterer Build fix for WinCE after r111778. * WinCELauncher/CMakeLists.txt: 2012-03-23 Peter Beverloo Unreviewed buildfix for the Chromium Android builder. Disable the ImageDiff target for now. Android needs to build this for host rather than for target (as other configurations do), but since the WTF move the dependency chain got significantly more complicated. I'll work out a proper fix in the following bug, but since several things are broken due to this, this buildfix should be landed first. https://bugs.webkit.org/show_bug.cgi?id=82039 * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: 2012-03-23 Grzegorz Czajkowski [EFL][DRT] Implement LayoutTestController's methods related with editing. https://bugs.webkit.org/show_bug.cgi?id=80136 Reviewed by Ryosuke Niwa. Implements EFL's LayoutTestController methods e.i. setSmartInsertDeleteEnabled, setSelectTrailingWhitespaceEnabled. * DumpRenderTree/efl/LayoutTestControllerEfl.cpp: (LayoutTestController::setSmartInsertDeleteEnabled): (LayoutTestController::setSelectTrailingWhitespaceEnabled): 2012-03-22 Gyuyoung Kim Convert hasGrammarMarker to use Internals interface https://bugs.webkit.org/show_bug.cgi?id=82004 Reviewed by Ryosuke Niwa. Remove hasGrammarMarker functions, because it is able to work in the cross-port way through the Internals interface. * DumpRenderTree/LayoutTestController.cpp: (LayoutTestController::staticFunctions): * DumpRenderTree/LayoutTestController.h: (LayoutTestController): * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp: * DumpRenderTree/efl/LayoutTestControllerEfl.cpp: * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: * DumpRenderTree/mac/LayoutTestControllerMac.mm: * DumpRenderTree/win/LayoutTestControllerWin.cpp: * DumpRenderTree/wx/LayoutTestControllerWx.cpp: 2012-03-22 Adam Barth sync-master-with-upstream creates non-linear git history https://bugs.webkit.org/show_bug.cgi?id=82006 Reviewed by Julien Chaffraix. Previously this script would create a merge commit at the HEAD of origin/master, causing your fork of WebKit to diverge from upstream. The new version of this script pushes directly from upstream to origin (without round-tripping through any local branches), avoiding this problem. * Scripts/sync-master-with-upstream: 2012-03-22 Gustavo Noronha Silva Unreviewed build fix. Add knowledge of the WTF project to the autotools build system scripts so that build-jsc works correctly for GTK+. * Scripts/webkitdirs.pm: (buildAutotoolsProject): handle the WTF project, build the libWTF.la target. (buildGtkProject): add WTF to the list of supported projects. 2012-03-22 Eric Seidel Make svn-apply re-write JavaScriptCore/wtf to WTF/wtf https://bugs.webkit.org/show_bug.cgi?id=81984 Reviewed by Adam Barth. * Scripts/VCSUtils.pm: (adjustPathForRecentRenamings): 2012-03-22 Raphael Kubo da Costa [CMake] Fix build-jsc after r111778 and r111797. https://bugs.webkit.org/show_bug.cgi?id=82001 Reviewed by Filip Pizlo. Contrary to the comment in build-jsc, buildCMakeProjectOrExit() does return if no error occurred, and build-jsc failed with "building not defined for this platform". * Scripts/build-jsc: Always exit after caling buildCMakeProjectOrExit(). * Scripts/webkitdirs.pm: (buildCMakeProjectOrExit): Return 0 if no error occurred. 2012-03-22 Raphael Kubo da Costa [CMake] Unreviewed build fix after r111778. * DumpRenderTree/efl/CMakeLists.txt: Replace ${JAVASCRIPTCORE_DIR}/wtf with ${WTF_DIR}/wtf in the include paths. * DumpRenderTree/efl/LayoutTestControllerEfl.cpp: Use the right wtf include. * DumpRenderTree/efl/WorkQueueItemEfl.cpp: Ditto. * WinCELauncher/CMakeLists.txt: Replace ${JAVASCRIPTCORE_DIR}/wtf with ${WTF_DIR}/wtf in the include paths. 2012-03-22 Filip Pizlo Tools/Scripts/build-jsc doesn't work after WTF move https://bugs.webkit.org/show_bug.cgi?id=81999 Reviewed by Eric Seidel. For ports that require WTF and JSC to be built as two projects and where the machinery to build both does not already exist, teach the tool to do so for us. * Scripts/build-jsc: (buildMyProject): 2012-03-22 Ojan Vafai Fix accidental missing line in r111793. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js: * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js: Remove base.values. It was unused and duplicates the builtin Object.values. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js: Accidentally deleted this line before committing r111793. 2012-03-22 Ojan Vafai Move garden-o-matic progress feedback from non-modal dialogs to a status console anchored to the bottom of the page https://bugs.webkit.org/show_bug.cgi?id=81983 Reviewed by Adam Barth. The dialogs get in the way if you are doing multiple rebaselines. Also, a number of people didn't realize that you could do multiple rebaselines in parallel. A non-modal dialog is just confusing. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js: * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js: If we're only rebaselining 1 test, show the test name in the initial message. Otherwise, show the number of tests being rebaselined. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js: Turn MessageBox into StatusArea. StatusArea is a singleton and messages in the StatusArea are grouped by ID. That way, the results of each UI action (e.g. clicking rebaseline) are grouped together into a single area. Once addFinalMessage has been called for all IDs, we show the close button. Clicking close also serves to clear all teh content in the StatusArea. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js: * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css: 2012-03-22 Tony Chang Unreviewed, fix chromium build after wtf move. Only use newwtf, remove references to wtf. * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: 2012-03-22 Csaba Osztrogonác Actually move WTF files to their new home https://bugs.webkit.org/show_bug.cgi?id=81844 [Qt] Unreviewed buildfix after r111778. * DumpRenderTree/qt/DumpRenderTree.pro: 2012-03-22 Dan Bernstein Font fallback in WebKitTestRunner depends on user settings https://bugs.webkit.org/show_bug.cgi?id=81978 Reviewed by Jessie Berlin. * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm: (WTR::InjectedBundle::platformInitialize): Added an AppleLanguages key with a value consisting of the array ("en") to the override defaults dictionary. This is the same value used in DumpRenderTree, and it ensures that font fallback follows a consistent path that is not affected by the language preferences of the user running the test. 2012-03-22 Andy Estes check-for-inappropriate-objc-class-names should ignore the class defined by libarclite. https://bugs.webkit.org/show_bug.cgi?id=81971 Reviewed by Dan Bernstein. Xcode will automatically link ObjC binaries against libarclite in some cases, which defines a class called __ARCLite__. check-for-inappropriate-objc-class-names shouldn't complain about this class name. * Scripts/check-for-inappropriate-objc-class-names: 2012-03-22 Dirk Pranke new-run-webkit-tests blames the wrong test for crashing https://bugs.webkit.org/show_bug.cgi?id=81951 Reviewed by Adam Barth. NRWT wasn't extracting the WebProcess pid correct; should've used re.search instead of re.match :(. Add more tests! * Scripts/webkitpy/layout_tests/port/mac.py: (MacPort._get_crash_log): * Scripts/webkitpy/layout_tests/port/webkit.py: (WebKitDriver.has_crashed): (WebKitDriver._check_for_driver_crash): * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: (WebKitDriverTest.test_no_timeout): (WebKitDriverTest): (WebKitDriverTest.test_check_for_driver_crash): (WebKitDriverTest.test_check_for_driver_crash.FakeServerProcess): (WebKitDriverTest.test_check_for_driver_crash.FakeServerProcess.__init__): (WebKitDriverTest.test_check_for_driver_crash.FakeServerProcess.pid): (WebKitDriverTest.test_check_for_driver_crash.FakeServerProcess.name): (WebKitDriverTest.test_check_for_driver_crash.FakeServerProcess.has_crashed): (WebKitDriverTest.test_check_for_driver_crash.assert_crash): 2012-03-22 Sudarsana Nagineni [EFL] [DRT] Implement LayoutTestController::markerTextForListItem() https://bugs.webkit.org/show_bug.cgi?id=81512 Adding missing implementation markerTextForListItem to EFL's LayoutTestController so that we can unskip related tests from the skip list. Reviewed by Antonio Gomes. * DumpRenderTree/efl/LayoutTestControllerEfl.cpp: (LayoutTestController::markerTextForListItem): Implemented. 2012-03-22 Sudarsana Nagineni [EFL] Enable view mode media feature layout tests https://bugs.webkit.org/show_bug.cgi?id=81205 Adding missing implementation setViewModeMediaFeature to EFL's LayoutTestController so that we can unskip view mode media feature layout tests. Reviewed by Antonio Gomes. * DumpRenderTree/efl/LayoutTestControllerEfl.cpp: (LayoutTestController::setViewModeMediaFeature): Implemented. 2012-03-22 Dirk Pranke nrwt: crash while stopping layout test helper on apple mac lion https://bugs.webkit.org/show_bug.cgi?id=81949 Reviewed by Eric Seidel. stop_helper() didn't work right if the helper process wasn't still running or didn't respond properly to being shut down. Fix this and add some tests. Also add code to MockExecutive() to be able to mock executive.popen() properly. * Scripts/webkitpy/common/system/executive_mock.py: (MockProcess.__init__): (MockProcess.wait): (MockExecutive.__init__): (MockExecutive.popen): * Scripts/webkitpy/common/system/systemhost_mock.py: (MockSystemHost.__init__): * Scripts/webkitpy/layout_tests/port/mac.py: (MacPort.start_helper): (MacPort.stop_helper): * Scripts/webkitpy/layout_tests/port/mac_unittest.py: (test_get_crash_log): (test_helper_starts): (test_helper_fails_to_start): (test_helper_fails_to_stop): (test_helper_fails_to_stop.bad_waiter): 2012-03-22 Gustavo Noronha Silva [GTK] Add make to the jhbuild moduleset https://bugs.webkit.org/show_bug.cgi?id=81769 Reviewed by Martin Robinson. Mostly based on a patch by Carlos Garcia Campos . Add GNU make with custom patches to fix several issues: - make-3.82-arg-list-length.patch: Patch by Ralf Wildenhues to fix the argument list limit of GNU make when running make distcheck. - make-3.82-parallel-build.patch: Patch by Kamil Mierzejewski and Jeremy Devenport to fix parallel build issues present in GNU make 3.82 * gtk/jhbuild.modules: Added make with patches. * gtk/patches/make-3.82-arg-list-length.patch: Added. * gtk/patches/make-3.82-parallel-build.patch: Added. 2012-03-22 Kevin Ollivier [wx] Unreviewed. Adding Source/WTF to the build and updating waf port list. * DumpRenderTree/wscript: * waf/build/settings.py: 2012-03-22 Dirk Pranke Re-land fix for r81603 yet again (!) with latest build fix. https://bugs.webkit.org/show_bug.cgi?id=81603 Unreviewed, build fix. The latest problem was a bad sprintf() in BasePort._get_crash_log(). I've reworked that routine and added unit tests for coverage. * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py: (SingleTestRunner._handle_error): * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py: (write_test_result): (TestResultWriter.write_crash_log): * Scripts/webkitpy/layout_tests/port/base.py: (Port.diff_text): (Port._get_crash_log): * Scripts/webkitpy/layout_tests/port/chromium.py: (ChromiumDriver.run_test): * Scripts/webkitpy/layout_tests/port/chromium_unittest.py: (ChromiumDriverTest.test_crash_log): * Scripts/webkitpy/layout_tests/port/driver.py: (DriverOutput.__init__): * Scripts/webkitpy/layout_tests/port/mac.py: (MacPort.is_lion): (MacPort._get_crash_log): * Scripts/webkitpy/layout_tests/port/mac_unittest.py: (test_default_child_processes): (test_get_crash_log): * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: (MockDRTPortTest.test_get_crash_log): * Scripts/webkitpy/layout_tests/port/port_testcase.py: (PortTestCase.test_get_crash_log): * Scripts/webkitpy/layout_tests/port/test.py: (TestDriver.run_test): * Scripts/webkitpy/layout_tests/port/webkit.py: (WebKitDriver.__init__): (WebKitDriver._start): (WebKitDriver.has_crashed): (WebKitDriver._check_for_driver_crash): (WebKitDriver.run_test): 2012-03-22 Alexander Færøy [Qt] Enable support for handling database quota's in the MiniBrowser https://bugs.webkit.org/show_bug.cgi?id=81928 Reviewed by Simon Hausmann. * MiniBrowser/qt/qml/BrowserWindow.qml: 2012-03-22 Sudarsana Nagineni [EFL] Implement LayoutTestController::setEditingBehavior https://bugs.webkit.org/show_bug.cgi?id=81124 Adding missing implementation setEditingBehavior to EFL's LayoutTestController. This implementation allows us to unskip some tests from the skip list. Reviewed by Martin Robinson. * DumpRenderTree/efl/LayoutTestControllerEfl.cpp: (LayoutTestController::setEditingBehavior): Implemented. 2012-03-22 Carlos Garcia Campos [GTK] Use the angle-bracket form to include wtf headers https://bugs.webkit.org/show_bug.cgi?id=81884 Reviewed by Eric Seidel. Use #include instead of #include "foo". * DumpRenderTree/gtk/AccessibilityCallbacks.cpp: * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: * DumpRenderTree/gtk/DumpRenderTree.cpp: * DumpRenderTree/gtk/EditingCallbacks.cpp: * DumpRenderTree/gtk/WorkQueueItemGtk.cpp: * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp: 2012-03-22 Alexander Færøy Unreviewed, add Michael Brüning and Allan Jensen to committers.py. * Scripts/webkitpy/common/config/committers.py: 2012-03-22 Allan Sandfeld Jensen [Qt] Enable FAST_MOBILE_SCROLLING when scrolling is delegated. https://bugs.webkit.org/show_bug.cgi?id=81889 Reviewed by Kenneth Rohde Christiansen. Enable FAST_MOBILE_SCROLLING feature. * qmake/mkspecs/features/features.prf: 2012-03-22 Raphael Kubo da Costa [EFL] DRT: Do not pass a relative path to DOWNLOADED_FONTS_DIR. https://bugs.webkit.org/show_bug.cgi?id=81900 Reviewed by Gustavo Noronha Silva. r111598 added the DOWNLOADED_FONTS_DIR define, but it used a relative path which assumed a certain directory structure for the build directory which may noy be true. Instead, hardcode the path to the downloaded fonts starting from the top-level source directory. While this solution is also far from perfect, it makes it more consistent and reliable, and easier to tackle at once with the rest of bug 81475. * DumpRenderTree/efl/CMakeLists.txt: 2012-03-22 Carlos Garcia Campos [GTK] Allow to run any jhbuild command with jhbuild-wrapper script https://bugs.webkit.org/show_bug.cgi?id=81888 Reviewed by Philippe Normand. * Scripts/update-webkit-libs-jhbuild: (runJhbuild): Helper function to run jhbuild with a given command. Instead of running jhbuild directly, use the jhbuild-wrapper, so that we don't need to run it first to check whether jhbuild is installed or not. * efl/run-with-jhbuild: Call jhbuild-wrapper with run command. * gtk/run-with-jhbuild: Ditto. * jhbuild/jhbuild-wrapper: Allow to execute any jhbuild command, not only run. 2012-03-22 Philippe Normand Unreviewed, test-webkitpy fix after r111661. * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: (MainTest.test_crash_log): (MainTest.test_web_process_crash_log): 2012-03-22 Philippe Normand Unreviewed, test-webkitpy fix after r111642. * Scripts/webkitpy/layout_tests/port/chromium_unittest.py: (ChromiumDriverTest.setUp): (ChromiumDriverTest.test_two_drivers): 2012-03-22 Csaba Osztrogonác webkitpy: clean up actually getting crash logs from DRT/WTR crashes https://bugs.webkit.org/show_bug.cgi?id=81603 Unreviewed rolling out r111609 and part of r111615, because it broke NRWT on Qt-WK2 platform. * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py: (SingleTestRunner._handle_error): * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py: (write_test_result): (TestResultWriter.write_crash_report): * Scripts/webkitpy/layout_tests/port/base.py: (Port.is_crash_reporter): (Port._driver_class): * Scripts/webkitpy/layout_tests/port/chromium.py: (ChromiumDriver.run_test): * Scripts/webkitpy/layout_tests/port/chromium_unittest.py: (ChromiumDriverTest.test_crashed_process_name): * Scripts/webkitpy/layout_tests/port/driver.py: (DriverOutput.__init__): * Scripts/webkitpy/layout_tests/port/mac.py: (MacPort): (MacPort.is_crash_reporter): (MacPort.release_http_lock): * Scripts/webkitpy/layout_tests/port/test.py: (TestDriver.run_test): * Scripts/webkitpy/layout_tests/port/webkit.py: (WebKitDriver.__init__): (WebKitDriver._start): (WebKitDriver.has_crashed): (WebKitDriver._check_for_driver_crash): (WebKitDriver.run_test): 2012-03-22 Csaba Osztrogonác [Qt] Add full platforms to Qt buildslaves https://bugs.webkit.org/show_bug.cgi?id=81877 Reviewed by Ryosuke Niwa. * BuildSlaveSupport/build.webkit.org-config/config.json: 2012-03-21 Johnny Ding Customize layout test timeout value for different ports. https://bugs.webkit.org/show_bug.cgi?id=79859 Reviewed by Ojan Vafai. * Scripts/webkitpy/layout_tests/controllers/manager.py: (Manager): * Scripts/webkitpy/layout_tests/port/base.py: (Port.default_test_timeout_ms): * Scripts/webkitpy/layout_tests/port/chromium.py: (ChromiumDriver.stop): * Scripts/webkitpy/layout_tests/port/chromium_android.py: (ChromiumAndroidPort.default_test_timeout_ms): * Scripts/webkitpy/layout_tests/run_webkit_tests.py: (_set_up_derived_options): 2012-03-21 Mark Rowe Fix the build. Ensure that our test tools don't try and use RTTI unnecessarily. * DumpRenderTree/mac/Configurations/Base.xcconfig: * TestWebKitAPI/Configurations/Base.xcconfig: * WebKitTestRunner/Configurations/Base.xcconfig: 2012-03-21 Adam Barth WebKit should have some scripts to smooth interactions with GitHub https://bugs.webkit.org/show_bug.cgi?id=81842 Reviewed by Eric Seidel. These scripts support the workflow in https://trac.webkit.org/wiki/UsingGitHub by automating the configuration and syncing operations needed for a GitHub fork of WebKit to track the main WebKit repository. * Scripts/configure-github-as-upstream: Added. * Scripts/sync-master-with-upstream: Added. 2012-03-21 Dirk Pranke WTR - log the pid of a crashing WebProcess https://bugs.webkit.org/show_bug.cgi?id=81575 Reviewed by Alexey Proskuryakov. This allows run-webkit-tests to find the right crash log for a given crashed WebProcess in WebKit2. * WebKitTestRunner/TestController.cpp: (WTR::exceededDatabaseQuota): (WTR::TestController::createOtherPage): (WTR::TestController::initialize): (WTR::TestController::resetStateToConsistentValues): (WTR::TestController::runTest): (WTR::TestController::processDidCrash): 2012-03-21 Enrica Casucci WebKitURLWithTitles pasteboard format should support URLs containing Emoji characters. https://bugs.webkit.org/show_bug.cgi?id=81835 Reviewed by Brady Eidson. * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.html: * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.mm: (TestWebKitAPI::contextMenuCopyLink): 2012-03-21 Alexandru Chiculita [CSS Shaders] Make CSS Shaders compile on Chromium https://bugs.webkit.org/show_bug.cgi?id=81435 Reviewed by Stephen White. I've added WebKitCSSCustomFilterEnabled support for the layoutTestController.overridePreference function. * DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::overridePreference): * DumpRenderTree/chromium/WebPreferences.cpp: (WebPreferences::reset): (WebPreferences::applyTo): * DumpRenderTree/chromium/WebPreferences.h: (WebPreferences): 2012-03-21 Dirk Pranke fix regression on gtk port introduced by r111609 https://bugs.webkit.org/show_bug.cgi?id=81839 Reviewed by Philippe Normand. r111609 should've initialized a couple of missing fields in WebKitDriver, and also should've checked for method overrides in the other ports :(. * Scripts/webkitpy/layout_tests/port/gtk.py: (GtkDriver._start): * Scripts/webkitpy/layout_tests/port/webkit.py: (WebKitDriver.__init__): * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: (MainTest.test_crash_log): (MainTest.test_web_process_crash_log): 2012-03-21 Dirk Pranke webkitpy: clean up actually getting crash logs from DRT/WTR crashes https://bugs.webkit.org/show_bug.cgi?id=81603 Reviewed by Adam Barth. Add a new _get_crash_log() overridable method on the Port object to customize how we fetch crash logs per port. Mac will now slow-spin with a timeout waiting for the crash log, rather than waiting for the ReportCrash process to exit (it appears that the mac will manage multiple crashes with a single ReportCrash process, the process waits around longer than necessary, presumably to avoid thrashing if processes are repeatedly crashing). Also, add the DriverOutput should contain the crash log and other info, which is created in a port-specific manner but can then be treated generically. Previously single_test_runner would get told that something crashed and attempt to do something to get the crash log, but it didn't have the information it needed to od the right thing; better to make the driver hand back the right info. * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py: (SingleTestRunner._handle_error): * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py: (write_test_result): (TestResultWriter.write_crash_log): * Scripts/webkitpy/layout_tests/port/base.py: (Port.diff_text): (Port._get_crash_log): * Scripts/webkitpy/layout_tests/port/chromium.py: (ChromiumDriver.run_test): * Scripts/webkitpy/layout_tests/port/chromium_unittest.py: (ChromiumDriverTest.test_crash_log): * Scripts/webkitpy/layout_tests/port/driver.py: (DriverOutput.__init__): * Scripts/webkitpy/layout_tests/port/mac.py: (MacPort.is_lion): (MacPort._get_crash_log): * Scripts/webkitpy/layout_tests/port/test.py: (TestDriver.run_test): * Scripts/webkitpy/layout_tests/port/webkit.py: (WebKitDriver.__init__): (WebKitDriver._start): (WebKitDriver.has_crashed): (WebKitDriver._check_for_driver_crash): (WebKitDriver.run_test): 2012-03-21 Dominik Röttsches [EFL] Use jhbuild downloaded fonts instead of hardcoded system font paths https://bugs.webkit.org/show_bug.cgi?id=81507 Now that we're only loading from one directory, no need to iterate over a list of directories anymore. Reviewed by Martin Robinson. * DumpRenderTree/efl/CMakeLists.txt: * DumpRenderTree/efl/FontManagement.cpp: (addFontDirectory): (addFontsToEnvironment): 2012-03-21 Dirk Pranke webkitpy: get ServerProcess out of the reportcrash business https://bugs.webkit.org/show_bug.cgi?id=81600 Unreviewed, build fix. Re-land r111307 and r111293 with another fix for a crash in NRWT; we need to check if the driver has crashed before attempting to read from it. * Scripts/webkitpy/layout_tests/port/server_process.py: (ServerProcess._reset): (ServerProcess._handle_possible_interrupt): (ServerProcess.write): (ServerProcess.read_stdout): (ServerProcess.has_crashed): (ServerProcess._read): (ServerProcess.stop): * Scripts/webkitpy/layout_tests/port/server_process_unittest.py: (TrivialMockPort.check_for_leaks): (TestServerProcess.test_broken_pipe): * Scripts/webkitpy/layout_tests/port/webkit.py: (WebKitPort._read_image_diff): (WebKitDriver.has_crashed): (WebKitDriver._check_for_driver_crash): (WebKitDriver.run_test): (WebKitDriver._read_block): * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: (MockServerProcess.__init__): (MockServerProcess): (MockServerProcess.has_crashed): 2012-03-21 Zeno Albisser [Qt][Mac] ranlib segfaults when creating symbol tables for libWebCore.a. https://bugs.webkit.org/show_bug.cgi?id=81750 Building WebCore on mac currently creates an archive that is bigger than 4GB. But ranlib fails to create a symbol table for such a big archive, even on 64bit machines. Therefore we start using SVGAllInOne.cpp when building debug on mac. This reduces the size of the archive by about 300MB. Reviewed by Tor Arne Vestbø. * qmake/mkspecs/features/mac/default_pre.prf: 2012-03-21 Szilard Ledan Updated the address list of committers.py. Reviewed by Csaba Osztrogonác. * Scripts/webkitpy/common/config/committers.py: 2012-03-21 W. James MacLean Updating my nick in committers file. Unreviewed. * Scripts/webkitpy/common/config/committers.py: 2012-03-21 Peter Beverloo [Chromium] Remove Android build-fix when the proper fix rolled into WebKit https://bugs.webkit.org/show_bug.cgi?id=80861 Reviewed by Tony Chang. Remove most Android-specific logic from webkitdirs.pm in favor of handling this during project generation time. * Scripts/webkitdirs.pm: (buildChromiumMakefile): 2012-03-21 Carlos Garcia Campos [GTK] Allow running javascript from location bar in MiniBrowser https://bugs.webkit.org/show_bug.cgi?id=81331 Reviewed by Martin Robinson. * MiniBrowser/gtk/BrowserWindow.c: (activateUriEntryCallback): Use browser_window_load_uri(). (browser_window_load_uri): Check whether uri starts with javascript: and run the given script, or just call webkit_web_view_load_uri() to load the given uri. * MiniBrowser/gtk/BrowserWindow.h: * MiniBrowser/gtk/main.c: (createBrowserWindow): Use browser_window_load_uri(). 2012-03-21 Carlos Garcia Campos [GTK] Add webkit_web_view_run_javascript() to WebKit2 GTK+ https://bugs.webkit.org/show_bug.cgi?id=75543 Reviewed by Martin Robinson. * MiniBrowser/gtk/GNUmakefile.am: Add javascriptcore_cppflags to MiniBrowser CPP flags. 2012-03-20 Eric Seidel Move wtf/Platform.h from JavaScriptCore to Source/WTF/wtf https://bugs.webkit.org/show_bug.cgi?id=80911 Reviewed by Adam Barth. Update include paths for Source/WTF. * DumpRenderTree/efl/CMakeLists.txt: * DumpRenderTree/qt/DumpRenderTree.pro: * QtTestBrowser/QtTestBrowser.pro: * Scripts/build-webkit: Build Source/WTF on AppleWin as well. 2012-03-20 Adam Barth svn-apply should move inflight patches from WebCore/webaudio to WebCore/Modules/webaudio https://bugs.webkit.org/show_bug.cgi?id=81567 Reviewed by Eric Seidel. This temporary measure should help us avoid disrupting the folks working on WebAudio when we move the webaudio directory to Modules. * Scripts/VCSUtils.pm: (adjustPathForRecentRenamings): (parseGitDiffHeader): (parseSvnDiffHeader): 2012-03-20 Dirk Pranke Unreviewed, rolling out r111453. http://trac.webkit.org/changeset/111453 https://bugs.webkit.org/show_bug.cgi?id=81600 still broken * Scripts/webkitpy/layout_tests/port/server_process.py: (ServerProcess._reset): (ServerProcess.handle_interrupt): (ServerProcess.write): (ServerProcess._check_for_crash): (ServerProcess._handle_timeout): (ServerProcess._check_for_abort): (ServerProcess._read): (ServerProcess.stop): (ServerProcess): (ServerProcess.set_crashed): * Scripts/webkitpy/layout_tests/port/server_process_unittest.py: (TrivialMockPort.is_crash_reporter): (TestServerProcess.test_broken_pipe): * Scripts/webkitpy/layout_tests/port/webkit.py: (WebKitPort._read_image_diff): (WebKitDriver.has_crashed): (WebKitDriver._check_for_driver_crash): (WebKitDriver): (WebKitDriver._detected_crash): (WebKitDriver._subprocess_crashed): (WebKitDriver._crashed_process_name): (WebKitDriver.run_test): (WebKitDriver._read_block): * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: (MockServerProcess.__init__): 2012-03-20 Dirk Pranke webkitpy: get ServerProcess out of the reportcrash business https://bugs.webkit.org/show_bug.cgi?id=81600 Unreviewed, build fix. Re-land r111307 and r111293 with fix for crash in NRWT; I was failing to set the crashing process name. * Scripts/webkitpy/layout_tests/port/server_process.py: (ServerProcess._reset): (ServerProcess._handle_possible_interrupt): (ServerProcess.write): (ServerProcess.read_stdout): (ServerProcess.has_crashed): (ServerProcess._read): (ServerProcess.stop): * Scripts/webkitpy/layout_tests/port/server_process_unittest.py: (TrivialMockPort.check_for_leaks): (TestServerProcess.test_broken_pipe): * Scripts/webkitpy/layout_tests/port/webkit.py: (WebKitPort._read_image_diff): (WebKitDriver.has_crashed): (WebKitDriver._check_for_driver_crash): (WebKitDriver.run_test): (WebKitDriver._read_block): * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: (MockServerProcess.__init__): (MockServerProcess): (MockServerProcess.has_crashed): 2012-03-20 Tim Horton [mac] Restore color space switching code to run-webkit-tests https://bugs.webkit.org/show_bug.cgi?id=80571 Reviewed by Simon Fraser. http://trac.webkit.org/changeset/111429 broke tools build on Snow Leopard. Use the old CM* API on Snow Leopard, since CGDisplayCreateUUIDFromDisplayID didn't exist until Lion. * DumpRenderTree/mac/LayoutTestHelper.m: (installLayoutTestColorProfile): (restoreUserColorProfile): 2012-03-20 Adele Peterson Update the last test to use EXPECT_WK_STREQ. Reviewed by Dan Bernstein. * TestWebKitAPI/Tests/mac/AttributedString.mm: (TestWebKitAPI::TEST): 2012-03-20 Adele Peterson "Attempt to insert nil value " exception when calling attributed string APIs on content with a custom font https://bugs.webkit.org/show_bug.cgi?id=81630 Reviewed by Alexey Proskuryakov. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/mac/Ahem.ttf: Added. * TestWebKitAPI/Tests/mac/AttributedString.mm: Added. (-[AttributedStringTest webView:didFinishLoadForFrame:]): (TestWebKitAPI): (TestWebKitAPI::didFinishLoadForFrame): (TestWebKitAPI::TEST): * TestWebKitAPI/Tests/mac/attributedStringCustomFont.html: Added. 2012-03-20 Eric Seidel Add link on queues.webkit.org to kov's fancy queue-depth graph https://bugs.webkit.org/show_bug.cgi?id=81690 Reviewed by Adam Barth. * QueueStatusServer/templates/recentstatus.html: 2012-03-20 Tim Horton [mac] Restore color space switching code to run-webkit-tests https://bugs.webkit.org/show_bug.cgi?id=80571 Reviewed by Simon Fraser. Make use of the layout test helper hooks to restore the Mac system-wide color profile switching code. This makes WkTR and DRT results match, and causes the main display's color profile to not affect results on Lion. * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: * DumpRenderTree/mac/LayoutTestHelper.m: Added. (installLayoutTestColorProfile): (restoreUserColorProfile): (simpleSignalHandler): (main): * Scripts/webkitpy/layout_tests/port/mac.py: (MacPort.release_http_lock): (MacPort): (MacPort._path_to_helper): (MacPort.start_helper): (MacPort.stop_helper): * WebKitTestRunner/mac/PlatformWebViewMac.mm: (WTR::PlatformWebView::PlatformWebView): (WTR::PlatformWebView::windowSnapshotImage): 2012-02-24 Darin Fisher Add more Chromium WebKit API reviewers https://bugs.webkit.org/show_bug.cgi?id=81576 Reviewed by Adam Barth and David Levin. Simplify watchlist to lump all WebKit API into one. * Scripts/webkitpy/common/config/watchlist: 2012-03-20 Gyuyoung Kim Convert hasSpellingMarker to use Internals interface. https://bugs.webkit.org/show_bug.cgi?id=81300 Reviewed by Ryosuke Niwa. Remove hasSpellingMarker functions, because it is able to work in the cross-port way through the Internals interface. * DumpRenderTree/LayoutTestController.cpp: (LayoutTestController::staticFunctions): * DumpRenderTree/LayoutTestController.h: (LayoutTestController): * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp: * DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): * DumpRenderTree/chromium/LayoutTestController.h: (LayoutTestController): * DumpRenderTree/efl/LayoutTestControllerEfl.cpp: * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: * DumpRenderTree/mac/LayoutTestControllerMac.mm: * DumpRenderTree/qt/LayoutTestControllerQt.cpp: * DumpRenderTree/qt/LayoutTestControllerQt.h: * DumpRenderTree/win/LayoutTestControllerWin.cpp: * DumpRenderTree/wx/LayoutTestControllerWx.cpp: 2012-03-20 Csaba Osztrogonác Add new Qt-WK2 performance tester bot to build.webkit.org https://bugs.webkit.org/show_bug.cgi?id=80842 Reviewed by Ryosuke Niwa. * BuildSlaveSupport/build.webkit.org-config/config.json: * BuildSlaveSupport/build.webkit.org-config/master.cfg: (RunAndUploadPerfTestsWebKit2): (RunAndUploadPerfTestsWebKit2.start): (BuildAndPerfTestWebKit2Factory): (BuildAndPerfTestWebKit2Factory.__init__): (DownloadAndPerfTestWebKit2Factory): (DownloadAndPerfTestWebKit2Factory.__init__): 2012-03-20 Peter Beverloo [Chromium] Update to Android NDK r7b https://bugs.webkit.org/show_bug.cgi?id=81005 Reviewed by Adam Barth. Update to version r7b of the Android NDK, release notes of which are available on the following page: http://developer.android.com/sdk/ndk/index.html * Scripts/update-webkit-chromium: 2012-03-20 Csaba Osztrogonác x86 GCC bug triggers a compilation error in generated copy constructor of CollapsedBorderValue https://bugs.webkit.org/show_bug.cgi?id=81502 Unreviewed. * qmake/mkspecs/features/unix/default_post.prf: Reenable Werror after r111171. 2012-03-19 Jessie Berlin Unreviewed; roll out http://trac.webkit.org/changeset/111307 and http://trac.webkit.org/changeset/111293 because they broke running the layout tests on mac. * Scripts/webkitpy/layout_tests/port/webkit.py: (WebKitDriver._check_for_driver_crash): 2012-03-16 Martin Robinson [GTK] Allow running run-gtk-tests during 'make distcheck' https://bugs.webkit.org/show_bug.cgi?id=81415 Reviewed by Philippe Normand. Modify the build and run-gtk-tests so that it can run during 'make distcheck' * GNUmakefile.am: Distribute run-gtk-tests during 'make dist' and make it the main command run during 'make check.' * Scripts/run-gtk-tests: Refactored run-gtk-tests so that jhbuild is no longer a requirement to run it. If jhbuild isn't around it will simply not start the SPI daemons and skip the WebKit2 accessibility test. Remove test runs from the main loop and simply use the main loop in a synchronous method to start SPI daemons. Did a bunch of general cleanup around these tasks. 2012-03-19 Raphael Kubo da Costa jhbuild: Use the multiprocessing module to get the number of CPUs. https://bugs.webkit.org/show_bug.cgi?id=81585 Reviewed by Martin Robinson. Now that support for Python 2.5 has been dropped, we can safely use multiprocessing.cpu_count() to obtain the current number of CPUs in the system instead of running a webkitperl script for that. * efl/common.py: (top_level_path): * efl/jhbuildrc: * gtk/common.py: (build_path): * gtk/jhbuildrc: 2012-03-19 Ojan Vafai We should only add a live event listener once, not once per TestSelector. Adding one per TestSelector would cause accordion('option', 'active') to incorrectly be "false" if you examine multiple sets of tests. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js: 2012-03-19 Dirk Pranke Fix typo introduced in r111293. Unreviewed, build fix. * Scripts/webkitpy/layout_tests/port/webkit.py: (WebKitDriver._check_for_driver_crash): 2012-03-19 Dirk Pranke webkitpy: get ServerProcess out of the reportcrash business https://bugs.webkit.org/show_bug.cgi?id=81600 Reviewed by Adam Barth. ServerProcess was half-aware that ReportCrash might run sometimes, and that the process ServerProcess was talking to might have its own crashing subprocesses; neither of these things really worked right and it made the logic convoluted, so this change makes handling crashes completely separate from the server_process code, so that it can focus on just I/O to the subprocess. There should be no functional changes resulting from this patch. * Scripts/webkitpy/layout_tests/port/server_process.py: (ServerProcess._reset): (ServerProcess._handle_possible_interrupt): (ServerProcess.write): (ServerProcess.read_stdout): (ServerProcess.has_crashed): (ServerProcess._read): (ServerProcess.stop): * Scripts/webkitpy/layout_tests/port/server_process_unittest.py: (TrivialMockPort.check_for_leaks): (TestServerProcess.test_broken_pipe): * Scripts/webkitpy/layout_tests/port/webkit.py: (WebKitPort._read_image_diff): (WebKitDriver.has_crashed): (WebKitDriver._check_for_driver_crash): (WebKitDriver.run_test): (WebKitDriver._read_block): * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: (MockServerProcess.__init__): (MockServerProcess): (MockServerProcess.has_crashed): 2012-03-19 Dirk Pranke webkitpy: crashlog parsing is broken https://bugs.webkit.org/show_bug.cgi?id=81586 Reviewed by Adam Barth. Seeking on a file opened through codecs() appears to not work correctly (at least on SL). The code was more complicated than it needed to be, so I have revamped it to just read a full crashlog at once and then look for matches. I have also added the ability to optionally propagate errors back (which can be helpful to debug races when ReportCrash is still running and you need to see that you couldn't open some files, rather than just ignoring them). * Scripts/webkitpy/common/system/crashlogs.py: (CrashLogs.find_newest_log): (CrashLogs._find_newest_log_darwin): * Scripts/webkitpy/common/system/crashlogs_unittest.py: (CrashLogsTest.test_find_log_darwin): 2012-03-19 Dirk Pranke webkitpy: clean up some port._filesystem references to not reference private members https://bugs.webkit.org/show_bug.cgi?id=81595 Reviewed by Eric Seidel. There should be no functional changes in this patch, just some refactoring. Also, fixes a minor nit in write_image_diff_files(() * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py: (SingleTestRunner.__init__): (SingleTestRunner._run_compare_test): (SingleTestRunner._run_rebaseline): (SingleTestRunner._save_baseline_data): (SingleTestRunner._handle_error): (SingleTestRunner._run_reftest): * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py: (write_test_result): (TestResultWriter.__init__): (TestResultWriter._make_output_directory): (TestResultWriter.output_filename): (TestResultWriter._output_testname): (TestResultWriter.write_output_files): (TestResultWriter.write_stderr): (TestResultWriter.write_crash_report): (TestResultWriter.create_text_diff_and_write_result): (TestResultWriter.write_image_diff_files): (copy_file): * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py: (TestResultWriterTest.test_reftest_diff_image): 2012-03-19 Dirk Pranke webkitpy: fix nit - incorrect reference to DRT in test_expectations.py https://bugs.webkit.org/show_bug.cgi?id=81598 Reviewed by Eric Seidel. "DumpRenderTree" shouldn't be hard-coded here, since some other process may actually be crashing (WebKitTestRunner, WebProcess, etc.) * Scripts/webkitpy/layout_tests/models/test_expectations.py: (TestExpectations): 2012-03-19 Dirk Pranke webkitpy: allow instance data in TestFailure objects https://bugs.webkit.org/show_bug.cgi?id=81580 Reviewed by Tony Chang. Current TestFailures are basically enums, but it would be nice, especially for crashes, if they contained the name and pid of the process that crashed. * Scripts/webkitpy/layout_tests/models/test_failures.py: (TestFailure.message): (FailureTimeout.message): (FailureCrash): (FailureCrash.__init__): (FailureCrash.message): (FailureMissingResult.message): (FailureTextMismatch.message): (FailureMissingImageHash.message): (FailureMissingImage.message): (FailureImageHashMismatch.message): (FailureImageHashIncorrect.message): (FailureReftestMismatch.message): (FailureReftestMismatchDidNotOccur.message): (FailureReftestNoImagesGenerated.message): (FailureMissingAudio.message): (FailureAudioMismatch.message): * Scripts/webkitpy/layout_tests/models/test_failures_unittest.py: (TestFailuresTest.test_equals): (TestFailuresTest): (TestFailuresTest.test_crashes): 2012-03-19 Brady Eidson and https://bugs.webkit.org/show_bug.cgi?id=81066 Crash in 3rd party WebKit apps under XHR/Cache code Reviewed by Antti Koivisto. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/mac/MemoryCachePruneWithinResourceLoadDelegate.html: Added. * TestWebKitAPI/Tests/mac/MemoryCachePruneWithinResourceLoadDelegate.mm: Added. (-[MemoryCachePruneTestResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]): (-[MemoryCachePruneTestResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]): (-[MemoryCachePruneTestResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]): (-[MemoryCachePruneTestResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]): (TestWebKitAPI): (TestWebKitAPI::TEST): 2012-03-19 Brady Eidson and https://bugs.webkit.org/show_bug.cgi?id=81516 REGRESSION (r107435) URLs copied from WebKit apps aren't in the right pasteboard format Reviewed by Enrica Casucci. Bring up a context menu on a link, copy the link, then verify the pasteboard contents are in the correct format. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.html: Added. * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.mm: Added. (-[ContextMenuCanCopyURLDelegate webView:didFinishLoadForFrame:]): (TestWebKitAPI::contextMenuCopyLink): (TestWebKitAPI::TEST): 2012-03-19 Ojan Vafai Make the selected item in the accordion a link to the flakiness dashboard https://bugs.webkit.org/show_bug.cgi?id=81571 Reviewed by Dimitri Glazkov. Also, make it so that you can select the text of the link, instead of the current behavior of acting as if you had clicked on the accordion header. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js: * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css: 2012-03-19 Dirk Pranke NRWT runs some tests that are skipped with -i command line option https://bugs.webkit.org/show_bug.cgi?id=81535 Reviewed by Ojan Vafai. This change modifies the interaction of Skipped files and test_expectations files so that entries in Skipped files (and the -i command line) override *everything* in the expectations file. Specifically, a directory in a Skipped file will cause all of the tests in the dir to be skipped even if individual tests in the dir are listed in the test_expectations.txt. Skipped files also override anything in an overrides files. This seems to make more intuitive sense, since if you list something in the Skips file (and even more specify it on the command line) you probably want it to be universally applied. Theoretically we could add more precedence levels and have full paths in an expectations file override dirs in a Skipped file (but not the command line), but I don't know yet that that level of complexity is justified. * Scripts/webkitpy/layout_tests/models/test_expectations.py: (TestExpectations.__init__): (TestExpectations._add_skipped_tests): (TestExpectations._add_test): (TestExpectations._add_expectations): (TestExpectations._add_expectation_line): (TestExpectations._already_seen_better_match): * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: (test_more_specific_override_resets_skip): (SkippedTests): (SkippedTests.get_exp): (SkippedTests.assert_exp): (SkippedTests.test_skipped_tests_work): (SkippedTests.test_duplicate_skipped_test_fails_lint): (SkippedTests.test_skipped_file_overrides_expectations): (SkippedTests.test_skipped_dir_overrides_expectations): (SkippedTests.test_skipped_file_overrides_overrides): (SkippedTests.test_skipped_dir_overrides_overrides): 2012-03-19 Eric Seidel Fix WTF header include discipline in Chromium WebKit https://bugs.webkit.org/show_bug.cgi?id=81281 Reviewed by James Robinson. * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: * Scripts/update-webkit-chromium: Made it possible to run this from a directory other than the root. 2012-03-19 Andy Chen [BlackBerry] Add new layout test for text match marker https://bugs.webkit.org/show_bug.cgi?id=81531 Make the LayoutTestControllerBlackBerry::findString to test the BlackBerry port implementation. Reviewed by Rob Buis. * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp: (LayoutTestController::findString): 2012-03-19 Ojan Vafai Don't show WONTFIX tests in garden-o-matic https://bugs.webkit.org/show_bug.cgi?id=81554 Reviewed by Dimitri Glazkov. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js: * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js: 2012-03-19 Chris Fleizach platform/mac/accessibility/selected-rows-table.html failing on Lion Intel Debug WebKit2 testers https://bugs.webkit.org/show_bug.cgi?id=81530 Reviewed by Jessie Berlin. Add rowAtIndex to WebKitTestRunner. * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp: (WTR::AccessibilityUIElement::rowAtIndex): * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h: (AccessibilityUIElement): * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl: * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm: (WTR): (WTR::AccessibilityUIElement::rowAtIndex): 2012-03-19 Ojan Vafai Change garden-o-matic All Failures tab to Expected Failures https://bugs.webkit.org/show_bug.cgi?id=81540 Reviewed by Dimitri Glazkov. Also, fix some broken unittests that had just gotten stale. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js: * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers/rebaseline.js: * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js: * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js: * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js: * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js: * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js: * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js: * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js: 2012-03-19 Hao Zheng [chromium] DRT crashes at shutdown. https://bugs.webkit.org/show_bug.cgi?id=81504 Reviewed by James Robinson. WebCompositor must be destroyed after WebView is properly destroyed, or some compositor objects like CCLayerTreeHost may not be destroyed. However, it is really hard to make the destruction order correct explicitly in ~TestShell. So move it out to DumpRenderTree. * DumpRenderTree/chromium/DumpRenderTree.cpp: (main): * DumpRenderTree/chromium/TestShell.cpp: (TestShell::~TestShell): 2012-03-19 Dirk Pranke add dpranke to webkitpy watchlist https://bugs.webkit.org/show_bug.cgi?id=81433 Reviewed by Benjamin Poulain. * Scripts/webkitpy/common/config/watchlist: 2012-03-19 Dirk Pranke test-webkitpy is failing on SL/Python 2.6.1 https://bugs.webkit.org/show_bug.cgi?id=81533 Reviewed by Ojan Vafai. It appears that itertools.combinations() is buggy in 2.6.1; this backports the implementation from 2.7. * Scripts/webkitpy/layout_tests/models/test_configuration.py: (TestConfigurationConverter.collapse_macros): (TestConfigurationConverter): (TestConfigurationConverter.combinations): 2012-03-19 David Michael Barr Optimize the cleanup sequence in the start-queue.sh script https://github.com/abarth/webkit/pull/1 Reviewed by Adam Barth. Updating the working copy is an expensive operation for a repository the size of WebKit. Attempt to reset only to the target revision. * EWSTools/start-queue.sh: 2012-03-19 Raphael Kubo da Costa Adjust architecture type of the EFL build bot. https://bugs.webkit.org/show_bug.cgi?id=81452 Reviewed by Tony Chang. * BuildSlaveSupport/build.webkit.org-config/config.json: The buildslave is a 64-bit machine, therefore describe it as being x86_64, not i386. 2012-03-19 Alexander Færøy [Qt] printLoadedUrls prints "Object" instead of the actual URL. https://bugs.webkit.org/show_bug.cgi?id=81514 Reviewed by Simon Hausmann. * MiniBrowser/qt/qml/BrowserWindow.qml: 2012-03-19 Raphael Kubo da Costa [EFL] jhbuild: Set CMAKE_PREFIX_PATH in jhbuildrc. https://bugs.webkit.org/show_bug.cgi?id=81491 Reviewed by Philippe Normand. For the find_path(), find_library() etc CMake calls to find the dependencies built with jhbuild, CMAKE_PREFIX_PATH must be properly set, otherwise CMake cannot know the dependencies exist and will only look in the standard directories. * efl/jhbuildrc: Set the CMAKE_PREFIX_PATH environment variable with the jhbuild Root directory. 2012-03-19 Dominik Röttsches [EFL] Add XDG env vars to jhbuildrc https://bugs.webkit.org/show_bug.cgi?id=81510 Needed to ensure correct glib behaviour in jhbuild environment. Reviewed by Philippe Normand. * efl/jhbuildrc: 2012-03-19 Allan Sandfeld Jensen Select best target for tap gesture. https://bugs.webkit.org/show_bug.cgi?id=78801 Reviewed by Kenneth Rohde Christiansen. Add TOUCH_ADJUSTMENT to enabled features. * qmake/mkspecs/features/features.prf: 2012-03-19 Robert Kroeger [chromium] synthesize wheel events for fling on main thread https://bugs.webkit.org/show_bug.cgi?id=81458 Added the ability to dispatch GestureFlingStart and GestureFlingCancel from EventSender. Reviewed by James Robinson. * DumpRenderTree/chromium/EventSender.cpp: (EventSender::EventSender): (EventSender::gestureFlingCancel): (EventSender::gestureFlingStart): * DumpRenderTree/chromium/EventSender.h: (EventSender): 2012-03-19 Alexander Færøy [Qt] Add command line option to set the user agent in the MiniBrowser https://bugs.webkit.org/show_bug.cgi?id=81508 Reviewed by Simon Hausmann. * MiniBrowser/qt/BrowserWindow.cpp: (BrowserWindow::BrowserWindow): (BrowserWindow::webViewExperimental): * MiniBrowser/qt/BrowserWindow.h: (BrowserWindow): * MiniBrowser/qt/MiniBrowserApplication.cpp: (printHelp): (MiniBrowserApplication::handleUserOptions): * MiniBrowser/qt/MiniBrowserApplication.h: (WindowOptions::WindowOptions): (WindowOptions::setUserAgent): (WindowOptions::userAgent): (WindowOptions): 2012-03-19 Alexander Færøy [Qt] Remove dead user agent code from the MiniBrowser. Reviewed by Simon Hausmann. * MiniBrowser/qt/BrowserWindow.cpp: * MiniBrowser/qt/BrowserWindow.h: (BrowserWindow): * MiniBrowser/qt/MiniBrowser.qrc: * MiniBrowser/qt/useragentlist.txt: Removed. 2012-03-19 Raphael Kubo da Costa jhbuild: Call jhbuild's autogen.sh via bash. https://bugs.webkit.org/show_bug.cgi?id=81485 Reviewed by Philippe Normand. jhbuild's autogen.sh uses "/bin/bash" in the shebang line, however this is usually true only on Linux systems, and even then bash for some reason might not be available in that location. It is safer to call bash directly and pass autogen.sh to it instead. * jhbuild/jhbuild-wrapper: (install_jhbuild): 2012-03-19 Philippe Normand [GTK] Prefix run-launcher with run-with-jhbuild https://bugs.webkit.org/show_bug.cgi?id=81503 Reviewed by Hajime Morita. * Scripts/run-launcher: 2012-03-19 Dominik Röttsches [EFL] Prefix run-launcher with run-with-jhbuild https://bugs.webkit.org/show_bug.cgi?id=80026 Reviewed by Hajime Morita. * Scripts/run-launcher: 2012-03-18 Csaba Osztrogonác [Qt] Unreviewed. Disable -Werror on x86 until proper fix. https://bugs.webkit.org/show_bug.cgi?id=81498 * qmake/mkspecs/features/unix/default_post.prf: 2012-03-17 Raphael Kubo da Costa Unreviewed; switch to using my FreeBSD.org email address, the other one is going to disappear soon. * Scripts/webkitpy/common/config/committers.py: * Scripts/webkitpy/common/config/watchlist: 2012-03-17 Raphael Kubo da Costa Unreviewed; fix webkitpy unit test failures after r111116. It turns out that cmd_line in the patch in bug 80025 had the right signature when it was submitted, but r109242 added a few more required parameters, and since the method (and EflDriver) did not exist at the time we ended up committing a broken method. * Scripts/webkitpy/layout_tests/port/efl.py: (EflDriver.cmd_line): Add the `pixel_tests' and `per_test_args' arguments. 2012-03-17 Charles Wei [BlackBerry] Enable Web Timing for performance profiling and improvement. https://bugs.webkit.org/show_bug.cgi?id=81085 Reviewed by Rob Buis. * Scripts/build-webkit: 2012-03-17 Dominik Röttsches Add a dependencies installation step for EFL to buildbot master.cfg https://bugs.webkit.org/show_bug.cgi?id=81337 Reviewed by Gustavo Noronha Silva. * BuildSlaveSupport/build.webkit.org-config/master.cfg: (InstallEflDependencies): (Factory.__init__): 2012-03-17 Dominik Röttsches [EFL] Prefixing run-webkit-tests with run-with-jhbuild https://bugs.webkit.org/show_bug.cgi?id=80025 Reviewed by Gustavo Noronha Silva. * Scripts/webkitpy/layout_tests/port/efl.py: (EflDriver): (EflDriver.cmd_line): (EflPort._driver_class): 2012-03-17 Dominik Röttsches [EFL] Add and use run-with-jhbuild and update-webkitefl-libs scripts for EFL https://bugs.webkit.org/show_bug.cgi?id=79904 build-webkit --efl will use jhbuild for fetching and building dependencies. Reviewed by Gustavo Noronha Silva. * Scripts/update-webkitefl-libs: Added. * Scripts/webkitdirs.pm: (jhbuildWrapperPrefixIfNeeded): (generateBuildSystemFromCMakeProject): (buildCMakeGeneratedProject): * efl/common.py: Added. (script_path): (top_level_path): (number_of_cpus): * efl/jhbuild.modules: Added. * efl/jhbuildrc: Added. * efl/run-with-jhbuild: Added. 2012-03-16 Stephanie Lewis https://bugs.webkit.org/show_bug.cgi?id=81065 CrashTracer: [USER] 111 crashes in WebProcess at WebKitTestRunnerInjectedBundle: WTR::InjectedBundle::done + 142 Fix crash preventing WebKitTestRunner from working in Release. WebKitTestRunner used ostringstream to collect output from the test. ostringstream is incompatible with our FastMalloc overrides. When copying strings out ostringstream a new string is allocated with FastMalloc because the allocation is inlined. When that string is freed is uses the system malloc because that call is not inlined. I removed ostringstream in favor of StringBuilder. Properly set NDEBUG on Release builds so we don't crash when when we free the strings StringBuilder created. Reviewed by Geoff Garen. Add DEBUG_DEFINES to set NDEBUG on release builds. * WebKitTestRunner/Configurations/Base.xcconfig: * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Remove ostringstream member in favor of StringBuilder. * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::initialize): (WTR::InjectedBundle::beginTesting): (WTR::InjectedBundle::done): * WebKitTestRunner/InjectedBundle/InjectedBundle.h: (WTF): (WTR::InjectedBundle::stringBuilder): (InjectedBundle): Append output to StringBuilder. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::hasPrefix): (WTR::dumpPath): (WTR::rangeToStr): (WTR::styleDecToStr): (WTR::frameToStr): (WTR::dumpFrameScrollPosition): (WTR::dumpFrameText): (WTR::dumpDescendantFramesText): (WTR::InjectedBundlePage::dump): (WTR::InjectedBundlePage::didReceiveTitleForFrame): (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame): (WTR::InjectedBundlePage::willSendRequestForFrame): (WTR::InjectedBundlePage::decidePolicyForNavigationAction): (WTR::lastFileURLPathComponent): (WTR::InjectedBundlePage::willAddMessageToConsole): (WTR::InjectedBundlePage::willSetStatusbarText): (WTR::InjectedBundlePage::willRunJavaScriptAlert): (WTR::InjectedBundlePage::willRunJavaScriptConfirm): (WTR::InjectedBundlePage::willRunJavaScriptPrompt): (WTR::InjectedBundlePage::shouldBeginEditing): (WTR::InjectedBundlePage::shouldEndEditing): (WTR::InjectedBundlePage::shouldInsertNode): (WTR::InjectedBundlePage::shouldInsertText): (WTR::InjectedBundlePage::shouldDeleteRange): (WTR::InjectedBundlePage::shouldChangeSelectedRange): (WTR::InjectedBundlePage::shouldApplyStyle): (WTR::InjectedBundlePage::didBeginEditing): (WTR::InjectedBundlePage::didEndEditing): (WTR::InjectedBundlePage::didChange): (WTR::InjectedBundlePage::didChangeSelection): (WTR::InjectedBundlePage::supportsFullScreen): (WTR::InjectedBundlePage::enterFullScreenForElement): (WTR::InjectedBundlePage::exitFullScreenForElement): (WTR::InjectedBundlePage::beganEnterFullScreen): (WTR::InjectedBundlePage::beganExitFullScreen): (WTR::dumpBackForwardListItem): (WTR::InjectedBundlePage::dumpBackForwardList): * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::LayoutTestController::waitToDumpWatchdogTimerFired): (WTR::LayoutTestController::dumpConfigurationForViewport): Convert between WTF::String and WKStringRef. * WebKitTestRunner/StringFunctions.h: (WTR::toWTFString): (WTR): * WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): 2012-03-16 Eric Seidel Add a land-from-url command https://bugs.webkit.org/show_bug.cgi?id=81411 Reviewed by Adam Barth. Very basic so far. The goal is to make it landing smarter so that users don't have to bother to parse out the ids out of the urls. * Scripts/webkitpy/common/config/urls.py: (parse_bug_id): (parse_attachment_id): * Scripts/webkitpy/common/config/urls_unittest.py: (URLsTest.test_parse_bug_id): (URLsTest): (URLsTest.test_parse_attachment_id): * Scripts/webkitpy/tool/commands/download.py: (ProcessURLsMixin): (ProcessURLsMixin._fetch_list_of_patches_to_process): (LandFromURL): * Scripts/webkitpy/tool/commands/download_unittest.py: (test_land_from_bug): (test_land_from_url): 2012-03-16 Dave Tharp build-webkit launcher instructions use wrong relative path for Qt https://bugs.webkit.org/show_bug.cgi?id=81357 Reviewed by Eric Seidel. Ensure we are at the proper directory before generating run-launcher instructions. * Scripts/build-webkit: 2012-03-16 Brady Eidson and https://bugs.webkit.org/show_bug.cgi?id=81412 REGRESSION (r107435) Copy a link and paste to Mail: Nothing is pasted Reviewed by Geoff Garen. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/mac/WebViewCanPasteURL.mm: Added. 2012-03-16 Ojan Vafai Mark wontfix tests in full_results.json so we can ignore them in garden-o-matic https://bugs.webkit.org/show_bug.cgi?id=81407 Reviewed by Adam Barth. * Scripts/webkitpy/layout_tests/controllers/manager.py: (summarize_results): * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py: (ResultSummaryTest.summarized_results): (ResultSummaryTest.test_no_svn_revision): (ResultSummaryTest.test_svn_revision): (ResultSummaryTest): (ResultSummaryTest.test_summarized_results_wontfix): 2012-03-16 Ojan Vafai Have webkit-patch rebaseline-test update test_expectations.txt https://bugs.webkit.org/show_bug.cgi?id=81054 Recommit http://trac.webkit.org/changeset/110783 now that http://trac.webkit.org/changeset/111034 has landed. * Scripts/webkitpy/layout_tests/models/test_expectations.py: (TestExpectations.remove_configuration_from_test): * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: (RemoveConfigurationsTest): (RemoveConfigurationsTest.test_remove): (test_remove_line): * Scripts/webkitpy/tool/commands/rebaseline.py: (RebaselineTest._update_expectations_file): (RebaselineTest._rebaseline_test_and_update_expectations): (RebaselineTest): (RebaselineTest.execute): * Scripts/webkitpy/tool/commands/rebaseline_unittest.py: (TestRebaseline.test_rebaseline_updates_expectations_file_noop): (test_rebaseline_updates_expectations_file): 2012-03-15 Ojan Vafai Specifier collapsing when writing test expectations lines gets a number of cases wrong https://bugs.webkit.org/show_bug.cgi?id=81309 Reviewed by Dimitri Glazkov. I've run this over all the lines in the current Chromium test_expectations.txt file, so I'm relatively confident we now cover all the cases. * Scripts/webkitpy/layout_tests/models/test_configuration.py: (TestConfigurationConverter.__init__): (TestConfigurationConverter.collapse_macros): (TestConfigurationConverter.collapse_macros.collapse_individual_specifier_set): (TestConfigurationConverter): (TestConfigurationConverter.intersect_combination): (TestConfigurationConverter.symmetric_difference): (TestConfigurationConverter.to_specifiers_list): (TestConfigurationConverter.to_specifiers_list.try_collapsing): (TestConfigurationConverter.to_specifiers_list.try_abbreviating): * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py: (make_mock_all_test_configurations_set): (TestConfigurationConverterTest.test_symmetric_difference): (TestConfigurationConverterTest.test_to_config_set): (TestConfigurationConverterTest.test_macro_expansion): (TestConfigurationConverterTest.test_to_specifier_lists): (TestConfigurationConverterTest.test_converter_macro_collapsing): * Scripts/webkitpy/layout_tests/port/chromium.py: (ChromiumPort): * Scripts/webkitpy/layout_tests/port/chromium_android.py: (ChromiumAndroidPort.__init__): The android port uses "arm" as it's architecture, which is technically correct, but considerably complicates making collapsing work. We probably should kill the concept of architecture entirely. The benefits are not worth the code complexity. * Scripts/webkitpy/layout_tests/port/chromium_unittest.py: (ChromiumPortTest.test_all_test_configurations): * Scripts/webkitpy/tool/commands/rebaseline_unittest.py: (TestRebaseline.test_rebaseline_updates_expectations_file_noop): (test_rebaseline_updates_expectations_file): 2012-03-16 Dinu Jacob [Qt][Wk2] Assertion Failure and crash on file upload https://bugs.webkit.org/show_bug.cgi?id=80854 Reviewed by Simon Hausmann. Added filePicker to WebView using experimental API. * MiniBrowser/qt/MiniBrowser.qrc: * MiniBrowser/qt/icons/folder.png: Added. * MiniBrowser/qt/icons/titlebar.png: Added. * MiniBrowser/qt/icons/up.png: Added. * MiniBrowser/qt/qml/BrowserWindow.qml: * MiniBrowser/qt/qml/FilePicker.qml: Added. 2012-03-16 Mahesh Kulkarni Updating email for committer.py script. * Scripts/webkitpy/common/config/committers.py: 2012-03-16 Robert Kroeger [chromium] DRT: Add support for sending gesture scrolls without a begin https://bugs.webkit.org/show_bug.cgi?id=81292 Reviewed by Kent Tamura. * DumpRenderTree/chromium/EventSender.cpp: (EventSender::EventSender): (EventSender::gestureScrollFirstPoint): * DumpRenderTree/chromium/EventSender.h: (EventSender): 2012-03-02 Carlos Garcia Campos and Sergio Villar Senin [GTK] WebKitIconDatabase doesn't keep icons cached https://bugs.webkit.org/show_bug.cgi?id=56200 Reviewed by Martin Robinson. Add support for favicons in GtkLauncher. * GtkLauncher/main.c: (activateUriEntryCb): (iconLoadedCb): (createBrowser): 2012-03-16 Adam Barth Remove sheriff-bot's last-green-revision command https://bugs.webkit.org/show_bug.cgi?id=81314 Reviewed by Eric Seidel. This command is a cruel joke. WebKit doesn't really ever have a last-green-revision. * Scripts/webkitpy/common/net/buildbot/buildbot.py: (BuildBot._find_green_revision): * Scripts/webkitpy/common/net/buildbot/buildbot_mock.py: (MockBuildBot.builder_statuses): * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py: (test_find_green_revision): * Scripts/webkitpy/tool/bot/irc_command.py: (IRCCommand.execute): * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py: (SheriffIRCBotTest.test_help): * Scripts/webkitpy/tool/commands/queries.py: (PatchesToReview.execute): 2012-03-16 Tor Arne Vestbø [Qt] Make gccdepends test aware of broken icecream deps generation Icecream seems to build the files without passing -o to gcc with the original destination path, which means the target name in the dependency file is wrong. Also, echo something to the final file instead of just touching it, so it's not deleted on every build. Reviewed by Simon Hausmann. * qmake/config.tests/gccdepends/gccdepends.pro: 2012-03-16 Kihong Kwon Support for Battery Status API https://bugs.webkit.org/show_bug.cgi?id=62698 Add include directory and file. http://www.w3.org/TR/battery-status/ Reviewed by Adam Barth. * Scripts/build-webkit: 2012-03-16 Kishore Bolisetty check-webkit-style fails on LayoutTests/platform/efl/test_expectations.txt https://bugs.webkit.org/show_bug.cgi?id=81007 Reviewed by Adam Barth. A dedidcated build slave is available for efl on build.webkit.org. This change add's an entry for the elf port in list of available port builders. This is required because test_expectations.py when triggered, looks for a valid port object for the specified port. * Scripts/webkitpy/layout_tests/port/builders.py: 2012-03-16 Adam Barth [webkitpy] StatusServer.next_work_item has an incorrectly named local variable https://bugs.webkit.org/show_bug.cgi?id=81302 Reviewed by Eric Seidel. This is a trivial patch, but the variable name turned up in a grep of webkitpy and looks like copy pasta. * Scripts/webkitpy/common/net/statusserver.py: (StatusServer.next_work_item): 2012-03-16 Andrew Lo [BlackBerry] Enable PAGE_VISIBILITY_API https://bugs.webkit.org/show_bug.cgi?id=81257 Enable Page Visibility API for BlackBerry. Reviewed by Rob Buis. * Scripts/build-webkit: 2012-03-16 Zan Dobersek [Gtk] Add computedStyleIncludingVisitedInfo to DumpRenderTreeSupport https://bugs.webkit.org/show_bug.cgi?id=81232 Reviewed by Philippe Normand. Use the newly-added helper method in DumpRenderTreeSupportGtk. * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::computedStyleIncludingVisitedInfo): 2012-03-15 Eric Seidel Move parse_bug_id into config/urls in preparation for re-use elsewhere. https://bugs.webkit.org/show_bug.cgi?id=81313 Reviewed by Adam Barth. * Scripts/webkitpy/common/checkout/changelog.py: (parse_bug_id_from_changelog): * Scripts/webkitpy/common/config/urls.py: (parse_bug_id): * Scripts/webkitpy/common/config/urls_unittest.py: Copied from Tools/Scripts/webkitpy/common/config/urls.py. (URLsTest): (URLsTest.test_parse_bug_id): * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py: (test_parse_bug_id): * Scripts/webkitpy/tool/bot/irc_command.py: (_post_error_and_check_for_bug_url): * Scripts/webkitpy/tool/bot/sheriff.py: (Sheriff.post_rollout_patch): (Sheriff.post_chromium_deps_roll): 2012-03-15 Adam Barth The commit-queue should fast-track patches that have already passed the testing EWS bots https://bugs.webkit.org/show_bug.cgi?id=81305 Reviewed by Eric Seidel. If a patch has already passed the testing EWS bots (currently only the chromium-ews bot), we should be able to land the patch without running the tests again. This patch is somewhat risky in that the tests might have been broken between when the EWS bots ran and when the commit-queue is processing the patch. If that turns out to be a problem in practice, we'll tighten up this fast-track in some way, likely by making sure that the pass status is recent. * Scripts/webkitpy/tool/bot/commitqueuetask.py: (CommitQueueTaskDelegate.did_pass_testing_ews): (CommitQueueTask._did_pass_tests_recently): (CommitQueueTask.run): * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py: (MockCommitQueue.did_pass_testing_ews): (test_fast_success_case): * Scripts/webkitpy/tool/commands/queues.py: (CommitQueue.did_pass_testing_ews): * Scripts/webkitpy/tool/commands/queues_unittest.py: (test_did_pass_testing_ews): 2012-03-15 Kentaro Hara [PerformanceTests] run-perf-tests should output correct units https://bugs.webkit.org/show_bug.cgi?id=78303 Reviewed by Ryosuke Niwa. Previously run-perf-tests just supported "ms" for units. Consequently, Dromaeo perf tests had been reporting runs/s as "ms". This patch fixes run-perf-tests so that they can support custom units. The default unit is "ms". The test result looks like this: $ ./Tools/Scripts/run-perf-tests Dromaeo/dom-attr.html RESULT Dromaeo: dom-attr= 6465.9525483 runs/s median= 0.0 runs/s, stdev= 24.2983433436 runs/s, min= 6435.87649402 runs/s, max= 6515.63693392 runs/s * Scripts/webkitpy/performance_tests/perftestsrunner.py: (PerfTestsRunner._process_parser_test_result): 2012-03-15 Brent Fulgham [WinCairo] Unreviewed build change after wtf path changes. * DumpRenderTree/win/ImageDiffWinCairoCommon.vsprops: Updated include directories to look at the private header directory to find 'wtf'. 2012-03-15 Kent Tamura REGRESSION(r110595): webkit-patch suggest-reviewers doesn't work https://bugs.webkit.org/show_bug.cgi?id=81293 Reviewed by Adam Barth. r110595 introduced new format of the author field of ChangeLog entry: "Adam Barth && Benjamin Poulain " Updte chanelog.py to support it. * Scripts/webkitpy/common/checkout/changelog.py: (ChangeLogEntry._split_contributor_names): * Scripts/webkitpy/common/checkout/changelog_unittest.py: (test_parse_authors): 2012-03-15 Lynn Neir Implement LayoutTestController::setValueForUser on Windows https://bugs.webkit.org/show_bug.cgi?id=55834 Implemented setValueForUser in both DumpRenderTree and WebKitTestRunner. Reviewed by Jessie Berlin. * DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::setValueForUser): * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::LayoutTestController::setValueForUser): (WTR): * WebKitTestRunner/InjectedBundle/LayoutTestController.h: (LayoutTestController): 2012-03-15 Adam Barth Update the start-queue.sh script to match what we're using on the bots https://bugs.webkit.org/show_bug.cgi?id=81277 Reviewed by Eric Seidel. Over time we've added more magic git commands to clean up the local repo after it has been borked in various ways. The idea behind this sequence is to clear out any changes in the working copy and then to rebuild the master branch from origin/master. This patch also removes the watchdog timer that we've stopped using on the bots. This patch was reviewed on . Note: Eric and I are experimenting with GitHub to see if it might be useful for WebKit. If you have thoughts on this topic, please feel free to grab Eric or me on #webkit to chat. I assume that he and I are the only ones who care about this file so using this alternative process for this patch shouldn't cause any trouble. * EWSTools/start-queue.sh: 2012-03-15 Adam Barth The commit-queue can hang when the test_expectations.txt style check fails during commit https://bugs.webkit.org/show_bug.cgi?id=81251 Reviewed by Eric Seidel. We forgot to check the --non-interactive flag, so we end up prompting the "user" who doesn't exist on the bot. We might consider teaching the User class about non-interactive if we have this sort of bug again. * Scripts/webkitpy/tool/steps/commit.py: (Commit.options): (Commit._check_test_expectations): (Commit.run): * Scripts/webkitpy/tool/steps/commit_unittest.py: (CommitTest.test_check_test_expectations): 2012-03-15 Jessie Berlin fast/dom/Window/window-properties.html and fast/dom/prototype-inheritance-2.html failing on Mac WK2 because WebAudio is not enabled https://bugs.webkit.org/show_bug.cgi?id=81259 Reviewed by Dan Bernstein. Enable WebAudio so that it appears in the window object in the tests. The webaudio tests are all still skipped in the Mac Skipped list. * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetStateToConsistentValues): 2012-03-15 David Levin Various autoresize fixes. https://bugs.webkit.org/show_bug.cgi?id=81199 Reviewed by Darin Fisher. * DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::reset): Stop using the deprecated api that was removed. 2012-03-15 Carlos Garcia Campos [GTK] Actually use --release and --debug command line options in run-gtk-test https://bugs.webkit.org/show_bug.cgi?id=81234 Reviewed by Philippe Normand. Actually handle --release and --debug command line options to create the build directory, falling back to current hack to detect whether it's a Release or Debug build when both options are missed. * Scripts/run-gtk-tests: (TestRunner.__init__): Receive options too. (TestRunner._get_top_level_directory): Helper function to get the top level directory. (TestRunner._get_build_directory): Helper function to get the build directory depending on --release/--debug command line options or gessing it if both options are missing. (TestRunner._ensure_accessibility_daemon_is_running): Use self-options now. (TestRunner.run): Ditto. (TestRunner.run.run_tests): Pass options to the constructor instead of run(). 2012-03-15 Carlos Garcia Campos [GTK] Run unit tests with --verbose in the bots https://bugs.webkit.org/show_bug.cgi?id=81230 Reviewed by Martin Robinson. * BuildSlaveSupport/build.webkit.org-config/master.cfg: (RunGtkAPITests): Add --verbose to run-gtk-test command. 2012-03-15 Kevin Ollivier Move wx port to using export macros https://bugs.webkit.org/show_bug.cgi?id=77279 Reviewed by Hajime Morita. * waf/build/settings.py: (common_configure): 2012-03-15 Philippe Normand Unreviewed, GTK build fix attempt after r110845. * Scripts/run-gtk-tests: Added --release and --debug options. 2012-03-15 Dominik Röttsches Parametrize run-with-jhbuild and update-webkitgtk-libs with platform --gtk/--efl https://bugs.webkit.org/show_bug.cgi?id=79673 Preparatory work for bringing jhbuild enabled build to EFL port. Reviewed by Philippe Normand. * Scripts/update-webkit-libs-jhbuild: Copied from Tools/Scripts/update-webkitgtk-libs. * Scripts/update-webkitgtk-libs: * gtk/run-with-jhbuild: * jhbuild/jhbuild-wrapper: Copied from Tools/gtk/run-with-jhbuild. (top_level_path): (jhbuild_installed): (jhbuild_cloned): (jhbuild_at_expected_revision): (update_jhbuild): (clone_jhbuild): (install_jhbuild): (update_webkit_libs_jhbuild): (determine_platform): (ensure_jhbuild): 2012-03-15 Carlos Garcia Campos [GTK] Add command line options to run-gtk-tests script https://bugs.webkit.org/show_bug.cgi?id=81218 Reviewed by Philippe Normand. Following command line options have been added: -v, --verbose: to run gtester with --verbose. That would be used by the bots to make it easier to know which test case it failing. --display: to use a different display for Xvfb It's also possible to pass one or more tests as arguments. * Scripts/run-gtk-tests: (TestRunner.__init__): Receive command line arguments. (TestRunner._get_tests): Get all the tests or the ones passed by command line arguments. (TestRunner._ensure_accessibility_daemon_is_running): Use display command line argument. (TestRunner.run): Pas command line options. (TestRunner.run.run_tests): Pass command line arguments. 2012-03-15 Carlos Garcia Campos [GTK] WebKit2APITests/TestPrinting timeout in the bots https://bugs.webkit.org/show_bug.cgi?id=81211 Reviewed by Philippe Normand. Add gtk+ patch to fix timeout in the bots. A similar patch has already landed in updatream gtk+, see http://git.gnome.org/browse/gtk+/commit/?id=5ebfad5d091f4c9d9c6e60364fad4c60842f027f * gtk/jhbuild.modules: * gtk/patches/gtk+-3.0.12-gtkprinter.patch: Added. 2012-03-14 Gustavo Noronha Silva sheriffbot should also be addressable with a comma in addition to colon https://bugs.webkit.org/show_bug.cgi?id=81101 Reviewed by Adam Barth. * Scripts/webkitpy/common/net/irc/ircbot.py: (IRCBot.on_pubmsg): 2012-03-15 Alexander Færøy [Qt] MiniBrowser scroll indicators should not scroll out of view https://bugs.webkit.org/show_bug.cgi?id=81131 Reviewed by Kenneth Rohde Christiansen. * MiniBrowser/qt/qml/ScrollIndicator.qml: 2012-03-14 Chris Fleizach AX: ARIA tables need to support selected rows attribute/select rows changed notification https://bugs.webkit.org/show_bug.cgi?id=79821 Reviewed by Beth Dakin. * DumpRenderTree/AccessibilityUIElement.cpp: (rowAtIndexCallback): (AccessibilityUIElement::getJSClass): * DumpRenderTree/AccessibilityUIElement.h: (AccessibilityUIElement): * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp: (AccessibilityUIElement::rowAtIndex): * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: (AccessibilityUIElement::rowAtIndex): * DumpRenderTree/mac/AccessibilityUIElementMac.mm: (AccessibilityUIElement::rowAtIndex): * DumpRenderTree/win/AccessibilityUIElementWin.cpp: (AccessibilityUIElement::rowAtIndex): 2012-03-14 Tim Horton NRWT should respect --additional-platform-directory's Skipped list https://bugs.webkit.org/show_bug.cgi?id=81172 Reviewed by Timothy Hatcher. Respect the Skipped file inside all paths included via the --additional-platform-directory option. Test results from said path are already used, but the Skipped file is ignored. * Scripts/webkitpy/layout_tests/port/webkit.py: (WebKitPort._skipped_file_search_paths): * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: (test_skipped_file_search_paths): 2012-03-14 Ojan Vafai Unreviewed, rolling out r110783. http://trac.webkit.org/changeset/110783 https://bugs.webkit.org/show_bug.cgi?id=81054 Caused existing test expectation lines to expand to one for each test configuration. * Scripts/webkitpy/layout_tests/models/test_expectations.py: (TestExpectations.has_warnings): * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: (test_macro_overrides): * Scripts/webkitpy/tool/commands/rebaseline.py: (RebaselineTest._save_baseline): (RebaselineTest._rebaseline_test): (RebaselineTest.execute): * Scripts/webkitpy/tool/commands/rebaseline_unittest.py: (TestRebaseline.test_tests_to_update): 2012-03-13 Jon Lee Separate NOTIFICATIONS and LEGACY_NOTIFICATIONS https://bugs.webkit.org/show_bug.cgi?id=80922 Reviewed by Jian Li. You can include either NOTIFICATIONS or LEGACY_NOTIFICATIONS and have a complete API. LEGACY_NOTIFICATIONS should cover all of the previous functionality, and NOTIFICATIONS will cover the new API. Therefore, APIs that are common between the two will have: #if ENABLE(NOTIFICATIONS) || ENABLE(LEGACY_NOTIFICATIONS) This patch initially sets both to be exactly the same. As other bugs with patches begin to migrate to the new API, the defines will begin to split. This allows ports to decide which set of APIs to include. Update everything to be #if ENABLE(NOTIFICATIONS) || ENABLE(LEGACY_NOTIFICATIONS) * DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::grantDesktopNotificationPermission): (LayoutTestController::simulateDesktopNotificationClick): * DumpRenderTree/chromium/NotificationPresenter.cpp: * DumpRenderTree/chromium/TestShell.cpp: (TestShell::TestShell): (TestShell::resetTestController): * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp: (DRTDesktopNotificationPresenter::checkNotificationPermission): 2012-03-13 Ojan Vafai Have webkit-patch rebaseline-test update test_expectations.txt https://bugs.webkit.org/show_bug.cgi?id=81054 Reviewed by Dirk Pranke. This will allow us to use the All Failures tab in garden-o-matic to rebaseline tests without making test_expectations.txt stale. It's conservative and only removes lines if the test is not flaky and fails in a way the rebaseline would fix (e.g. CRASH/TIMEOUT will not be touched). * Scripts/webkitpy/layout_tests/models/test_expectations.py: (TestExpectations.remove_configuration_from_test): * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: (RemoveConfigurationsTest): (RemoveConfigurationsTest.test_remove): (test_remove_line): * Scripts/webkitpy/tool/commands/rebaseline.py: (RebaselineTest._is_supported_port): (RebaselineTest): (RebaselineTest._update_expectations_file): (RebaselineTest._rebaseline_test_and_update_expectations): (RebaselineTest.execute): * Scripts/webkitpy/tool/commands/rebaseline_unittest.py: (TestRebaseline.test_rebaseline_updates_expectations_file): 2012-03-14 Jessie Berlin Crash in WKTR under addChromeInputField due to using 0 as a key in a HashMap https://bugs.webkit.org/show_bug.cgi?id=81167 Reviewed by Sam Weinig. Do not use 0 as a key in a HashMap. * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: cacheLayoutTestControllerCallback uses the enum as keys for the callback map. 2012-03-14 Ojan Vafai Add the chromium lion bot to garden-o-matic and remove the platform_move_to in builders.py since the Chromium Lion port is now a normal port. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js: * Scripts/webkitpy/layout_tests/port/builders.py: 2012-03-14 Dirk Pranke Fix regression/crash introduced in r110724 - bad type passed from skipped_tests() by default. Unreviewed, build fix. * Scripts/webkitpy/layout_tests/port/base.py: (Port.skipped_tests): 2012-03-14 Dirk Pranke Please add a way to manually skip some tests in NRWT https://bugs.webkit.org/show_bug.cgi?id=81019 Reviewed by Ojan Vafai. This patch implements the -i / --ignore-tests flag from ORWT and refactors the test_expectations.py code slightly to handle it. * Scripts/webkitpy/layout_tests/controllers/manager.py: (Manager.parse_expectations): * Scripts/webkitpy/layout_tests/models/test_expectations.py: (TestExpectations.__init__): * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: (test_add_skipped_tests): (test_add_skipped_tests_duplicate): * Scripts/webkitpy/layout_tests/run_webkit_tests.py: (parse_args): * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: (MainTest.test_ignore_tests): (MainTest.test_ignore_tests.assert_ignored): 2012-03-14 Dirk Pranke nrwt: run with no args on lion, is putting baselines in platform/mac-lion, not platform/mac https://bugs.webkit.org/show_bug.cgi?id=81028 Reviewed by Ojan Vafai. The mac port had incorrect lookups for 'mac-lion' and 'mac-future' in some places. This patch fixes that and adds a bunch of tests. * Scripts/webkitpy/layout_tests/port/mac.py: (MacPort.baseline_path): * Scripts/webkitpy/layout_tests/port/mac_unittest.py: (MacTest.assert_skipped_file_search_paths): (MacTest.test_skipped_file_search_paths): (_assert_search_path): (test_baseline_search_path): * Scripts/webkitpy/layout_tests/port/webkit.py: (WebKitPort._skipped_file_search_paths): 2012-03-13 Jer Noble Lion Intel Debug WebKit2 Tests crashing under [WKFullScreenWindowController _startEnterFullScreenAnimationWithDuration:] https://bugs.webkit.org/show_bug.cgi?id=81056 Reviewed by Jessie Berlin. Intercept beganEnterFullScreen and beganExitFullScreen and turn them into no-ops (plus logging). * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::InjectedBundlePage): (WTR::InjectedBundlePage::beganEnterFullScreen): (WTR::InjectedBundlePage::beganExitFullScreen): 2012-03-14 Alexander Færøy The width and height of the scroll indicators in the MiniBrowser does not consider the offset margins. https://bugs.webkit.org/show_bug.cgi?id=81112 Reviewed by Kenneth Rohde Christiansen. This patch fixes the issue by withdrawing two times the anchor margins. * MiniBrowser/qt/qml/ScrollIndicator.qml: 2012-03-14 Sudarsana Nagineni [EFL] Implement LayoutTestController::clearBackForwardList https://bugs.webkit.org/show_bug.cgi?id=80142 Adding missing implementation clearBackForwardList to EFL's LayoutTestController. This implementation allows us to unskip tests connected with history. Reviewed by Antonio Gomes. * DumpRenderTree/efl/LayoutTestControllerEfl.cpp: (LayoutTestController::clearBackForwardList): Implemented. 2012-03-13 Thiago Marcos P. Santos [EFL][DRT] Expose window.internals object https://bugs.webkit.org/show_bug.cgi?id=79900 Exposes window.internals for EFL's DRT. Makes possible to remove some tests from the skip list. Reviewed by Antonio Gomes. * DumpRenderTree/efl/CMakeLists.txt: * DumpRenderTree/efl/DumpRenderTreeChrome.cpp: (DumpRenderTreeChrome::onWindowObjectCleared): 2012-03-13 Adam Barth && Benjamin Poulain Always enable ENABLE(CLIENT_BASED_GEOLOCATION) https://bugs.webkit.org/show_bug.cgi?id=78853 Reviewed by Adam Barth. * Scripts/build-webkit: * qmake/mkspecs/features/features.prf: 2012-03-12 Antonio Gomes Convert nodesFromRect tests to use Internals interface https://bugs.webkit.org/show_bug.cgi?id=80886 Reviewed by Ryosuke Niwa. This clean up allows to remove port specific bits of each DRT implementation that supports testing Document::nodesFromRect, in favor of making use of the 'Internals' interface to test it. This makes its code conveniently more expansible and cleaner. Also removed stubs from Win and EFL DRTs. * DumpRenderTree/LayoutTestController.cpp: (LayoutTestController::staticFunctions): * DumpRenderTree/LayoutTestController.h: (LayoutTestController): * DumpRenderTree/efl/LayoutTestControllerEfl.cpp: * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: * DumpRenderTree/mac/LayoutTestControllerMac.mm: * DumpRenderTree/qt/LayoutTestControllerQt.cpp: * DumpRenderTree/qt/LayoutTestControllerQt.h: (LayoutTestController): * DumpRenderTree/win/LayoutTestControllerWin.cpp: 2012-03-13 Ojan Vafai Rebaselining for a new port doesn't work right with multiple fallback ports https://bugs.webkit.org/show_bug.cgi?id=80932 Reviewed by Adam Barth. Since chromium-leopard also falls back to mac-leopard, we need to copy the existing result for both chromium-leopard and chromium-snowleopard before doing lion rebaselines. * Scripts/webkitpy/layout_tests/port/builders.py: (fallback_port_names_for_new_port): * Scripts/webkitpy/tool/commands/rebaseline.py: (RebaselineTest): (RebaselineTest._copy_existing_baseline): (RebaselineTest._rebaseline_test): (RebaselineTest.execute): * Scripts/webkitpy/tool/commands/rebaseline_unittest.py: * Scripts/webkitpy/tool/servers/gardeningserver.py: (GardeningHTTPRequestHandler.rebaseline): * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py: (GardeningServerTest.test_rebaseline_new_port): 2012-03-13 Tor Arne Vestbø [Qt] Tweak minibrowser UI Add some margins to the scroll indicators, and set a dark background color so you see the page dimensions. Reviewed by Antonio Gomes. * MiniBrowser/qt/qml/BrowserWindow.qml: * MiniBrowser/qt/qml/ScrollIndicator.qml: 2012-03-13 ChangSeok Oh [EFL] [DRT] Implement scheduleAsynchronousKeyDown. https://bugs.webkit.org/show_bug.cgi?id=79601 Reviewed by Gustavo Noronha Silva. Extracted shareable code from keyDownCallback and then added createKeyEventInfo. createKeyEventInfo creates a new structure KeyEventInfo that has keyName and modifiers and is taken over to sendKeyDown. Added sendKeyDown and sendAsynchronousKeyDown to evaluate keyDown event directly and asynchronously. Eventually, sendAsynchronousKeyDown calls sendKeyDown. * DumpRenderTree/efl/EventSender.cpp: (KeyEventInfo::KeyEventInfo): (KeyEventInfo): (createKeyEventInfo): (sendKeyDown): (keyDownCallback): (sendAsynchronousKeyDown): (scheduleAsynchronousKeyDownCallback): 2012-03-12 Ojan Vafai webkit-patch optimize-baselines sometimes creates a mac-future result https://bugs.webkit.org/show_bug.cgi?id=80717 Reviewed by Adam Barth. * Scripts/webkitpy/common/checkout/baselineoptimizer.py: (_baseline_search_hypergraph): (BaselineOptimizer._find_optimal_result_placement): (BaselineOptimizer._filter_virtual_ports): * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py: (BaselineOptimizerTest.test_no_add_mac_future): 2012-03-12 Jessie Berlin More Windows build fixing. * DumpRenderTree/win/WorkQueueItemWin.cpp: 2012-03-12 Jessie Berlin More Windows build fixing. * DumpRenderTree/win/AccessibilityControllerWin.cpp: * DumpRenderTree/win/EditingDelegate.cpp: * DumpRenderTree/win/EventSender.cpp: * DumpRenderTree/win/FrameLoadDelegate.cpp: * DumpRenderTree/win/LayoutTestControllerWin.cpp: * DumpRenderTree/win/UIDelegate.cpp: 2012-03-12 Dirk Pranke remove the 'gpu' group from the flakiness dashboard https://bugs.webkit.org/show_bug.cgi?id=80353 Reviewed by Adam Barth. Since those bots are obsolete, we don't need this any more. * TestResultServer/static-dashboards/builders.js: * TestResultServer/static-dashboards/flakiness_dashboard_tests.js: (testPlatformAndBuildType): (testHtmlForTestTypeSwitcherGroup): 2012-03-12 Dirk Pranke remove graphics_type from webkitpy.layout_tests.models.test_configuration https://bugs.webkit.org/show_bug.cgi?id=80643 Reviewed by Ojan Vafai. Now that the chromium-gpu ports are gone, there's no need for the graphics_type CPU/GPU distinction. Most of this change is just updating tests accordingly. * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py: (TestExpectationEditorTests): * Scripts/webkitpy/layout_tests/models/test_configuration.py: (TestConfiguration.__init__): (TestConfiguration.category_order): (TestConfiguration.__str__): (TestConfiguration.__repr__): (TestConfiguration.__hash__): (TestConfigurationConverter.to_specifiers_list): * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py: (make_mock_all_test_configurations_set): (TestConfigurationTest.test_items): (TestConfigurationTest.test_keys): (TestConfigurationTest.test_str): (TestConfigurationTest.test_repr): (TestConfigurationTest.test_hash): (TestConfigurationTest.test_hash.query_unknown_key): (TestConfigurationTest.test_eq): (TestConfigurationTest.test_values): (SpecifierSorterTest.test_specifier_priority): (SpecifierSorterTest.test_sort_specifiers): (TestConfigurationConverterTest.test_to_config_set): (TestConfigurationConverterTest.test_macro_expansion): (TestConfigurationConverterTest.test_to_specifier_lists): (TestConfigurationConverterTest.test_converter_macro_collapsing): * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: (test_error_on_different_build_type): (TestExpectationSerializerTests.test_parsed_to_string): (TestExpectationSerializerTests.test_reconstitute_only_these): * Scripts/webkitpy/layout_tests/port/apple.py: (ApplePort._generate_all_test_configurations): * Scripts/webkitpy/layout_tests/port/base.py: (Port.__init__): (Port.name): (Port.version): (Port.test_configuration): * Scripts/webkitpy/layout_tests/port/builders.py: * Scripts/webkitpy/layout_tests/port/chromium.py: (ChromiumPort): (ChromiumPort._generate_all_test_configurations): * Scripts/webkitpy/layout_tests/port/chromium_linux.py: (ChromiumLinuxPort.__init__): * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py: (ChromiumLinuxPortTest.test_check_illegal_port_names): * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py: (ChromiumMacPortTest.test_baseline_path): * Scripts/webkitpy/layout_tests/port/chromium_unittest.py: (ChromiumPortTest.test_all_test_configurations): * Scripts/webkitpy/layout_tests/port/efl.py: (EflPort._generate_all_test_configurations): * Scripts/webkitpy/layout_tests/port/gtk.py: (GtkPort._generate_all_test_configurations): * Scripts/webkitpy/layout_tests/port/qt.py: (QtPort._generate_all_test_configurations): * Scripts/webkitpy/layout_tests/port/test.py: (TestPort.all_test_configurations): (TestPort._all_build_types): * Scripts/webkitpy/tool/commands/rebaseline_unittest.py: * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py: (BuildCoverageExtrapolatorTest.test_extrapolate): (GardeningExpectationsUpdaterTest.test_unknown_failure_type): (GardeningExpectationsUpdaterTest.test_add_new_expectation): (GardeningExpectationsUpdaterTest.test_replace_old_expectation): (GardeningExpectationsUpdaterTest.test_pass_expectation): (GardeningExpectationsUpdaterTest.test_supplement_old_expectation): (GardeningExpectationsUpdaterTest.test_spurious_updates): 2012-03-12 Dirk Pranke _runtime_feature_list isn't supported on Apple Mac DRT https://bugs.webkit.org/show_bug.cgi?id=80906 Reviewed by Eric Seidel. It looks like this feature is actually only supported on the Win DRT port, so this patch reworks the code to make that clearer and reduce unnecessary overrides. * Scripts/webkitpy/layout_tests/port/efl.py: (EflPort._path_to_webcore_library): * Scripts/webkitpy/layout_tests/port/gtk.py: (GtkPort._path_to_webcore_library): * Scripts/webkitpy/layout_tests/port/qt.py: (QtPort._skipped_file_search_paths): * Scripts/webkitpy/layout_tests/port/webkit.py: (WebKitPort._runtime_feature_list): * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: (TestWebKitPort.__init__): (TestWebKitPort.all_test_configurations): (test_skipped_directories_for_features): * Scripts/webkitpy/layout_tests/port/win.py: (WinPort): (WinPort._runtime_feature_list): * Scripts/webkitpy/layout_tests/port/win_unittest.py: (WinPortTest.test_operating_system): (WinPortTest): (WinPortTest.test_runtime_feature_list): 2012-03-12 Peter Beverloo [Chromium] Temporary build-fix for the Android bot https://bugs.webkit.org/show_bug.cgi?id=80862 Reviewed by Adam Barth. Manually set the environmental variables required to compile source files through the Android NDK instead of relying on the envsetup.sh script. A proper fix will be landed to Chromium ASAP, and following a Chromium roll into WebKit this code will be removed. * Scripts/webkitdirs.pm: (buildChromiumMakefile): 2012-03-12 Tor Arne Vestbø [Qt] Use right construct to detect config_test_gccdepends Reviewed by Andreas Kling. * qmake/mkspecs/features/default_pre.prf: 2012-03-12 Tor Arne Vestbø [Qt] Expose location of WebKit's bin and imports dir through module file Reviewed by Andreas Kling. * qmake/qt_webkit.pri: 2012-03-12 Andras Becsi [Qt][WK2] Add support for rudimentary scroll indicators in MiniBrowser https://bugs.webkit.org/show_bug.cgi?id=80832 Reviewed by Tor Arne Vestbø. Add a basic scroll indicator component to MiniBrowser so that it behaves similar to the ScrollDecorator QML component. * MiniBrowser/qt/MiniBrowser.qrc: * MiniBrowser/qt/qml/BrowserWindow.qml: * MiniBrowser/qt/qml/ScrollIndicator.qml: Added. 2012-03-12 C Anthony Risinger [GTK] r110296 included an extra $ in @$(AM_V_GEN) https://bugs.webkit.org/show_bug.cgi?id=80809 Reviewed by Philippe Normand. * GNUmakefile.am: Add `$` to @(AM_V_GEN), else /bin/sh syntax error 2012-03-12 Ming Xie [BlackBerry] build-webkit doesn't recognize "--cmakearg" for the BlackBerry port https://bugs.webkit.org/show_bug.cgi?id=80812 Reviewed by Rob Buis. * Scripts/build-webkit: Add $cmakeArgs to buildCMakeProjectOrExit() * Scripts/webkitdirs.pm: (blackberryCMakeArguments): Remove "PUBLIC_BUILD=0" define 2012-03-12 Simon Hausmann [Qt] Fix build with newer Qt 5. Reviewed by Tor Arne Vestbø. Newer Qt 5 renames QDeclarativeFoo to QQmlFoo and provides backwards compatible renames, which however do trigger a #warning. Until we _require_ a newer Qt 5 we should disable -Werror. Also load(moc) for the availability of QMAKE_MOC in various derived sources. The implicit load was removed recently. * qmake/mkspecs/features/default_pre.prf: * qmake/mkspecs/features/unix/default_post.prf: 2012-03-11 Maciej Stachowiak Add --instruments option to sunspider to profile with Instruments https://bugs.webkit.org/show_bug.cgi?id=80783 Reviewed by Filip Pizlo. * Scripts/run-sunspider: 2012-03-11 Viatcheslav Ostapenko [Qt] [WK2] Support threaded renderer in WK2 https://bugs.webkit.org/show_bug.cgi?id=76661 Remove disabling of threaded rendering. Reviewed by Noam Rosenthal. * MiniBrowser/qt/main.cpp: (main): 2012-03-09 Zan Dobersek [WK2] run-perf-tests should be able to run with WTR https://bugs.webkit.org/show_bug.cgi?id=80042 Reviewed by Martin Robinson. Add an option to PerfTestRunner to use WebKitTestRunner instead of DumpRenderTree and add the '--no-timeout' flag to WebKitTestRunner to avoid timing out when running performance tests. * Scripts/webkitpy/performance_tests/perftestsrunner.py: (PerfTestsRunner._parse_args): * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::InjectedBundle): Initialize m_useWaitToDumpWatchdogTimer to true. (WTR::InjectedBundle::didReceiveMessage): Unpack the 'BeginTest' message as a dictionary containing DumpPixels and UseWaitToDumpWatchdogTimer keys. * WebKitTestRunner/InjectedBundle/InjectedBundle.h: (WTR::InjectedBundle::useWaitToDumpWatchdogTimer): Make m_useWaitToDumpWatchdogTimer publicly accessible. * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::LayoutTestController::waitUntilDone): Only initialize the watchdog if it is required. * WebKitTestRunner/TestController.cpp: (WTR::TestController::TestController): Initialize m_useWaitToDumpWatchdogTimer to true. (WTR::TestController::initialize): Set m_useWaitToDumpWatchdogTimer to false if '--no-timeout' option is present. (WTR::TestController::runUntil): Translate TimeoutDuration to a proper timeout value, or -1.0 if timeout should not occur. * WebKitTestRunner/TestController.h: (WTR::TestController::useWaitToDumpWatchdogTimer): Make m_useWaitToDumpWatchdogTimer publicly accessible. * WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::invoke): Pack the 'BeginTest' message as a dictionary, containing DumpPixels and UseWaitToDumpWatchdogTimer keys and corresponding values. Waiting for final message should not time out if not necessary. * WebKitTestRunner/gtk/TestControllerGtk.cpp: (WTR::TestController::platformRunUntil): Only set up a timeout if necessary. * WebKitTestRunner/qt/TestControllerQt.cpp: (WTR::TestController::platformRunUntil): Ditto. * WebKitTestRunner/mac/TestControllerMac.mm: (WTR::TestController::platformRunUntil): Add a FIXME, indicating functionality is missing. * WebKitTestRunner/win/TestControllerWin.cpp: (WTR::TestController::platformRunUntil): Ditto. 2012-03-09 Jon Lee Rename NotificationPresenter to NotificationClient https://bugs.webkit.org/show_bug.cgi?id=80488 Reviewed by Kentaro Hara. Refactor to use renamed WebCore::NotificationClient. * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp: (DRTDesktopNotificationPresenter::checkNotificationPermission): 2012-03-07 James Robinson [chromium] Deprecate renderDirectlyToWebView parameter of WebViewClient::createGraphicsContext3D() https://bugs.webkit.org/show_bug.cgi?id=80523 Reviewed by Darin Fisher. * DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::createGraphicsContext3D): * DumpRenderTree/chromium/WebViewHost.h: (WebViewHost): 2012-03-09 Eric Seidel build-webkit should build Source/WTF on Mac https://bugs.webkit.org/show_bug.cgi?id=80728 Reviewed by Adam Barth. We'll add other ports to this list in future commits. * Scripts/build-webkit: 2012-03-09 Jon Lee Add support for ENABLE(LEGACY_NOTIFICATIONS) https://bugs.webkit.org/show_bug.cgi?id=80497 Reviewed by Adam Barth. Prep for b80472: Update API for Web Notifications * Scripts/build-webkit: * qmake/mkspecs/features/features.prf: 2012-03-09 Ashod Nakashian Bash scripts should support LF endings only https://bugs.webkit.org/show_bug.cgi?id=79509 Reviewed by David Kilzer. * EWSTools/boot.sh: Added properties svn:executable and svn:eol-style. * EWSTools/start-queue.sh: Added property svn:eol-style. * Scripts/webkit-tools-completion.sh: Added properties svn:executable and svn:eol-style. * WebKitTestRunner/win/build-generated-files.sh: Added properties svn:executable and svn:eol-style. * iExploder/iexploder-1.7.2/tools/release_src.sh: Added property svn:eol-style. * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh: Added property svn:eol-style. 2012-03-09 Ionut Biru [BUILD] use detected python to run generate-gtkdoc https://bugs.webkit.org/show_bug.cgi?id=80695 Reviewed by Gustavo Noronha Silva. * GNUmakefile.am: Use $(PYTHON) instead of plain `python` 2012-03-09 Nat Duca Make check-webkit-style complain about "no new tests" lines in changelogs https://bugs.webkit.org/show_bug.cgi?id=80582 Reviewed by David Levin. * Scripts/webkitpy/style/checkers/changelog.py: (ChangeLogChecker.check_entry): * Scripts/webkitpy/style/checkers/changelog_unittest.py: (ChangeLogCheckerTest.test_no_new_tests): 2012-03-09 Sheriff Bot Unreviewed, rolling out r110250. http://trac.webkit.org/changeset/110250 https://bugs.webkit.org/show_bug.cgi?id=80682 It made NRWT ignore test_expectations.txt on Qt-WK2 and ignore qt-linux at all. (Requested by Ossy on #webkit). * Scripts/old-run-webkit-tests: * Scripts/webkitpy/layout_tests/port/qt.py: (QtPort): (QtPort.determine_full_port_name): (QtPort.baseline_search_path): * Scripts/webkitpy/layout_tests/port/qt_unittest.py: (QtPortTest): (QtPortTest._assert_search_path): (QtPortTest.test_baseline_search_path): 2012-03-08 Tor Arne Vestbø [Qt] Use Qt's module system for install rules and depending on QtWebKit Instead of rolling our own install rules we now use the same approach as every other Qt module, by loading qt_module.prf and qt_module_config.prf. This ensures that we follow the same semantics as the rest of Qt on what sort of config options are enabled by default (create_cmake eg.). It also allows us to use QT += webkit instead of the workaround we had with CONFIG += qtwebkit. We do however force Qt to always treat our build as a non-developer build, so the libraries will end up in the WebKit lib directory instead of the qtbase directory (as with a normal developer-build). This allows us to keep the webkit-build self-contained. If Qt is a developer build we still copy the module file manually to Qt, so that you don't have to install WebKit to make it available. For non-developer builds of Qt, it is still possible to use the built WebKit libraries without having to install them, by having the variable QMAKE_EXTRA_MODULE_FORWARDS set in the project's .qmake.cache file, pointing to $WEBKITOUTUTDIR/$CONFIGURATION/modules. https://bugs.webkit.org/show_bug.cgi?id=80590 Reviewed by Simon Hausmann. * DumpRenderTree/qt/DumpRenderTree.pro: * MiniBrowser/qt/BrowserWindow.cpp: * MiniBrowser/qt/MiniBrowser.pro: * MiniBrowser/qt/MiniBrowserApplication.cpp: * MiniBrowser/qt/UrlLoader.cpp: * QtTestBrowser/QtTestBrowser.pro: * Tools.pro: * WebKitTestRunner/InjectedBundle/Target.pri: * WebKitTestRunner/Target.pri: * qmake/mkspecs/features/default_post.prf: * qmake/mkspecs/features/default_pre.prf: * qmake/mkspecs/features/functions.prf: * qmake/mkspecs/features/qtwebkit-private.prf: Removed. * qmake/mkspecs/features/qtwebkit.prf: * qmake/mkspecs/features/rpath.prf: * qmake/mkspecs/modules/qt_webkit.pri: Removed. * qmake/qt_webkit.pri: Added. 2012-03-08 Igor Oliveira Unreviewed. Update my email. * Scripts/webkitpy/common/config/committers.py: 2012-03-08 Xianzhu Wang Recent changes to chromium.py etc. broke chromium_android.py https://bugs.webkit.org/show_bug.cgi?id=80623 Reviewed by Dirk Pranke. * Scripts/webkitpy/layout_tests/port/chromium_android.py: (ChromiumAndroidDriver.__init__): (ChromiumAndroidDriver._start): 2012-03-08 Xianzhu Wang [Chromium] Exception running reftest with --no-pixel-tests https://bugs.webkit.org/show_bug.cgi?id=80642 Reviewed by Dirk Pranke. * Scripts/webkitpy/layout_tests/port/chromium.py: (ChromiumDriver.__init__): (ChromiumDriver._wrapper_options): 2012-03-08 Rafael Brandao [NRWT] Fix --platform=qt-5.0 --new-baseline combo https://bugs.webkit.org/show_bug.cgi?id=72489 Reviewed by Dirk Pranke. NRWT: The default platform name for Qt combined with --webkit-test-runner is now "qt-5.0-wk2" instead of "qt-linux" and that name is now prefered for tests. --platform will override the platform name and then we'll use it. ORWT: We check for qt version and use platform name "qt-4.8" if the version is lower than 5.0.0, and then we choose between "qt-5.0-wk1" and "qt-5.0-wk2". --platform will override it in the end. * Scripts/old-run-webkit-tests: * Scripts/webkitpy/layout_tests/port/qt.py: (QtPort): (QtPort.determine_full_port_name): (QtPort.baseline_search_path): * Scripts/webkitpy/layout_tests/port/qt_unittest.py: (QtPortTest): (QtPortTest._assert_search_path): (QtPortTest.test_baseline_search_path): 2012-03-08 Beth Dakin https://bugs.webkit.org/show_bug.cgi?id=80463 RenderImage is using the wrong origin when calling addRelevantRepaintedObject -and corresponding- Reviewed by Dan Bernstein. New test! * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages.cpp: Added. (TestWebKitAPI): (TestWebKitAPI::didNewFirstVisuallyNonEmptyLayout): (TestWebKitAPI::setPageLoaderClient): (TestWebKitAPI::TEST): * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages_Bundle.cpp: Added. (TestWebKitAPI): (NewFirstVisuallyNonEmptyLayoutForImagesTest): (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutForImagesTest::NewFirstVisuallyNonEmptyLayoutForImagesTest): (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutForImagesTest::didCreatePage): * TestWebKitAPI/Tests/WebKit2/lots-of-images.html: Added. 2012-03-08 Tor Arne Vestbø [Qt] Prospective Windows build fix Don't assume that windows-builds will always run inside a cmd.exe shell. * qmake/mkspecs/features/default_pre.prf: 2012-03-08 Dan Bernstein Dashboard regions should not be in device space Reviewed by John Sullivan. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/mac/DeviceScaleFactorInDashboardRegions.mm: Added. (-[DeviceScaleFactorInDashboardRegionsUIDelegate webView:dashboardRegionsChanged:]): (TestWebKitAPI): (TestWebKitAPI::TEST): 2012-03-08 Dirk Pranke webkit-patch works oddly on local Git branches https://bugs.webkit.org/show_bug.cgi?id=76958 Reviewed by Ojan Vafai. This change makes the '-g' flag to webkit-patch behave a little more consistently with git. The 'HEAD..' syntax is changed to 'HEAD....' (four dots), so as to not collide with the underlying git syntax. We also generalize the syntax to support any refname, so 'foo....' means diff against foo and include working copy changes. This change also adds the 'UPSTREAM' shortcut to identify whatever the current upstream/tracking branch is; this is useful if you have multiple local branches stacked up. * Scripts/webkitpy/common/checkout/scm/git.py: (Git._branch_from_ref): (Git): (Git._current_branch): (Git._upstream_branch): (Git.merge_base): (Git._commit_on_branch): * Scripts/webkitpy/common/checkout/scm/scm_unittest.py: (GitSVNTest._second_local_commit): (GitSVNTest._two_local_commits): (GitSVNTest.test_commit_with_message_git_commit_range): (GitSVNTest.test_upstream_branch): (GitSVNTest.test_create_patch_working_copy_only): (GitSVNTest.test_changed_files_local_plus_working_copy): (GitSVNTest.test_changed_files_working_copy_only): (GitSVNTest.test_changed_files_upstream): * Scripts/webkitpy/tool/steps/options.py: (Options): 2012-03-08 John Sullivan Made extract-localizable-strings ignore NSLocalizedFileSizeDescription Reviewed by Eric Carlson. * Scripts/extract-localizable-strings: Added NSLocalizedFileSizeDescription to allowed list of tokens that start with NSLocalized. Also improved an error message to include the troublesome token. 2012-03-08 Sheriff Bot Unreviewed, rolling out r110115. http://trac.webkit.org/changeset/110115 https://bugs.webkit.org/show_bug.cgi?id=80581 broke test-webkitpy (Requested by philn-tp on #webkit). * Scripts/old-run-webkit-tests: * Scripts/webkitpy/layout_tests/port/qt.py: (QtPort): (QtPort.determine_full_port_name): (QtPort.baseline_search_path): 2012-03-08 Kentaro Hara Unreviewed. Added myself to watchlist. * Scripts/webkitpy/common/config/watchlist: 2012-03-07 Jessie Berlin Clean Windows build fails after r110033 https://bugs.webkit.org/show_bug.cgi?id=80553 Rubber-stamped by Jon Honeycutt and Eric Seidel. Add the new JavaScriptCore include directory to some more vsprops files. * DumpRenderTree/win/ImageDiffCommon.vsprops: * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops: * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops: 2012-03-07 Rafael Brandao [NRWT] Fix --platform=qt-5.0 --new-baseline combo https://bugs.webkit.org/show_bug.cgi?id=72489 Reviewed by Dirk Pranke. NRWT: The default platform name for Qt combined with --webkit-test-runner is now "qt-5.0-wk2" instead of "qt-linux" and that name is now prefered for tests. --platform will override the platform name and then we'll use it. ORWT: We check for qt version and use platform name "qt-4.8" if the version is lower than 5.0.0, and then we choose between "qt-5.0-wk1" and "qt-5.0-wk2". --platform will override it in the end. * Scripts/old-run-webkit-tests: * Scripts/webkitpy/layout_tests/port/qt.py: (QtPort): (QtPort.determine_full_port_name): (QtPort.baseline_search_path): 2012-03-07 Hugo Parente Lima [Qt][WK2] MiniBrowser on desktop does not react to click events https://bugs.webkit.org/show_bug.cgi?id=80314 Reviewed by Kenneth Rohde Christiansen. Do not enable touch mocking on desktop mode. * MiniBrowser/qt/MiniBrowserApplication.cpp: (MiniBrowserApplication::handleUserOptions): 2012-03-07 Ojan Vafai Automatically move to the next test after rebaseline in the results view https://bugs.webkit.org/show_bug.cgi?id=80527 Reviewed by Dimitri Glazkov. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js: * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js: 2012-03-07 Ojan Vafai garden-o-matic rebaseline is broken for ports that don't have a fallback port https://bugs.webkit.org/show_bug.cgi?id=80526 Reviewed by Adam Barth. Passing "None" as the fallback port throws an error in "webkit-patch rebaseline-test" since there is no "None" port. * Scripts/webkitpy/tool/servers/gardeningserver.py: (GardeningHTTPRequestHandler.rebaseline): * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py: (GardeningServerTest.test_rebaseline): 2012-03-07 James Robinson [chromium] Remove the TestWebPlugin's use of implicit FBO for offscreen contexts https://bugs.webkit.org/show_bug.cgi?id=80521 Reviewed by Kenneth Russell. Switches TestWebPlugin from using a context created by WebViewClient::createGraphicsContext3D(..., false) over to an explicitly offscreen context with explicitly managed texture / FBO, so we can deprecate the renderDirectlyToHostWindow flag from WebViewClient::createGraphicsContext3D. Covered by platform/chromium/compositing/plugins/* * DumpRenderTree/chromium/TestWebPlugin.cpp: (TestWebPlugin::TestWebPlugin): (TestWebPlugin::initialize): (TestWebPlugin::updateGeometry): (TestWebPlugin::initScene): (TestWebPlugin::destroyScene): * DumpRenderTree/chromium/TestWebPlugin.h: (TestWebPlugin): * DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::createPlugin): 2012-03-07 Philippe Normand [GTK] remove webkitpy dependency in run-gtk-tests https://bugs.webkit.org/show_bug.cgi?id=80500 Reviewed by Martin Robinson. Replace Executive calls with bare subprocess calls. * Scripts/run-gtk-tests: (TestRunner): (TestRunner._lookup_atspi2_binary): (TestRunner.run): (TestRunner.run.run_for_real): 2012-03-07 Philippe Normand Unreviewed, GTK build fix after r110059. * Scripts/run-gtk-tests: (TestRunner._check_if_tests_have_timed_out): (TestRunner.run.run_tests): (TestRunner): 2012-03-07 Philippe Normand [GTK] race condition in run-gtk-tests https://bugs.webkit.org/show_bug.cgi?id=80495 Reviewed by Martin Robinson. Refactored the script to wait the a11y dbus service becomes available before starting the tests. * Scripts/run-gtk-tests: (TestRunner._lookup_atspi2_binary): (TestRunner): (TestRunner._wait_dbus_service_and_run): (TestRunner._wait_dbus_service_and_run.on_name_appeared): (TestRunner._wait_dbus_service_and_run.on_name_vanished): (TestRunner.run): (TestRunner.run.bailout): (TestRunner.run.run_for_real): 2012-03-07 Dinu Jacob [Qt] REGRESSION(r109575) Broke tap-to-zoom gesture https://bugs.webkit.org/show_bug.cgi?id=80425 Reviewed by Simon Hausmann. Set startScreenPos in mock touch point * MiniBrowser/qt/MiniBrowserApplication.cpp: (MiniBrowserApplication::notify): * MiniBrowser/qt/MiniBrowserApplication.h: (MiniBrowserApplication): 2012-03-07 Simon Hausmann [Qt] Windows build fix. Reviewed by Tor Arne Vestbø. Pass the -j parameter only to "make", not "nmake". * Scripts/webkitdirs.pm: (buildQMakeProjects): 2012-03-07 Simon Hausmann [Qt] Fix compilation without QtQuick1 https://bugs.webkit.org/show_bug.cgi?id=80503 Reviewed by Tor Arne Vestbø. Introduce HAVE_QQUICK1 as feature and added haveQtModule as convenience function. * qmake/mkspecs/features/features.prf: * qmake/mkspecs/features/functions.prf: 2012-03-07 Zoltan Horvath [Qt] Add qmake config tests for JPEG and PNG library https://bugs.webkit.org/show_bug.cgi?id=80398 Add JPEG and PNG library tests to config.tests and add error() abort to WebCore.pri if tests don't work. Reviewed by Tor Arne Vestbø. * qmake/config.tests/libjpeg/libjpeg.cpp: Added. (main): * qmake/config.tests/libjpeg/libjpeg.pro: Added. * qmake/config.tests/libpng/libpng.cpp: Added. (main): * qmake/config.tests/libpng/libpng.pro: Added. * qmake/sync.profile: 2012-03-07 Byungwoo Lee [EFL] Build warning: Fix warn_unused_result warnings. https://bugs.webkit.org/show_bug.cgi?id=79194 Reviewed by Filip Pizlo. Fixed build warning which is getting generated when not using return value of a fuction, especially declared with warn_unused_result attribute. * DumpRenderTree/efl/ImageDiff.cpp: (printImage): 2012-03-07 Kangil Han [DRT] Remove PlainTextController implementations. https://bugs.webkit.org/show_bug.cgi?id=79959 Reviewed by Hajime Morita. PlainTextController usages in existing tests have been replaced by internals API by bug 78570. So this patch will remove PlainTextController implementations to avoid further usage in new tests. * DumpRenderTree/DumpRenderTree.gypi: * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: * DumpRenderTree/chromium/PlainTextController.cpp: Removed. * DumpRenderTree/chromium/PlainTextController.h: Removed. * DumpRenderTree/chromium/TestShell.cpp: (TestShell::TestShell): (TestShell::bindJSObjectsToWindow): * DumpRenderTree/chromium/TestShell.h: (TestShell): * DumpRenderTree/gtk/DumpRenderTree.cpp: (webViewWindowObjectCleared): * DumpRenderTree/gtk/PlainTextController.cpp: Removed. * DumpRenderTree/gtk/PlainTextController.h: Removed. * DumpRenderTree/mac/FrameLoadDelegate.mm: (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]): * DumpRenderTree/mac/PlainTextController.h: Removed. * DumpRenderTree/mac/PlainTextController.mm: Removed. * DumpRenderTree/qt/DumpRenderTree.pro: * DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::DumpRenderTree): (WebCore::DumpRenderTree::initJSObjects): * DumpRenderTree/qt/DumpRenderTreeQt.h: (DumpRenderTree): * DumpRenderTree/qt/PlainTextControllerQt.cpp: Removed. * DumpRenderTree/qt/PlainTextControllerQt.h: Removed. * GNUmakefile.am: 2012-03-06 Grzegorz Czajkowski [EFL][DRT] Implements LayoutTestController's setPopupBlockingEnabled. https://bugs.webkit.org/show_bug.cgi?id=80137 Reviewed by Eric Seidel. Adds implementation LayoutTestController's setPopupBlockingEnabled. To pass popup-blocking-click-in-iframe.html EventSender should not repeat click events in idler's function. EventSender allows to asynchronously send click event through ecore_idler_add. This event will be called repeatedly as long as it return true. Click event should be called only once by returning ECORE_CALLBACK_CANCEL. * DumpRenderTree/efl/EventSender.cpp: (sendMouseEvent): Changed return value from bool to void because it always returns true. (sendClick): Idler is deleted by returning ECORE_CALLBACK_CANCEL. (mouseDownCallback): Remove unnecessary checking of return value. * DumpRenderTree/efl/LayoutTestControllerEfl.cpp: (LayoutTestController::setPopupBlockingEnabled): 2012-03-06 Dirk Pranke rebaseline_chromium_webkit_tests is obsolete and should be removed https://bugs.webkit.org/show_bug.cgi?id=80347 Reviewed by Tony Chang. * Scripts/rebaseline-chromium-webkit-tests: Removed. * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py: Removed. * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py: Removed. 2012-03-06 Dirk Pranke test_start_cmd (webkitpy.layout_tests.servers.http_server_unittest.TestHttpServer) is broken https://bugs.webkit.org/show_bug.cgi?id=80468 Unreviewed, build fix. Fixing a bug revealed by r80443 when we fixed filesystem.copyfile(). * Scripts/webkitpy/layout_tests/servers/http_server.py: (Lighttpd._prepare_config): 2012-03-06 Dirk Pranke remove chromium_gpu ports https://bugs.webkit.org/show_bug.cgi?id=80345 Reviewed by Ojan Vafai. This change leaves in the 'graphics_type' distinction in the test_expectations; removing that will require more updates and a pass over test_expectations.txt, so I'm separating that out. * Scripts/webkitpy/layout_tests/port/builders.py: * Scripts/webkitpy/layout_tests/port/chromium.py: (ChromiumPort): * Scripts/webkitpy/layout_tests/port/chromium_gpu.py: Removed. * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py: Removed. * Scripts/webkitpy/layout_tests/port/factory.py: (PortFactory): (PortFactory.get): * Scripts/webkitpy/layout_tests/port/factory_unittest.py: (FactoryTest.test_qt): * Scripts/webkitpy/tool/commands/rebaseline_unittest.py: (TestRebaseline.test_rebaseline_expectations): 2012-03-06 Raphael Kubo da Costa undefined reference to JSC::IdentifierTable::~IdentifierTable() on EFL port https://bugs.webkit.org/show_bug.cgi?id=80282 Reviewed by Antonio Gomes. Remove transitive library dependencies; they are especially dangerous when one ends up linking against WTF, JSC and then WTF again, since some symbols will not be defined. Passing --no-copy-dt-needed-entries and --as-needed to the linker (which some recent Linux distros do by default) makes the issue even more evident. * DumpRenderTree/efl/CMakeLists.txt: Do not link directly to WTF, as the other libraries have the needed symbols. Explicitly link against fontconfig. 2012-03-06 Dean Jackson filter-build-webkit needs more filters https://bugs.webkit.org/show_bug.cgi?id=80440 Reviewed by Joseph Pecoraro. Added as many missing filters as I could find for Apple builds. Plus a few minor style updates. * Scripts/filter-build-webkit: (printLine): 2012-03-06 Ojan Vafai Copying old baselines throws an error if the new directory doesn't exist https://bugs.webkit.org/show_bug.cgi?id=80443 Reviewed by Adam Barth. Existing tests cover the new code with the fix to filesystem_mock. * Scripts/webkitpy/common/system/filesystem_mock.py: (MockFileSystem.copyfile): Fix the mock to better match python's copyfile semantics. * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py: (Rebaseliner._create_html_baseline_files): * Scripts/webkitpy/tool/commands/rebaseline.py: (RebaselineTest._copy_existing_baseline): 2012-03-05 Ojan Vafai Add a mechanism to rebaseline new ports https://bugs.webkit.org/show_bug.cgi?id=80355 Reviewed by Adam Barth. For a test that's only failing on a new port, we want to first copy the existing result into the location for the port it's replacing in order to not break that port. For example, bringing up the chromium-lion port, if we just stick the results in the chromium-mac directory, the snow leopard will start failing. Instead, we first copy the existing result to the chromium-mac-snowleopard directory. * Scripts/webkitpy/layout_tests/port/builders.py: (builder_path_for_port_name): (fallback_port_name_for_new_port): * Scripts/webkitpy/tool/commands/rebaseline.py: (RebaselineTest): (RebaselineTest._copy_existing_baseline): (RebaselineTest._rebaseline_test): (RebaselineTest.execute): * Scripts/webkitpy/tool/commands/rebaseline_unittest.py: (TestRebaseline.test_rebaseline_test): (TestRebaseline): (TestRebaseline.test_rebaseline_and_copy_test): (test_rebaseline_and_copy_test_no_existing_result): (test_rebaseline_and_copy_test_with_lion_result): (test_rebaseline_and_copy_no_overwrite_test): * Scripts/webkitpy/tool/servers/gardeningserver.py: (GardeningHTTPRequestHandler.rebaseline): * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py: (GardeningServerTest.test_rebaseline): (GardeningServerTest): (GardeningServerTest.test_rebaseline_new_port): 2012-03-06 Beth Dakin https://bugs.webkit.org/show_bug.cgi?id=80351 InlineTextBox is using the wrong origin when calling addRelevantRepaintedObject -and corresponding- Reviewed by Sam Weinig. This test has actually been broken since revision 109273. This change makes the test pass again, and it makes it specifically exercise the fix for this bug. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout.cpp: (TestWebKitAPI::TEST): Adjust comments in the other tests to reflect the API changes from 109273. * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails.cpp: (TestWebKitAPI::TEST): * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails_Bundle.cpp: (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutFailsTest::didCreatePage): * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames_Bundle.cpp: (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutFramesTest::didCreatePage): * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout_Bundle.cpp: (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutTest::didCreatePage): * TestWebKitAPI/Tests/WebKit2/lots-of-text.html: Added. 2012-03-06 Hans Wennborg Speech JavaScript API: add SpeechRecognitionError https://bugs.webkit.org/show_bug.cgi?id=80410 Chromium: enable the runtime flag for scripted speech so we can run the layout tests for it. Reviewed by Adam Barth. * DumpRenderTree/chromium/TestShell.cpp: (TestShell::TestShell): 2012-03-06 Sami Kyostila Enable universal newlines in chromium android layout test runner https://bugs.webkit.org/show_bug.cgi?id=80418 Reviewed by Adam Barth. The Chromium Android layout test runner uses the 'adb' program to communicate with the Android device. Adb uses CRLF ('\r\n') to delimit output lines from the test runner, while the test expectation files are written with LF ('\n') delimiters. This causes the results to have spurious whitespace differences, making them more difficult to interpret. The fix is to enable universal newlines for the DumpRenderTree pipe, causing the output to only contain LF newlines like on other platforms. * Scripts/webkitpy/layout_tests/port/chromium_android.py: (ChromiumAndroidDriver._start): 2012-03-06 Tor Arne Vestbø [Qt] Revert r109900, it was completly busted HAVE_FOO does _not_ have a WTF_ prefix, go figure. We still leave in the HAVE(FOO) in QtInitializeTestFonts.cpp, instead of manual define checks. Reviewed by Ossy. * DumpRenderTree/qt/DumpRenderTree.pro: * QtTestBrowser/QtTestBrowser.pro: * WebKitTestRunner/InjectedBundle/Target.pri: * qmake/mkspecs/features/features.prf: 2012-03-05 Tor Arne Vestbø [Qt] Use config test to determine if the compiler supports -MD We used to assume that unix systems building against Qt5 would have a compiler that supported -MD. Although this was usually the case, we failed to take into account broken tools for distributed builds (e.g. teambuilder or icecream) which would end up producing .d files in the root of the build dir instead of along-side the object file. Now that we use a config-test to determine the support, we'll capture those cases, unless distributed builds are enabled after the initial build-webkit run. Reviewed by Csaba Osztrogonác. * Tools.pro: * qmake/config.tests/gccdepends/empty.cpp: Added. * qmake/config.tests/gccdepends/gccdepends.pro: Added. * qmake/mkspecs/features/default_pre.prf: * qmake/mkspecs/features/features.prf: * qmake/mkspecs/features/unix/default_pre.prf: * qmake/sync.profile: 2012-03-06 Csaba Osztrogonác REGRESSION(r109294): It broke the unittest of master.cfg https://bugs.webkit.org/show_bug.cgi?id=80253 Reviewed by Tor Arne Vestbø. * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Use json instead of simplejson. (BuildBotConfigLoader._create_mock_passwords_dict): (BuildBotConfigLoader._mock_open): (BuildBotConfigLoader._add_dependant_modules_to_sys_modules): (BuildBotConfigLoader.load_config): 2012-03-06 Kristóf Kosztyó Qt API test buildstep throws exception after buildmaster update https://bugs.webkit.org/show_bug.cgi?id=80249 This patch based on Peter Gal's work. Reviewed by Csaba Osztrogonác. * BuildSlaveSupport/build.webkit.org-config/master.cfg: (RunQtAPITests): (BuildAndTestFactory.__init__): Enable API tests on the Qt platform again. 2012-03-06 Tor Arne Vestbø [Qt] Use correct define names for HAVE(FOO) style optional dependencies Reviewed by Simon Hausmann. Reviewed by Ossy. * DumpRenderTree/qt/DumpRenderTree.pro: * DumpRenderTree/qt/QtInitializeTestFonts.cpp: (WebKit::initializeTestFonts): * QtTestBrowser/QtTestBrowser.pro: * WebKitTestRunner/InjectedBundle/Target.pri: * qmake/mkspecs/features/features.prf: 2012-03-06 Tor Arne Vestbø [Qt] Don't add recursive qmake_all target if there are no subdirs to recurse Reviewed by Ossy. * qmake/mkspecs/features/default_post.prf: 2012-03-06 Tor Arne Vestbø [Qt] Make sure clean builds are followed by make qmake && make if needed On non-GNUmake systems we have to run make qmake so that the generated sources are generated before we run qmake on the target pro files. This is achieved by using the 'incremental' target. Reviewed by Ossy. * Scripts/webkitdirs.pm: (buildQMakeProjects): 2012-03-06 Filip Pizlo DumpRenderTree should support preciseTime() https://bugs.webkit.org/show_bug.cgi?id=80397 Reviewed by Gavin Barraclough. * DumpRenderTree/LayoutTestController.cpp: (preciseTimeCallback): (LayoutTestController::staticFunctions): 2012-03-06 Sheriff Bot Unreviewed, rolling out r109887. http://trac.webkit.org/changeset/109887 https://bugs.webkit.org/show_bug.cgi?id=80402 It broke the build (Requested by Ossy on #webkit). * DumpRenderTree/qt/DumpRenderTree.pro: * DumpRenderTree/qt/QtInitializeTestFonts.cpp: (WebKit::initializeTestFonts): * QtTestBrowser/QtTestBrowser.pro: * WebKitTestRunner/InjectedBundle/Target.pri: * qmake/mkspecs/features/features.prf: 2012-03-06 Sheriff Bot Unreviewed, rolling out r109837. http://trac.webkit.org/changeset/109837 https://bugs.webkit.org/show_bug.cgi?id=80399 breaks Mac Productions builds, too late to try and fix it tonight (Requested by eseidel on #webkit). * Scripts/build-webkit: 2012-03-06 Tor Arne Vestbø [Qt] Use correct define names for HAVE(FOO) style optional dependencies Reviewed by Simon Hausmann. * DumpRenderTree/qt/DumpRenderTree.pro: * DumpRenderTree/qt/QtInitializeTestFonts.cpp: (WebKit::initializeTestFonts): * QtTestBrowser/QtTestBrowser.pro: * WebKitTestRunner/InjectedBundle/Target.pri: * qmake/mkspecs/features/features.prf: 2012-03-06 Kristóf Kosztyó [Qt] Create EWS to build WebKit2 https://bugs.webkit.org/show_bug.cgi?id=80277 Reviewed by Csaba Osztrogonác. * QueueStatusServer/model/queues.py: (Queue): * Scripts/webkitpy/tool/commands/earlywarningsystem.py: (QtWK2EWS): * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py: (EarlyWarningSytemTest.test_builder_ewses): 2012-03-05 Sheriff Bot Unreviewed, rolling out r109733. http://trac.webkit.org/changeset/109733 https://bugs.webkit.org/show_bug.cgi?id=80378 It broke Qt5 build system (Requested by Ossy on #webkit). * Tools.pro: * qmake/config.tests/gccdepends/empty.cpp: Removed. * qmake/config.tests/gccdepends/gccdepends.pro: Removed. * qmake/mkspecs/features/default_pre.prf: * qmake/mkspecs/features/features.prf: * qmake/mkspecs/features/unix/default_pre.prf: * qmake/sync.profile: 2012-03-05 Eric Seidel Update JavaScriptCore files to use fully-qualified WTF include path https://bugs.webkit.org/show_bug.cgi?id=79960 Reviewed by Adam Barth. Build WTF/WTF.xcodeproj by default on Mac. * Scripts/build-webkit: 2012-03-05 Dirk Pranke There should be a way to disable optimizer in webkit-patch rebaseline-expectations https://bugs.webkit.org/show_bug.cgi?id=69590 Reviewed by Ryosuke Niwa. Adds a --no-optimize flag to webkit-patch rebaseline-expectations to skip the 'optimize-expectations' step. * Scripts/webkitpy/tool/commands/rebaseline.py: (RebaselineExpectations.__init__): (RebaselineExpectations.execute): * Scripts/webkitpy/tool/commands/rebaseline_unittest.py: 2012-03-05 Kent Tamura [Chromium] Add new popup type: PagePopup https://bugs.webkit.org/show_bug.cgi?id=80106 Reviewed by Darin Fisher. * DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::createPopupMenu): 2012-03-05 Jessie Berlin Add myself as a reviewer. * Scripts/webkitpy/common/config/committers.py: Also, add my IRC nick so it is easier to find and yell at me. 2012-03-05 Robert Kroeger Correctly compute the positions of GestureScroll* events on Chromium. https://bugs.webkit.org/show_bug.cgi?id=80075 Reviewed by Adam Barth. * DumpRenderTree/chromium/EventSender.cpp: (EventSender::reset): (EventSender::gestureEvent): * DumpRenderTree/chromium/EventSender.h: (EventSender): 2012-03-05 Dirk Pranke flakiness dashboard doesn't display baselines for virtual tests correctly https://bugs.webkit.org/show_bug.cgi?id=80341 Reviewed by Ojan Vafai. If the test is part of a virtual test suite, we need to look for baselines in the underlying fallback path for the actual test being run, as well as baselines for the virtual version. This patch adds code to handle both branches and also pulls the mapping of the test suites up into a constant. * TestResultServer/static-dashboards/flakiness_dashboard.html: * TestResultServer/static-dashboards/flakiness_dashboard_tests.js: (testLookupVirtualTestSuite): (testBaseTest): 2012-03-05 Sheriff Bot Unreviewed, rolling out r109760. http://trac.webkit.org/changeset/109760 https://bugs.webkit.org/show_bug.cgi?id=80320 Caused many GTK+ tests to crash (Requested by mrobinson on #webkit). * gtk/jhbuild.modules: 2012-03-05 Charlie Reis [chromium] Pass WebNavigationPolicy to WebViewClient::createView https://bugs.webkit.org/show_bug.cgi?id=80057 Reviewed by Darin Fisher. * DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::createView): * DumpRenderTree/chromium/WebViewHost.h: (WebViewHost): 2012-03-05 Martin Robinson [soup] Crash while loading http://www.jusco.cn https://bugs.webkit.org/show_bug.cgi?id=68238 Reviewed by Philippe Normand. * gtk/jhbuild.modules: Bumped the libsoup and glib dependencies in the jhbuild file. 2012-03-05 Sheriff Bot Unreviewed, rolling out r109748. http://trac.webkit.org/changeset/109748 https://bugs.webkit.org/show_bug.cgi?id=80296 Made some tests crash, will fix and recommit (Requested by noamr on #webkit). * MiniBrowser/qt/main.cpp: (main): 2012-03-05 Zan Dobersek [GTK] plugins/netscape-plugin-page-cache-works.html fails https://bugs.webkit.org/show_bug.cgi?id=74409 Reviewed by Martin Robinson. Add support for overriding the page-cache-for-plugins preference through DumpRenderTreeSupport. * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (booleanFromValue): A helper function to convert a string to boolean. (LayoutTestController::overridePreference): 2012-03-05 Rob Buis [BlackBerry] Update Tools/DumpRenderTree https://bugs.webkit.org/show_bug.cgi?id=80287 Reviewed by Antonio Gomes. Update so we are sure we can build our implementation of DRT. * DumpRenderTree/DumpRenderTree.h: include DumpRenderTreeBlackBerry.h. * DumpRenderTree/PixelDumpSupport.cpp: include PixelDumpSupportBlackBerry.h. * DumpRenderTree/blackberry/AccessibilityControllerBlackBerry.cpp: (AccessibilityController::addNotificationListener): add missing hook. (AccessibilityController::removeNotificationListener): add missing hook. * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp: (AccessibilityUIElement::isSelectedOptionActive): add missing hook. * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp: (LayoutTestController::setMockSpeechInputDumpRect): add missing hook. (LayoutTestController::simulateDesktopNotificationClick): add missing hook. 2012-03-05 No'am Rosenthal [Qt] [WK2] Support threaded renderer in WK2 https://bugs.webkit.org/show_bug.cgi?id=76661 Remove the QML_NO_THREADED_RENDERER environment variable from MiniBrowser. Reviewed by Kenneth Rohde Christiansen. * MiniBrowser/qt/main.cpp: (main): 2012-03-05 Alexander Færøy Unreviewed. Add myself to committer list. * Scripts/webkitpy/common/config/committers.py: 2012-03-05 Tor Arne Vestbø [Qt] Use config test to determine if the compiler supports -MD We used to assume that unix systems building against Qt5 would have a compiler that supported -MD. Although this was usually the case, we failed to take into account broken tools for distributed builds (e.g. teambuilder or icecream) which would end up producing .d files in the root of the build dir instead of along-side the object file. Now that we use a config-test to determine the support, we'll capture those cases, unless distributed builds are enabled after the initial build-webkit run. Reviewed by Csaba Osztrogonác. * Tools.pro: * qmake/config.tests/gccdepends/empty.cpp: Added. * qmake/config.tests/gccdepends/gccdepends.pro: Added. * qmake/mkspecs/features/default_pre.prf: * qmake/mkspecs/features/features.prf: * qmake/mkspecs/features/unix/default_pre.prf: * qmake/sync.profile: 2012-03-05 Csaba Osztrogonác Qt API test buildstep throws exception after buildmaster update https://bugs.webkit.org/show_bug.cgi?id=80249 Reviewed by Zoltan Herczeg. * BuildSlaveSupport/build.webkit.org-config/master.cfg: Disable API tests on the Qt bot temporarily. (BuildAndTestFactory.__init__): 2012-03-04 Martin Robinson [GTK] Unit tests are noisy when run under jhbuild https://bugs.webkit.org/show_bug.cgi?id=80241 Reviewed by Philippe Normand. Force the 'memory' backend in GSettings so that each unit test doesn't produce a warning when it's forced to fall back to the 'memory' backend. * Scripts/run-gtk-tests: (TestRunner.run): Force the 'memory' backend. 2012-03-04 Martin Robinson [GTK] "Console: undefined @0: ReferenceError: Can't find variable: WebInspector" during testwebinspector https://bugs.webkit.org/show_bug.cgi?id=80235 Reviewed by Philippe Normand. * Scripts/run-gtk-tests: (TestRunner.run): Use the WEBKIT_INSPECTOR_PATH environment variable so that inspector resources path determination is shared by all tests. 2012-03-04 Martin Robinson [GTK] REGRESSION: r108278 broke some tests that expect focus https://bugs.webkit.org/show_bug.cgi?id=79084 Reviewed by Philippe Normand. Grab focus when dumping test results and also when sending events. During the course of testing, the WebView may lose focus and this seems to snap it back when tests demand it. * DumpRenderTree/gtk/DumpRenderTree.cpp: (dump): Grab focus. * DumpRenderTree/gtk/EventSender.cpp: (dispatchEvent): Ditto. 2012-03-04 Charles Wei Unreviewed, Add myself to committer list. https://bugs.webkit.org/show_bug.cgi?id=80232 * Scripts/webkitpy/common/config/committers.py: 2012-03-04 Anders Carlsson Newer versions of clang fail to compile WebKit. Fix build. * DumpRenderTree/mac/AccessibilityUIElementMac.mm: (descriptionOfValue): (AccessibilityUIElement::rowIndexRange): (AccessibilityUIElement::columnIndexRange): (AccessibilityUIElement::selectedTextRange): * DumpRenderTree/mac/EditingDelegate.mm: (-[DOMRange dump]): * DumpRenderTree/mac/PolicyDelegate.mm: (-[PolicyDelegate webView:unableToImplementPolicyWithError:frame:]): * DumpRenderTree/mac/ResourceLoadDelegate.mm: (-[NSError _drt_descriptionSuitableForTestResult]): * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm: (WTR::descriptionOfValue): (WTR::AccessibilityUIElement::rowIndexRange): (WTR::AccessibilityUIElement::columnIndexRange): (WTR::AccessibilityUIElement::selectedTextRange): 2012-03-03 Simon Hausmann [Qt] Fix static_libs_as_shared build https://bugs.webkit.org/show_bug.cgi?id=80214 Reviewed by Tor Arne Vestbø. * WebKitTestRunner/qt/main.cpp: (main): Set the correct environment variable for choosing the theme in the web process. 2012-03-03 Hans Wennborg Implement Speech JavaScript API https://bugs.webkit.org/show_bug.cgi?id=80019 Reviewed by Adam Barth. Add ENABLE_SCRIPTED_SPEECH. * Scripts/build-webkit: * qmake/mkspecs/features/features.prf: 2012-03-02 Alexey Proskuryakov Fix commit queue, remove duplicate entry. * Scripts/webkitpy/common/config/committers.py: 2012-03-02 Stephen Chenney Unreviewed, add myself as a committer * Scripts/webkitpy/common/config/committers.py: 2012-03-02 Ojan Vafai Add the Chromium Lion canary bot to the flakiness dashboard. * TestResultServer/static-dashboards/builders.js: 2012-03-02 Dirk Pranke links for virtual tests are broken in the flakiness dashboard https://bugs.webkit.org/show_bug.cgi?id=80180 Reviewed by Ojan Vafai. * TestResultServer/static-dashboards/flakiness_dashboard.html: (linkHTMLToOpenWindow): * TestResultServer/static-dashboards/flakiness_dashboard_tests.js: (testLinkHTMLToOpenWindow): added. 2012-03-02 Philippe Normand [GTK] security/block-test.html baselines differ from mac https://bugs.webkit.org/show_bug.cgi?id=78343 Reviewed by Martin Robinson. Improved the FrameLoader error heuristics to match mac behavior a bit more. * DumpRenderTree/gtk/DumpRenderTree.cpp: (pathFromSoupURI): Handle ftp urls the same as http urls. (descriptionSuitableForTestResult): Map WebKitPolicyError to WebKitErrorDomain. 2012-03-02 Andras Becsi [Qt][WK2] Fix typo in patch committed in r109575 Unreviewed typo fix. * MiniBrowser/qt/MiniBrowserApplication.cpp: (MiniBrowserApplication::notify): Cache the position in floating point coordinates. 2012-03-02 Andras Becsi [Qt][WK2] Infinite loop on history navigation, when panning https://bugs.webkit.org/show_bug.cgi?id=79119 Reviewed by Simon Hausmann. Make the touch mocking more robust by creating touch events directly and sending them synchronously to the browser window. If the sent touch event was not accepted we propagate the original mouse event to its target. This way we make sure we only send either a touch or a mouse event and do not end up in an infinite loop between our mocking code and the Qt5 automatic mouse event synthesizing. * MiniBrowser/qt/BrowserWindow.cpp: (BrowserWindow::updateVisualMockTouchPoints): * MiniBrowser/qt/BrowserWindow.h: (BrowserWindow): * MiniBrowser/qt/MiniBrowserApplication.cpp: (touchRectForPosition): (MiniBrowserApplication::notify): (MiniBrowserApplication::sendTouchEvent): * MiniBrowser/qt/MiniBrowserApplication.h: (MiniBrowserApplication): 2012-03-02 Tor Arne Vestbø [Qt] Use 'all' as default target when debug_and_release is in effect When debug_and_release is enabled, in combination with build_all, qmake will generate an aggregate makefile that calls make on both the debug and the release makefiles, but with the 'all' target. In this case we can't use 'first' as the default target, as the extra targets would then not be run, so we append extra targets to 'all' instead. Reviewed by Simon Hausmann. * qmake/mkspecs/features/default_post.prf: 2012-03-02 Tor Arne Vestbø [Qt] Make sure activeBuildConfig() returns the right config Using isActiveConfig fails, as that only checks if the given argument is in CONFIG, not the order. Reviewed by Simon Hausmann. * qmake/mkspecs/features/functions.prf: 2012-03-02 Simon Hausmann [Qt] Fix tests run with WTR not using QStyle theme https://bugs.webkit.org/show_bug.cgi?id=80147 Reviewed by Csaba Osztrogonác. * WebKitTestRunner/qt/main.cpp: (main): Set environment variable for web process to use QStyle theme. 2012-03-02 Philippe Normand Unreviewed, remove debug print call. * DumpRenderTree/gtk/DumpRenderTree.cpp: (descriptionSuitableForTestResult): 2012-03-02 Robert Kroeger Updated EventSender to send complete gesture events. https://bugs.webkit.org/show_bug.cgi?id=80075 Reviewed by Adam Barth. * DumpRenderTree/chromium/EventSender.cpp: (EventSender::gestureEvent): set additional parameters in sent events. 2012-03-01 Kalev Lember WebKitTestRunner: Explicitly include unistd.h for gcc 4.7 https://bugs.webkit.org/show_bug.cgi?id=80033 Reviewed by Gustavo Noronha Silva. GCC 4.7 no longer includes unistd.h from most of the standard C++ header files, so we need to explicitly include it for getcwd(). * WebKitTestRunner/TestInvocation.cpp: Make sure unistd.h gets included not only on Mac, but on all Unix platforms. 2012-03-01 Dirk Pranke Actually look at the args in driver_input :(. Unreviewed, build fix. * Scripts/webkitpy/layout_tests/port/chromium.py: (ChromiumDriver.run_test): 2012-03-01 Dirk Pranke Fix typo in flag used to run gpu virtual suites. Unreviewed, build fix. * Scripts/webkitpy/layout_tests/port/chromium.py: (ChromiumPort.virtual_test_suites): 2012-03-01 Adam Barth Unreviewed, rolling out r109317. http://trac.webkit.org/changeset/109317 Let's try watchlists again now that we're using a pure git working copy * Scripts/webkitpy/tool/bot/stylequeuetask.py: (StyleQueueTask.run): * Scripts/webkitpy/tool/commands/queues_unittest.py: 2012-03-01 Dirk Pranke webkitpy: test_run_test_pause_before_testing is failing after r109482 https://bugs.webkit.org/show_bug.cgi?id=80084 Unreviewed, build fix. Fixes the test string compare to ignore the time spent running the tests. * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py: (test_run_test_pause_before_testing): 2012-03-01 Dirk Pranke nrwt: virtual tests aren't being run https://bugs.webkit.org/show_bug.cgi?id=80083 Reviewed by Eric Seidel. If we tried to run all of the tests by default (and didn't specify any paths), the virtual tests weren't picked up. * Scripts/webkitpy/layout_tests/port/base.py: (Port._virtual_tests): * Scripts/webkitpy/layout_tests/port/base_unittest.py: (PortTest.test_tests): * Scripts/webkitpy/layout_tests/port/test.py: (TestPort.virtual_test_suites): 2012-03-01 Ryosuke Niwa run-perf-tests should report the test runtime https://bugs.webkit.org/show_bug.cgi?id=80078 Reviewed by Hajime Morita. Record and output the aggreated test run time. * Scripts/webkitpy/performance_tests/perftestsrunner.py: (PerfTestsRunner._run_single_test): 2012-03-01 Michael Nordman [chromium] Use webkit_support to create session storage namespaces in DRT. https://bugs.webkit.org/show_bug.cgi?id=79933 Reviewed by Tony Chang. * DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::createSessionStorageNamespace): 2012-03-01 Dirk Pranke nrwt: test_isfile, test_isdir, and test_exists don't work for virtual tests https://bugs.webkit.org/show_bug.cgi?id=80048 Reviewed by Adam Barth. * Scripts/webkitpy/layout_tests/port/base.py: (Port.test_isfile): (Port.test_isdir): (Port): (Port.test_exists): * Scripts/webkitpy/layout_tests/port/base_unittest.py: (PortTest.test_test_exists): (PortTest): (PortTest.test_test_isfile): (PortTest.test_test_isdir): * Scripts/webkitpy/layout_tests/port/test.py: (TestPort.virtual_test_suites): * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: (MainTest.test_virtual): 2012-03-01 Kalev Lember [GTK] Avoid building any parts of WebKitTestRunner when WK2 is disabled https://bugs.webkit.org/show_bug.cgi?id=80031 Reviewed by Gustavo Noronha Silva. Only build the libTestRunnerInjectedBundle.la convenience library when ENABLE_WEBKIT2 is defined. * WebKitTestRunner/GNUmakefile.am: 2012-03-01 Philippe Normand Unreviewed, second attempt to fix GTK NRWT after r109242. * Scripts/webkitpy/layout_tests/port/gtk.py: (GtkDriver._start): 2012-03-01 Philippe Normand Unreviewed, GTK NRWT build fix attempt after r109242. * Scripts/webkitpy/layout_tests/port/gtk.py: (GtkDriver._start): 2012-03-01 Kentaro Hara REGRESSION(r109036): run-bindings-tests fails because resolve-supplemental.pl was renamed https://bugs.webkit.org/show_bug.cgi?id=80008 Reviewed by Adam Barth. In r109036, I forgot to rename "resolve-supplemental.pl" in run-bindings-tests to "preprocess-idls.pl". This patch renames it. Test: Confirm that run-bindings-tests runs. * Scripts/webkitpy/bindings/main.py: (BindingsTests.generate_supplemental_dependency): 2012-02-29 Simon Hausmann [Qt][WK2] QQuickWebView::event should lookup faster which events QQuickWebPage can handle https://bugs.webkit.org/show_bug.cgi?id=78047 Reviewed by Kenneth Rohde Christiansen. Send events for the webview through the QQuickCanvas instead of directly to the item. Direct sending to the item requires the QObject::event re-implementation to dispatch to the correct event handling function. However QQuickItem::event doesn't do that. Instead QQuickCanvas calls the event handlers directly, and with the removal of our own dispatching we need to go through that code path. * WebKitTestRunner/qt/PlatformWebViewQt.cpp: (WTR::PlatformWebView::sendEvent): (WTR::PlatformWebView::postEvent): 2012-02-29 Adam Barth Disable watchlist. It's been spamming CCs. * Scripts/webkitpy/tool/bot/stylequeuetask.py: (StyleQueueTask.run): * Scripts/webkitpy/tool/commands/queues_unittest.py: 2012-02-29 Dirk Pranke need to clone the gpu baselines and expectations into the new "virtual" dir https://bugs.webkit.org/show_bug.cgi?id=79956 Reviewed by Adam Barth. * Scripts/webkitpy/layout_tests/port/chromium.py: (ChromiumPort.virtual_test_suites): 2012-02-29 Mark Rowe Switch to using json rather than simplejson now that the master is using Python 2.7. * BuildSlaveSupport/build.webkit.org-config/master.cfg: (loadBuilderConfig): 2012-02-29 David Levin [chromium] Add the ability to turn off autoresize. https://bugs.webkit.org/show_bug.cgi?id=77452 Reviewed by Darin Fisher. * DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): Expose a way to turn off auto-resize. (LayoutTestController::enableAutoResizeMode): Ditto and adjust to new WebKit api. (LayoutTestController::disableAutoResizeMode): Ditto. * DumpRenderTree/chromium/LayoutTestController.h: Ditto. 2012-02-29 Dirk Pranke nrwt: make --print trace work with virtual tests https://bugs.webkit.org/show_bug.cgi?id=79952 Reviewed by Adam Barth. * Scripts/webkitpy/layout_tests/views/printing.py: (Printer._print_test_trace): (Printer._print_baseline): 2012-02-28 Brian Weinstein WebKit2: didNewFirstVisuallyNonEmptyLayout should be sent to injected bundle https://bugs.webkit.org/show_bug.cgi?id=79849 Reviewed by Beth Dakin. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::InjectedBundlePage): Add an entry to the struct. 2012-02-29 Lucas Forschler Removed unused Apple buildslaves from the master configuration https://bugs.webkit.org/show_bug.cgi?id=79925 Reviewed by Stephanie Lewis. * BuildSlaveSupport/build.webkit.org-config/config.json: 2012-02-29 Dirk Pranke nrwt: implement simple 'virtual test suite' support https://bugs.webkit.org/show_bug.cgi?id=79737 Reviewed by Adam Barth. Add very basic support for 'virtual test suites' to NRWT: a virtual suite is a directory that may contain new baselines, contains a pointer to a "base" directory of tests, and an optional list of command line arguments to pass to DRT; it gives us a way to run all of the tests in a given directory multiple times with multiple (potentially differing) sets of results and baselines. This patch implements the support needed for this feature, and some basic tests, but no actual port will use the feature yet. This is probably the simplest implementation possible - the list of virtual suites will be hard-coded into the port's implementation. One can imagine a more data-driven approach where the suite instructions are stored in a manifest file either in LayoutTests (all suites in one file), or per-port, or per-directory. If this feature ends up being useful we should probably add something like that so people don't have to hunt around in the code to add suites. * Scripts/webkitpy/layout_tests/port/base.py: (Port.__init__): (Port.expected_filename): (Port.tests): (Port): (Port._real_tests): (Port._driver_class): (Port.virtual_test_suites): (Port.virtual_suite): (Port.virtual_suite.VirtualTestSuite): (Port.virtual_suite.VirtualTestSuite.__init__): (Port.virtual_suite.VirtualTestSuite.__repr__): (Port.populated_virtual_test_suites): (Port._virtual_tests): (Port.lookup_virtual_test_base): (Port.lookup_virtual_test_args): * Scripts/webkitpy/layout_tests/port/base_unittest.py: (PortTest.test_find_with_skipped_directories): * Scripts/webkitpy/layout_tests/port/driver.py: (DriverInput.__init__): (DriverProxy.run_test): * Scripts/webkitpy/layout_tests/port/test.py: (TestPort.virtual_test_suites): (TestDriver.run_test): * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: (MainTest.test_all): (MainTest.test_virtual): 2012-02-29 Dirk Pranke nrwt: support more than two drivers in DriverProxy https://bugs.webkit.org/show_bug.cgi?id=79736 Reviewed by Adam Barth. Now that we can support per-test command lines for Drivers, modify DriverProxy to keep a map of running drivers for each needed command-line; this will allow us to transparently maintain a pool of appropriately configured DRTs without having to constantly start and stop them. Note that this potentially raises a garbage collection problem - the number of running DRTs will grow with the number of different sets of command line args. For now this is no worse than the current code - if you're running with pixel tests, you will only need one DRT per worker, and if you aren't, you'll need two (one for text-only tests, and one for reftests). An alternative would be to only ever have one running driver, and restart the driver as the command line changes, but this might (?) slow down execution in the text-only case - we should benchmark this because it would be simpler and possibly allow us to eliminate DriverProxy altogether. * Scripts/webkitpy/layout_tests/port/driver.py: (DriverProxy.__init__): (DriverProxy): (DriverProxy._make_driver): (DriverProxy.run_test): (DriverProxy.has_crashed): (DriverProxy.stop): (DriverProxy.cmd_line): (DriverProxy._cmd_line_as_key): 2012-02-29 Adrienne Walker Unreviewed, add myself as a reviewer * Scripts/webkitpy/common/config/committers.py: 2012-02-29 Greg Billock Add more tests for web intents https://bugs.webkit.org/show_bug.cgi?id=79527 Reviewed by Adam Barth. * DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::sendWebIntentResponse): * DumpRenderTree/chromium/LayoutTestController.h: (LayoutTestController): * DumpRenderTree/chromium/WebViewHost.h: (WebViewHost): (WebViewHost::currentIntentRequest): 2012-02-29 Dirk Pranke nrwt: port/Driver needs to support per-test command line args https://bugs.webkit.org/show_bug.cgi?id=79733 Reviewed by Adam Barth. As part of removing the 'gpu' configurations and adding support for 'virtual test suites', the Driver classes need to support per-test command lines (since different tests will need to be run with different command line options). The per-test args are not yet used, so this change should have no visible effects and need no additional testing. * Scripts/webkitpy/layout_tests/port/base.py: (Port.driver_cmd_line): * Scripts/webkitpy/layout_tests/port/chromium.py: (ChromiumDriver.cmd_line): (ChromiumDriver._start): (ChromiumDriver.start): * Scripts/webkitpy/layout_tests/port/chromium_unittest.py: (ChromiumDriverTest.test_two_drivers.MockDriver.cmd_line): (ChromiumDriverTest): (ChromiumDriverTest.test_two_drivers): * Scripts/webkitpy/layout_tests/port/driver.py: (Driver.cmd_line): (DriverProxy.__init__): (DriverProxy.start): (DriverProxy.cmd_line): * Scripts/webkitpy/layout_tests/port/driver_unittest.py: (DriverTest.test_virtual_driver_methods): * Scripts/webkitpy/layout_tests/port/gtk.py: (GtkDriver.cmd_line): * Scripts/webkitpy/layout_tests/port/mock_drt.py: * Scripts/webkitpy/layout_tests/port/test.py: (TestPort._path_to_driver): (TestDriver.cmd_line): (TestDriver.start): * Scripts/webkitpy/layout_tests/port/webkit.py: (WebKitDriver.cmd_line): (WebKitDriver._start): (WebKitDriver.run_test): (WebKitDriver.start): * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: (WebKitDriverTest.test_no_timeout): * Scripts/webkitpy/performance_tests/perftestsrunner.py: (PerfTestsRunner._run_tests_set): * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py: (test_run_test_pause_before_testing): 2012-02-29 Dirk Pranke perftestsrunner can call printer.write() after printer.cleanup() https://bugs.webkit.org/show_bug.cgi?id=79872 Reviewed by Ryosuke Niwa. This patch fixes a unittest that was incorrectly calling PerfTestsRunner.run() twice (which led to a weird state in the printer object). * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py: (MainTest.test_run_with_upload_json): 2012-02-29 Balazs Kelemen [Qt][WK2] WebKitTestRunner should use 480x360 sized view for W3C SVG tests https://bugs.webkit.org/show_bug.cgi?id=76546 Reviewed by Simon Hausmann. Revert the workaround introduced in r107868 and reintroduce the qml binding so we can test the code path that we are more interested in. The reason that it did not work before is that we don't have an active platform window which we now workaround by propagating the resize through QWindowSystemInterface. * WebKitTestRunner/qt/PlatformWebViewQt.cpp: (WTR::WrapperWindow::handleStatusChanged): (WTR::PlatformWebView::resizeTo): 2012-02-29 Gabor Rapcsanyi [GTK] Small fix for cross compilation to not generate gtkdoc. Rubber-stamped by Csaba Osztrogonác. * Scripts/webkitdirs.pm: (isCrossCompilation): 2012-02-28 Lucas Forschler Fix a typo in config.json linx -> linux * BuildSlaveSupport/build.webkit.org-config/config.json: 2012-02-28 Mahesh Kulkarni [Qt] Allow read/write to the WebView.url property https://bugs.webkit.org/show_bug.cgi?id=77554 Reviewed by Tor Arne Vestbø. Fix MiniBrowser to use WebView.url property and remove WebView.load usage. * MiniBrowser/qt/qml/BrowserWindow.qml: 2012-02-28 Dan Winship [GTK] make tests explicitly request GSettingsBackendMemory https://bugs.webkit.org/show_bug.cgi?id=79788 Reviewed by Martin Robinson. Explicitly request the fallback memory-based GSettings backend; if other backends are available then we don't want to use them, because they would make tests depend on the user's preferences. And if other backends aren't available, we don't need glib to print a warning about that fact. * Scripts/webkitpy/layout_tests/port/gtk.py: (GtkPort.setup_environ_for_server): 2012-02-28 Sheriff Bot Unreviewed, rolling out r109110. http://trac.webkit.org/changeset/109110 https://bugs.webkit.org/show_bug.cgi?id=79806 webkitpy makes it too easy to add wkb.ug URLs to ChangeLogs (Requested by aroben on #webkit). * Scripts/webkitpy/common/checkout/changelog.py: (parse_bug_id): (parse_bug_id_from_changelog): * Scripts/webkitpy/common/checkout/changelog_unittest.py: * Scripts/webkitpy/common/config/urls.py: 2012-02-28 Adam Roben Add my new email address Fixes Adam Roben's email address in webkitpy is soon to be incorrect Reviewed by Anders Carlsson. * Scripts/webkitpy/common/config/committers.py: 2012-02-28 Adam Roben Teach webkitpy about wkb.ug URLs Fixes webkit-patch can't find bug numbers from ChangeLog entries that use wkb.ug URLs Reviewed by Anders Carlsson. * Scripts/webkitpy/common/checkout/changelog.py: (parse_bug_id): (parse_bug_id_from_changelog): Fall back to the tiny URL format if neither the short nor long URL formats work. * Scripts/webkitpy/common/checkout/changelog_unittest.py: (ChangeLogTest.test_parse_bug_id_from_changelog): Added tests for the above changes. * Scripts/webkitpy/common/config/urls.py: Added bug_url_tiny, which can be used to match wkb.ug URLs. 2012-02-28 János Badics [Qt] build-webkit does not detect the number of CPUs https://bugs.webkit.org/show_bug.cgi?id=76445 Based on Seo Sanghyeon's work (modification: Automatically determine the number of CPUs for make only if -j make argument haven't already been specified.) Reviewed by Csaba Osztrogonác. * Scripts/webkitdirs.pm: (buildQMakeProjects): 2012-02-28 Kent Tamura Update a pattern for forms files of watchlist https://bugs.webkit.org/show_bug.cgi?id=79767 Reviewed by Kentaro Hara. * Scripts/webkitpy/common/config/watchlist: Catches the following files with the "Forms" pattern. - HTMLDatListElement.* - HTMLKeygenElement.* - HTMLLegendElement.* - HTMLOutputElement.* - FormAssociatedElement.* - SliderThumbElement.* - TextControlInnerElements.* - RenderFileUploadControl.* 2012-02-27 Sheriff Bot Unreviewed, rolling out r109041. http://trac.webkit.org/changeset/109041 https://bugs.webkit.org/show_bug.cgi?id=79741 Broke Chromium Win build (Requested by bashi on #webkit). * DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): * DumpRenderTree/chromium/LayoutTestController.h: (LayoutTestController): * DumpRenderTree/chromium/WebViewHost.h: 2012-02-27 James Robinson [chromium] Remove media tests from ChromiumGpu configurations https://bugs.webkit.org/show_bug.cgi?id=79720 Reviewed by Adam Barth. We no longer need to run the media/ tests in both GPU and non-GPU configurations since we can exercise the GPU composited playback path via tests in the compositing/ directory. * Scripts/webkitpy/layout_tests/port/chromium_gpu.py: (_default_tests_paths): * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py: (ChromiumGpuTest.test_default_tests_paths): (ChromiumGpuTest.test_test_files): 2012-02-27 Dirk Pranke nrwt: log multiline stderr/crash output properly https://bugs.webkit.org/show_bug.cgi?id=79722 Reviewed by Adam Barth. This cleans up some nits in the log output to make things slightly easier to read (every line gets timestamped, etc.). Also tweaks the log message for pixel hash mismatches. * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py: (SingleTestRunner._handle_error): (SingleTestRunner._compare_image): 2012-02-27 Ryosuke Niwa Touch the master.cfg to force a reconfig. * BuildSlaveSupport/build.webkit.org-config/master.cfg: (BuildAndTestLeaksFactory): (NewBuildAndTestFactory): 2012-02-27 Jacky Jiang [BlackBerry] Upstream BlackBerry API web page related files https://bugs.webkit.org/show_bug.cgi?id=74380 Reviewed by Antonio Gomes. Adapt to the removing of WebPage::mainFrame(), use DumpRenderTreeSupport::corePage() and its mainFrame() instead. No new tests as this patch doesn't change behavior. * DumpRenderTree/blackberry/DumpRenderTree.cpp: (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting): (BlackBerry::WebKit::DumpRenderTree::runTests): 2012-02-27 Ryosuke Niwa Add Windows and Linux Chromium perf bots https://bugs.webkit.org/show_bug.cgi?id=79418 Reviewed by Tony Chang. Add Chromium Win and Linux perf bots. Also replace Chromium Mac by the dedicated perf bot slave (uses the same hardware). * BuildSlaveSupport/build.webkit.org-config/config.json: 2012-02-27 Xianzhu Wang Undefined variable 'current' when running chromium_android.py https://bugs.webkit.org/show_bug.cgi?id=79696 Reviewed by Adam Barth. * Scripts/webkitpy/layout_tests/port/chromium_android.py: (ChromiumAndroidDriver._read_prompt): 2012-02-27 Greg Billock Add more tests for web intents https://bugs.webkit.org/show_bug.cgi?id=79527 Reviewed by Adam Barth. * DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::sendWebIntentResponse): * DumpRenderTree/chromium/LayoutTestController.h: (LayoutTestController): * DumpRenderTree/chromium/WebViewHost.h: (WebViewHost): (WebViewHost::currentIntentRequest): 2012-02-27 Xianzhu Wang Chromium-Android layout test script: the adb shell prompt is not always '# ' https://bugs.webkit.org/show_bug.cgi?id=79506 Reviewed by Adam Barth. * Scripts/webkitpy/layout_tests/port/chromium_android.py: (ChromiumAndroidDriver._start): (ChromiumAndroidDriver._read_prompt): 2012-02-27 Dan Bernstein Added a test for REGRESSION (WebKit2): Non-activating links sometimes don’t work https://bugs.webkit.org/show_bug.cgi?id=79607 Reviewed by Adele Peterson. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new files. * TestWebKitAPI/Tests/mac/AcceptsFirstMouse.mm: Added. (TestWebKitAPI::AcceptsFirstMouse::url): (TestWebKitAPI::AcceptsFirstMouse::didLoadURL): (TestWebKitAPI::AcceptsFirstMouse::runTest): (TestWebKitAPI::TEST_F): * TestWebKitAPI/Tests/mac/acceptsFirstMouse.html: Added. 2012-02-27 Carlos Garcia Campos Unreviewed. Fix make distcheck. * GNUmakefile.am: Fix typo. 2012-02-27 Tor Arne Vestbø [Qt] Use USE() macro instead of ENABLE() for using the Qt image decoder Reviewed by Kenneth Rohde Christiansen.. * qmake/mkspecs/features/features.prf: 2012-02-27 Hao Zheng Add a ChromiumGpuAndroid port. https://bugs.webkit.org/show_bug.cgi?id=79628 Reviewed by Adam Barth. Android does have a gpu port, so revert r107697. * Scripts/webkitpy/layout_tests/port/chromium_android.py: (ChromiumAndroidPort.__init__): * Scripts/webkitpy/layout_tests/port/chromium_gpu.py: (ChromiumGpuAndroidPort): (ChromiumGpuAndroidPort.__init__): (ChromiumGpuAndroidPort.baseline_search_path): (ChromiumGpuAndroidPort.default_child_processes): (ChromiumGpuAndroidPort.tests): * Scripts/webkitpy/layout_tests/port/factory.py: (PortFactory): 2012-02-25 Gyuyoung Kim Change Build bot with BuildAndTest bot for EFL port. https://bugs.webkit.org/show_bug.cgi?id=77518 Reviewed by Ryosuke Niwa. EFL build bot starts to support layout test. * BuildSlaveSupport/build.webkit.org-config/config.json: * BuildSlaveSupport/built-product-archive: (archiveBuiltProduct): (extractBuiltProduct): * BuildSlaveSupport/test-result-archive: (archiveTestResults): * Scripts/webkitdirs.pm: Enable SHARED_CORE option when ENABLE_DRT is enable in EFL port. (generateBuildSystemFromCMakeProject): 2012-02-24 Darin Fisher Add watchlist for ChromiumPlatformApi matching Source/Platform/chromium/public/ Reviewed by James Robinson. * Scripts/webkitpy/common/config/watchlist: 2012-02-24 Dirk Pranke webkitpy: changelog_unittest test_fuzzy_reviewer_match is slow https://bugs.webkit.org/show_bug.cgi?id=79258 Reviewed by Ryosuke Niwa. Split the fuzzy matching into separate functions so that they can be sharded and run in parallel. Also, fix a bug in the svn_blame_regexp that was causing us to require ChangeLog lines to have at least one space after the author, making the code require trailing whitespace in the changelog in some places (this was making my life harder because I have my text editor set to strip trailing whitespace in python files, and that was causing test_parse_log_entries_from_changelog() to fail when the whitespace on line 275 was removed). * Scripts/webkitpy/common/checkout/changelog.py: (ChangeLog): * Scripts/webkitpy/common/checkout/changelog_unittest.py: (test_fuzzy_reviewer_match__none): (test_fuzzy_reviewer_match_adam_barth): (test_fuzzy_reviewer_match_darin_adler_et_al): (test_fuzzy_reviewer_match_dimitri_glazkov): (test_fuzzy_reviewer_match_george_staikos): (test_fuzzy_reviewer_match_mark_rowe): 2012-02-24 Dirk Pranke webkitpy: committers_unittest fuzzy matching is really slow https://bugs.webkit.org/show_bug.cgi?id=79179 Reviewed by Ryosuke Niwa. Break the fuzzy matching tests into individual routines for each contributor so that the intent is a little clearer, so that it's easier to test individual names (and identify duplicate tests), and so that we can eventually run them in parallel. Also, mark most of them as 'integration' tests so that they can be skipped if we want to go fast (we leave a few as regular tests for functional coverage). * Scripts/webkitpy/common/config/committers_unittest.py: (CommittersTest): (CommittersTest.test_contributors_by_fuzzy_match): (CommittersTest.integration_test_contributors__none): (CommittersTest.integration_test_contributors__none_2): (CommittersTest.integration_test_contributors__none_3): (CommittersTest.integration_test_contributors_ada_chan): (CommittersTest.integration_test_contributors_adele_peterson): (CommittersTest.integration_test_contributors_alexey_proskuryakov): (CommittersTest.integration_test_contributors_alice_liu): (CommittersTest.integration_test_contributors_alp_toker): (CommittersTest.integration_test_contributors_anders_carlsson): (CommittersTest.integration_test_contributors_antti_koivisto): (CommittersTest.integration_test_contributors_beth_dakin): (CommittersTest.integration_test_contributors_brady_eidson): (CommittersTest.integration_test_contributors_cameron_zwarich): (CommittersTest.integration_test_contributors_chris_blumenberg): (CommittersTest.integration_test_contributors_dan_bernstein): (CommittersTest.integration_test_contributors_dan_bernstein_2): (CommittersTest.integration_test_contributors_darin_adler): (CommittersTest.integration_test_contributors_david_harrison): (CommittersTest.integration_test_contributors_david_harrison_2): (CommittersTest.integration_test_contributors_david_hyatt): (CommittersTest.integration_test_contributors_david_kilzer): (CommittersTest.integration_test_contributors_don_melton): (CommittersTest.integration_test_contributors_eric_seidel): (CommittersTest.integration_test_contributors_geoffrey_garen): (CommittersTest.integration_test_contributors_greg_bolsinga): (CommittersTest.integration_test_contributors_holger_freyther): (CommittersTest.integration_test_contributors_jon_sullivan): (CommittersTest.integration_test_contributors_jon_honeycutt): (CommittersTest.integration_test_contributors_joseph_pecoraro): (CommittersTest.integration_test_contributors_ken_kocienda): (CommittersTest.integration_test_contributors_kenneth_russell): (CommittersTest.integration_test_contributors_kevin_decker): (CommittersTest.integration_test_contributors_kevin_mccullough): (CommittersTest.integration_test_contributors_lars_knoll): (CommittersTest.integration_test_contributors_lars_weintraub): (CommittersTest.integration_test_contributors_maciej_stachowiak): (CommittersTest.integration_test_contributors_mark_rowe): (CommittersTest.integration_test_contributors_nikolas_zimmermann): (CommittersTest.integration_test_contributors_oliver_hunt): (CommittersTest.integration_test_contributors_rniwa): (CommittersTest.disabled_integration_test_contributors_simon_fraser): (CommittersTest.integration_test_contributors_steve_falkenburg): (CommittersTest.integration_test_contributors_sam_weinig): (CommittersTest.integration_test_contributors_tim_omernick): (CommittersTest.integration_test_contributors_timothy_hatcher): (CommittersTest.integration_test_contributors_tor_arne_vestbo): (CommittersTest.integration_test_contributors_vicki_murley): (CommittersTest.integration_test_contributors_zack_rusin): 2012-02-24 Dirk Pranke webkitpy: should autoinstall coverage https://bugs.webkit.org/show_bug.cgi?id=79535 Reviewed by Eric Seidel. We should automatically print the coverage report after the run, too. * Scripts/webkitpy/test/main.py: (Tester._run_tests): * Scripts/webkitpy/thirdparty/__init__.py: (AutoinstallImportHook.find_module): (AutoinstallImportHook._install_coverage): 2012-02-24 Pablo Flouret Fix copypasta in build-webkit's --vibration option description https://bugs.webkit.org/show_bug.cgi?id=79528 Reviewed by Andreas Kling. * Scripts/build-webkit: 2012-02-24 Antonio Gomes Adding myself to ScrollingCoordinator watchlist https://bugs.webkit.org/show_bug.cgi?id=79525 Reviewed by Rob Buis. * Scripts/webkitpy/common/config/watchlist: 2012-02-24 Darin Fisher Update watchlist for ChromiumPublicApi to include Platform/chromium/public/ Reviewed by Adam Barth. * Scripts/webkitpy/common/config/watchlist: 2012-02-24 Dirk Pranke webkitpy: config_unittest is sensitive to other tests that might've already run https://bugs.webkit.org/show_bug.cgi?id=79382 Reviewed by Adam Barth. If another test runs prior to config_unittest and pokes the cached configuration, the first test in config_unittest might fail; the tearDown() will then allow subsequent tests to pass. Clearing the configuration prior to each test makes things slightly slower but safer. * Scripts/webkitpy/layout_tests/port/config_unittest.py: (ConfigTest.setUp): 2012-02-24 David Kilzer Use xcrun to find compiler paths for Generate Derived Sources build phase script Reviewed by Dan Bernstein. * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: (Generate Derived Sources): Use xcrun to find the path to the compiler since that works on both iOS and OS X. 2012-02-24 James Robinson Create a watchlist for ScrollingCoordinator changes https://bugs.webkit.org/show_bug.cgi?id=79511 Reviewed by Anders Carlsson. * Scripts/webkitpy/common/config/watchlist: 2012-02-24 Grzegorz Czajkowski [EFL][DRT] Implement setValueForUser and setAutofilled. https://bugs.webkit.org/show_bug.cgi?id=79237 Reviewed by Andreas Kling. Adds missing implementation setValueForUser and setAutofilled to EFL's LayoutTestController. Those implementations are related with input fields and allow to pass following tests: fast/forms/onchange-setvalueforuser.html fast/forms/input-autofilled.html fast/forms/reset-autofilled.html * DumpRenderTree/efl/LayoutTestControllerEfl.cpp: (LayoutTestController::setValueForUser): (LayoutTestController::setAutofilled): 2012-02-24 Zoltan Horvath [Qt] Allow to use WebCore imagedecoders https://bugs.webkit.org/show_bug.cgi?id=32410 Add ENABLE_QT_IMAGE_DECODER macro, it's enabled by default. Reviewed by Simon Hausmann. * qmake/mkspecs/features/features.prf: 2012-02-24 Balazs Kelemen [Qt] Add Qt5 way to force 96 DPI for tests https://bugs.webkit.org/show_bug.cgi?id=79364 Reviewed by Simon Hausmann. * DumpRenderTree/qt/main.cpp: (main): * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp: (WTR::activateFonts): 2012-02-24 Carlos Garcia Campos [GTK] MiniBrowser should reload the view then the reload button is clicked https://bugs.webkit.org/show_bug.cgi?id=79472 Reviewed by Philippe Normand. * MiniBrowser/gtk/BrowserWindow.c: (reloadCallback): Call webkit_web_view_reload(). (browser_window_init): Connect reload item clicked even to reloadCallback instead of activateUriEntryCallback. 2012-02-24 Kentaro Hara Add performance tests for DOM attribute getters and setters https://bugs.webkit.org/show_bug.cgi?id=79208 Reviewed by Ryosuke Niwa. We want to allow perf tests to output info messages that do not affect the test results. To accomplish this, this patch modifies perftestsrunner.py so that it ignores a line that starts from "Info:". * Scripts/webkitpy/performance_tests/perftestsrunner.py: (PerfTestsRunner): 2012-02-24 Andrew Lo [BlackBerry] Enable requestAnimationFrame https://bugs.webkit.org/show_bug.cgi?id=79408 Enable requestAnimationFrame for BlackBerry. Reviewed by Rob Buis. * Scripts/build-webkit: 2012-02-24 Adam Barth style-queue tries to apply the patch twice https://bugs.webkit.org/show_bug.cgi?id=79459 Reviewed by Eric Seidel. Previously, we applied the patch using both apply-patch and check-style. This patch introduces a check-style-local to mirror the apply-watchlist-local, which operates on the current working diff. This patch also cleans up some other bugs I found by running the queue locally for a while. The queue still prints out a slightly less-than-ideal message on the bugs when it find an error, but it's ok for now. We'll need to iterate a bit. * Scripts/webkitpy/tool/bot/stylequeuetask.py: (StyleQueueTask.validate): (StyleQueueTask._check_style): * Scripts/webkitpy/tool/commands/download.py: (CheckStyleLocal): * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py: (EarlyWarningSytemTest._default_expected_stderr): (EarlyWarningSytemTest._test_testing_ews): * Scripts/webkitpy/tool/commands/queues.py: (AbstractReviewQueue.handle_script_error): (StyleQueue.review_patch): * Scripts/webkitpy/tool/commands/queues_unittest.py: * Scripts/webkitpy/tool/commands/queuestest.py: (QueuesTest.assert_queue_outputs): 2012-02-23 Adam Barth should_proceed_with_work_item is unused and can be removed https://bugs.webkit.org/show_bug.cgi?id=79416 Reviewed by Eric Seidel. We used to use this function to check whether the tree is red. Now, we don't use external measures of whether to proceed with work items. Instead, we analyze them with the idea in mind that the tree might be red. * Scripts/webkitpy/tool/bot/queueengine.py: (QueueEngineDelegate.next_work_item): (QueueEngine.run): * Scripts/webkitpy/tool/bot/queueengine_unittest.py: (LoggingDelegate): (LoggingDelegate.next_work_item): (RaisingDelegate.process_work_item): (QueueEngineTest.test_terminating_error): * Scripts/webkitpy/tool/commands/earlywarningsystem.py: (AbstractEarlyWarningSystem.__init__): * Scripts/webkitpy/tool/commands/queues.py: (AbstractQueue.next_work_item): (FeederQueue.next_work_item): (CommitQueue.next_work_item): (AbstractReviewQueue.next_work_item): (StyleQueue.__init__): * Scripts/webkitpy/tool/commands/queues_unittest.py: (FeederQueueTest.test_feeder_queue): (CommitQueueTest.test_commit_queue): (test_commit_queue_failure): (test_commit_queue_failure_with_failing_tests): (test_rollout): (test_rollout_lands): (StyleQueueTest.test_style_queue_with_style_exception): (test_style_queue_with_watch_list_exception): * Scripts/webkitpy/tool/commands/queuestest.py: (QueuesTest.assert_queue_outputs): * Scripts/webkitpy/tool/commands/sheriffbot.py: (SheriffBot.next_work_item): 2012-02-23 Adrienne Walker Unreviewed, add Stephen Chenney to committers.py as a contributor. * Scripts/webkitpy/common/config/committers.py: 2012-02-23 Adam Barth style-queue logs bogus messages to the QueueStatusServer https://bugs.webkit.org/show_bug.cgi?id=79424 Reviewed by Eric Seidel. Copy/paste error. * Scripts/webkitpy/tool/bot/stylequeuetask.py: (StyleQueueTask._check_style): (StyleQueueTask._apply_watch_list): * Scripts/webkitpy/tool/commands/queues_unittest.py: 2012-02-23 Eric Seidel Use self._filesystem in more places in the SCM classes https://bugs.webkit.org/show_bug.cgi?id=79415 Reviewed by Adam Barth. * Scripts/webkitpy/common/checkout/scm/detection_unittest.py: (SCMDetectorTest.test_detect_scm_system): * Scripts/webkitpy/common/checkout/scm/git.py: (Git.find_checkout_root): (Git.to_object_name): * Scripts/webkitpy/common/checkout/scm/scm.py: (SCM.__init__): (SCM.in_working_directory): * Scripts/webkitpy/common/checkout/scm/svn.py: (SVN.find_uuid): (SVN.find_checkout_root): 2012-02-23 Sheriff Bot Unreviewed, rolling out r108685. http://trac.webkit.org/changeset/108685 https://bugs.webkit.org/show_bug.cgi?id=79414 Broke Chromium builds (Requested by enne on #webkit). * qmake/mkspecs/features/features.prf: 2012-02-23 Adam Barth style-queue shouldn't spam bugs if it fails to update its working copy https://bugs.webkit.org/show_bug.cgi?id=79412 Reviewed by Eric Seidel. This patch moves style-queue over to the new PatchAnalysisTask infrastructure, which is smarter about retrying patches when update fails. * Scripts/webkitpy/common/system/executive_mock.py: (MockExecutive.run_and_throw_if_fail): * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py: * Scripts/webkitpy/tool/bot/patchanalysistask.py: (UnableToApplyPatch): (UnableToApplyPatch.__init__): (PatchAnalysisTask.__init__): * Scripts/webkitpy/tool/bot/stylequeuetask.py: Added. (StyleQueueTaskDelegate): (StyleQueueTaskDelegate.parent_command): (StyleQueueTask): (StyleQueueTask.validate): (StyleQueueTask._check_style): (StyleQueueTask._apply_watch_list): (StyleQueueTask.run): * Scripts/webkitpy/tool/commands/earlywarningsystem.py: * Scripts/webkitpy/tool/commands/queues.py: (StyleQueue): (StyleQueue.should_proceed_with_work_item): (StyleQueue.review_patch): (StyleQueue.run_command): (StyleQueue.command_passed): (StyleQueue.command_failed): (StyleQueue.expected_failures): (StyleQueue.refetch_patch): * Scripts/webkitpy/tool/commands/queues_unittest.py: (StyleQueueTest.test_style_queue_with_style_exception): (test_style_queue_with_watch_list_exception): 2012-02-23 Zoltan Horvath [Qt] Allow to use WebCore imagedecoders https://bugs.webkit.org/show_bug.cgi?id=32410 Add ENABLE_QT_IMAGE_DECODER macro, it's enabled by default. Reviewed by Simon Hausmann. * qmake/mkspecs/features/features.prf: 2012-02-23 Eric Seidel Remove old broken find_checkout_root tests now that find_checkout_root is gone https://bugs.webkit.org/show_bug.cgi?id=79405 Reviewed by Adam Barth. * Scripts/webkitpy/common/checkout/scm/detection_unittest.py: Added. (SCMDetectorTest): (SCMDetectorTest.test_find_checkout_root): * Scripts/webkitpy/common/checkout/scm/scm_unittest.py: (SVNTestRepository.tear_down): 2012-02-23 Michael Brüning [Qt][WK2] Implement proxy authentication dialog. https://bugs.webkit.org/show_bug.cgi?id=79350 Reviewed by Simon Hausmann. * MiniBrowser/qt/MiniBrowser.qrc: * MiniBrowser/qt/qml/BrowserWindow.qml: * MiniBrowser/qt/qml/ProxyAuthenticationDialog.qml: Added. 2012-02-23 Kevin Ollivier [wx] Build fix, add recently added source dirs. * waf/build/settings.py: 2012-02-23 Simon Hausmann [Qt] Add support for touch cancellation https://bugs.webkit.org/show_bug.cgi?id=79348 Reviewed by Kenneth Rohde Christiansen. Added straight-forward touch cancellation event sending to Qt WK1 DRT and WK2 WTR. * DumpRenderTree/qt/EventSenderQt.cpp: (EventSender::touchCancel): (EventSender::cancelTouchPoint): * DumpRenderTree/qt/EventSenderQt.h: (EventSender): * WebKitTestRunner/EventSenderProxy.h: (EventSenderProxy): * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl: * WebKitTestRunner/InjectedBundle/EventSendingController.cpp: (WTR::EventSendingController::touchCancel): (WTR): (WTR::EventSendingController::cancelTouchPoint): * WebKitTestRunner/InjectedBundle/EventSendingController.h: (EventSendingController): * WebKitTestRunner/TestController.cpp: (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle): * WebKitTestRunner/qt/EventSenderProxyQt.cpp: (WTR::EventSenderProxy::touchCancel): (WTR): (WTR::EventSenderProxy::cancelTouchPoint): 2012-02-23 Sheriff Bot Unreviewed, rolling out r108626. http://trac.webkit.org/changeset/108626 https://bugs.webkit.org/show_bug.cgi?id=79370 broke qt-wk2 bot, somehow the workaround does not work on the bot (Requested by Ossy on #webkit). * WebKitTestRunner/qt/PlatformWebViewQt.cpp: (WTR::WrapperWindow::handleStatusChanged): (WTR::PlatformWebView::resizeTo): 2012-02-23 ChangSeok Oh [GTK] DRT doesn't support scheduleAsynchronousKeyDown. https://bugs.webkit.org/show_bug.cgi?id=78481 Reviewed by Gustavo Noronha Silva. Extracted shareable code from keyDownCallback and then added createKeyPressEvent to create gdk press key event. Added sendKeyDown and sendAsynchronousKeyDown to evaluate keyDown event directly and asynchronously. Eventually, sendAsynchronousKeyDown calls sendKeyDown. * DumpRenderTree/gtk/EventSender.cpp: (scheduleAsynchronousClickCallback): (createKeyPressEvent): (sendKeyDown): (keyDownCallback): (sendAsynchronousKeyDown): (scheduleAsynchronousKeyDownCallback): 2012-02-23 Balazs Kelemen [Qt][WK2] WebKitTestRunner should use 480x360 sized view for W3C SVG tests https://bugs.webkit.org/show_bug.cgi?id=76546 Reviewed by Simon Hausmann. Co-authored with Simon Hausmann. Revert the workaround introduced in r107868 and reintroduce the qml binding so we can test the code path that we are more interested in. The reason that it did not work before is that we don't have an active platform window which we now workaround by propagating the resize through QWindowSystemInterface. * WebKitTestRunner/qt/PlatformWebViewQt.cpp: (WTR::WrapperWindow::handleStatusChanged): (WTR::PlatformWebView::resizeTo): 2012-02-23 Sheriff Bot Unreviewed, rolling out r108577. http://trac.webkit.org/changeset/108577 https://bugs.webkit.org/show_bug.cgi?id=79359 It doesn't work as expected (Requested by Ossy on #webkit). * DumpRenderTree/qt/EventSenderQt.cpp: (EventSender::postEvent): * DumpRenderTree/qt/EventSenderQt.h: (EventSender): 2012-02-23 Philippe Normand [GTK] FullScreen signals https://bugs.webkit.org/show_bug.cgi?id=76181 Reviewed by Martin Robinson. Use the two new entering/leaving fullscreen signals to hide/show the tool bar, the status bar and ask the user's permission before entering fullscreen. * GtkLauncher/main.c: (webViewFullscreenMessageWindowClose): (webViewWindowStateEvent): (hide_widget): (show_widget): (webViewEnteringFullScreen): (webViewLeavingFullScreen): (createBrowser): (createWindow): 2012-02-22 Dongwoo Im [EFL] Fix to launch the EWebLauncher using the script, run-launcher. https://bugs.webkit.org/show_bug.cgi?id=79076 Reviewed by Andreas Kling. * Scripts/webkitdirs.pm: Fix the path of libewebkit.so. (builtDylibPathForName): 2012-02-22 Allan Sandfeld Jensen [Qt] Add eventSender.gestureTap https://bugs.webkit.org/show_bug.cgi?id=66173 Reviewed by Kenneth Rohde Christiansen. * DumpRenderTree/qt/EventSenderQt.cpp: (EventSender::gestureTap): * DumpRenderTree/qt/EventSenderQt.h: 2012-02-22 Brady Eidson and https://bugs.webkit.org/show_bug.cgi?id=79279 Synchronous ShouldGoToBackForwardListItem causes lots of WebProcess hangs Reviewed by Anders Carlsson. Update our tools to the new form of the PageLoadClient. * MiniBrowser/mac/BrowserWindowController.m: (-[BrowserWindowController awakeFromNib]): * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize): 2012-02-22 Daniel Bates new-run-webkit-tests shouldn't restore Safari state on Lion when showing results https://bugs.webkit.org/show_bug.cgi?id=79277 Reviewed by Adam Barth. Pass command line argument no-saved-state to run-safari to disable Safari state restoration for the session on OS 10.7. * Scripts/webkitpy/layout_tests/port/mac.py: (MacPort.show_results_html_file): * Scripts/webkitpy/layout_tests/port/mac_unittest.py: (test_show_results_html_file): 2012-02-22 Kalev Lember Explicitly include unistd.h in TestNetscapePlugIn for GCC 4.7 https://bugs.webkit.org/show_bug.cgi?id=77759 Reviewed by Tony Chang. Fixes build with gcc 4.7. r100432 added the include only for ANDROID; this changes the ifdef to also cover other unix platforms. On Fedora 17 the gcc 4.7 compiler no longer implicitly includes unistd.h from standard headers and other unix platforms are likely to get gcc 4.7 as well in the future. * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp: 2012-02-22 Philippe Normand Unreviewed, rolling out r108522. http://trac.webkit.org/changeset/108522 https://bugs.webkit.org/show_bug.cgi?id=76181 Broke 4 fullscreen tests on GTK. * GtkLauncher/main.c: (createBrowser): (createWindow): 2012-02-20 Philippe Normand [GTK] FullScreen signals https://bugs.webkit.org/show_bug.cgi?id=76181 Reviewed by Martin Robinson. Use the two new entering/leaving fullscreen signals to hide/show the tool bar, the status bar and ask the user's permission before entering fullscreen. * GtkLauncher/main.c: (webViewFullscreenMessageWindowClose): (webViewWindowStateEvent): (hide_widget): (show_widget): (webViewEnteringFullScreen): (webViewLeavingFullScreen): (createBrowser): (createWindow): 2012-02-22 Rob Flack Update Linux ChromiumOS builders in flakiness dashboard. https://bugs.webkit.org/show_bug.cgi?id=79238 Reviewed by Ojan Vafai. * TestResultServer/static-dashboards/builders.js: 2012-02-22 Dirk Pranke webkitpy: test_function_length_check_definition_huge_lines is slow https://bugs.webkit.org/show_bug.cgi?id=79185 Reviewed by Adam Barth. This test takes ~3 seconds to run, apparently because we're running a test on a 10,000 line function :). Dropping the function length to 640 still exercises the code path and provides a 10x speedup. * Scripts/webkitpy/style/checkers/cpp_unittest.py: (CppStyleTest): (CheckForFunctionLengthsTest.test_function_length_check_definition_huge_lines): 2012-02-22 Dirk Pranke webkitpy: speed up FileLockTest.test_lock_lifecycle https://bugs.webkit.org/show_bug.cgi?id=79189 Reviewed by Adam Barth. The unit test had a second lock trying to acquire a lock already held, and a hard-coded timeout of one second. I have changed the timeouts to a tenth of a second (which is probably still fine) and changed the hard-spin on the lock to a slow-spin every hundredth of a second. * Scripts/webkitpy/common/system/file_lock.py: (FileLock.acquire_lock): * Scripts/webkitpy/common/system/file_lock_integrationtest.py: (FileLockTest.setUp): (FileLockTest.test_stuck_lock): 2012-02-22 Gabor Rapcsanyi build-webkit should use environment variable at number of CPU detection on all platform https://bugs.webkit.org/show_bug.cgi?id=79227 Reviewed by Martin Robinson. * Scripts/webkitdirs.pm: (determineNumberOfCPUs): 2012-02-22 Mihnea Ovidenie [Qt] REGRESSION(r108108): It made 3 fast/repaint tests fail https://bugs.webkit.org/show_bug.cgi?id=78960 Reviewed by Csaba Osztrogonác. * DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::overridePreference): 2012-02-22 Hao Zheng [chromium] Build WebKit with MEDIA_STREAM disabled. https://bugs.webkit.org/show_bug.cgi?id=79214 Reviewed by Kent Tamura. * DumpRenderTree/chromium/WebUserMediaClientMock.cpp: * DumpRenderTree/chromium/WebUserMediaClientMock.h: * DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::createMediaPlayer): * DumpRenderTree/chromium/WebViewHost.h: (WebViewHost): 2012-02-22 Zeno Albisser [Qt][WK2][Mac] WebKitTestRunner does not build with clang. https://bugs.webkit.org/show_bug.cgi?id=79124 WebKitTestRunnerPrefix.h should also be included when building with clang. Reviewed by Kenneth Rohde Christiansen. * WebKitTestRunner/Target.pri: 2012-02-20 Roland Steiner