2011-06-10 Tony Chang Reviewed by Ojan Vafai. add a compile guard ENABLE(FLEXBOX) https://bugs.webkit.org/show_bug.cgi?id=62049 * Configurations/FeatureDefines.xcconfig: 2011-06-10 Ryuan Choi Reviewed by Kenneth Rohde Christiansen. [EFL][WK2] Add dummy files in WebProcess/WebCoreSupport/efl https://bugs.webkit.org/show_bug.cgi?id=62346 Add WebProcess/WebCoreSupport/efl directory and files. * WebProcess/WebCoreSupport/efl/WebContextMenuClientEfl.cpp: Added. (WebKit::WebContextMenuClient::lookUpInDictionary): (WebKit::WebContextMenuClient::isSpeaking): (WebKit::WebContextMenuClient::speak): (WebKit::WebContextMenuClient::stopSpeaking): * WebProcess/WebCoreSupport/efl/WebEditorClientEfl.cpp: Added. (WebKit::WebEditorClient::handleKeyboardEvent): (WebKit::WebEditorClient::handleInputMethodKeydown): * WebProcess/WebCoreSupport/efl/WebErrorsEfl.cpp: Added. (WebKit::cancelledError): (WebKit::blockedError): (WebKit::cannotShowURLError): (WebKit::interruptForPolicyChangeError): (WebKit::cannotShowMIMETypeError): (WebKit::fileDoesNotExistError): (WebKit::pluginWillHandleLoadError): * WebProcess/WebCoreSupport/efl/WebFrameNetworkingContext.h: Added. (WebFrameNetworkingContext::create): (WebFrameNetworkingContext::WebFrameNetworkingContext): * WebProcess/WebCoreSupport/efl/WebPopupMenuEfl.cpp: Added. (WebKit::WebPopupMenu::setUpPlatformData): 2011-06-09 Andreas Kling Reviewed by Darin Adler. WebKit2: Remove unused function CoreIPC::Connection::deprecatedWaitFor(). https://bugs.webkit.org/show_bug.cgi?id=62386 * Platform/CoreIPC/Connection.h: 2011-06-09 Andreas Kling Reviewed by Anders Carlsson. [Qt][WK2] Remove usage of deprecated CoreIPC functions. https://bugs.webkit.org/show_bug.cgi?id=62290 Use the new DrawingArea{,Proxy}.messages.in approach to CoreIPC in TiledDrawingArea. The TiledDrawingArea{,Proxy}-specific messages were moved up into DrawingArea{,Proxy} and guarded by ENABLE(TILED_BACKING_STORE). * Shared/CoreIPCSupport/DrawingAreaMessageKinds.h: Removed. * Shared/CoreIPCSupport/DrawingAreaProxyMessageKinds.h: Removed. * GNUmakefile.am: * WebKit2.pro: * WebKit2.xcodeproj/project.pbxproj: * win/WebKit2.vcproj: Prune deleted files from build system. * Platform/CoreIPC/MessageID.h: Remove legacy DrawingArea message ID's. * UIProcess/API/qt/qgraphicswkview.cpp: (QGraphicsWKViewPrivate::commitScale): No longer waits for all tile updates to complete, this will be addressed by the soon-to-be-upstreamed TileSet mechanism. * UIProcess/DrawingAreaProxy.messages.in: * UIProcess/DrawingAreaProxy.h: (WebKit::DrawingAreaProxy::didSetSize): (WebKit::DrawingAreaProxy::invalidate): (WebKit::DrawingAreaProxy::snapshotTaken): (WebKit::DrawingAreaProxy::tileUpdated): (WebKit::DrawingAreaProxy::allTileUpdatesProcessed): Added IPC calls used by TiledDrawingAreaProxy to DrawingAreaProxy. * WebProcess/WebPage/DrawingArea.messages.in: * WebProcess/WebPage/DrawingArea.h: (WebKit::DrawingArea::setSize): (WebKit::DrawingArea::cancelTileUpdate): (WebKit::DrawingArea::requestTileUpdate): (WebKit::DrawingArea::takeSnapshot): Added IPC calls used by TiledDrawingArea to DrawingArea. * UIProcess/DrawingAreaProxyImpl.h: * UIProcess/DrawingAreaProxyImpl.cpp: Remove the now-unneeded didReceiveMessage() and didReceiveSyncMessage(). * WebProcess/WebPage/DrawingAreaImpl.cpp: * WebProcess/WebPage/DrawingAreaImpl.h: Remove the now-unneeded didReceiveMessage(). * UIProcess/TiledDrawingAreaProxy.h: * UIProcess/TiledDrawingAreaProxy.cpp: (WebKit::TiledDrawingAreaProxy::sizeDidChange): (WebKit::TiledDrawingAreaProxy::tileUpdated): (WebKit::TiledDrawingAreaProxy::allTileUpdatesProcessed): Split didReceiveMessage() into functions. (WebKit::TiledDrawingAreaProxy::removeTile): (WebKit::TiledDrawingAreaProxy::requestTileUpdate): (WebKit::TiledDrawingAreaProxy::setPageIsVisible): (WebKit::TiledDrawingAreaProxy::takeSnapshot): Use new-style IPC. * WebProcess/WebPage/TiledDrawingArea.cpp: (WebKit::TiledDrawingArea::setSize): (WebKit::TiledDrawingArea::cancelTileUpdate): (WebKit::TiledDrawingArea::requestTileUpdate): (WebKit::TiledDrawingArea::takeSnapshot): Split didReceiveMessage() into functions. (WebKit::TiledDrawingArea::display): (WebKit::TiledDrawingArea::updateTile): (WebKit::TiledDrawingArea::tileUpdateTimerFired): Use new-style IPC. * UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::didReceiveMessage): Remove handling of CoreIPC::MessageClassDrawingAreaProxyLegacy. * WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::didReceiveMessage): Remove handling of CoreIPC::MessageClassDrawingAreaLegacy. * UIProcess/qt/TiledDrawingAreaProxyQt.cpp: Remove unneeded includes. * WebProcess/WebPage/TiledDrawingArea.h: Remove didReceiveMessage() and make CoreIPC message handlers explicitly virtual. 2011-06-09 Andreas Kling Reviewed by Anders Carlsson. WebKit2: Generate correct header conditionals in message receivers. https://bugs.webkit.org/show_bug.cgi?id=62379 Given a *.messages.in file like this: Foo(AwesomeObject o) #if ENABLE(ESOTERIC_FEATURE) Bar(AwesomeObject o) #endif messages.py would include AwesomeObject.h only #if ENABLE(ESOTERIC_FEATURE). This breaks the build on platforms without that defined. Furthermore, if two messages guarded by different conditionals both pull in the same header, only the last conditional will be applied, for example: #if ENABLE(ESOTERIC_FEATURE) Foo(AwesomeObject o) #endif #if ENABLE(MYSTERIOUS_FEATURE) Bar(AwesomeObject o) #endif Would include AwesomeObject.h #if ENABLE(MYSTERIOUS_FEATURE) when it really should check #if ENABLE(ESOTERIC_FEATURE) || ENABLE(MYSTERIOUS_FEATURE). Change the generator to consider all conditionals for a given header file. Also consider conditionals for reply parameters. * Scripts/webkit2/messages.py: * Scripts/webkit2/messages_unittest.py: 2011-06-09 Eunmi Lee Reviewed by Kenneth Rohde Christiansen. [EFL][WK2] Add PageClientImpl and WebPageProxyEfl for efl port https://bugs.webkit.org/show_bug.cgi?id=62363 * UIProcess/API/efl/PageClientImpl.cpp: Added. (WebKit::PageClientImpl::PageClientImpl): (WebKit::PageClientImpl::~PageClientImpl): (WebKit::PageClientImpl::createDrawingAreaProxy): (WebKit::PageClientImpl::setViewNeedsDisplay): (WebKit::PageClientImpl::displayView): (WebKit::PageClientImpl::scrollView): (WebKit::PageClientImpl::viewSize): (WebKit::PageClientImpl::isViewWindowActive): (WebKit::PageClientImpl::isViewFocused): (WebKit::PageClientImpl::isViewVisible): (WebKit::PageClientImpl::isViewInWindow): (WebKit::PageClientImpl::processDidCrash): (WebKit::PageClientImpl::didRelaunchProcess): (WebKit::PageClientImpl::pageClosed): (WebKit::PageClientImpl::toolTipChanged): (WebKit::PageClientImpl::setCursor): (WebKit::PageClientImpl::setViewportArguments): (WebKit::PageClientImpl::registerEditCommand): (WebKit::PageClientImpl::clearAllEditCommands): (WebKit::PageClientImpl::canUndoRedo): (WebKit::PageClientImpl::executeUndoRedo): (WebKit::PageClientImpl::convertToDeviceSpace): (WebKit::PageClientImpl::convertToUserSpace): (WebKit::PageClientImpl::windowToScreen): (WebKit::PageClientImpl::doneWithKeyEvent): (WebKit::PageClientImpl::createPopupMenuProxy): (WebKit::PageClientImpl::createContextMenuProxy): (WebKit::PageClientImpl::setFindIndicator): (WebKit::PageClientImpl::didChangeScrollbarsForMainFrame): (WebKit::PageClientImpl::didCommitLoadForMainFrame): (WebKit::PageClientImpl::didFinishLoadingDataForCustomRepresentation): (WebKit::PageClientImpl::customRepresentationZoomFactor): (WebKit::PageClientImpl::setCustomRepresentationZoomFactor): (WebKit::PageClientImpl::flashBackingStoreUpdates): (WebKit::PageClientImpl::findStringInCustomRepresentation): (WebKit::PageClientImpl::countStringMatchesInCustomRepresentation): (WebKit::PageClientImpl::userSpaceScaleFactor): * UIProcess/API/efl/PageClientImpl.h: Added. (WebKit::PageClientImpl::create): (WebKit::PageClientImpl::viewObject): (WebKit::PageClientImpl::page): * UIProcess/WebPageProxy.h: * UIProcess/efl/WebPageProxyEfl.cpp: Added. (WebKit::WebPageProxy::viewObject): (WebKit::WebPageProxy::standardUserAgent): (WebKit::WebPageProxy::getEditorCommandsForKeyEvent): (WebKit::WebPageProxy::saveRecentSearches): (WebKit::WebPageProxy::loadRecentSearches): 2011-06-08 John Sullivan Reviewed by Darin Adler. [WKView _setDragImage:at:linkDrag:] can crash if WKView is dealloc'ed during drag * UIProcess/API/mac/WKView.mm: (-[WKView _resendKeyDownEvent:]): Renamed self-protecting RetainPtr from "protect" to "protector" so it's a noun. (-[WKView _setDragImage:at:linkDrag:]): Added a self-protecting RetainPtr. 2011-06-08 No'am Rosenthal Reviewed by Kenneth Rohde Christiansen. WebKit2: Enable serializing of data types needed for cross-process accelerated compositing https://bugs.webkit.org/show_bug.cgi?id=61694 Add an ArgumentCoder for FloatPoint3D. Together with Viatcheslav Ostapenko. * Scripts/webkit2/messages.py: * Shared/WebCoreArgumentCoders.h: 2011-06-08 No'am Rosenthal Reviewed by Kenneth Rohde Christiansen. WebKit2: Enable serializing of data types needed for cross-process accelerated compositing https://bugs.webkit.org/show_bug.cgi?id=61694 Add ArgumentCoders for TransformOperation, including all the subclasses, and TransformOperations. * Scripts/webkit2/messages.py: * Shared/WebCoreArgumentCoders.h: 2011-06-08 Yael Aharon Reviewed by Andreas Kling. [Qt] Build fix for building QtWebKit inside of Qt. https://bugs.webkit.org/show_bug.cgi?id=62280 Remove CONFIG=staticlib, because it causes the configure script to add -lwebkit2 into QtWebKit.prl. * WebKit2.pri: 2011-06-07 Tim Horton Reviewed by Alexey Proskuryakov. Use correct CFURLStorageSessionRef definition on Snow Leopard https://bugs.webkit.org/show_bug.cgi?id=62223 * PluginProcess/mac/PluginProcessShim.mm: 2011-06-07 John Sullivan Reviewed by Darin Adler. WKResponderChainSink mechanism isn't robust against some types of responder chain manipulation * UIProcess/API/mac/WKView.mm: (-[WKResponderChainSink detach]): This method formerly blindly assumed that since -initWithResponderChain: put self at the end of the responder chain, after _lastResponderInChain, then self is still at the end of the responder chain and still immediately after _lastResponderInChain. Made this function robust against some kinds of responder chain manipulations, though it can't be robust against some other kinds (e.g., manipulations that removed self from this chain and put it into some other chain). 2011-06-07 Sam Weinig Reviewed by Anders Carlsson. Remove repeated IPC traffic from SetRenderTreeSize message https://bugs.webkit.org/show_bug.cgi?id=62244 * WebProcess/InjectedBundle/API/c/WKBundlePage.h: Add didLayoutForFrame callback. * WebProcess/InjectedBundle/API/c/WKBundlePage.cpp: (WKBundlePageGetRenderTreeSize): * WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h: Add render tree size getter in WebProcess. * WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp: (WebKit::InjectedBundlePageLoaderClient::didLayoutForFrame): * WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h: Added. * WebProcess/WebCoreSupport/WebChromeClient.cpp: * WebProcess/WebCoreSupport/WebChromeClient.h: Removed setRenderTreeSize. * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::dispatchDidLayout): * WebProcess/WebCoreSupport/WebFrameLoaderClient.h: Call the new didLayoutForFrame client function. * WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::renderTreeSize): * WebProcess/WebPage/WebPage.h: Add iterative implementation to compute the total size of the render tree for a page. 2011-06-07 Zalan Bujtas Reviewed by Andreas Kling. TiledDrawingArea: Delay serving tile requests when the drawing area is suspended. Do not paint tiles when painting is disabled (suspended) on the web process side. Buffer up the tile requests and paint them, when the drawing area gets resumed. On the UI process side, do not block on tile updates, when the tiled area is not visible (painting is disabled on the web process side). * UIProcess/TiledDrawingAreaProxy.cpp: (WebKit::TiledDrawingAreaProxy::waitUntilUpdatesComplete): * WebProcess/WebPage/TiledDrawingArea.cpp: (WebKit::TiledDrawingArea::suspendPainting): (WebKit::TiledDrawingArea::resumePainting): (WebKit::TiledDrawingArea::scheduleTileUpdate): (WebKit::TiledDrawingArea::tileUpdateTimerFired): (WebKit::TiledDrawingArea::didReceiveMessage): * WebProcess/WebPage/TiledDrawingArea.h: 2011-06-07 Sheriff Bot Unreviewed, rolling out r88259 and r88263. http://trac.webkit.org/changeset/88259 http://trac.webkit.org/changeset/88263 https://bugs.webkit.org/show_bug.cgi?id=62228 broke builds (Requested by rniwa on #webkit). * PluginProcess/mac/PluginProcessShim.mm: 2011-06-07 Tim Horton Reviewed by Alexey Proskuryakov. Use correct CFURLStorageSessionRef definition on Snow Leopard https://bugs.webkit.org/show_bug.cgi?id=62223 * PluginProcess/mac/PluginProcessShim.mm: 2011-06-07 Carlos Garcia Campos Reviewed by Martin Robinson. [GTK] Move moduleMixesGtkSymbols() from PluginPackage to PluginView https://bugs.webkit.org/show_bug.cgi?id=62200 In WebKit2 PluginPackage is used by the UI process to load plugins in order to get information about them, but it doesn't use any GTK symbol. So the UI process should be able to load plugins even when building with GTK3, but we should not allow the plugin view to use the plugin if it mixes GTK2 and GTK3 symbols. * WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp: (WebKit::moduleMixesGtkSymbols): (WebKit::NetscapePlugin::platformPostInitialize): Check whether the module is mixing GTK+ 2 and GTK+ 3 symbols. 2011-06-06 Sheriff Bot Unreviewed, rolling out r88222. http://trac.webkit.org/changeset/88222 https://bugs.webkit.org/show_bug.cgi?id=62192 Broke compile on Mac (Requested by abarth on #webkit). * Scripts/webkit2/messages.py: * Shared/WebCoreArgumentCoders.h: 2011-06-06 Noam Rosenthal Reviewed by Kenneth Rohde Christiansen. WebKit2: Enable serializing of data types needed for cross-process accelerated compositing https://bugs.webkit.org/show_bug.cgi?id=61694 Add ArgumentCoders for TransformOperation, including all the subclasses, and TransformOperations. * Scripts/webkit2/messages.py: * Shared/WebCoreArgumentCoders.h: 2011-06-06 John Sullivan Reviewed by Dan Bernstein. WebKit2 find-on-page callback doesn’t handle kWKMoreThanMaximumMatchCount on PDF pages * UIProcess/API/mac/PDFViewController.mm: (WebKit::PDFViewController::findString): Return kWKMoreThanMaximumMatchCount when appropriate, a la FindController::countStringMatches(). Also, skip counting all the matches if maxMatchCount is 0, to avoid (perhaps slowly) computing a number that would be ignored. 2011-06-06 Carlos Garcia Campos Reviewed by Anders Carlsson. Do not use NPRuntimeObjectMap in NetscapePlugin::setException when plug-in is running out of process https://bugs.webkit.org/show_bug.cgi?id=62124 * WebProcess/Plugins/Netscape/NetscapePlugin.cpp: (WebKit::NetscapePlugin::setException): 2011-06-06 Dominic Cooney Unreviewed WinCairo build fix after r88159. * win/WebKit2CFLite.def: Export symbols for WebCoreTestSupport. 2011-06-04 Dominic Cooney Reviewed by Dimitri Glazkov. Re-export JSC and WebCore symbols required by WebCoreTestSupport. https://bugs.webkit.org/show_bug.cgi?id=61076 * win/WebKit2.def: 2011-06-06 Alexandru Chiculita Reviewed by Kent Tamura. Add ENABLE_CSS_EXCLUSIONS support for build-webkit script https://bugs.webkit.org/show_bug.cgi?id=61628 * Configurations/FeatureDefines.xcconfig: 2011-06-06 Mihnea Ovidenie Reviewed by Kent Tamura. Add ENABLE(CSS_REGIONS) guard for CSS Regions support https://bugs.webkit.org/show_bug.cgi?id=61631 * Configurations/FeatureDefines.xcconfig: 2011-06-06 Carlos Garcia Campos Reviewed by Anders Carlsson. [UNIX] SOCK_DGRAM sockets are not notified when the other end closes the connection https://bugs.webkit.org/show_bug.cgi?id=61538 Use SOCK_STREAM instead of SOCK_DGRAM sockets. Rework the message receiver code to support stream sockets, since it requires to handle message boundaries. The same code works for DGRAM sockets, so this change shouldn't break other ports using DGRAM. * Platform/CoreIPC/Connection.h: * Platform/CoreIPC/unix/ConnectionUnix.cpp: (CoreIPC::Connection::platformInitialize): (CoreIPC::Connection::processMessage): Process messages from data already received. (CoreIPC::readBytesFromSocket): Read from socket using recvmsg(). (CoreIPC::Connection::readyReadHandler): * UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp: (WebKit::ProcessLauncher::launchProcess): Use SOCK_DGRAM in socketpair(). == Rolled over to ChangeLog-2011-06-04 ==