source: @ 64255

Revision Log Mode:


Legend:

Added
Modified
Copied or renamed
Diff Rev Age Author
(edit) @64255   5 years weinig

Fix builds.

  • UIProcess/API/C/WKAPICast.h:

(WebKit::ProxyingRefPtr::operator APIType):
(toURLRef):
(toCopiedRef):
(toCopiedURLRef):

  • UIProcess/win/WebView.h:

(WebKit::WebView::type):
(edit) @64254   5 years victorw

2010-07-28 Alex Nicolaou <​anicolao@chromium.org>

Reviewed by Ojan Vafai.

Set incorrect but close expectations for mask-colorspace.svg on mac
​https://bugs.webkit.org/show_bug.cgi?id=43102

Blocks:

[chromium] r63450 caused some svg mask tests to fail pixel tests
​https://bugs.webkit.org/show_bug.cgi?id=42403

ImageBufferCG.cpp uses CoreGraphics to do the transform of SVG masks
into LinearRGB, but only for MAC which means not for CHROMIUM, so I
have changed the #if to account for both platforms. I am assuming this
isn't in for windows because it's missing in CG itself, but I didn't
verify that.

  • platform/graphics/cg/ImageBufferCG.cpp: (WebCore::ImageBuffer::ImageBuffer):

2010-07-28 Alex Nicolaou <​anicolao@chromium.org>

Reviewed by Ojan Vafai.

Set incorrect but close expectations for mask-colorspace.svg on mac
​https://bugs.webkit.org/show_bug.cgi?id=43102

Blocks:

[chromium] r63450 caused some svg mask tests to fail pixel tests
​https://bugs.webkit.org/show_bug.cgi?id=42403

On my Mac, after my best efforts, the mask colorspace doesn't
seem to come out right. Though the pixel values in the test
rectangle should be 111, they come out to 104, and ultimately
it is because the pixel values coming out of ImageBufferCG are
not linearized properly. Checking in this expected result because
visually the colours are close enough and I want to catch other
regressions, but if this starts to fail because the first image
has color 111,111,111 in the rectange and 76,76,76 or 78,78,78 in
the circle, the actual problem will have been corrected. (111 and
78 are the correct values).

Also removed fail expectations for those tests that are now
passing on my Mac.

  • platform/chromium/test_expectations.txt:
  • platform/mac/svg/custom/mask-colorspace-expected.checksum:
  • platform/mac/svg/custom/mask-colorspace-expected.png:
(edit) @64253   5 years weinig

Patch for ​https://bugs.webkit.org/show_bug.cgi?id=43163
Add a CF-style base type (WKTypeRef) as a base for polymorphic functions.

Reviewed by Darin Adler.

  • Add first polymorphic function, WKGetTypeID.
  • Add functions to each WK type to get their respective TypeIDs.
  • Adds WebURL to complement WebString.
  • Shared/APIObject.h:

(WebKit::APIObject::):
(WebKit::APIObject::~APIObject):

  • Shared/ImmutableArray.h:

(WebKit::ImmutableArray::type):

  • Shared/WebString.h:

(WebKit::WebString::type):

  • Shared/WebURL.h: Added.

(WebKit::WebURL::create):
(WebKit::WebURL::type):
(WebKit::WebURL::isNull):
(WebKit::WebURL::isEmpty):
(WebKit::WebURL::string):
(WebKit::WebURL::WebURL):

  • UIProcess/API/C/WKAPICast.h:

(WebKit::ProxyingRefPtr::ProxyingRefPtr):
(WebKit::ProxyingRefPtr::operator APIType):
(toRef):
(toURLRef):
(toCopiedURLRef):

  • UIProcess/API/C/WKArray.cpp:

(WKArrayGetTypeID):

  • UIProcess/API/C/WKArray.h:
  • UIProcess/API/C/WKBackForwardList.cpp:

(WKBackForwardListGetTypeID):

  • UIProcess/API/C/WKBackForwardList.h:
  • UIProcess/API/C/WKBackForwardListItem.cpp:

(WKBackForwardListItemGetTypeID):

  • UIProcess/API/C/WKBackForwardListItem.h:
  • UIProcess/API/C/WKBase.h:
  • UIProcess/API/C/WKContext.cpp:

(WKContextGetTypeID):

  • UIProcess/API/C/WKContext.h:
  • UIProcess/API/C/WKFrame.cpp:

(WKFrameGetTypeID):

  • UIProcess/API/C/WKFrame.h:
  • UIProcess/API/C/WKFramePolicyListener.cpp:

(WKFramePolicyListenerGetTypeID):

  • UIProcess/API/C/WKFramePolicyListener.h:
  • UIProcess/API/C/WKNavigationData.cpp:

(WKNavigationDataGetTypeID):

  • UIProcess/API/C/WKNavigationData.h:
  • UIProcess/API/C/WKPage.cpp:

(WKPageGetTypeID):

  • UIProcess/API/C/WKPage.h:
  • UIProcess/API/C/WKPageNamespace.cpp:

(WKPageNamespaceGetTypeID):

  • UIProcess/API/C/WKPageNamespace.h:
  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesGetTypeID):

  • UIProcess/API/C/WKPreferences.h:
  • UIProcess/API/C/WKString.cpp:

(WKStringGetTypeID):

  • UIProcess/API/C/WKString.h:
  • UIProcess/API/C/WKType.cpp: Added.

(WKGetTypeID):

  • UIProcess/API/C/WKType.h: Added.
  • UIProcess/API/C/WKURL.cpp:

(WKURLGetTypeID):

  • UIProcess/API/C/WKURL.h:
  • UIProcess/API/win/WKView.cpp:

(WKViewGetTypeID):

  • UIProcess/API/win/WKView.h:
  • UIProcess/WebBackForwardList.h:

(WebKit::WebBackForwardList::type):

  • UIProcess/WebBackForwardListItem.h:

(WebKit::WebBackForwardListItem::type):

  • UIProcess/WebContext.h:

(WebKit::WebContext::type):

  • UIProcess/WebFramePolicyListenerProxy.h:

(WebKit::WebFramePolicyListenerProxy::type):

  • UIProcess/WebFrameProxy.h:

(WebKit::WebFrameProxy::type):

  • UIProcess/WebNavigationData.h:

(WebKit::WebNavigationData::type):

  • UIProcess/WebPageNamespace.h:

(WebKit::WebPageNamespace::type):

  • UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::type):

  • UIProcess/WebPreferences.h:

(WebKit::WebPreferences::type):

  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/InjectedBundle/API/c/WKBundle.cpp:

(WKBundleGetTypeID):

  • WebProcess/InjectedBundle/API/c/WKBundle.h:
  • WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:

(WKBundleFrameGetTypeID):

  • WebProcess/InjectedBundle/API/c/WKBundleFrame.h:
  • WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(WKBundlePageGetTypeID):
(WKBundlePageSetEditorClient):
(WKBundlePageSetLoaderClient):
(WKBundlePageSetUIClient):

  • WebProcess/InjectedBundle/API/c/WKBundlePage.h:
  • WebProcess/WebPage/WebFrame.h:

(WebKit::WebFrame::type):

  • WebProcess/WebPage/WebPage.h:

(WebKit::WebPage::type):

  • win/WebKit2.vcproj:
Note: See TracRevisionLog for help on using the revision log.