source: @ 65259

2010-08-12 Nate Chapin <​japhet@chromium.org>

Unreviewed, Chromium expectations tweak.

Remove a duplicate linux debug expectation.

• platform/chromium/test_expectations.txt:

Add file I forgot to add in r65255.

2010-08-12 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Reviewed by Martin Robinson.

[GTK] Use GSettings to save/restore Web Inspector settings
​https://bugs.webkit.org/show_bug.cgi?id=43512

• GNUmakefile.am: GSettings rules.
• configure.ac: GSettings infrastructure, and check if we should use it by looking for an appropriate version of GIO.

JavaScriptCore

2010-08-12 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Reviewed by Martin Robinson.

[GTK] Use GSettings to save/restore Web Inspector settings
​https://bugs.webkit.org/show_bug.cgi?id=43512

• wtf/gobject/GRefPtr.cpp: Added support for GVariant, used by our GSettings support. (WTF::refGPtr): (WTF::derefGPtr):
• wtf/gobject/GRefPtr.h:

WebKit/gtk

2010-08-12 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Reviewed by Martin Robinson.

[GTK] Use GSettings to save/restore Web Inspector settings
​https://bugs.webkit.org/show_bug.cgi?id=43512

Use GSettings to save/restore settings used by the Web Inspector.
A few helper functions were added to have settings that use
boolean values be actual booleans, and also to conform with the
GSettings naming requirements for keys.

• WebCoreSupport/InspectorClientGtk.cpp: (WebKit::toGSettingName): (WebKit::truthStringFromVariant): (WebKit::variantFromTruthString): (WebKit::InspectorClient::populateSetting): (WebKit::InspectorClient::storeSetting):
• org.webkit.gtk.gschema.xml: Added.
• webkit/webkitprivate.cpp: (inspectorGSettings): (webkit_init):
• webkit/webkitprivate.h:

2010-08-12 Rafael Antognolli <​antognolli@profusion.mobi>

Reviewed by Kenneth Rohde Christiansen.

[EFL] Making CMake keep track of theme dependencies.
​https://bugs.webkit.org/show_bug.cgi?id=43862

Removing unused macro GENERATE_EDJ.

• cmake/WebKitEfl.cmake:

2010-08-12 Rafael Antognolli <​antognolli@profusion.mobi>

Reviewed by Kenneth Rohde Christiansen.

[EFL] Making CMake keep track of theme dependencies.
​https://bugs.webkit.org/show_bug.cgi?id=43862

Adding theme source files and images as dependencies of the theme.

• CMakeListsEfl.txt:

2010-08-12 John Gregg <​johnnyg@google.com>

Reviewed by Kent Tamura.

[chromium] Add Notification::detachPresenter to the WebKit API.
​https://bugs.webkit.org/show_bug.cgi?id=43659

• public/WebNotification.h:
• src/WebNotification.cpp: (WebKit::WebNotification::detachPresenter):

2010-08-12 Hui Huang <​hui.2.huang@nokia.com>

Reviewed by Eric Seidel.

m_windowRect is not updated because parent of PluginView is not
set when updatePluginWidget is called. plugin gets wrong window
size on setwindow.
​https://bugs.webkit.org/show_bug.cgi?id=43635

• plugins/symbian/PluginViewSymbian.cpp: (WebCore::PluginView::setParent):

2010-08-11 Stephen White <​senorblanco@chromium.org>

Reviewed by David Levin.

Add support for BGRA pixel format to GraphicsContext3D.
​https://bugs.webkit.org/show_bug.cgi?id=43858

Although this has been standard in desktop GL since 1.2, it's an
extension in GL ES 2.0, so a query function is provided to check
for support. The DefaultImpl returns false, since it does not yet
implement the TexImage2D internalFormat quirks.

• public/WebGraphicsContext3D.h: (WebKit::WebGraphicsContext3D::supportsBGRA):
• src/GraphicsContext3D.cpp:
• src/WebGraphicsContext3DDefaultImpl.cpp: (WebKit::WebGraphicsContext3DDefaultImpl::supportsBGRA):
• src/WebGraphicsContext3DDefaultImpl.h:

2010-08-11 Stephen White <​senorblanco@chromium.org>

Reviewed by David Levin.

Add support for BGRA pixel format to GraphicsContext3D.
​https://bugs.webkit.org/show_bug.cgi?id=43858

Although this has been standard in desktop GL since 1.2, it's an
extension in GL ES 2.0, so a query function is provided to check
for support. Since they differ on semantics (GL ES 2.0 requires
TexImage2D()'s format and internalFormat to match, while desktop GL
will not accept BGRA as an internalFormat), the stub implementation
returns false until these quirks have been implemented and tested on
each port.

• platform/graphics/GraphicsContext3D.cpp: (WebCore::GraphicsContext3D::supportsBGRA): Add implementation for non-chromium platforms which returns false.
• platform/graphics/GraphicsContext3D.h: (WebCore::GraphicsContext3D::): Add query function (supportsBGRA()) and the BGRA_EXT token.

2010-08-12 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed. Rolling out r65241 and 65243 for breaking inspector tests.

2010-08-12 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed. Adding the file missing in r65241.

• inspector/front-end/RemoteObject.js: Added. (WebInspector.RemoteObjectId): (WebInspector.RemoteObject): (WebInspector.RemoteObject.fromPrimitiveValue): (WebInspector.RemoteObject.fromNode): (WebInspector.RemoteObject.fromPayload): (WebInspector.RemoteObject.type): (WebInspector.RemoteObject.prototype.get objectId): (WebInspector.RemoteObject.prototype.get type): (WebInspector.RemoteObject.prototype.get description): (WebInspector.RemoteObject.prototype.get hasChildren): (WebInspector.RemoteObject.prototype.isError): (WebInspector.RemoteObject.prototype.getPropertyValueDescriptions): (WebInspector.RemoteObject.prototype.getOwnProperties):

2010-08-12 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: brush up object proxies, introduce remote object model.
​https://bugs.webkit.org/show_bug.cgi?id=43847

• WebCore.gypi:
• WebCore.vcproj/WebCore.vcproj:
• inspector/front-end/AuditRules.js: (WebInspector.AuditRules.CssInHeadRule.prototype.doRun): (WebInspector.AuditRules.StylesScriptsOrderRule.prototype.doRun):
• inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype.doEvalInWindow): (WebInspector.ConsoleView.prototype._enterKeyPressed.printResult): (WebInspector.ConsoleView.prototype._enterKeyPressed): (WebInspector.ConsoleView.prototype._format): (WebInspector.ConsoleView.prototype._formatnode): (WebInspector.ConsoleView.prototype._formatarray): (WebInspector.ConsoleView.prototype._formatAsArrayEntry): (WebInspector.ConsoleMessage.prototype._format): (WebInspector.ConsoleCommandResult):
• inspector/front-end/DOMAgent.js: (WebInspector.DOMNode):
• inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype._createTooltipForNode):
• inspector/front-end/EventListenersSidebarPane.js:
• inspector/front-end/InjectedScript.js: (injectedScriptConstructor): (injectedScriptConstructor.):
• inspector/front-end/ObjectPropertiesSection.js: (WebInspector.ObjectPropertiesSection.prototype.update): (WebInspector.ObjectPropertiesSection.prototype.updateProperties): (WebInspector.ObjectPropertyTreeElement.prototype.onpopulate): (WebInspector.ObjectPropertyTreeElement.prototype.update): (WebInspector.ObjectPropertyTreeElement.prototype.applyExpression):
• inspector/front-end/ObjectProxy.js: Removed.
• inspector/front-end/PropertiesSidebarPane.js: (WebInspector.PropertiesSidebarPane.prototype.update.callback):
• inspector/front-end/RemoteObject.js: Added. (WebInspector.RemoteObjectId): (WebInspector.RemoteObject): (WebInspector.RemoteObject.fromPrimitiveValue): (WebInspector.RemoteObject.fromErrorMessage): (WebInspector.RemoteObject.fromNode): (WebInspector.RemoteObject.fromPayload): (WebInspector.RemoteObject.type): (WebInspector.RemoteObject.prototype.get objectId): (WebInspector.RemoteObject.prototype.get type): (WebInspector.RemoteObject.prototype.get description): (WebInspector.RemoteObject.prototype.get hasChildren): (WebInspector.RemoteObject.prototype.isError): (WebInspector.RemoteObject.prototype.getPropertyValueDescriptions): (WebInspector.RemoteObject.prototype.getOwnProperties): (WebInspector.RemoteObject.prototype.getProperties.remoteObjectBinder): (WebInspector.RemoteObjectProperty):
• inspector/front-end/ScopeChainSidebarPane.js: (WebInspector.ScopeChainSidebarPane.prototype.update):
• inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame.updatingCallbackWrapper): (WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame): (WebInspector.ScriptsPanel.prototype.doEvalInCallFrame):
• inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._showPopup.evaluateCallback): (WebInspector.SourceFrame.prototype._showPopup): (WebInspector.SourceFrame.prototype._evalSelectionInCallFrame):
• inspector/front-end/WatchExpressionsSidebarPane.js: (WebInspector.WatchExpressionsSection.prototype.update): (WebInspector.WatchExpressionTreeElement.prototype.update):
• inspector/front-end/WebKit.qrc:
• inspector/front-end/inspector.html:
• inspector/front-end/inspector.js: (WebInspector.log.logMessage): (WebInspector.log):
• inspector/front-end/utilities.js:

2010-08-12 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: brush up object proxies, introduce remote object model.
​https://bugs.webkit.org/show_bug.cgi?id=43847

• inspector/console-dir-expected.txt:
• inspector/console-dir-global.html:
• inspector/console-dir.html:
• inspector/console-format-collections-expected.txt:
• inspector/console-format-expected.txt:

2010-08-12 Philippe Normand <​pnormand@igalia.com>

Unreviewed.

Media test baseline forgotten in r65224.

• platform/gtk/media/audio-no-installed-engines-expected.txt: Added.

2010-08-12 Shinichiro Hamaji <​hamaji@chromium.org>

Update chromium's test_expectations.txt

• platform/chromium/test_expectations.txt: Two failing video related tests.

2010-08-12 Shinichiro Hamaji <​hamaji@chromium.org>

Update chromium's test_expectations.txt

• platform/chromium/test_expectations.txt: animations/play-state is flaky on Mac

2010-08-12 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed. Delete a test that slipped in by accident.

• svg/zoom/page/zoom-mask.svg: Removed.

2010-08-12 Jeremy Orlow <​jorlow@chromium.org>

Build fix.

• rendering/SVGImageBufferTools.cpp: (WebCore::SVGImageBufferTools::createImageBuffer):

2010-08-12 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

SVG masking performance very slow
​https://bugs.webkit.org/show_bug.cgi?id=43622

Create ImageBuffers only as large as the final rendered size on screen. Only gradient on text on CG handled this correctly so far.
Refactored the code into a new SVGImageBufferTools class, and use the code from RenderSVGResourceMasker -> makes the IE9 demo SVG dice usable.
Clippers, Patterns and Filters remain to be converted.

Test: svg/zoom/page/zoom-mask-with-percentages.svg

• Android.mk: Add SVGImageBufferTools.* to build.
• CMakeLists.txt: Ditto.
• GNUmakefile.am: Ditto.
• WebCore.gypi: Ditto.
• WebCore.pro: Ditto.
• WebCore.xcodeproj/project.pbxproj: Ditto.
• rendering/RenderSVGAllInOne.cpp: Ditto.
• rendering/RenderSVGResourceGradient.cpp: Refactored CG gradient specific "create image buffer in absolute coordinates" code into SVGImageBufferTools class. (WebCore::createMaskAndSwapContextForTextGradient): (WebCore::clipToTextMask): (WebCore::RenderSVGResourceGradient::applyResource):
• rendering/RenderSVGResourceMasker.cpp: Use new SVGImageBufferTools class, to avoid pixelation when zooming and to create image buffers as big as the final rendered size on screen, not more. (WebCore::RenderSVGResourceMasker::invalidateClients): (WebCore::RenderSVGResourceMasker::applyResource): (WebCore::RenderSVGResourceMasker::drawContentIntoMaskImage): (WebCore::RenderSVGResourceMasker::calculateMaskContentRepaintRect): (WebCore::RenderSVGResourceMasker::resourceBoundingBox):
• rendering/RenderSVGResourceMasker.h:
• rendering/SVGImageBufferTools.cpp: Added. (WebCore::SVGImageBufferTools::absoluteTransformFromContext): (WebCore::SVGImageBufferTools::createImageBuffer): (WebCore::SVGImageBufferTools::clipToImageBuffer):
• rendering/SVGImageBufferTools.h: Added. (WebCore::SVGImageBufferTools::SVGImageBufferTools): (WebCore::SVGImageBufferTools::~SVGImageBufferTools):

2010-08-12 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

SVG masking performance very slow
​https://bugs.webkit.org/show_bug.cgi?id=43622

Update mask results, now that mask image buffers are as big as the finaled rendered size on screen.
Add new test covering zooming into masks, to show that it doesn't pixelate anymore.

• platform/mac/svg/W3C-SVG-1.1/masking-intro-01-f-expected.checksum:
• platform/mac/svg/W3C-SVG-1.1/masking-intro-01-f-expected.png:
• platform/mac/svg/batik/masking/maskRegions-expected.checksum:
• platform/mac/svg/batik/masking/maskRegions-expected.png:
• platform/mac/svg/custom/grayscale-gradient-mask-expected.checksum:
• platform/mac/svg/custom/grayscale-gradient-mask-expected.png:
• platform/mac/svg/zoom/page/zoom-mask-with-percentages-expected.checksum: Added.
• platform/mac/svg/zoom/page/zoom-mask-with-percentages-expected.png: Added.
• platform/mac/svg/zoom/page/zoom-mask-with-percentages-expected.txt: Added.
• svg/zoom/page/zoom-mask-with-percentages.svg: Added.

[Qt] Decode images directly to QPixmap
​https://bugs.webkit.org/show_bug.cgi?id=40797

Patch by Benjamin Poulain <​benjamin.poulain@nokia.com> on 2010-08-12
Reviewed by Simon Hausmann.

Use the new API of Qt 4.7 to decode data from the image
reader directly to QPixmap.

This allow us to use JDCT_IFAST when decoding jpeg images
to pixmap, and to decode animated GIF images, while still
using in-place conversion of color space.

• platform/graphics/qt/ImageDecoderQt.cpp:

(WebCore::ImageDecoderQt::setData):
(WebCore::ImageDecoderQt::internalHandleCurrentImage):

2010-08-12 Patrick Gansterer <​paroga@paroga.com>

Reviewed by Nikolas Zimmermann.

[CMake] Cleanup generator code.
​https://bugs.webkit.org/show_bug.cgi?id=39164

• cmake/WebKitGenerators.cmake:
• cmake/WebKitMacros.cmake:

2010-08-12 Alejandro G. Castro <​alex@igalia.com>

Reviewed by David Levin.

The #if clause enabling a feature should avoid the all includes of
the feature
​https://bugs.webkit.org/show_bug.cgi?id=43866

Modified the position of the guard to avoid including all the
headers if the feature controlling the guard is not enabled.

• dom/make_names.pl:

2010-08-11 Stephen White <​senorblanco@chromium.org>

Reviewed by David Levin.

Add support for BGRA pixel format to GraphicsContext3D.
​https://bugs.webkit.org/show_bug.cgi?id=43858

Although this has been standard in desktop GL since 1.2, it's an
extension in GL ES 2.0, so a query function is provided to check
for support. Since they differ on semantics (GL ES 2.0 requires
TexImage2D()'s format and internalFormat to match, while desktop GL
will not accept BGRA as an internalFormat), the stub implementation
returns false until these quirks have been implemented and tested on
each port.

• platform/graphics/GraphicsContext3D.cpp: (WebCore::GraphicsContext3D::supportsBGRA): Add implementation for non-chromium platforms which returns false.
• platform/graphics/GraphicsContext3D.h: (WebCore::GraphicsContext3D::): Add query function (supportsBGRA()) and the BGRA_EXT token.

2010-08-11 Stephen White <​senorblanco@chromium.org>

Reviewed by David Levin.

Add support for BGRA pixel format to GraphicsContext3D.
​https://bugs.webkit.org/show_bug.cgi?id=43858

Although this has been standard in desktop GL since 1.2, it's an
extension in GL ES 2.0, so a query function is provided to check
for support. The DefaultImpl returns false, since it does not yet
implement the TexImage2D internalFormat quirks.

• public/WebGraphicsContext3D.h: (WebKit::WebGraphicsContext3D::supportsBGRA):
• src/GraphicsContext3D.cpp:
• src/WebGraphicsContext3DDefaultImpl.cpp: (WebKit::WebGraphicsContext3DDefaultImpl::supportsBGRA):
• src/WebGraphicsContext3DDefaultImpl.h:

2010-08-11 Fumitoshi Ukai <​ukai@chromium.org>

Reviewed by Alexey Proskuryakov.

REGRESSION(65135): format specifier warnings
​https://bugs.webkit.org/show_bug.cgi?id=43876

• websockets/WebSocketChannel.cpp: (WebCore::WebSocketChannel::appendToBuffer): cast size_t to unsigned long for %lu. (WebCore::WebSocketChannel::processBuffer): cast size_t to unsigned long for %lu.

2010-08-11 Tony Gentilcore <​tonyg@chromium.org>

Reviewed by Adam Barth.

Make PendingScript copyable so that it can be stored in containers
​https://bugs.webkit.org/show_bug.cgi?id=43875

This will be useful for storing PendingScripts in a Vector or Deque for
async and defer scripts.

No new tests because no functional changes.

• dom/PendingScript.h: (WebCore::PendingScript::PendingScript): (WebCore::PendingScript::operator=):

2010-08-11 Victoria Kirst <​vrk@google.com>

Reviewed by David Levin.

Fixing a regression in the UI for Mac default audio/video controls.
​https://bugs.webkit.org/show_bug.cgi?id=43750

• rendering/RenderThemeChromiumMac.h:
• rendering/RenderThemeChromiumMac.mm: (WebCore::RenderThemeChromiumMac::paintMediaVolumeSliderContainer): (WebCore::RenderThemeChromiumMac::paintMediaSliderThumb): (WebCore::RenderThemeChromiumMac::volumeSliderOffsetFromMuteButton):

2010-08-11 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

HTML TreeBuilder hits ASSERT in fragment case with insertAdjacentHTML and colgroup
​https://bugs.webkit.org/show_bug.cgi?id=43758

• html5lib/runner-expected-html5.txt:

2010-08-11 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

HTML TreeBuilder hits ASSERT in fragment case with insertAdjacentHTML and colgroup
​https://bugs.webkit.org/show_bug.cgi?id=43758

This patch conditionalizes some LegacyHTMLTreeBuilder-specific code in
HTMLElement::createContextualFragment that interferes with the new
HTMLTreeBuilder. Doing that exposes the above ASSERT, which I've fixed
in this patch too. Fixing that ASSERT involved a small refactoring in
ExternalCharacterTokenBuffer.

• html/HTMLElement.cpp: (WebCore::HTMLElement::createContextualFragment):
• html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::ExternalCharacterTokenBuffer::skipLeadingWhitespace): (WebCore::HTMLTreeBuilder::ExternalCharacterTokenBuffer::takeLeadingWhitespace): (WebCore::HTMLTreeBuilder::ExternalCharacterTokenBuffer::takeLeadingNonWhitespace): (WebCore::HTMLTreeBuilder::ExternalCharacterTokenBuffer::skipLeading): (WebCore::HTMLTreeBuilder::ExternalCharacterTokenBuffer::takeLeading): (WebCore::HTMLTreeBuilder::processCharacterBuffer):

2010-08-11 Adam Barth <​abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

fast/encoding/japanese-encoding-mix.html fails on Tiger after enabling HTML5 Lexer
​https://bugs.webkit.org/show_bug.cgi?id=40725

Qt and Tiger seem to have encoding problems that swallow the --
characters that terminate the comment. We can avoid those problems by
inserting a space before the -->. We're losing coverage of these
issues, but I'm not sure we should be in the business of debugging
these encoders unless there's a security problem.

Thanks to ap for investigating and finding this workaround.

• fast/encoding/japanese-encoding-mix.html:
• platform/mac-tiger/Skipped:
• platform/qt/Skipped:

2010-08-11 Joone Hur <​joone@kldp.org>

Reviewed by Martin Robinson.

[GTK] Last Hangul letter is typed again when a composition is finished with mouse press
​https://bugs.webkit.org/show_bug.cgi?id=40518

When a mouse press fires during a IME composition, the current composition character
can be entered twice at the previous editing position and a new editing position.
Because the IME commit signal is emitted after the mouse press event.
This patch allows to prevent the commit signal during a composition when a mouse press fires.

• WebCoreSupport/EditorClientGtk.cpp: (WebKit::imContextCommitted): (WebKit::EditorClient::handleInputMethodKeydown): Allow to accept the next composition commit. (WebKit::EditorClient::handleInputMethodMousePress): Added for handling IME when a mouse press fires. (WebKit::EditorClient::EditorClient): Initialize m_preventNextCompositionCommit
• WebCoreSupport/EditorClientGtk.h: (WebKit::EditorClient::preventNextCompositionCommit): Added for checking whether skipping a commit.
• webkit/webkitwebview.cpp: (webkit_web_view_button_press_event): Call handleInputMethodMousePress()

Windows build fix.

• JavaScriptCore.xcodeproj/project.pbxproj:
• wtf/Forward.h:

2010-08-11 Julien Chaffraix <​jchaffraix@codeaurora.org>

Reviewed by Ariya Hidayat.

Remove dead code in CSSStyleSelector.
​https://bugs.webkit.org/show_bug.cgi?id=43805

• css/CSSStyleSelector.cpp: Remove some debugging code that was compiled out.

2010-08-11 Shinichiro Hamaji <​hamaji@chromium.org>

Chromium test_expectations update.

• platform/chromium/test_expectations.txt: Mark http/tests/storage/callbacks-are-called-in-correct-context.html as flaky.

2010-08-11 Leo Yang <​leo.yang@torchmobile.com.cn>

Reviewed by Geoffrey Garen.

Date("") should be an invalid date. For IE, Firefox and Chrome, Date("") is invalid date,
which means isNaN(new Date("")) should return true.
​https://bugs.webkit.org/show_bug.cgi?id=43793
Tests: fast/js/date-constructor.html

• runtime/JSGlobalData.cpp: (JSC::JSGlobalData::resetDateCache):

2010-08-11 Leo Yang <​leo.yang@torchmobile.com.cn>

Reviewed by Geoffrey Garen.

Add isNaN(new Date("")) test to fast/js/script-tests/date-constructor.js.
​https://bugs.webkit.org/show_bug.cgi?id=43793

• fast/js/date-constructor-expected.txt:
• fast/js/script-tests/date-constructor.js:

2010-08-11 Steve Block <​steveblock@google.com>

Reviewed by David Levin.

[chromium] Geolocation breaks the compile if ENABLE_GEOLOCATION is set to 0
​https://bugs.webkit.org/show_bug.cgi?id=43753

This change guards the entire contents of the V8 custom bindings files
with ENABLE(GEOLOCATION) to match JSC.

No new tests, build fix only.

• bindings/v8/custom/V8CustomPositionCallback.cpp:
• bindings/v8/custom/V8CustomPositionErrorCallback.cpp:
• bindings/v8/custom/V8GeolocationCustom.cpp:

2010-08-11 Kwang Yul Seo <​skyul@company100.net>

Reviewed by David Levin.

Include <wtf/UnusedParam.h> in GraphicsContextSkia.cpp
​https://bugs.webkit.org/show_bug.cgi?id=43843

wtf/UnusedParam.h must be included because UNUSED_PARAM macro is used.

• platform/graphics/skia/GraphicsContextSkia.cpp:

2010-08-11 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Reviewed by Martin Robinson.

[GTK] Geolocation policy decision object leaking
​https://bugs.webkit.org/show_bug.cgi?id=43884

Use GRefPtr on the policy decision object to fix the leak.

• WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::requestGeolocationPermissionForFrame):

2010-08-11 Kenneth Russell <​kbr@google.com>

Reviewed by Dimitri Glazkov.

Remove obsolete texImage2D and texSubImage2D entry points
​https://bugs.webkit.org/show_bug.cgi?id=40320

No new tests; covered by existing WebGL tests.

• html/canvas/WebGLRenderingContext.cpp:
• html/canvas/WebGLRenderingContext.h:
• html/canvas/WebGLRenderingContext.idl:

2010-08-11 James Hawkins <​jhawkins@chromium.org>

Reviewed by Dmitry Titov.

[Chromium] Notify the WebFrameClient when the frame is detached from
the view. This is used to clear the cached frame in the FormManager.
Eventually this will be removed once handling forms is moved into
WebCore.
​https://bugs.webkit.org/show_bug.cgi?id=43648

• public/WebFrameClient.h: (WebKit::WebFrameClient::frameDetached):
• src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::detachedFromParent3):

2010-08-11 Martin Robinson <​mrobinson@igalia.com>

Adding myself as a reviewer.

• Scripts/webkitpy/common/config/committers.py:

Qt build fix II.

• WebCore.xcodeproj/project.pbxproj:
• bridge/qt/qt_runtime.cpp:

(JSC::Bindings::convertValueToQVariant):

Qt build fix.

• WebCore.xcodeproj/project.pbxproj:
• bridge/qt/qt_runtime.cpp:

(JSC::Bindings::convertValueToQVariant):

2010-08-11 Steve Block <​steveblock@google.com>

Reviewed by Jeremy Orlow.

Need EmptyDeviceOrientationClient and EmptyDeviceMotionClient for use with SVGImage
​https://bugs.webkit.org/show_bug.cgi?id=43848

Tested by existing DeviceOrientation tests.

• loader/EmptyClients.h: (WebCore::EmptyDeviceMotionClient::setController): (WebCore::EmptyDeviceMotionClient::startUpdating): (WebCore::EmptyDeviceMotionClient::stopUpdating): (WebCore::EmptyDeviceMotionClient::currentDeviceMotion): (WebCore::EmptyDeviceOrientationClient::setController): (WebCore::EmptyDeviceOrientationClient::startUpdating): (WebCore::EmptyDeviceOrientationClient::stopUpdating): (WebCore::EmptyDeviceOrientationClient::lastOrientation):
• svg/graphics/SVGImage.cpp: (WebCore::SVGImage::dataChanged):

2010-08-10 Aaron Boodman <​aa@chromium.org>

Reviewed by David Hyatt.

Make the cascade level of "user" styles configurable
​https://bugs.webkit.org/show_bug.cgi?id=43457

• css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::CSSStyleSelector): Handle the case where user styles might have author level. Minor refactor.
• dom/Document.cpp: (WebCore::Document::pageGroupUserSheets): Set isUserStyle on created stylesheet objects appropriately.
• page/PageGroup.cpp: (WebCore::PageGroup::addUserStyleSheetToWorld): Add new optional "level" argument.
• page/PageGroup.h: Ditto.
• page/UserStyleSheet.h: Add level property. (WebCore::UserStyleSheet::): (WebCore::UserStyleSheet::UserStyleSheet): (WebCore::UserStyleSheet::setLevel): (WebCore::UserStyleSheet::level):

2010-08-10 Aaron Boodman <​aa@chromium.org>

Reviewed by David Hyatt.

Make the cascade level of "user" styles configurable
​https://bugs.webkit.org/show_bug.cgi?id=43457

• src/WebViewImpl.cpp: (WebKit::WebView::addUserStyleSheet): Send "author" for the css level of user styles.

2010-08-11 James Hawkins <​jhawkins@chromium.org>

Reviewed by Dmitry Titov.

[Chromium] Notify the WebFrameClient when the frame is detached from
the view. This is used to clear the cached frame in the FormManager.
Eventually this will be removed once handling forms is moved into
WebCore.
​https://bugs.webkit.org/show_bug.cgi?id=43648

• public/WebFrameClient.h: (WebKit::WebFrameClient::frameDetached):
• src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::detachedFromParent3):