Changeset 188162 in webkit


Ignore:
Timestamp:
Aug 7, 2015 2:12:47 PM (9 years ago)
Author:
Wenson Hsieh
Message:

Temporarily allow programmatic input assistance for adding Gmail account
​https://bugs.webkit.org/show_bug.cgi?id=147792

Reviewed by Enrica Casucci.
<rdar://problem/22126518>

Temporary fix for keyboard input sliding out and immediately back in upon user interaction
in the Gmail 2-factor authentication page.

Source/WebCore:

  • platform/RuntimeApplicationChecksIOS.h:
  • platform/RuntimeApplicationChecksIOS.mm:

(WebCore::applicationIsGmailAddAccountOnIOS): Added bundle ID for Gmail settings.

Source/WebKit2:

  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _startAssistingNode:userIsInteracting:blurPreviousNode:userObject:]): Early

return no longer triggers due to lack of user interaction when adding a new Gmail account
through Settings.

Location:
trunk/Source
Files:
5 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebCore/ChangeLog

    r188150 r188162  
     12015-08-07  Wenson Hsieh  <wenson_hsieh@apple.com>
     2
     3        Temporarily allow programmatic input assistance for adding Gmail account
     4        https://bugs.webkit.org/show_bug.cgi?id=147792
     5
     6        Reviewed by Enrica Casucci.
     7        <rdar://problem/22126518>
     8
     9        Temporary fix for keyboard input sliding out and immediately back in upon user interaction
     10        in the Gmail 2-factor authentication page.
     11
     12        * platform/RuntimeApplicationChecksIOS.h:
     13        * platform/RuntimeApplicationChecksIOS.mm:
     14        (WebCore::applicationIsGmailAddAccountOnIOS): Added bundle ID for Gmail settings.
     15
    1162015-08-07  Andy Estes  <aestes@apple.com>
    217

  • trunk/Source/WebCore/platform/RuntimeApplicationChecksIOS.h

    r185733 r188162  
    4444bool applicationIsWebProcess();
    4545bool applicationIsIBooksOnIOS();
     46WEBCORE_EXPORT bool applicationIsGmailAddAccountOnIOS();
    4647
    4748} // namespace WebCore

  • trunk/Source/WebCore/platform/RuntimeApplicationChecksIOS.mm

    r185733 r188162  
    123123}
    124124
     125bool applicationIsGmailAddAccountOnIOS()
     126{
     127    static const bool isGmailAddAccountOnIOS = [[[NSBundle mainBundle] bundleIdentifier] isEqualToString:@"com.apple.social.SLGoogleAuth.SLGoogleAuthService"];
     128    return isGmailAddAccountOnIOS;
     129}
     130
    125131} // namespace WebCore
    126132

  • trunk/Source/WebKit2/ChangeLog

    r188144 r188162  
     12015-08-07  Wenson Hsieh  <wenson_hsieh@apple.com>
     2
     3        Temporarily allow programmatic input assistance for adding Gmail account
     4        https://bugs.webkit.org/show_bug.cgi?id=147792
     5
     6        Reviewed by Enrica Casucci.
     7        <rdar://problem/22126518>
     8
     9        Temporary fix for keyboard input sliding out and immediately back in upon user interaction
     10        in the Gmail 2-factor authentication page.
     11
     12        * UIProcess/ios/WKContentViewInteraction.mm:
     13        (-[WKContentView _startAssistingNode:userIsInteracting:blurPreviousNode:userObject:]): Early
     14            return no longer triggers due to lack of user interaction when adding a new Gmail account
     15            through Settings.
     16
    1172015-08-07  Brady Eidson  <beidson@apple.com>
    218

  • trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm

    r188112 r188162  
    6565#import <WebCore/Path.h>
    6666#import <WebCore/PathUtilities.h>
     67#import <WebCore/RuntimeApplicationChecksIOS.h>
    6768#import <WebCore/Scrollbar.h>
    6869#import <WebCore/SoftLinking.h>
    … …  
    30193020- (void)_startAssistingNode:(const AssistedNodeInformation&)information userIsInteracting:(BOOL)userIsInteracting blurPreviousNode:(BOOL)blurPreviousNode userObject:(NSObject <NSSecureCoding> *)userObject
    30203021{
    3021     if (!userIsInteracting && !_textSelectionAssistant)
     3022    // FIXME: This is a temporary workaround for <rdar://problem/22126518>. The real fix will involve refactoring
     3023    // the way we assist programmatically focused nodes.
     3024    if (!applicationIsGmailAddAccountOnIOS() && !userIsInteracting && !_textSelectionAssistant)
    30223025        return;
    30233026
Note: See TracChangeset for help on using the changeset viewer.