Changeset 191751 in webkit

Timestamp:

Oct 29, 2015 1:18:56 PM (8 years ago)

Author:

Wenson Hsieh

Message:

Date input values should not overlap with menu list dropdown button on iOS
​https://bugs.webkit.org/show_bug.cgi?id=150681
<rdar://problem/19965078>

Reviewed by Zalan Bujtas.

Source/WebCore:

Adds a right margin on iOS date and time inputs so that the inner div does
not render the value of the date on top of the dropdown button on the right
of the menu list.

Tests: fast/forms/date/date-input-rendering-basic.html

fast/forms/time/time-input-rendering-basic.html

• css/html.css:

(input::-webkit-date-and-time-value):

LayoutTests:

Tests that date and time inputs render properly. Namely, the text should not
be rendered such that it covers the dropdown button on the right of the menu
list.

• fast/forms/date/date-input-rendering-basic-expected.txt: Added.
• fast/forms/date/date-input-rendering-basic.html: Added.
• fast/forms/time/time-input-rendering-basic-expected.txt: Added.
• fast/forms/time/time-input-rendering-basic.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/forms/date/date-input-rendering-basic-expected.txt (added)
• LayoutTests/fast/forms/date/date-input-rendering-basic.html (added)
• LayoutTests/fast/forms/time/time-input-rendering-basic-expected.txt (added)
• LayoutTests/fast/forms/time/time-input-rendering-basic.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/css/html.css (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2015-10-29  Wenson Hsieh  <wenson_hsieh@apple.com>
+
+        Date input values should not overlap with menu list dropdown button on iOS
+        https://bugs.webkit.org/show_bug.cgi?id=150681
+        <rdar://problem/19965078>
+
+        Reviewed by Zalan Bujtas.
+
+        Tests that date and time inputs render properly. Namely, the text should not
+        be rendered such that it covers the dropdown button on the right of the menu
+        list.
+
+        * fast/forms/date/date-input-rendering-basic-expected.txt: Added.
+        * fast/forms/date/date-input-rendering-basic.html: Added.
+        * fast/forms/time/time-input-rendering-basic-expected.txt: Added.
+        * fast/forms/time/time-input-rendering-basic.html: Added.
+
 2015-10-29  Ryan Haddad  <ryanhaddad@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2015-10-29  Wenson Hsieh  <wenson_hsieh@apple.com>
+
+        Date input values should not overlap with menu list dropdown button on iOS
+        https://bugs.webkit.org/show_bug.cgi?id=150681
+        <rdar://problem/19965078>
+
+        Reviewed by Zalan Bujtas.
+
+        Adds a right margin on iOS date and time inputs so that the inner div does
+        not render the value of the date on top of the dropdown button on the right
+        of the menu list.
+
+        Tests: fast/forms/date/date-input-rendering-basic.html
+               fast/forms/time/time-input-rendering-basic.html
+
+        * css/html.css:
+        (input::-webkit-date-and-time-value):
+
 2015-10-29  Alex Christensen  <achristensen@webkit.org>
 

trunk/Source/WebCore/css/html.css

@@ -527 +527 @@
 #endif
 
-#if !(defined(WTF_PLATFORM_IOS) && WTF_PLATFORM_IOS)
 input::-webkit-date-and-time-value {
+#if defined(WTF_PLATFORM_IOS) && WTF_PLATFORM_IOS
+    margin-right: 18px;
+#else
     margin: 1px 24px 1px 4px;
     white-space: pre;
-}
-#endif
+#endif
+}
 
 input::-webkit-inner-spin-button {