Changeset 191974 in webkit

Timestamp:

Nov 3, 2015 1:40:20 PM (8 years ago)

Author:

Wenson Hsieh

Message:

Fix touch event sending crash in WebKitTestRunner
​https://bugs.webkit.org/show_bug.cgi?id=150848
<rdar://problem/23360841>

Reviewed by Simon Fraser.

Fixes a redundant force event generated by HIDEventGenerator. See the Radar diagnosis for more details.

• WebKitTestRunner/ios/HIDEventGenerator.mm:

(-[HIDEventGenerator _createIOHIDEventType:]): Deleted.

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• WebKitTestRunner/ios/HIDEventGenerator.mm (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2015-11-03  Wenson Hsieh  <wenson_hsieh@apple.com>
+
+        Fix touch event sending crash in WebKitTestRunner
+        https://bugs.webkit.org/show_bug.cgi?id=150848
+        <rdar://problem/23360841>
+
+        Reviewed by Simon Fraser.
+
+        Fixes a redundant force event generated by HIDEventGenerator. See the Radar diagnosis for more details.
+
+        * WebKitTestRunner/ios/HIDEventGenerator.mm:
+        (-[HIDEventGenerator _createIOHIDEventType:]): Deleted.
+
 2015-11-03  Brent Fulgham  <bfulgham@apple.com>
 

trunk/Tools/WebKitTestRunner/ios/HIDEventGenerator.mm

@@ -204 +204 @@
         IOHIDEventSetFloatValue(subEvent.get(), kIOHIDEventFieldDigitizerMinorRadius, pointInfo->pathMajorRadius);
         IOHIDEventAppendEvent(eventRef.get(), subEvent.get(), 0);
-    }
-
-    if (_activePointCount) {
-        IOHIDFloat progress = _activePoints[0].pathPressure;
-        RetainPtr<IOHIDEventRef> forceEvent = adoptCF(IOHIDEventCreateForceEvent(kCFAllocatorDefault,
-            machTime,
-            0,
-            progress,
-            0,
-            0.0,
-            kIOHIDEventOptionNone));
-        IOHIDEventAppendEvent(eventRef.get(), forceEvent.get(), 0);
     }