Changeset 204428 in webkit

Timestamp:

Aug 12, 2016 3:32:55 PM (8 years ago)

Author:

Nikita Vasilyev

Message:

Web Inspector: Command-Shift-O causes infinite loop if web page has frames
​https://bugs.webkit.org/show_bug.cgi?id=160810

Reviewed by Joseph Pecoraro.

• UserInterface/Views/OpenResourceDialog.js:

(WebInspector.OpenResourceDialog.prototype._addResourcesForFrame):
"frame" doesn't change inside the loop.

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Views/OpenResourceDialog.js (modified) (1 diff)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2016-08-12  Nikita Vasilyev  <nvasilyev@apple.com>
+
+        Web Inspector: Command-Shift-O causes infinite loop if web page has frames
+        https://bugs.webkit.org/show_bug.cgi?id=160810
+
+        Reviewed by Joseph Pecoraro.
+
+        * UserInterface/Views/OpenResourceDialog.js:
+        (WebInspector.OpenResourceDialog.prototype._addResourcesForFrame):
+        "frame" doesn't change inside the loop.
+
 2016-08-12  Joseph Pecoraro  <pecoraro@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Views/OpenResourceDialog.js

@@ -273 +273 @@
                 this._addResource(resource, suppressFilterUpdate);
 
-            frames = frames.concat(frame.childFrames);
+            frames = frames.concat(currentFrame.childFrames);
         }