Changeset 205965 in webkit


Ignore:
Timestamp:
Sep 15, 2016 2:24:56 AM (8 years ago)
Author:
commit-queue@webkit.org
Message:

Fix build warnings in the mediastream code
https://bugs.webkit.org/show_bug.cgi?id=161957

Patch by Alejandro G. Castro <alex@igalia.com> on 2016-09-15
Reviewed by Philippe Normand.

  • platform/mediastream/MediaConstraints.cpp:

(WebCore::MediaConstraint::create): Added assertion and mock return.

  • platform/mediastream/RealtimeMediaSourceSupportedConstraints.cpp:

(WebCore::RealtimeMediaSourceSupportedConstraints::nameForConstraint):
Added assertion and mock return.
(WebCore::RealtimeMediaSourceSupportedConstraints::supportsConstraint):
Added assertion and mock return.

Location:
trunk/Source/WebCore
Files:
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r205964 r205965  
     12016-09-15  Alejandro G. Castro  <alex@igalia.com>
     2
     3        Fix build warnings in the mediastream code
     4        https://bugs.webkit.org/show_bug.cgi?id=161957
     5
     6        Reviewed by Philippe Normand.
     7
     8        * platform/mediastream/MediaConstraints.cpp:
     9        (WebCore::MediaConstraint::create): Added assertion and mock return.
     10        * platform/mediastream/RealtimeMediaSourceSupportedConstraints.cpp:
     11        (WebCore::RealtimeMediaSourceSupportedConstraints::nameForConstraint):
     12        Added assertion and mock return.
     13        (WebCore::RealtimeMediaSourceSupportedConstraints::supportsConstraint):
     14        Added assertion and mock return.
     15
    1162016-09-15  Youenn Fablet  <youenn@apple.com>
    217
  • trunk/Source/WebCore/platform/mediastream/MediaConstraints.cpp

    r205574 r205965  
    6161        return UnknownConstraint::create(name, constraintType);
    6262    }
     63
     64    ASSERT_NOT_REACHED();
     65    return MediaConstraint::create(String());
    6366}
    6467
  • trunk/Source/WebCore/platform/mediastream/RealtimeMediaSourceSupportedConstraints.cpp

    r204595 r205965  
    7676        return groupIdConstraintName;
    7777    }
     78
     79    ASSERT_NOT_REACHED();
     80    return emptyAtom;
    7881}
    7982
     
    127130        return supportsGroupId();
    128131    }
     132
     133    ASSERT_NOT_REACHED();
     134    return false;
    129135}
    130136
Note: See TracChangeset for help on using the changeset viewer.