Changeset 205998 in webkit

Timestamp:

Sep 15, 2016 3:01:37 PM (8 years ago)

Author:

fpizlo@apple.com

Message:

REGRESSION (r205462): Lot of leaks
​https://bugs.webkit.org/show_bug.cgi?id=161946

Reviewed by Saam Barati.

We were forgetting to delete LargeAllocations on VM exit!

• heap/MarkedSpace.cpp:

(JSC::MarkedSpace::~MarkedSpace):

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• heap/MarkedSpace.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2016-09-15  Filip Pizlo  <fpizlo@apple.com>
+
+        REGRESSION (r205462): Lot of leaks
+        https://bugs.webkit.org/show_bug.cgi?id=161946
+
+        Reviewed by Saam Barati.
+        
+        We were forgetting to delete LargeAllocations on VM exit!
+
+        * heap/MarkedSpace.cpp:
+        (JSC::MarkedSpace::~MarkedSpace):
+
 2016-09-15  Keith Miller  <keith_miller@apple.com>
 

trunk/Source/JavaScriptCore/heap/MarkedSpace.cpp

@@ -204 +204 @@
             freeBlock(block);
         });
+    for (LargeAllocation* allocation : m_largeAllocations)
+        allocation->destroy();
     ASSERT(!m_blocks.set().size());
 }