Changeset 206026 in webkit
- Timestamp:
- Sep 16, 2016 9:32:34 AM (8 years ago)
- Location:
- trunk
- Files:
-
- 2 added
- 9 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r206014 r206026 1 2016-09-16 Chris Dumez <cdumez@apple.com> 2 3 Cloning a textarea does not clone the textarea's value 4 https://bugs.webkit.org/show_bug.cgi?id=156637 5 6 Reviewed by Ryosuke Niwa. 7 8 Update existing test to reflect behavior change. 9 10 * fast/forms/checkValidity-cloneNode-crash-expected.txt: 11 * fast/forms/checkValidity-cloneNode-crash.html: 12 1 13 2016-09-16 Youenn Fablet <youenn@apple.com> 2 14 -
trunk/LayoutTests/fast/forms/checkValidity-cloneNode-crash-expected.txt
r200069 r206026 11 11 PASS element2.checkValidity() is false 12 12 PASS element.checkValidity() is true 13 PASS element2.value is " "14 PASS element2.checkValidity() is false13 PASS element2.value is "a" 14 PASS element2.checkValidity() is true 15 15 PASS element2.checkValidity() is true 16 16 PASS successfullyParsed is true -
trunk/LayoutTests/fast/forms/checkValidity-cloneNode-crash.html
r200069 r206026 45 45 shouldBeTrue("element.checkValidity()"); 46 46 element2 = element.cloneNode(); 47 shouldBeEqualToString("element2.value", " ");48 shouldBe False("element2.checkValidity()");47 shouldBeEqualToString("element2.value", "a"); 48 shouldBeTrue("element2.checkValidity()"); 49 49 element2.value = element.value; 50 50 shouldBeTrue("element2.checkValidity()"); -
trunk/LayoutTests/imported/w3c/ChangeLog
r206014 r206026 1 2016-09-16 Chris Dumez <cdumez@apple.com> 2 3 Cloning a textarea does not clone the textarea's value 4 https://bugs.webkit.org/show_bug.cgi?id=156637 5 6 Reviewed by Ryosuke Niwa. 7 8 Import corresponding W3C web platform test. 9 10 * web-platform-tests/html/semantics/forms/the-textarea-element/cloning-steps-expected.txt: Added. 11 * web-platform-tests/html/semantics/forms/the-textarea-element/cloning-steps.html: Added. 12 * web-platform-tests/html/semantics/forms/the-textarea-element/w3c-import.log: 13 1 14 2016-09-16 Youenn Fablet <youenn@apple.com> 2 15 -
trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-textarea-element/w3c-import.log
r200238 r206026 16 16 ------------------------------------------------------------------------ 17 17 List of files: 18 /LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-textarea-element/cloning-steps.html 18 19 /LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-textarea-element/textarea-newline-bidi-expected.html 19 20 /LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-textarea-element/textarea-newline-bidi.html -
trunk/Source/WebCore/ChangeLog
r206025 r206026 1 2016-09-16 Chris Dumez <cdumez@apple.com> 2 3 Cloning a textarea does not clone the textarea's value 4 https://bugs.webkit.org/show_bug.cgi?id=156637 5 6 Reviewed by Ryosuke Niwa. 7 8 Update WebKit so that cloning a textarea element also clones its value. 9 This matches the HTML specification after: 10 - https://github.com/whatwg/html/pull/1784 11 12 The new behavior also matches Chrome and Edge. 13 14 Test: imported/w3c/web-platform-tests/html/semantics/forms/the-textarea-element/cloning-steps.html 15 16 * html/HTMLInputElement.cpp: 17 (WebCore::HTMLInputElement::copyNonAttributePropertiesFromElement): 18 * html/HTMLTextAreaElement.cpp: 19 (WebCore::HTMLTextAreaElement::copyNonAttributePropertiesFromElement): 20 * html/HTMLTextAreaElement.h: 21 1 22 2016-09-16 Jer Noble <jer.noble@apple.com> 2 23 -
trunk/Source/WebCore/html/HTMLInputElement.cpp
r205912 r206026 955 955 void HTMLInputElement::copyNonAttributePropertiesFromElement(const Element& source) 956 956 { 957 const HTMLInputElement& sourceElement = static_cast<const HTMLInputElement&>(source);957 auto& sourceElement = downcast<HTMLInputElement>(source); 958 958 959 959 m_valueIfDirty = sourceElement.m_valueIfDirty; -
trunk/Source/WebCore/html/HTMLTextAreaElement.cpp
r205663 r206026 588 588 } 589 589 590 void HTMLTextAreaElement::copyNonAttributePropertiesFromElement(const Element& source) 591 { 592 auto& sourceElement = downcast<HTMLTextAreaElement>(source); 593 594 setValueCommon(sourceElement.value()); 595 m_isDirty = sourceElement.m_isDirty; 596 HTMLTextFormControlElement::copyNonAttributePropertiesFromElement(source); 597 598 updateValidity(); 599 } 600 590 601 } // namespace WebCore -
trunk/Source/WebCore/html/HTMLTextAreaElement.h
r205524 r206026 56 56 TextControlInnerTextElement* innerTextElement() const final; 57 57 RenderStyle createInnerTextStyle(const RenderStyle&) const final; 58 void copyNonAttributePropertiesFromElement(const Element&) final; 58 59 59 60 void rendererWillBeDestroyed();
Note: See TracChangeset
for help on using the changeset viewer.