Changeset 206074 in webkit

Timestamp:

Sep 17, 2016 4:14:38 AM (8 years ago)

Author:

ddkilzer@apple.com

Message:

MainThreadBridge needs an isolatedCopy() of SecurityOrigin
<​https://webkit.org/b/162116>
<rdar://problem/27525870>

Reviewed by Carlos Garcia Campos.

Covered by existing tests.

• loader/WorkerThreadableLoader.cpp:

(WebCore::WorkerThreadableLoader::MainThreadBridge::MainThreadBridge):
Make an isolatedCopy() of SecurityOrigin here since that's the
correct idiom to use when the object is passed from a worker
thread back to the main thread. Fix suggested by Daniel Bates.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• loader/WorkerThreadableLoader.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2016-09-17  David Kilzer  <ddkilzer@apple.com>
+
+        MainThreadBridge needs an isolatedCopy() of SecurityOrigin
+        <https://webkit.org/b/162116>
+        <rdar://problem/27525870>
+
+        Reviewed by Carlos Garcia Campos.
+
+        Covered by existing tests.
+
+        * loader/WorkerThreadableLoader.cpp:
+        (WebCore::WorkerThreadableLoader::MainThreadBridge::MainThreadBridge):
+        Make an isolatedCopy() of SecurityOrigin here since that's the
+        correct idiom to use when the object is passed from a worker
+        thread back to the main thread.  Fix suggested by Daniel Bates.
+
 2016-09-16  Yusuke Suzuki  <utatane.tea@gmail.com>
 

trunk/Source/WebCore/loader/WorkerThreadableLoader.cpp

@@ -109 +109 @@
     ASSERT(contentSecurityPolicy);
 
-    auto contentSecurityPolicyCopy = std::make_unique<ContentSecurityPolicy>(*securityOrigin);
+    auto contentSecurityPolicyCopy = std::make_unique<ContentSecurityPolicy>(securityOrigin->isolatedCopy());
     contentSecurityPolicyCopy->copyStateFrom(contentSecurityPolicy);