Changeset 206085 in webkit

Timestamp:

Sep 18, 2016 12:49:28 PM (8 years ago)

Author:

Matt Baker

Message:

Web Inspector: Add test coverage for all array utility functions
​https://bugs.webkit.org/show_bug.cgi?id=162044
<rdar://problem/28330846>

Reviewed by Joseph Pecoraro.

New test cases and expectations for Array utility functions.

• inspector/unit-tests/array-utilities-expected.txt:
• inspector/unit-tests/array-utilities.html:

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• inspector/unit-tests/array-utilities-expected.txt (modified) (1 diff)
• inspector/unit-tests/array-utilities.html (modified) (6 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2016-09-18  Matt Baker  <mattbaker@apple.com>
+
+        Web Inspector: Add test coverage for all array utility functions
+        https://bugs.webkit.org/show_bug.cgi?id=162044
+        <rdar://problem/28330846>
+
+        Reviewed by Joseph Pecoraro.
+
+        New test cases and expectations for Array utility functions.
+
+        * inspector/unit-tests/array-utilities-expected.txt:
+        * inspector/unit-tests/array-utilities.html:
+
 2016-09-16  Joseph Pecoraro  <pecoraro@apple.com>
 

trunk/LayoutTests/inspector/unit-tests/array-utilities-expected.txt

@@ -46 +46 @@
 PASS: shallowEqual of non-arrays should be false.
 
+-- Running test case: Array.prototype.lastValue
+PASS: lastValue of a nonempty array should be the last value.
+PASS: lastValue of an empty array should be undefined.
+
+-- Running test case: Array.prototype.remove
+PASS: remove with onlyFirst equal to true should only remove the first matching value.
+PASS: remove with onlyFirst equal to false should remove all matching values.
+PASS: remove with onlyFirst unspecified should remove all matching values.
+
+-- Running test case: Array.prototype.toggleIncludes
+PASS: toggleIncludes of an existing item with force true should have no effect.
+PASS: toggleIncludes of an existing item with force false should remove the item.
+PASS: toggleIncludes of a nonexistent item with force true should add the item.
+PASS: toggleIncludes of a nonexistent item with force false should have no effect.
+
+-- Running test case: Array.prototype.insertAtIndex
+PASS: insertAtIndex with index unspecified should insert at the beginning.
+PASS: insertAtIndex with index zero should insert at the beginning.
+PASS: insertAtIndex with 0 < index < length should insert at the correct location.
+PASS: insertAtIndex with negative index should insert from the end.
+PASS: insertAtIndex with index greater than array length should insert at the end.
+
+-- Running test case: Array.prototype.keySet
+PASS: keySet should create an object with keys equal to the array values.
+PASS: keySet should create an object with all values equal to true.
+PASS: keySet should create an object with keys equal to stringified array values.
+

trunk/LayoutTests/inspector/unit-tests/array-utilities.html

@@ -10 +10 @@
     suite.addTestCase({
         name: "Array.prototype.lowerBound",
-        test: () => {
+        test() {
             // Index:  0  1  2  3  4  5  6  7  8  9
             let arr = [0, 1, 2, 2, 2, 2, 2, 2, 6, 7];
@@ -31 +31 @@
     suite.addTestCase({
         name: "Array.prototype.upperBound",
-        test: () => {
+        test() {
             // Index:  0  1  2  3  4  5  6  7  8  9
             let arr = [0, 1, 2, 2, 2, 2, 2, 2, 6, 7];
@@ -52 +52 @@
     suite.addTestCase({
         name: "Array.prototype.binaryIndexOf",
-        test: () => {
+        test() {
             // Index:  0  1  2  3  4  5  6  7  8  9
             let arr = [0, 1, 2, 2, 2, 2, 2, 2, 6, 7];
@@ -66 +66 @@
     suite.addTestCase({
         name: "Array.prototype.partition",
-        test: () => {
+        test() {
             let arr1 = [1, 2, 3, 4];
             let [even, odd] = arr1.partition((x) => x % 2 === 0);
@@ -88 +88 @@
     suite.addTestCase({
         name: "Array.shallowEqual",
-        test: () => {
+        test() {
             InspectorTest.expectThat(Array.shallowEqual([], []), "shallowEqual of empty arrays should be true.");
 
@@ -108 +108 @@
             InspectorTest.expectFalse(Array.shallowEqual(str, str), "shallowEqual of a non-array with itself should be false.");
             InspectorTest.expectFalse(Array.shallowEqual({}, {}), "shallowEqual of non-arrays should be false.");
+
+            return true;
+        }
+    });
+
+    suite.addTestCase({
+        name: "Array.prototype.lastValue",
+        test() {
+            let object1 = {};
+            let object2 = {};
+            InspectorTest.expectEqual([object1, object2].lastValue, object2, "lastValue of a nonempty array should be the last value.")
+            InspectorTest.expectEqual([].lastValue, undefined, "lastValue of an empty array should be undefined.")
+
+            return true;
+        }
+    });
+
+    suite.addTestCase({
+        name: "Array.prototype.remove",
+        test() {
+            let arr1 = [1, 2, 3, 1];
+            arr1.remove(1, true);
+            // Note: Array.prototype.remove starts searching from the end of the array.
+            InspectorTest.expectShallowEqual(arr1, [1, 2, 3], "remove with onlyFirst equal to true should only remove the first matching value.");
+
+            let arr2 = [1, 2, 3, 1];
+            arr2.remove(1, false);
+            InspectorTest.expectShallowEqual(arr2, [2, 3], "remove with onlyFirst equal to false should remove all matching values.");
+
+            let arr3 = [1, 2, 3, 1];
+            arr3.remove(1);
+            InspectorTest.expectShallowEqual(arr3, [2, 3], "remove with onlyFirst unspecified should remove all matching values.");
+
+            return true;
+        }
+    });
+
+    suite.addTestCase({
+        name: "Array.prototype.toggleIncludes",
+        test() {
+            let arr1 = [1, 2, 3];
+            arr1.toggleIncludes(3, true);
+            InspectorTest.expectShallowEqual(arr1, [1, 2, 3], "toggleIncludes of an existing item with force true should have no effect.");
+
+            let arr2 = [1, 2, 3];
+            arr2.toggleIncludes(3, false);
+            InspectorTest.expectShallowEqual(arr2, [1, 2], "toggleIncludes of an existing item with force false should remove the item.");
+
+            let arr3 = [1, 2, 3];
+            arr3.toggleIncludes(4, true);
+            InspectorTest.expectShallowEqual(arr3, [1, 2, 3, 4], "toggleIncludes of a nonexistent item with force true should add the item.");
+
+            let arr4 = [1, 2, 3];
+            arr4.toggleIncludes(4, false);
+            InspectorTest.expectShallowEqual(arr4, [1, 2, 3], "toggleIncludes of a nonexistent item with force false should have no effect.");
+
+            return true;
+        }
+    });
+
+    suite.addTestCase({
+        name: "Array.prototype.insertAtIndex",
+        test() {
+            let arr1 = [1, 2, 3];
+            arr1.insertAtIndex("x");
+            InspectorTest.expectShallowEqual(arr1, ["x", 1, 2, 3], "insertAtIndex with index unspecified should insert at the beginning.");
+
+            let arr2 = [1, 2, 3];
+            arr2.insertAtIndex("x", 0);
+            InspectorTest.expectShallowEqual(arr2, ["x", 1, 2, 3], "insertAtIndex with index zero should insert at the beginning.");
+
+            let arr3 = [1, 2, 3];
+            arr3.insertAtIndex("x", 2);
+            InspectorTest.expectShallowEqual(arr3, [1, 2, "x", 3], "insertAtIndex with 0 < index < length should insert at the correct location.");
+
+            let arr4 = [1, 2, 3];
+            arr4.insertAtIndex("x", -1);
+            InspectorTest.expectShallowEqual(arr4, [1, 2, "x", 3], "insertAtIndex with negative index should insert from the end.");
+
+            let arr5 = [1, 2, 3];
+            arr5.insertAtIndex("x", 100);
+            InspectorTest.expectShallowEqual(arr5, [1, 2, 3, "x"], "insertAtIndex with index greater than array length should insert at the end.");
+
+            return true;
+        }
+    });
+
+    suite.addTestCase({
+        name: "Array.prototype.keySet",
+        test() {
+            let arr1 = ["abc", "def", "xyz"];
+            let keySet = arr1.keySet();
+            InspectorTest.expectShallowEqual(Object.keys(keySet), arr1, "keySet should create an object with keys equal to the array values.");
+            InspectorTest.expectShallowEqual(Object.values(keySet), [true, true, true], "keySet should create an object with all values equal to true.");
+
+            let arr2 = [1, 2, 3];
+            InspectorTest.expectShallowEqual(Object.keys(arr2.keySet()), arr2.map(x => x.toString()), "keySet should create an object with keys equal to stringified array values.");
 
             return true;