Changeset 206140 in webkit

Timestamp:

Sep 19, 2016 9:22:31 PM (8 years ago)

Author:

Chris Dumez

Message:

Add support for HTMLSourceElement.prototype.sizes / HTMLSourceElement.prototype.srcset
​https://bugs.webkit.org/show_bug.cgi?id=162244

Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

Rebaseline now that more checks are passing.

• web-platform-tests/html/dom/interfaces-expected.txt:

Source/WebCore:

Add support for HTMLPrototype.prototype.sizes / HTMLPrototype.prototype.srcset:

• ​https://html.spec.whatwg.org/#the-source-element

We already support the corresponding content attributes internally. However, we
are missing the corresponding IDL attributes that are supposed to reflect them.

Chrome and Firefox support them. We already had those IDL attributes on
HTMLImageElement.

No new tests, rebaselined existing test.

• html/HTMLSourceElement.idl:

Location:

trunk

Files:

• LayoutTests/imported/w3c/ChangeLog (modified) (1 diff)
• LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt (modified) (4 diffs)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/html/HTMLSourceElement.idl (modified) (1 diff)

trunk/LayoutTests/imported/w3c/ChangeLog

@@ +1 @@
+2016-09-19  Chris Dumez  <cdumez@apple.com>
+
+        Add support for HTMLSourceElement.prototype.sizes / HTMLSourceElement.prototype.srcset
+        https://bugs.webkit.org/show_bug.cgi?id=162244
+
+        Reviewed by Alex Christensen.
+
+        Rebaseline now that more checks are passing.
+
+        * web-platform-tests/html/dom/interfaces-expected.txt:
+
 2016-09-19  Chris Dumez  <cdumez@apple.com>
 

trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt

@@ -1406 +1406 @@
 PASS HTMLHRElement interface: existence and properties of interface prototype object's "constructor" property 
 PASS HTMLHRElement interface: attribute align 
-FAIL HTMLHRElement interface: attribute color assert_true: The prototype object must have a property "color" expected true got false
+PASS HTMLHRElement interface: attribute color 
 PASS HTMLHRElement interface: attribute noShade 
 PASS HTMLHRElement interface: attribute size 
@@ -1413 +1413 @@
 PASS Stringification of document.createElement("hr") 
 PASS HTMLHRElement interface: document.createElement("hr") must inherit property "align" with the proper type (0) 
-FAIL HTMLHRElement interface: document.createElement("hr") must inherit property "color" with the proper type (1) assert_inherits: property "color" not found in prototype chain
+PASS HTMLHRElement interface: document.createElement("hr") must inherit property "color" with the proper type (1) 
 PASS HTMLHRElement interface: document.createElement("hr") must inherit property "noShade" with the proper type (2) 
 PASS HTMLHRElement interface: document.createElement("hr") must inherit property "size" with the proper type (3) 
@@ -1951 +1951 @@
 PASS HTMLSourceElement interface: attribute src 
 PASS HTMLSourceElement interface: attribute type 
-FAIL HTMLSourceElement interface: attribute srcset assert_true: The prototype object must have a property "srcset" expected true got false
-FAIL HTMLSourceElement interface: attribute sizes assert_true: The prototype object must have a property "sizes" expected true got false
+PASS HTMLSourceElement interface: attribute srcset 
+PASS HTMLSourceElement interface: attribute sizes 
 PASS HTMLSourceElement interface: attribute media 
 PASS HTMLSourceElement must be primary interface of document.createElement("source") 
@@ -1958 +1958 @@
 PASS HTMLSourceElement interface: document.createElement("source") must inherit property "src" with the proper type (0) 
 PASS HTMLSourceElement interface: document.createElement("source") must inherit property "type" with the proper type (1) 
-FAIL HTMLSourceElement interface: document.createElement("source") must inherit property "srcset" with the proper type (2) assert_inherits: property "srcset" not found in prototype chain
-FAIL HTMLSourceElement interface: document.createElement("source") must inherit property "sizes" with the proper type (3) assert_inherits: property "sizes" not found in prototype chain
+PASS HTMLSourceElement interface: document.createElement("source") must inherit property "srcset" with the proper type (2) 
+PASS HTMLSourceElement interface: document.createElement("source") must inherit property "sizes" with the proper type (3) 
 PASS HTMLSourceElement interface: document.createElement("source") must inherit property "media" with the proper type (4) 
 PASS HTMLTrackElement interface: existence and properties of interface object 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2016-09-19  Chris Dumez  <cdumez@apple.com>
+
+        Add support for HTMLSourceElement.prototype.sizes / HTMLSourceElement.prototype.srcset
+        https://bugs.webkit.org/show_bug.cgi?id=162244
+
+        Reviewed by Alex Christensen.
+
+        Add support for HTMLPrototype.prototype.sizes / HTMLPrototype.prototype.srcset:
+        - https://html.spec.whatwg.org/#the-source-element
+
+        We already support the corresponding content attributes internally. However, we
+        are missing the corresponding IDL attributes that are supposed to reflect them.
+
+        Chrome and Firefox support them. We already had those IDL attributes on
+        HTMLImageElement.
+
+        No new tests, rebaselined existing test.
+
+        * html/HTMLSourceElement.idl:
+
 2016-09-19  Anders Carlsson  <andersca@apple.com>
 

trunk/Source/WebCore/html/HTMLSourceElement.idl

@@ -25 +25 @@
 
 interface HTMLSourceElement : HTMLElement {
-[Reflect, URL] attribute USVString src;
-attribute DOMString type;
-attribute DOMString media;
+    [Reflect, URL] attribute USVString src;
+    attribute DOMString type;
+    [Reflect] attribute USVString srcset;
+    [Reflect] attribute DOMString sizes;
+    attribute DOMString media;
 };