Changeset 206169 in webkit

Timestamp:

Sep 20, 2016 1:25:03 PM (8 years ago)

Author:

achristensen@apple.com

Message:

URLParser: uidna_IDNToASCII_56 is deprecated
​https://bugs.webkit.org/show_bug.cgi?id=161841

Patch by Michael Catanzaro <Michael Catanzaro> on 2016-09-20
Reviewed by Alex Christensen.

Add pragmas to silence the warning, plus a FIXME.

• platform/URLParser.cpp:

(WebCore::domainToASCII):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/URLParser.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2016-09-20  Michael Catanzaro  <mcatanzaro@igalia.com>
+
+        URLParser: uidna_IDNToASCII_56 is deprecated
+        https://bugs.webkit.org/show_bug.cgi?id=161841
+
+        Reviewed by Alex Christensen.
+
+        Add pragmas to silence the warning, plus a FIXME.
+
+        * platform/URLParser.cpp:
+        (WebCore::domainToASCII):
+
 2016-09-20  Alex Christensen  <achristensen@webkit.org>
 

trunk/Source/WebCore/platform/URLParser.cpp

@@ -1972 +1972 @@
     UChar hostnameBuffer[hostnameBufferLength];
     UErrorCode error = U_ZERO_ERROR;
-    
+
+#if COMPILER(GCC) || COMPILER(CLANG)
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wdeprecated-declarations"
+#endif
+    // FIXME: This should use uidna_openUTS46 / uidna_close instead
     int32_t numCharactersConverted = uidna_IDNToASCII(StringView(domain).upconvertedCharacters(), domain.length(), hostnameBuffer, hostnameBufferLength, UIDNA_ALLOW_UNASSIGNED, nullptr, &error);
+#if COMPILER(GCC) || COMPILER(CLANG)
+#pragma GCC diagnostic pop
+#endif
 
     if (error == U_ZERO_ERROR) {