Changeset 206190 in webkit

Timestamp:

Sep 20, 2016 5:27:38 PM (8 years ago)

Author:

n_wang@apple.com

Message:

AX: AppleVisUser: VO can't navigate web dialogs iOS10
​https://bugs.webkit.org/show_bug.cgi?id=162322

Reviewed by Chris Fleizach.

Source/WebCore:

When using VoiceOver to navigate a web dialog's children, we were setting focus
onto the focusable parent in accessibilityElementDidBecomeFocused. When the focusable
parent is the dialog, it will cause the VO cursor jumping back and forward. Fixed it
by not setting focus on web dialogs in such case.

Test: accessibility/ios-simulator/dialog-did-become-focused.html

• accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:

(-[WebAccessibilityObjectWrapper accessibilityElementDidBecomeFocused]):

LayoutTests:

• accessibility/ios-simulator/dialog-did-become-focused-expected.txt: Added.
• accessibility/ios-simulator/dialog-did-become-focused.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/accessibility/ios-simulator/dialog-did-become-focused-expected.txt (added)
• LayoutTests/accessibility/ios-simulator/dialog-did-become-focused.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2016-09-20  Nan Wang  <n_wang@apple.com>
+
+        AX: AppleVisUser: VO can't navigate web dialogs iOS10
+        https://bugs.webkit.org/show_bug.cgi?id=162322
+
+        Reviewed by Chris Fleizach.
+
+        * accessibility/ios-simulator/dialog-did-become-focused-expected.txt: Added.
+        * accessibility/ios-simulator/dialog-did-become-focused.html: Added.
+
 2016-09-20  Zalan Bujtas  <zalan@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2016-09-20  Nan Wang  <n_wang@apple.com>
+
+        AX: AppleVisUser: VO can't navigate web dialogs iOS10
+        https://bugs.webkit.org/show_bug.cgi?id=162322
+
+        Reviewed by Chris Fleizach.
+
+        When using VoiceOver to navigate a web dialog's children, we were setting focus
+        onto the focusable parent in accessibilityElementDidBecomeFocused. When the focusable
+        parent is the dialog, it will cause the VO cursor jumping back and forward. Fixed it
+        by not setting focus on web dialogs in such case.
+
+        Test: accessibility/ios-simulator/dialog-did-become-focused.html
+
+        * accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
+        (-[WebAccessibilityObjectWrapper accessibilityElementDidBecomeFocused]):
+
 2016-09-20  Keith Rollin  <krollin@apple.com>
 

trunk/Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm

@@ -1892 +1892 @@
             if ([self detailParentForObject:object])
                 break;
+            
+            // webkit.org/b/162322 When a dialog is focusable, allowing focusing onto the dialog node will cause VO cursor jumping
+            // back and forward while navigating its children.
+            if ([object->wrapper() accessibilityIsDialog])
+                break;
+            
             object->setFocused(true);
             break;